1. 19 Oct, 2018 1 commit
    • Josef Ridky's avatar
      Issue #2087 - Issues discovered by coverity scan · 2987f012
      Josef Ridky authored
      Add missing fclose invocations and fix copy-paste issue.
      
      This issues has been discovered by coverity scan proceeded by Red Hat.
      
      Fixed some mistakes in the patch and added more fclose() (Mitch)
      
      (cherry picked from commit 56c8f832)
      2987f012
  2. 11 Jul, 2018 1 commit
  3. 24 Jun, 2018 1 commit
  4. 20 May, 2018 3 commits
    • Jehan's avatar
      plug-ins: install plug-ins in subfolder. · 870ca633
      Jehan authored
      I am going to forbid plug-ins from being installed directly in the root
      of the plug-ins/ directory. They will have to be installed in a
      subdirectory named the same as the entry point binary.
      This may seem useless for our core plug-ins which are nearly all
      self-contained in single binaries, but this is actually a necessary
      restriction to eliminate totally the DLL hell issue on Windows. Moving
      core plug-ins in subfolders is only a necessary consequence for it.
      870ca633
    • Michael Natterer's avatar
      Use the new macros from the last commit in all files · bdbec794
      Michael Natterer authored
      ...and gone are the annoying warnings.
      bdbec794
    • Simon Budig's avatar
      file-fli: kill GtkTable · 766b8200
      Simon Budig authored
      766b8200
  5. 22 Dec, 2017 3 commits
    • Jehan's avatar
      plug-ins: clean the rest of the file-fli plug-in. · eb218190
      Jehan authored
      While I am at it, let's just do all the files in there. Other also had a
      bunch of tabs and wrong coding style.
      eb218190
    • Jehan's avatar
      plug-ins: clean-up coding style of fli plug-in code. · 375b7679
      Jehan authored
      There should be absolutely no code change semantic in this commit. If
      there is, that's a mistake and it's on me. I only cleaned up the syntax
      in the C file which basically was following none of GIMP coding style
      (tabs everywhere, brackets at end of lines, nearly no space anywhere so
      all the code was a compressed mess which was hard to read, indentation
      absolutely wrong everywhere, etc.).
      I cleaned it up with a bunch of regexp search-and-replace followed by a
      lot of manual cleaning and verification as well.
      
      I also tested with various FLI files found on the web, and they were
      loading fine in GIMP. So I believe/hope that I didn't mess up somewhere,
      but it looks as the cleaning went all fine.
      375b7679
    • Tobias Stoeckmann's avatar
      Bug 739133 - (CVE-2017-17785) Heap overflow while parsing FLI files. · edb251a7
      Tobias Stoeckmann authored
      It is possible to trigger a heap overflow while parsing FLI files. The
      RLE decoder is vulnerable to out of boundary writes due to lack of
      boundary checks.
      
      The variable "framebuf" points to a memory area which was allocated
      with fli_header->width * fli_header->height bytes. The RLE decoder
      therefore must never write beyond that limit.
      
      If an illegal frame is detected, the parser won't stop, which means
      that the next valid sequence is properly parsed again. This should
      allow GIMP to parse FLI files as good as possible even if they are
      broken by an attacker or by accident.
      
      While at it, I changed the variable xc to be of type size_t, because
      the multiplication of width and height could overflow a 16 bit type.
      Signed-off-by: Tobias Stoeckmann's avatarTobias Stoeckmann <tobias@stoeckmann.org>
      edb251a7
  6. 21 Aug, 2017 1 commit
    • Michael Natterer's avatar
      Move the new "default_new_layer_mode" APIs to the image... · e16c8a23
      Michael Natterer authored
      ...in both the core and libgimp.
      
      Images now know what the default mode for new layers is:
      
      - NORMAL for empty images
      - NORMAL for images with any non-legacy layer
      - NORMAL_LEGAVY for images with only legacy layers
      
      This changes behavior when layers are created from the UI, but *also*
      when created by plug-ins (yes there is a compat issue here):
      
      - Most (all?) single-layer file importers now create NORMAL layers
      - Screenshot, Webpage etc also create NORMAL layers
      
      Scripts that create images from scratch (logos etc) should not be
      affected because they usually have NORMAL_LEGACY hardcoded.
      
      3rd party plug-ins and scripts will also behave old-style unless they
      get ported to gimp_image_get_default_new_layer_mode().
      e16c8a23
  7. 20 Aug, 2017 1 commit
  8. 26 Feb, 2017 1 commit
  9. 12 Feb, 2017 1 commit
  10. 08 Jan, 2017 1 commit
  11. 25 Jun, 2016 1 commit
    • Richard Kreckel's avatar
      Bug 768044 - Fix many typos · dd9b0fc5
      Richard Kreckel authored
      This fixes many typos in comments and one in a user-visible string (msgid
      "center abscisse" changed to "center abscissa" in affected po files. too).
      dd9b0fc5
  12. 16 Feb, 2016 1 commit
  13. 23 Jul, 2014 1 commit
  14. 21 Jun, 2014 1 commit
  15. 09 Nov, 2013 1 commit
  16. 05 Jun, 2013 1 commit
  17. 27 Jan, 2013 1 commit
  18. 20 Nov, 2012 1 commit
  19. 11 Nov, 2012 1 commit
  20. 02 May, 2012 1 commit
  21. 10 Apr, 2011 1 commit
  22. 08 Apr, 2011 1 commit
  23. 13 Feb, 2011 1 commit
  24. 30 Sep, 2010 1 commit
  25. 06 Sep, 2010 1 commit
  26. 01 Sep, 2010 1 commit
    • Michael Schumacher's avatar
      Bug 574018 - Add a manifest to executables · e77dd90f
      Michael Schumacher authored
      Created a resource file for plug-ins and a rule to link it to them.
      The application icon file is smaller than the default one, there's no
      point in doubling the size of a plug-in executable just for an icon.
      
      If no problems turn up, this will close the bug.
      e77dd90f
  27. 21 Jul, 2009 1 commit
  28. 15 Jul, 2009 1 commit
  29. 18 Jun, 2009 1 commit
  30. 31 Jan, 2009 1 commit
  31. 19 Jan, 2009 1 commit
    • Michael Natterer's avatar
      plug-ins/common/*.c plug-ins/color-rotate/color-rotate.c · 4ea14376
      Michael Natterer authored
      2009-01-19  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/common/*.c
      	* plug-ins/color-rotate/color-rotate.c
      	* plug-ins/file-bmp/bmp.c
      	* plug-ins/file-faxg3/faxg3.c
      	* plug-ins/file-fits/fits.c
      	* plug-ins/file-fli/fli-gimp.c
      	* plug-ins/file-ico/ico.c
      	* plug-ins/file-jpeg/jpeg.c
      	* plug-ins/file-psd/psd-save.c
      	* plug-ins/file-psd/psd.c
      	* plug-ins/file-sgi/sgi.c
      	* plug-ins/file-uri/uri.c
      	* plug-ins/file-xjt/xjt.c
      	* plug-ins/flame/flame.c
      	* plug-ins/fractal-explorer/fractal-explorer.c
      	* plug-ins/gfig/gfig.c
      	* plug-ins/gimpressionist/gimp.c
      	* plug-ins/gradient-flare/gradient-flare.c
      	* plug-ins/help-browser/help-browser.c
      	* plug-ins/ifs-compose/ifs-compose.c
      	* plug-ins/imagemap/imap_main.c
      	* plug-ins/lighting/lighting-main.c
      	* plug-ins/map-object/map-object-main.c
      	* plug-ins/maze/maze.c
      	* plug-ins/metadata/metadata.c
      	* plug-ins/pagecurl/pagecurl.c
      	* plug-ins/print/print.c
      	* plug-ins/pygimp/gimpfu.py
      	* plug-ins/script-fu/script-fu-script.c
      	* plug-ins/script-fu/script-fu.c
      	* plug-ins/selection-to-path/selection-to-path.c
      	* plug-ins/twain/twain.c
      	* plug-ins/win-snap/winsnap.c: document the "run-mode" parameter
      	as we document enums for core procedures.
      
      
      svn path=/trunk/; revision=27922
      4ea14376
  32. 17 Jan, 2009 1 commit
    • Michael Natterer's avatar
      Change licence to GPLv3 (and to LGPLv3 for libgimp). · d9b5207a
      Michael Natterer authored
      2009-01-17  Michael Natterer  <mitch@gimp.org>
      
      	* all files with a GPL header and all COPYING files:
      
      	Change licence to GPLv3 (and to LGPLv3 for libgimp).
      
      	Cleaned up some copyright headers and regenerated the parsers in
      	the ImageMap plugin.
      
      
      svn path=/trunk/; revision=27913
      d9b5207a
  33. 20 Aug, 2008 1 commit
  34. 11 Aug, 2008 1 commit
    • Michael Natterer's avatar
      plug-ins/bmp/* plug-ins/faxg3/* plug-ins/fits/* plug-ins/fli/* · 3d75c95f
      Michael Natterer authored
      2008-08-11  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/bmp/*
      	* plug-ins/faxg3/*
      	* plug-ins/fits/*
      	* plug-ins/fli/*
      	* plug-ins/ico/*
      	* plug-ins/jpeg/*
      	* plug-ins/psd/*
      	* plug-ins/sgi/*
      	* plug-ins/uri/*
      	* plug-ins/xjt/*: removed these...
      
      	* plug-ins/file-bmp/*
      	* plug-ins/file-faxg3/*
      	* plug-ins/file-fits/*
      	* plug-ins/file-fli/*
      	* plug-ins/file-ico/*
      	* plug-ins/file-jpeg/*
      	* plug-ins/file-psd/*
      	* plug-ins/file-sgi/*
      	* plug-ins/file-uri/*
      	* plug-ins/file-xjt/*: and moved them here. Changed executable
      	names to "file-foo".
      
      	* plug-ins/Makefile.am: changed accordingly.
      
      	* plug-ins/common/*: rename all file plug-ins to file-foo.c. Get
      	rid of the names "poppler" and "postscript" and call them
      	"file-pdf" and "file-ps" because the conflict with standard
      	autofoo targets is gone.
      
      	* plug-ins/common/plugin-defs.pl: changed accordingly.
      
      	* plug-ins/common/mkgen.pl: make sure cflags variables are named
      	"PLUG_IN_NAME_CFLAGS" and not "PLUG-IN-NAME_CFLAGS"
      
      	* plug-ins/common/Makefile.am: regenerated.
      
      	* configure.in: change folders and variable names to match above
      	changes.
      
      
      svn path=/trunk/; revision=26494
      3d75c95f