1. 01 Oct, 2018 1 commit
  2. 11 Jul, 2018 1 commit
  3. 20 May, 2018 2 commits
    • Jehan's avatar
      plug-ins: install plug-ins in subfolder. · 870ca633
      Jehan authored
      I am going to forbid plug-ins from being installed directly in the root
      of the plug-ins/ directory. They will have to be installed in a
      subdirectory named the same as the entry point binary.
      This may seem useless for our core plug-ins which are nearly all
      self-contained in single binaries, but this is actually a necessary
      restriction to eliminate totally the DLL hell issue on Windows. Moving
      core plug-ins in subfolders is only a necessary consequence for it.
      870ca633
    • Michael Natterer's avatar
      Use the new macros from the last commit in all files · bdbec794
      Michael Natterer authored
      ...and gone are the annoying warnings.
      bdbec794
  4. 25 Apr, 2018 1 commit
  5. 18 Apr, 2018 1 commit
  6. 16 Mar, 2018 1 commit
    • Jehan's avatar
      plug-ins: properly check widget class holding tag data. · 4fdf301d
      Jehan authored
      Some tag data is hold in GtkEntry, other in GtkTextView, which are not
      parent to each other. Previous checks were wrong and resulted in
      "invalid cast from 'GtkEntry' to 'GtkTextView'" WARNINGs (followed by
      many CRITICALs because of this first error).
      
      Also properly free the data returned by gtk_text_buffer_get_text() which
      is allocated (unlike strings returned by gtk_entry_get_text() which must
      not be freed).
      4fdf301d
  7. 10 Jan, 2018 2 commits
    • Jehan's avatar
      plug-ins: fix some coding-style issues in metadata-editor. · bc503201
      Jehan authored
      Mostly missing spaces here and there fixed with search and replace
      followed by manual verification and retouching.
      bc503201
    • Jehan's avatar
      plug-ins: metadata-editor crashes when strtok() initialized with NULL. · 62ee5d3c
      Jehan authored
      When running strtok() the first time, it needs to be non-NULL so we must
      check for the string. This is even more important because NULL actually
      has a special meaning in strtok() to indicate further search on the same
      string, in a stateful way. So searching with NULL at first call was
      crashing the metadata editor plug-in in my case.
      I could also imagine it could have reused strings from previous
      searches, mixing metadata contents in some edge cases. Anyway that would
      be bad as well!
      
      While I was there, I also checked for non-null search string before
      strstr() calls, when there was not already such a check before. This
      function also requires non-NULL haystack argument.
      It feels like this code doesn't do much validity checks, and it's likely
      there are more similar issues. I haven't reviewed the whole code, only
      this part which was crashing here.
      62ee5d3c
  8. 28 Sep, 2017 1 commit
  9. 23 Aug, 2017 1 commit
  10. 21 Aug, 2017 1 commit
  11. 05 Aug, 2017 1 commit
  12. 24 Jul, 2017 1 commit
  13. 14 Jul, 2017 1 commit
  14. 09 Jul, 2017 1 commit
  15. 08 Jul, 2017 6 commits
  16. 07 Jul, 2017 3 commits
  17. 26 Oct, 2013 1 commit
  18. 05 Jun, 2013 1 commit
  19. 25 May, 2013 1 commit
  20. 27 Jan, 2013 1 commit
  21. 19 Jan, 2013 2 commits
  22. 12 Nov, 2012 1 commit
  23. 10 Sep, 2012 1 commit
  24. 08 Sep, 2012 1 commit
  25. 31 Jul, 2012 1 commit
    • Michael Natterer's avatar
      Bug 680432 - metadata.exe keeps dying · c207e395
      Michael Natterer authored
      Based on a patch by Hartmut Kuhse, run all strings through
      gimp_any_to_utf8() which always returns something that's UTF-8, even
      if it's only "(invalid UTF-8 String)". Better than crashing.
      c207e395
  26. 13 Jun, 2012 1 commit
  27. 02 May, 2012 1 commit
  28. 27 Oct, 2011 1 commit
  29. 06 Oct, 2011 2 commits