1. 03 Dec, 2018 1 commit
  2. 02 Dec, 2018 1 commit
  3. 11 Sep, 2018 1 commit
  4. 21 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Initial space invasion commit in GIMP · e09e563a
      Michael Natterer authored
      All babl formats now have a space equivalent to a color profile,
      determining the format's primaries and TRCs. This commit makes GIMP
      aware of this.
      - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
        as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
        NON_LINEAR and PERCPTUAL for each encoding, matching the babl
        encoding variants RGB, R'G'B' and R~G~B~.
      - gimp_color_transform_can_gegl_copy() now returns TRUE if both
        profiles can return a babl space, increasing the amount of fast babl
        color conversions significantly.
      - TODO: no solution yet for getting libgimp drawable proxy buffers in
        the right format with space.
      - follow the GimpPrecision change.
      - TODO: everything else unchanged and partly broken or sub-optimal,
        like setting a new image's color profile too late.
      - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
        replacement for all "linear" booleans.
      - change gimp-babl functions to take babl spaces and GimpTRCType
        parameters and support all sorts of new perceptual ~ formats.
      - a lot of places changed in the early days of goat invasion didn't
        take advantage of gimp-babl utility functions and constructed
        formats manually. They all needed revisiting and many now use much
        simpler code calling gimp-babl API.
      - change gimp_babl_format_get_color_profile() to really extract a
        newly allocated color profile from the format, and add
        gimp_babl_get_builtin_color_profile() which does the same as
        gimp_babl_format_get_color_profile() did before. Visited all callers
        to decide whether they are looking for the format's actual profile,
        or for one of the builtin profiles, simplifying code that only needs
        builtin profiles.
      - drawables have a new get_space_api(), get_linear() is now get_trc().
      - images now have a "layer space" and an API to get it,
        gimp_image_get_layer_format() returns formats in that space.
      - an image's layer space is created from the image's color profile,
        change gimpimage-color-profile to deal with that correctly
      - change many babl_format() calls to babl_format_with_space() and take
        the space from passed formats or drawables
      - add function gimp_layer_fix_format_space() which replaces the
        layer's buffer with one that has the image's layer format, but
        doesn't change pixel values
      - use gimp_layer_fix_format_space() to make sure layers loaded from
        XCF and created by plug-ins have the right space when added to the
        image, because it's impossible to always assign the right space upon
        layer creation
      - "assign color profile" and "discard color profile" now require use
        of gimp_layer_fix_format_space() too because the profile is now
        embedded in all formats via the space.  Add
        gimp_image_assign_color_profile() which does all that and call it
        instead of a simple gimp_image_set_color_profile(), also from the
        PDB set-color-profile functions, which are essentially "assign" and
        "discard" calls.
      - generally, make sure a new image's color profile is set before
        adding layers to it, gimp_image_set_color_profile() is more than
        before considered know-what-you-are-doing API.
      - take special precaution in all places that call
        gimp_drawable_convert_type(), we now must pass a new_profile from
        all callers that convert layers within the same image (such as
        image_convert_type, image_convert_precision), because the layer's
        new space can't be determined from the image's layer format during
        the call.
      - change all "linear" properties to "trc", in all config objects like
        for levels and curves, in the histogram, in the widgets. This results
        in some GUI that now has three choices instead of two.
        TODO: we might want to reduce that back to two later.
      - keep "linear" boolean properties around as compat if needed for file
        pasring, but always convert the parsed parsed boolean to
      - TODO: the image's "enable color management" switch is currently
        broken, will fix that in another commit.
  5. 17 Jul, 2018 1 commit
    • Ell's avatar
      Issue #1825 - PSD files are loaded as merged by default ... · 03201262
      Ell authored
      ... depending on UI language
      Use gimp_register_file_handler_priority(), added in the previous
      commit, to increase the priority of the merged PSD loader, so that
      the non-merged loader is always preferred over it (unless
      explicitly chosen), regardless of the UI language.
  6. 11 Jul, 2018 1 commit
  7. 18 Jun, 2018 1 commit
    • Ell's avatar
      plug-ins: add support for loading merged image data from PSD files · 1d9a8a91
      Ell authored
      PSD files may include a "merged", pre-composited, version of the
      image (in Photoshop, this is the case when saving files with
      "Maximize Compatibility" enabled; GIMP always saves the merged
      image data in exported PSD files.)  This commit adds support for
      loading the merged image version from PSDs, instead of the full
      layer hierarchy.  This is useful when loading PSD files that use
      features that we don't currently support, and therefore can't
      render correctly, such as adjustment layers.
      When loading the merged image version, we avoid loading certain
      additional data from the file, such as channels, paths, and
      guides, while still loading metadata, making this akin to loading
      other "flat" image formats.
      This option is currently exposed as an additional file type
      ("Photoshop image (merged)"), which has to be explicitly selected
      from the file-type list when opening the image.
  8. 12 Jun, 2018 1 commit
  9. 20 May, 2018 1 commit
    • Jehan's avatar
      plug-ins: install plug-ins in subfolder. · 870ca633
      Jehan authored
      I am going to forbid plug-ins from being installed directly in the root
      of the plug-ins/ directory. They will have to be installed in a
      subdirectory named the same as the entry point binary.
      This may seem useless for our core plug-ins which are nearly all
      self-contained in single binaries, but this is actually a necessary
      restriction to eliminate totally the DLL hell issue on Windows. Moving
      core plug-ins in subfolders is only a necessary consequence for it.
  10. 01 May, 2018 1 commit
    • Ell's avatar
      Bug 795693 - GIMP doesn't enable visibility of vector layers in PSD · 474e27b2
      Ell authored
      In the file-psd plug-in, ignore the 'irrelevant' flag of layers
      when loading PSD files; in particular, don't hide such layers
      unconditionally.  The 'irrelevant' flag seems to indicate that the
      layer's content can be entirely derived without using the layer's
      pixel data, and not that the layer itself it irrelevant.
  11. 25 Apr, 2018 1 commit
  12. 18 Apr, 2018 1 commit
  13. 14 Mar, 2018 1 commit
    • Ell's avatar
      app, pdb, libgimp, plug-ins, menus: rename layer composite modes · a7f3a2dd
      Ell authored
      Our composite modes don't correspond directly to the Porter-Duff
      operators after which they're named, and these names aren't too
      descriptive anyway.
      Rename the composite modes as follows:
        Source Over       =>  Union
        Source Atop       =>  Clip to Backdrop
        Destination Atop  =>  Clip to Layer
        Source In         =>  Intersection
      Update relevant code, including UI text, enumerator names, function
      names, and action names.
  14. 05 Feb, 2018 1 commit
  15. 14 Jan, 2018 1 commit
  16. 06 Jan, 2018 1 commit
  17. 06 Dec, 2017 1 commit
    • Ell's avatar
      plug-ins: in file-psd, insert layers to image after writing buffers · 67e68575
      Ell authored
      When loading PSDs, insert layers to the image as the last step of
      layer creation, after writing the pixel data to their buffers, so
      that the data of child layers is available when their parent
      group's projection is subseqeuently invalidated; otherwise, we'd
      need an additional gimp_drawable_update() call after writing the
      data to the buffers.
  18. 11 Nov, 2017 2 commits
    • Ell's avatar
      Bug 789981 - Wrong layer structure in PSDs with deeply nested layer groups · 54ec9373
      Ell authored
      Photoshop CS5 adds support for layer groups whose nesting depth is
      above 5.  The end markers of these groups use an undocumented
      "lsdk" key for their section dividers, rather than the usual
      "lsct".  This caused the PSD plugin to treat them as regular
      layers, resulting in wrong layer-tree structure.
      Add support for "lsdk" section dividers upon loading, and also
      generate "lsdk" section dividers upon saving sufficiently-deep
    • Ell's avatar
      plug-ins: in file-psd, repalce tabs with spaces · 6708af39
      Ell authored
  19. 22 Oct, 2017 2 commits
  20. 09 Oct, 2017 2 commits
  21. 04 Sep, 2017 5 commits
  22. 27 Aug, 2017 1 commit
  23. 21 Aug, 2017 1 commit
    • Michael Natterer's avatar
      Move the new "default_new_layer_mode" APIs to the image... · e16c8a23
      Michael Natterer authored
      ...in both the core and libgimp.
      Images now know what the default mode for new layers is:
      - NORMAL for empty images
      - NORMAL for images with any non-legacy layer
      - NORMAL_LEGAVY for images with only legacy layers
      This changes behavior when layers are created from the UI, but *also*
      when created by plug-ins (yes there is a compat issue here):
      - Most (all?) single-layer file importers now create NORMAL layers
      - Screenshot, Webpage etc also create NORMAL layers
      Scripts that create images from scratch (logos etc) should not be
      affected because they usually have NORMAL_LEGACY hardcoded.
      3rd party plug-ins and scripts will also behave old-style unless they
      get ported to gimp_image_get_default_new_layer_mode().
  24. 20 Aug, 2017 3 commits
  25. 09 Aug, 2017 3 commits
    • Ell's avatar
      plug-ins: in file-psd, use SRC_OVER and RGB_PERCEPTUAL for all layers · dccaa5d5
      Ell authored
      Use SRC_OVER, instead of SRC_ATOP, as the composite mode for all
      layers (or use AUTO, when it results in SRC_OVER), to match
      Photoshop's behavior.  Use RGB_PERCEPTUAL as the blend and composite
      space, instead of AUTO, whose interpretation depends on the specific
      layer mode, to match Photoshop's behavior for RGB images.  Use NORMAL
      mode, instead of NORMAL_LEGACY, with the above properties, for normal
      layers, for consistency with the other layer modes, which don't (and,
      indeed, can't) use the legacy modes.
    • Ell's avatar
      plug-ins: small cleanup to last commit · 4d3481ca
      Ell authored
    • Ell's avatar
      plug-ins: in file-psd, read blend mode info of lsct layer records · e8f6a388
      Ell authored
      The section-divider (lsct) layer resource may contain blend mode
      information, which apparently overrides the blend mode specified in
      the layer record.  When reading such a resource, replace the layer's
      blend mode with the one specified by the resource.
      It seems like pass-through group layers specify normal mode in their
      layer record, but pass-through in their section-divider resource, so
      this commit allows correctly loading such layers.
  26. 08 Aug, 2017 1 commit
  27. 16 Mar, 2017 1 commit
  28. 08 Mar, 2017 1 commit
    • Ell's avatar
      app: implement color-erase mode as a GimpOperationLayerMode blendfun · b22c09e7
      Ell authored
      ... and get rid of the dedicated op.  This gives us support for all
      the blend/composite options for this mode.
      Rename COLOR_ERASE to COLOR_ERASE_LEGACY, with perceptual blending/
      compositing and immutable everything, and add a new COLOR_ERASE
      mode, defaulting to linear blending/compositing, with mutable
      everything.  Modify affected code.
  29. 26 Feb, 2017 1 commit