1. 29 Nov, 2018 1 commit
  2. 27 Nov, 2018 1 commit
    • Jehan's avatar
      app: radius map actually not useful during smart colorization grow step. · 6bec0bc8
      Jehan authored
      The distance map has all the information we need already. Also we will
      actually grow up to the max radius pixel (middle pixel of a stroke).
      After discussing with Aryeom, we realized it was better to fill a stroke
      fully (for cases of overflowing, I already added the "Maximum growing
      size" property anyway).
  3. 22 Nov, 2018 2 commits
    • Jehan's avatar
      app: add "line-art-max-grow" property to the bucket fill options. · eb042e6c
      Jehan authored
      When flooding the line art, we may overflood it in sample merge (which
      would use color in the line art computation). And if having all colors
      on the same layer, this would go over other colors (making the wrong
      impression that the line art leaked).
      This new option is mostly to keep some control over the mask growth.
      Usually a few pixels is enough for most styles of drawing (though we
      could technically allow for very wide strokes).
    • Jehan's avatar
      app: replace gegl:watershed-transform with custom algorithm. · 3467acf0
      Jehan authored
      We don't really need to flow every line art pixel and this new
      implementation is simpler (because we don't actually need over-featured
      watershedding), and a lot lot faster, making the line art bucket fill
      now very reactive.
      For this, I am keeping the computed distance map, as well as local
      thickness map around to be used when flooding the line art pixels
      (basically I try to flood half the stroke thickness).
      Note that there are still some issues with this new implementation as it
      doesn't properly flood yet created (i.e. invisible) splines and
      segments, and in particular the ones between 2 colored sections. I am
      going to fix this next.
  4. 19 Nov, 2018 1 commit
  5. 14 Nov, 2018 2 commits
    • Jehan's avatar
      app: edit the bucket fill tool options with new line art options. · 824af124
      Jehan authored
      I have not added all the options for this new tool yet, but this sets
      the base. I also added a bit of TODO for several places where we need to
      make it settable, in particular the fuzzy select tool, but also simply
      PDB calls (this will need to be a PDB context settings.
      Maybe also I will want to make some LineArtOptions struct in order not
      to have infinite list of parameters to functions. And at some point, it
      may also be worth splitting a bit process with other type of
      selection/fill (since they barely share any settings anyway).
      Finally I take the opportunity to document a little more the parameters
      to gimp_lineart_close(), which can still be improved later (I should
      have documented these straight away when I re-implemented this all from
      G'Mic code, as I am a bit fuzzy on some details now and will need to
      re-understand code).
    • Jehan's avatar
      app: compute line art in advance. · f246f404
      Jehan authored
      Right now, this is mostly meaningless as it is still done sequentially.
      But I am mostly preparing the field to pre-compute the line art as
      background thread.
  6. 11 Jul, 2018 1 commit
  7. 22 Jun, 2017 1 commit
  8. 16 Jan, 2016 2 commits
    • Ell's avatar
      app: Add diagonal_neighbors parameter to gimp_channel_select_fuzzy() · e0b1aa1c
      Ell authored
      and propagate it to gimp_pickable_contiguous_region_by_seed(), in
      preperation for adding a diagonal-neighbors setting to PDB.
    • Ell's avatar
      app: Add diagonal_neighbors parameter to... · 93bf78b8
      Ell authored
      ...gimp_pickable_contiguous_region_by_seed(), in preperation
      for adding a similar option to the relevant tools.
      When this parameter is TRUE, all eight neighbors of each pixel
      are considered when calculating the resulting region, instead
      of just the four orthogonal ones.
      This commit also modifies all callers to pass FALSE for this
      parameter, to retain the current behavior.
  9. 25 Aug, 2015 1 commit
  10. 31 May, 2014 1 commit
  11. 04 Mar, 2014 1 commit
    • Michael Natterer's avatar
      Bug 725556 - Feather selection extremely slow · 30ae88ef
      Michael Natterer authored
      gimp_gegl_apply_feather(): add a "dest_rect" parameter to restrict
      the feather area. Pass the selection bounds plus the feather radius.
      For consistency, newly add gimp_gegl_apply_border,grow,shrink() and use
      them in gimpchannel.c
  12. 14 Oct, 2013 1 commit
    • Michael Natterer's avatar
      app,libgimp*: fix includes to follow our include policy · 697572cc
      Michael Natterer authored
      - don't include <gdk-pixbuf/gdk-pixbuf.h> in headers in app/
      - instead, include it in many .c files instead of <glib-object.h>,
        finally acknowledging the fact that app/ depends on gdk-pixbuf almost
      - fix up includes as if libgimpbase depended in GIO, which it soon will
  13. 08 Apr, 2013 3 commits
  14. 02 May, 2012 3 commits
  15. 10 Apr, 2011 1 commit
  16. 09 Jun, 2010 1 commit
    • Barak Itkin's avatar
      app: add context to all undo descriptions · 5930b130
      Barak Itkin authored
      Description of undo actions should be marked as action descriptions,
      and not as commands. This is required for translation for some
      language (like Hebrew) that require a different grammatical tense for
      describing actions
  17. 17 Jan, 2009 1 commit
    • Michael Natterer's avatar
      Change licence to GPLv3 (and to LGPLv3 for libgimp). · d9b5207a
      Michael Natterer authored
      2009-01-17  Michael Natterer  <mitch@gimp.org>
      	* all files with a GPL header and all COPYING files:
      	Change licence to GPLv3 (and to LGPLv3 for libgimp).
      	Cleaned up some copyright headers and regenerated the parsers in
      	the ImageMap plugin.
      svn path=/trunk/; revision=27913
  18. 03 Nov, 2008 1 commit
    • Michael Natterer's avatar
      renamed gimp_item_width() to gimp_item_get_width() and gimp_item_height() · 740ab5e6
      Michael Natterer authored
      2008-11-03  Michael Natterer  <mitch@gimp.org>
      	* app/core/gimpitem.[ch]: renamed
      	gimp_item_width() to gimp_item_get_width() and
      	gimp_item_height() to gimp_item_get_height().
      	* app/actions/channels-commands.c
      	* app/actions/drawable-commands.c
      	* app/actions/layers-commands.c
      	* app/core/<many>.c
      	* app/dialogs/offset-dialog.c
      	* app/dialogs/resize-dialog.c
      	* app/dialogs/scale-dialog.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/display/gimpdisplayshell.c
      	* app/paint/gimpbrushcore.c
      	* app/paint/gimpdodgeburn.c
      	* app/paint/gimpink.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimpsmudge.c
      	* app/text/gimptextlayer-xcf.c
      	* app/text/gimptextlayer.c
      	* app/tools/gimpaligntool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimprectangletool.c
      	* app/tools/gimpregionselecttool.c
      	* app/tools/gimptexttool.c
      	* app/vectors/gimpvectors.c
      	* app/vectors/gimpvectorsmodundo.c
      	* app/widgets/gimptoolbox-dnd.c
      	* app/widgets/gimpviewrendererdrawable.c
      	* app/widgets/gimpviewrenderervectors.c
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c
      	* tools/pdbgen/pdb/drawable.pdb: changed accordingly.
      	* app/pdb/drawable-cmds.c: regenerated.
      svn path=/trunk/; revision=27531
  19. 02 Nov, 2008 1 commit
    • Michael Natterer's avatar
      renamed gimp_item_offsets() to gimp_item_get_offset() and · 5b68a1d0
      Michael Natterer authored
      2008-11-03  Michael Natterer  <mitch@gimp.org>
      	* app/core/gimpitem.[ch]: renamed
      	gimp_item_offsets() to gimp_item_get_offset() and
      	gimp_item_set_offsets() to gimp_item_set_offset().
      	* app/actions/drawable-commands.c
      	* app/actions/layers-commands.c
      	* app/core/<many>.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/display/gimpdisplayshell-preview.c
      	* app/display/gimpdisplayshell-transform.c
      	* app/display/gimpdisplayshell.c
      	* app/paint/gimppaintcore-stroke.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimpsourcecore.c
      	* app/text/gimptextlayer-xcf.c
      	* app/tools/<many>.c
      	* app/widgets/gimptoolbox-dnd.c
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/drawable_transform.pdb
      	* tools/pdbgen/pdb/selection.pdb
      	* tools/pdbgen/pdb/transform_tools.pdb
      	* tools/pdbgen/pdb/vectors.pdb: changed accordingly.
      	* app/pdb/drawable-cmds.c
      	* app/pdb/drawable-transform-cmds.c
      	* app/pdb/selection-cmds.c
      	* app/pdb/vectors-cmds.c
      	* app/pdb/transform-tools-cmds.c: regenerated.
      svn path=/trunk/; revision=27529
  20. 09 Oct, 2008 1 commit
    • Michael Natterer's avatar
      Add GEGL_CFLAGS and #includes as if gimpdrawable.h and gimpimage.h had a · 5503e6a0
      Michael Natterer authored
      2008-10-09  Michael Natterer  <mitch@gimp.org>
      	Add GEGL_CFLAGS and #includes as if gimpdrawable.h and gimpimage.h
      	had a GEGL dependency (they will have in the next commit, but I
      	wanted to keep the commit separate).
      	* app/dialogs/Makefile.am
      	* app/file/Makefile.am
      	* app/gui/Makefile.am
      	* app/menus/Makefile.am
      	* app/paint/Makefile.am
      	* app/plug-in/Makefile.am
      	* app/text/Makefile.am
      	* app/vectors/Makefile.am
      	* app/widgets/Makefile.am
      	* app/xcf/Makefile.am: add GEGL_CFLAGS.
      	* app/actions/*.c
      	* app/core/*.c
      	* app/dialogs/*.c
      	* app/display/*.c
      	* app/file/*.c
      	* app/gui/*.c
      	* app/menus/*.c
      	* app/paint/*.c
      	* app/pdb/gimppdb-utils.c
      	* app/pdb/gimpprocedure.c
      	* app/plug-in/*.c
      	* app/text/*.c
      	* app/tools/*.c
      	* app/vectors/*.c
      	* app/widgets/*.c
      	* app/xcf/*.c: add <gegl.h> or replace <glib-object.h> by <gegl.h>
      	to all files which include a drawable subclass or gimpimage.h
      	* tools/pdbgen/app.pl: include <gegl.h> instead of <glib-object.h>
      	in all generated files.
      	* app/pdb/*-cmds.c: regenerated.
      	* data/images/gimp-splash.png: the goat is still sleeping.
      	By Aurore Derriennic.
      svn path=/trunk/; revision=27202
  21. 23 May, 2008 1 commit
    • Sven Neumann's avatar
      app/core/gimpchannel-select.c app/core/gimpdrawable-bucket-fill.c · 5aa59b3b
      Sven Neumann authored
      2008-05-23  Sven Neumann  <sven@gimp.org>
      	* app/core/gimpchannel-select.c
      	* app/core/gimpdrawable-bucket-fill.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpimage-crop.c
      	* app/dialogs/image-scale-dialog.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimppolygonselecttool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c
      	* libgimpwidgets/gimpcolorprofilestore.c
      	* plug-ins/gfig/gfig-dialog.c: use C_() instead of Q_() for
      	translations with context.
      svn path=/trunk/; revision=25777
  22. 23 Dec, 2007 1 commit
    • Michael Natterer's avatar
      app/actions/layers-commands.c app/core/gimpchannel-combine.c · ecb2c46d
      Michael Natterer authored
      2007-12-23  Michael Natterer  <mitch@gimp.org>
      	* app/actions/layers-commands.c
      	* app/core/gimpchannel-combine.c
      	* app/core/gimpchannel-select.c
      	* app/core/gimpchannel.c
      	* app/core/gimpdrawable-convert.c
      	* app/core/gimpdrawable.c
      	* app/core/gimpdrawablemodundo.c
      	* app/core/gimpfloatingselundo.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage.c
      	* app/core/gimpitem-preview.c
      	* app/core/gimpitem.c
      	* app/core/gimplayer-floating-sel.c
      	* app/core/gimplayer.c
      	* app/core/gimplayermask.c
      	* app/core/gimplayerundo.c
      	* app/core/gimpmaskundo.c
      	* app/core/gimppalette-import.c
      	* app/core/gimpprojection-construct.c
      	* app/core/gimpselection.c
      	* app/dialogs/offset-dialog.c
      	* app/text/gimptextlayer-xcf.c
      	* app/text/gimptextlayer.c
      	* app/vectors/gimpvectors-compat.c
      	* app/vectors/gimpvectors.c
      	* app/vectors/gimpvectorsmodundo.c
      	* app/widgets/gimplayertreeview.c
      	* app/widgets/gimpviewrendererdrawable.c
      	* app/widgets/gimpviewrenderervectors.c: use accessors for item,
      	layer, channel and mask attributes.
      svn path=/trunk/; revision=24429
  23. 09 Mar, 2007 1 commit
    • Michael Natterer's avatar
      include "libgimpmath/gimpmathtypes.h" instead of "libgimpmath/gimpmath.h". · 83d3a750
      Michael Natterer authored
      2007-03-09  Michael Natterer  <mitch@gimp.org>
      	* app/core/core-types.h: include "libgimpmath/gimpmathtypes.h"
      	instead of "libgimpmath/gimpmath.h".
      	* app/core/gimpbrush.h
      	* app/paint/gimppaintcore.h
      	* app/paint/gimpperspectiveclone.h
      	* app/text/gimptext.h
      	* app/tools/gimptransformtool.h: include gimpvector.h and
      	gimpmatrix.h explicitely where they are needed in public structs.
      	* app/*/*.c
      	* tools/pdbgen/pdb/paths.pdb: include "libgimpmath/gimpmath.h"
      	where needed.
      	* app/pdb/paths_cmds.c: regenerated.
      svn path=/trunk/; revision=22084
  24. 09 Dec, 2006 1 commit
  25. 18 Oct, 2006 1 commit
    • Michael Natterer's avatar
      Applied modified patch from Martin Nordholts which adds a "Rounded · 1ee6516d
      Michael Natterer authored
      2006-10-18  Michael Natterer  <mitch@gimp.org>
      	Applied modified patch from Martin Nordholts which adds a "Rounded
      	Corners" option to the rectangle select tool. Fixes bug #86279.
      	* app/core/gimpchannel-combine.[ch]: added
      	gimp_channel_combine_ellipse_rect(). Use it from
      	* app/core/gimpchannel-select.[ch]: added
      	* app/tools/gimprectangleselectoptions.[ch]: added properties
      	"round-corners" and "corner-radius" and GUI for the new propeties.
      	* app/tools/gimprectangleselecttool.h: added macro
      	* app/tools/gimprectangleselecttool.c (gimp_rect_select_tool_draw):
      	draw round corners if enabled.
      	(gimp_rect_select_tool_real_select): use
      	gimp_channel_select_round_rect() if enabled.
      	* app/tools/gimpselectionoptions.[ch]: added "antialias_toggle"
      	to the GimpSelectionOptions struct so the rect select options
      	can set its sensitivity.
      	* app/tools/gimpellipseselecttool.c (gimp_ellipse_select_tool_draw):
      	use 360 * 64 instead of 23040.
  26. 25 Aug, 2006 1 commit
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 1d03a22c
      William Skaggs authored
      	* app/core/gimpchannel-select.[ch]: add push_undo arguments
      	to several gimp_channel_select_foo functions.
      	* app/actions/vectors-commands.c
      	* app/core/gimpchannel-select.c
      	* app/core/gimpchannel-select.h
      	* app/pdb/paths_cmds.c
      	* app/pdb/selection_tools_cmds.c
      	* app/pdb/vectors_cmds.c
      	* app/tools/gimpellipseselecttool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimprectangleselecttool.c
      	* app/tools/gimpvectortool.c
      	* tools/pdbgen/pdb/paths.pdb
      	* tools/pdbgen/pdb/selection_tools.pdb
      	* tools/pdbgen/pdb/vectors.pdb:  add push_undo argument
      	to function calls where needed.
  27. 05 Aug, 2006 1 commit
    • Michael Natterer's avatar
      Applied (modified and enhanced) patch from Chris Moller which allows tools · 9dabd23e
      Michael Natterer authored
      2006-08-05  Michael Natterer  <mitch@gimp.org>
      	Applied (modified and enhanced) patch from Chris Moller which allows
      	tools to distinguish similar colors not only by composite, but also
      	by R, G, B, H, S and V. Fixes bug #348291.
      	* app/core/core-enums.[ch]: added new enum GimpSelectCriterion
      	which can be one of { COMPOSITE, R, G, B, H, S, V }.
      	* app/core/gimpimage-contiguous-region.[ch]: added
      	select_criterion params and create the region based on difference
      	by the selected criterion.
      	* app/core/gimpchannel-select.[ch]
      	* app/core/gimpdrawable-bucket-fill.[ch]: take criterion params and
      	pass them through to the contiguous region functions.
      	* app/tools/gimpbucketfilloptions.[ch]
      	* app/tools/gimpselectionoptions.[ch]: added criterion properties
      	and GUI to select it.
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpfuzzyselecttool.c: pass the selected criterion to
      	the resp. core functions.
      	* app/widgets/gimpdrawabletreeview.c
      	* app/widgets/gimpselectioneditor.c
      	* app/display/gimpdisplayshell-dnd.c
      	* tools/pdbgen/pdb/edit.pdb
      	* tools/pdbgen/pdb/selection_tools.pdb: changed accordingly
      	(simply pass GIMP_SELECT_CRITERION_COMPOSITE in most cases).
      	* app/pdb/edit_cmds.c
      	* app/pdb/selection_tools_cmds.c: regenerated.
  28. 27 Jun, 2006 1 commit
    • Sven Neumann's avatar
      app/core/gimpchannel-select.c app/core/gimpdrawable-bucket-fill.c · 12e0bf90
      Sven Neumann authored
      2006-06-27  Sven Neumann  <sven@gimp.org>
      	* app/core/gimpchannel-select.c
      	* app/core/gimpdrawable-bucket-fill.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpimage-crop.c
      	* app/dialogs/image-scale-dialog.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpmovetool.c
      	* plug-ins/gfig/gfig-dialog.c: applied patch from Zbigniew Chyla
      	that adds translation context to some problematic strings
      	(bug #345982).
  29. 07 Apr, 2006 1 commit
  30. 24 Mar, 2006 2 commits
    • Sven Neumann's avatar
      app/actions/colormap-editor-actions.c · f40e8e8a
      Sven Neumann authored
      2006-03-24  Sven Neumann  <sven@gimp.org>
      	* app/actions/colormap-editor-actions.c
      	* app/actions/gradient-editor-actions.c
      	* app/actions/palette-editor-actions.c
      	* app/core/gimp-edit.c
      	* app/core/gimpchannel-select.c: some more string changes, mainly
      	avoiding the use of FG and BG in labels where there's no need for
      	being concise.
    • Sven Neumann's avatar
      renamed from "Rect Select" to "Rectangle Select" (bug #335715). · d6562240
      Sven Neumann authored
      2006-03-24  Sven Neumann  <sven@gimp.org>
              * app/tools/gimprectselecttool.c: renamed from "Rect Select" to
              "Rectangle Select" (bug #335715).
              * app/core/gimpchannel-select.c (gimp_channel_select_rectangle):
              string change (bug #335715).
              * plug-ins/common/svg.c: follow the change to the file format
              label done in the shared-mime-info package (bug #335716).
              * configure.in: fixed the --without-libtiff case in the summary
              (bug #335764).
  31. 15 Jan, 2005 1 commit
    • Michael Natterer's avatar
      don't require a non-NULL color parameter (just leave the default color · d0a78f3b
      Michael Natterer authored
      2005-01-15  Michael Natterer  <mitch@gimp.org>
      	* app/core/gimpchannel.c (gimp_channel_new*): don't require a
      	non-NULL color parameter (just leave the default color untouched
      	if NULL is passed).
      	* app/actions/channels-commands.c
      	* app/core/gimpchannel-select.c: pass NULL as color for temporary
      	channels or channels where we used to pass black.
  32. 16 Nov, 2004 1 commit
    • Michael Natterer's avatar
      app/core/gimpchannel-select.c app/core/gimpchannel.c · 0d5df419
      Michael Natterer authored
      2004-11-16  Michael Natterer  <mitch@gimp.org>
      	* app/core/gimpchannel-select.c
      	* app/core/gimpchannel.c
      	* app/core/gimpdrawable-desaturate.c
      	* app/core/gimpdrawable-equalize.c
      	* app/core/gimpdrawable-histogram.c
      	* app/core/gimpdrawable-invert.c
      	* app/core/gimpdrawable-levels.c
      	* app/core/gimpdrawable-offset.c
      	* app/core/gimpdrawable-stroke.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpdrawable.c
      	* app/core/gimpitem-linked.c
      	* app/core/gimpitem.c
      	* app/core/gimplayer.c
      	* app/core/gimpselection.c
      	* app/paint/gimppaintcore-stroke.c
      	* app/text/gimptextlayer.c: in all functions which somehow
      	(explicitely or implicitely) touch undo, either g_return_if_fail()
      	on gimp_item_is_attached() or simply don't push an undo step if
      	feasible (e.g. for simple stuff like layer opacity).
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/paint_tools.pdb: let PDB wrappers fail
      	accordingly so they don't run into the assertions added above.
      	* app/pdb/color_cmds.c
      	* app/pdb/drawable_cmds.c
      	* app/pdb/image_cmds.c
      	* app/pdb/layer_cmds.c
      	* app/pdb/paint_tools_cmds.c: regenerated.