1. 05 Feb, 2019 1 commit
  2. 30 Jan, 2019 1 commit
  3. 15 Jan, 2019 2 commits
    • Ell's avatar
      libgimp: in GimpTileBackendPlugin, change default tile multiplier to 1 · a5e2945b
      Ell authored
      In GimpTileBackendPlugin, change the default tile multiplier,
      specifying the ratio between the backend tile-size, and GIMP's
      tile-size, from 2 to 1.  Since we're reading/writing each GIMP tile
      using a separate command anyway, using a large multiplier doesn't
      provide any benefits, while it does have drawbacks.  In particular,
      it reduces the chance that a write operation will affect an entire
      tile, which allows us to avoid reading the tile data from GIMP.
    • Ell's avatar
      libgimp: in GimpTileBackendPlugin, don't read tile data upon TILE_SET · 5ffdb9aa
      Ell authored
      Add an internal _gimp_tile_ref_noinit() function, which increases
      the ref-count of a tile *without* initializing its data (in
      particular, without reading its data from GIMP, or zeroing it.)
      Use this function, instead of gimp_tile_ref(), when storing a tile
      in GimpTileBackendPlugin, to avoid unnecessarily reading the tile
      data from GIMP.
  4. 12 Jan, 2019 1 commit
    • Ell's avatar
      Issue #440 - libgimp/gimptilebackendplugin.c provides no pyramid · d0ae39f0
      Ell authored
      In GimpTileBackendPlugin, return NULL when fetching z>0 tiles,
      instead of simply ignoring the z coordinate, so that the mipmapped
      tile is rendered locally.  Likewise, avoid storing z>0 tiles.
      Note that this is suboptimal, since all the necessary level-0 tiles
      need to be sent to the buffer as a result.  Ideally, we should
      extend the wire protocol to handle mipmapped tiles.
  5. 06 Jan, 2019 1 commit
    • Michael Natterer's avatar
      Issue #1437 - 2.10 Image Metadata "keywords" corrupt · d708ac0b
      Michael Natterer authored
      We were not taking into account tags that can appear multiple times,
      such as "keyword", they are handled by gexiv2 with the
      get_tag_multiple() and set_tag_multiple() functions.
      gimp_metadata_deserialize_text(): when deserializing our XML format,
      check if a tag is already set on the metadata as "multiple" and if yes
      retrieve it, append the new value and set it again.
      gimp_image_metadata_save_finish(): take care of "multiple" values when
      copying tags to new metadata created for saving.
      This should preserve all values across an "import, edit, export".
      Thing will still break when using the metadata editor, it doesn't
      handle multiple values at all, but that code is very hard to
  6. 04 Jan, 2019 2 commits
  7. 02 Jan, 2019 3 commits
  8. 01 Jan, 2019 2 commits
  9. 12 Dec, 2018 1 commit
    • Jehan's avatar
      app: do not make line art bucket fill a GimpSelectCriterion anymore. · cd924f45
      Jehan authored
      This was my initial choice, but the more I think about it, the less I am
      sure this was the right choice. There was some common code (as I was
      making a common composite bucket fill once the line art was generated),
      but there is also a lot of different code and the functions were filled
      of exception when we were doing a line art fill. Also though there is a
      bit of color works (the way we decide whether a pixel is part of a
      stroke or not, though currently this is basic grayscale threshold), this
      is really not the same as other criterions. In particular this was made
      obvious on the Select by Color tool where the line art criterion was
      completely meaningless and would have had to be opted-out!
      This commit split a bit the code. Instead of finding the line art in the
      criterion list, I add a third choice to the "Fill whole selection"/"Fill
      similar colors" radio. In turn I create a new GimpBucketFillArea type
      with the 3 choices, and remove line art value from GimpSelectCriterion.
      I am not fully happy yet of this code, as it creates a bit of duplicate
      code, and I would appreciate to move some code away from gimpdrawable-*
      and gimppickable-* files. This may happen later. I break the work in
      pieces to not get too messy.
      Also this removes access to the smart colorization from the API, but
      that's probably ok as I prefer to not freeze options too early in the
      process since API needs to be stable. Probably we should get a concept
      of experimental API.
  10. 04 Dec, 2018 3 commits
  11. 19 Nov, 2018 1 commit
  12. 18 Oct, 2018 1 commit
    • Alex Samorukov's avatar
      Fix plugin focus issues on osx · ac26671e
      Alex Samorukov authored
      GTK/OSX does not automatically assign focus to the new windows (upstream
      issue), so activateIgnoringOtherApps is called. However, if it is called
      before gtk initialized it may cause number of focus issues.
      (cherry picked from commit 3adf4a48)
  13. 18 Sep, 2018 1 commit
    • Ell's avatar
      app, libgimp*, modules: don't use g_type_class_add_private() ... · 3b0040c0
      Ell authored
      g_type_class_add_private() and G_TYPE_INSTANCE_GET_PRIVATE() were
      deprecated in GLib 2.58.  Instead, use
      G_ADD_PRIVATE[_DYNAMIC](), and the implictly-defined
      foo_get_instance_private() functions, all of which are available in
      the GLib versions we depend on.
      This commit only covers types registered using one of the
      G_DEFINE_FOO() macros (i.e., most types), but not types with a
      custom registration function, of which we still have a few -- GLib
      currently only provides a (non-deprecated) public API for adding a
      private struct using the G_DEFINE_FOO() macros.
      Note that this commit was 99% auto-generated (because I'm not
      *that* crazy :), so if there are any style mismatches... we'll have
      to live with them for now.
  14. 19 Aug, 2018 2 commits
    • Ell's avatar
      libgimp: in GimpTileBackendPlugin, use gegl_tile_backend_command() · 668fee96
      Ell authored
      In the command handler of GimpTileBackendPlugin, forward unhandled
      commands to gegl_tile_backend_command(), instead of asserting that
      they're within range (which has already been disabled by commit
      bc3b076c).  See GEGL commit
    • Ell's avatar
      libgimp: disable tile command range check in plug-in tile backend · bc3b076c
      Ell authored
      In gimp_tile_backend_plugin_command(), disable the range check for
      the input tile command.  This check prevents us from adding new
      tile commands to GEGL without breaking the ABI; yet, the next GEGL
      release will add a new command.  We're going to have to decide what
      to do about this, but for now, let's just disable the check, so
      that at least GIMP 2.10.6 is compatible with newer versions of
      GEGL, no matter how we end up handling this.
      (cherry picked from commit 90ed3c8d)
  15. 24 Jul, 2018 1 commit
    • Ell's avatar
      */Makefile.am: add *marshal.h files to BUILT_SOURCES · a5102a7d
      Ell authored
      In subdirs containing a generated foomarshal.h header, add the
      generated sources to BUILT_SOURCES, so that they're generated
      before the rest of the source files are built.  Otherwise, since
      there is no rule specifying the dependency between the rest of the
      source files and foomarshal.h, and since foomarshal.h is not
      checked into git (and hence doesn't exist when doing a clean
      build), compilation of the said source files may fail if they're
      built before foomarshal.h is generated.
  16. 21 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Initial space invasion commit in GIMP · e09e563a
      Michael Natterer authored
      All babl formats now have a space equivalent to a color profile,
      determining the format's primaries and TRCs. This commit makes GIMP
      aware of this.
      - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
        as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
        NON_LINEAR and PERCPTUAL for each encoding, matching the babl
        encoding variants RGB, R'G'B' and R~G~B~.
      - gimp_color_transform_can_gegl_copy() now returns TRUE if both
        profiles can return a babl space, increasing the amount of fast babl
        color conversions significantly.
      - TODO: no solution yet for getting libgimp drawable proxy buffers in
        the right format with space.
      - follow the GimpPrecision change.
      - TODO: everything else unchanged and partly broken or sub-optimal,
        like setting a new image's color profile too late.
      - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
        replacement for all "linear" booleans.
      - change gimp-babl functions to take babl spaces and GimpTRCType
        parameters and support all sorts of new perceptual ~ formats.
      - a lot of places changed in the early days of goat invasion didn't
        take advantage of gimp-babl utility functions and constructed
        formats manually. They all needed revisiting and many now use much
        simpler code calling gimp-babl API.
      - change gimp_babl_format_get_color_profile() to really extract a
        newly allocated color profile from the format, and add
        gimp_babl_get_builtin_color_profile() which does the same as
        gimp_babl_format_get_color_profile() did before. Visited all callers
        to decide whether they are looking for the format's actual profile,
        or for one of the builtin profiles, simplifying code that only needs
        builtin profiles.
      - drawables have a new get_space_api(), get_linear() is now get_trc().
      - images now have a "layer space" and an API to get it,
        gimp_image_get_layer_format() returns formats in that space.
      - an image's layer space is created from the image's color profile,
        change gimpimage-color-profile to deal with that correctly
      - change many babl_format() calls to babl_format_with_space() and take
        the space from passed formats or drawables
      - add function gimp_layer_fix_format_space() which replaces the
        layer's buffer with one that has the image's layer format, but
        doesn't change pixel values
      - use gimp_layer_fix_format_space() to make sure layers loaded from
        XCF and created by plug-ins have the right space when added to the
        image, because it's impossible to always assign the right space upon
        layer creation
      - "assign color profile" and "discard color profile" now require use
        of gimp_layer_fix_format_space() too because the profile is now
        embedded in all formats via the space.  Add
        gimp_image_assign_color_profile() which does all that and call it
        instead of a simple gimp_image_set_color_profile(), also from the
        PDB set-color-profile functions, which are essentially "assign" and
        "discard" calls.
      - generally, make sure a new image's color profile is set before
        adding layers to it, gimp_image_set_color_profile() is more than
        before considered know-what-you-are-doing API.
      - take special precaution in all places that call
        gimp_drawable_convert_type(), we now must pass a new_profile from
        all callers that convert layers within the same image (such as
        image_convert_type, image_convert_precision), because the layer's
        new space can't be determined from the image's layer format during
        the call.
      - change all "linear" properties to "trc", in all config objects like
        for levels and curves, in the histogram, in the widgets. This results
        in some GUI that now has three choices instead of two.
        TODO: we might want to reduce that back to two later.
      - keep "linear" boolean properties around as compat if needed for file
        pasring, but always convert the parsed parsed boolean to
      - TODO: the image's "enable color management" switch is currently
        broken, will fix that in another commit.
  17. 17 Jul, 2018 1 commit
    • Ell's avatar
      app, pdb: add gimp-register-file-handler-priority procedure · b4ac9568
      Ell authored
      Add a gimp-register-file-handler-priority procedure, which can be
      used to set the priority of a file-handler procedure.  When more
      than one file-handler procedure matches a file, the procedure with
      the lowest priority is used; if more than one procedure has the
      lowest priority, it is unspecified which one of them is used.  The
      default priority of file-handler procedures is 0.
      Add the necessary plumbing (plus some fixes) to the plug-in manager
      to handle file-handler priorities.  In particular, use two
      different lists for each type of file-handler procedures: one meant
      for searching, and is sorted according to priority, and one meant
      for display, and is sorted alphabetically.
  18. 14 Jul, 2018 1 commit
  19. 13 Jul, 2018 1 commit
  20. 11 Jul, 2018 1 commit
  21. 23 Jun, 2018 1 commit
  22. 18 Jun, 2018 2 commits
  23. 06 Jun, 2018 1 commit
    • Michael Natterer's avatar
      app, libgimp*: remove the config option to disable tooltips · b3620517
      Michael Natterer authored
      Also remove all traces of it from the plug-in protocol and raise the
      protocol version to 0x0100 (we now allow features and therefore
      version bumps in stable, and the master protocol version should always
      be higher). Fix the code that aborts plug-in startup on protocol
      version mismatch, we can't use gimp_message() because we have no
  24. 29 May, 2018 2 commits
    • Ell's avatar
    • Ell's avatar
      libgimpbase, libgimp, app: pass icon theme dir to plug-ins through config · 97925de8
      Ell authored
      Pass the current icon theme directory to plug-ins through the
      config message, and add a gimp_icon_theme_dir() libgimp function
      for retrieving it.  Note that we already have a similar
      gimp_icon_get_theme_dir() PDB function, which we keep around, since
      it can be used to dynamically query for the current icon dir,
      unlike the former, and since it returns a dynamically-allocated
      string, while the rest of the config-related functions return
      statically allocated strings.
      Use the new function, instead of gimp_get_icon_theme_dir(), in
      gimp_ui_init().  This allows gimp_ui_init() to run without making
      any PDB calls.  Consequently, this allows us to start plug-ins that
      call gimp_ui_init() without entering the main loop in the main app.
      We're going to add a plug-in that displays an interactive dialog
      while the main app is blocking waiting for an operation to
      complete, and we need to be able to start the plug-in without
      entering the main loop, to avoid the possibility of arbitrary code
      being executed during the wait.
      Bump the protocol version.
  25. 25 May, 2018 1 commit
  26. 20 May, 2018 5 commits