1. 13 Jan, 2018 1 commit
  2. 16 Dec, 2017 2 commits
    • Jehan's avatar
      plug-ins: add a SCREENSHOT_CAN_SHOOT_WINDOW capability. · 80490a2c
      Jehan authored
      And add the relevant option for when such capability is absent. Right
      now it is absent only from the new Freedesktop API.
      80490a2c
    • Jehan's avatar
      plug-ins: implementation of the Freedesktop portal for screenshot. · 53a03b38
      Jehan authored
      I am told by the GNOME/Flatpak people that this is what we will
      ultimately need to implement. Basically this portal is supposed to work
      everywhere, in sandboxes (Flatpak, hopefully Snap too?), but also out
      of sandboxes, i.e. in GNOME and KDE, whether Wayland or X11. So that
      should be the unique API we will have to implement in the end, and every
      desktop environment/sandbox will need to implement this API (which is
      good!).
      Apparently it is not part of default GNOME yet, but has to be installed
      separately (on Fedora, package is xdg-desktop-portal-gtk for GNOME and
      xdg-desktop-portal-kde for KDE).
      
      Now there are currently many shortcomings, and in particular, the
      screenshot API has apparently no advanced features (at all!). No window
      snap, no rectangular selection, no delaying, no choice on including
      cursor or decoration, nothing! Apparently this is normal that the API
      presents no feature, because "the API itself is not meant to specify the
      details how the screenshot is obtained. Instead the portal will present
      the user a dialog to take a screenshot, and that screenshot will be
      given back to the sandboxed app".
      This is acceptable behavior, except that currently, the dialog has none
      of the basic features so this is a very bad regression. This is why I
      test the freedesktop API last, which basically means it will likely
      never be actually used. That's on purpose. At least, the code is in and
      will be easy to improve later. Of course, when the Freedesktop portal
      for screenshot will finally be featureful, it is meant to be tested
      first.
      
      See: https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.Screenshot.xml
      53a03b38
  3. 10 Dec, 2017 6 commits
  4. 09 Dec, 2017 3 commits
    • Jehan's avatar
      plug-ins: fix a bunch of coding style. · bf13c13e
      Jehan authored
      The screenshot-win32.c file was absolutely not following our coding
      style. A lot of things are still wrong (like camelCase functions), but
      at least I fixed a bunch of indentations, space between function and
      arguments, alignments, curly brackets at start of lines, etc.
      bf13c13e
    • Jehan's avatar
      Bug 791352 - Screenshot delay is broken for region shots in GNOME. · 614bcf6d
      Jehan authored
      Delay should indeed happen before root and window screenshots, but must
      happen in-between region selection and region screenshot.
      
      One can notice that the logics is different for Windows screenshot in
      X11. The reason is that X11 window screenshot has an additional window
      selection step (and therefore delay must happen in between selection and
      actual screenshot). Window screenshot in Wayland doesn't have this step
      and simply screenshots whatever is the currently active Window.
      614bcf6d
    • Jehan's avatar
      Bug 791352 - Screenshot delay is broken for region-grab screenshot. · d9cd4b61
      Jehan authored
      Fix first the delay in X11.
      Actually both for region and window screenshots, it makes no sense to
      delay *before* region or window selection. Usually when one uses a
      delay, the point is to prepare in-between selection and shot. For
      instance, I often used a delay to snap the contents of a menu because
      PrintScreen key would not work when a menu is opened. So I would set a
      delay, select my window/region, then quickly open the menu before the
      delay is counting down. This would not be possible with the way delay
      occurred (before selection), which just has no use that I can see of.
      d9cd4b61
  5. 08 Dec, 2017 2 commits
  6. 21 Aug, 2017 1 commit
    • Michael Natterer's avatar
      Move the new "default_new_layer_mode" APIs to the image... · e16c8a23
      Michael Natterer authored
      ...in both the core and libgimp.
      
      Images now know what the default mode for new layers is:
      
      - NORMAL for empty images
      - NORMAL for images with any non-legacy layer
      - NORMAL_LEGAVY for images with only legacy layers
      
      This changes behavior when layers are created from the UI, but *also*
      when created by plug-ins (yes there is a compat issue here):
      
      - Most (all?) single-layer file importers now create NORMAL layers
      - Screenshot, Webpage etc also create NORMAL layers
      
      Scripts that create images from scratch (logos etc) should not be
      affected because they usually have NORMAL_LEGACY hardcoded.
      
      3rd party plug-ins and scripts will also behave old-style unless they
      get ported to gimp_image_get_default_new_layer_mode().
      e16c8a23
  7. 20 Aug, 2017 1 commit
  8. 18 Jul, 2017 1 commit
    • Jehan's avatar
      Bug 784890 - Being able to take a screenshot of a single window and... · 24c2bdf6
      Jehan authored
      ... include mouse pointer.
      This is working find and tested under GNOME which already had the code
      for it (was only missing the GUI). I added the feature in OSX and X11,
      though it is untested. Windows does not seem to have the capability (at
      least according to screenshot_win32_get_capabilities() in our code).
      24c2bdf6
  9. 30 May, 2017 1 commit
  10. 21 Mar, 2017 1 commit
  11. 26 Feb, 2017 1 commit
  12. 12 Feb, 2017 1 commit
  13. 01 Feb, 2017 1 commit
    • Jehan's avatar
      plug-ins: make screenshot-win32 compile again. · f43092cb
      Jehan authored
      Commit e518b975 broke Win32 compilation with a non-defined variable
      "monitor". I made a dirty "fix" by using shootvals->monitor.
      Apparently, seeing previous comment, that is probably not the right
      value but Mitch is on it and I leave him work it out.
      At least now it builds.
      f43092cb
  14. 31 Jan, 2017 1 commit
    • Michael Natterer's avatar
      Bug 723498 - Gimp changes contrast and color of images · e518b975
      Michael Natterer authored
      Add color management options to the screenshot plug-in:
      
      By default, it tries to tag the image with the monitor profile;
      alternatively, there is an option to convert the image to sRGB.
      
      This works mostly fine on *one* monitor given its profile is
      configured correctly. With more than one monitor, funny things happen
      depending on the platform and on what we are shooting (window, screen,
      area). There are some FIXMEs left in the code.
      e518b975
  15. 08 Jan, 2017 1 commit
  16. 25 Jun, 2016 1 commit
    • Richard Kreckel's avatar
      Bug 768044 - Fix many typos · dd9b0fc5
      Richard Kreckel authored
      This fixes many typos in comments and one in a user-visible string (msgid
      "center abscisse" changed to "center abscissa" in affected po files. too).
      dd9b0fc5
  17. 31 May, 2016 1 commit
  18. 30 May, 2016 1 commit
  19. 28 May, 2016 1 commit
  20. 20 May, 2016 1 commit
  21. 01 May, 2016 3 commits
  22. 02 Apr, 2016 3 commits
  23. 01 Apr, 2016 2 commits
  24. 31 Mar, 2016 2 commits
  25. 30 Mar, 2016 1 commit