1. 17 Sep, 2018 1 commit
    • Jehan's avatar
      icons: fix icons! · ef8042e8
      Jehan authored
      Ok looks like I missed some changes when I updated these icon Makefiles.
      Anyway I still have a lot to straighten up within icons. :-/
      ef8042e8
  2. 02 Sep, 2018 1 commit
    • Ell's avatar
      app, icons, menus: add performance-log recording to the dashboard · 36477bb2
      Ell authored
      Add an option to record a performance log through the dashboard.
      The log contains a series of samples of the dashboard variables, as
      well as the full program backtrace, when available.  As such, it
      essentially acts as a built-in profiler, which allows us to
      correlate program execution with the information available through
      the dashboard.  It is meant to be used for creating logs to
      accompany perofrmance-related bug reports, as well as for profiling
      GIMP during development.
      
      The sample frequency defaults to 10 samples per second, but can be
      overridden using the GIMP_PERFORMANCE_LOG_SAMPLE_FREQUENCY
      environment variable.  Backtraces are included by default when
      available, but can be suppressed using the
      GIMP_PERFORMANCE_LOG_NO_BACKTRACE environment variable.
      
      Logs are created through the new "record" button at the bottom of
      the dashboard dialog.  When pressed, a file dialog is opened to
      select the log file, and, once confirmed, data is being recorded to
      the selected file.  Recording is stopped by pressing the "record"
      button again (we use a highlight to indicate that recording is
      active.)
      
      While recording, the "reset" button is replaced with an "add marker"
      button, which can be used to add event markers to the log.  These
      can be used to mark events of interest, such as "started painting"
      and "stopped painting", which then appear in the log as part of the
      sample stream.  Markers are numbered sequentually, and the number
      of the next (to-be-added) marker appears on the button.  Shift-
      clicking the button adds an empty (description-less) marker, which
      is only identified by its number; this can be used when markers
      need to be added quickly.
      
      The log is an XML file, containing some extra information (such as
      the output of "$ gimp -v", and symbol information) in addition to
      the samples.  The data in the file is delta-encoded to reduce the
      file size, meaning that samples (as well as some other elements)
      only specify the changes since the previous sample.  This adds a
      necessary decoding step before data can be processed; the next
      commit adds a tool that does that.
      
      There are currently no tools to actually analyze the data -- that's
      still TBD -- but at least we can start gathering it.
      36477bb2
  3. 18 Aug, 2018 2 commits
    • Jehan's avatar
      icons: fix build with vector icons (default). · 0b73a1bc
      Jehan authored
      That's the problem of having alternative build options! My previous
      commits were made when testing the build with PNG icons.
      Anyway I am planning to soon merge the 2 options.
      0b73a1bc
    • Jehan's avatar
      icons: generate PNG symbolic icons with `gtk-encode-symbolic-svg`. · babf74a3
      Jehan authored
      We don't need to commit PNG symbolic icons as `gtk-encode-symbolic-svg`
      is perfectly able to generate them from the SVG.
      Moreover its man says that it makes "specially prepared png files",
      whatever that means. So I don't think we should just rename our
      self-exported PNG files as '*-symbolic.symbolic.png'. It is better to
      generate them with this tool.
      
      Note that I am now splitting icon-list.mk into 2 files. This is only a
      temporary stepback, as I am actually going to merge the 2 icon themes
      into one very soon, and hopefully we should be able to generate the list
      to ensure we don't miss an icon.
      Anyway the icon lists had already diverged earlier, even though it was
      only all still in a single file.
      babf74a3
  4. 30 Jul, 2018 2 commits
    • Jehan's avatar
      icons: update icons for new top-to-bottom text feature. · e326faa7
      Jehan authored
      They are not perfect (not a designer here!) but a bit less packed than
      the previous one. So hopefully more understandable.
      e326faa7
    • ONO Yoshio's avatar
      MR !19: Add support for vertical text writing. · 587d9bbb
      ONO Yoshio authored
      Squashed commit of the following:
      
      commit ee1ff7d502658cfa1248a13a3f0348495db07eda
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sun Jul 29 00:31:47 2018 +0900
      
          Fixed that gimp-text-dir-ttb-* icons are lacked in Symbolic.
      
      commit d87d012d697628da28fe90199cc04b95b72ba8ef
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 16:23:10 2018 +0900
      
          Fix a typo.
      
      commit cf0238bf7df56c384cdf3b7ec69557d14740f853
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 15:50:57 2018 +0900
      
          Fixed seg fault error.
      
      commit b07f60d0
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Fri Jul 27 17:15:34 2018 +0900
      
          Add support for vertical text writing.
      
          #641
      587d9bbb
  5. 28 Jul, 2018 1 commit
  6. 21 Jul, 2018 2 commits
  7. 20 Jul, 2018 1 commit
  8. 07 Jul, 2018 2 commits
    • Jehan's avatar
      icons: toilet paper should always be white! · a4c1d73b
      Jehan authored
      I know that the idea of black toilet paper is traumatizing nomis! ;-)
      So here it is, using the CSS "!important" trick to override GTK+ CSS
      recoloring code.
      In order for the icon to be always visible, even on light background, I
      am adding a path around the toilet paper shape (which this time will
      be properly recolored by GTK+ with the foreground color, hence making
      the icon clearly visible).
      a4c1d73b
    • Jehan's avatar
      icons: fix symbolic icon gtk-select-color. · 56717f80
      Jehan authored
      There was again a visible square.
      56717f80
  9. 23 Jun, 2018 3 commits
    • Jehan's avatar
      icons: update various icons to account for librsvg bugs. · 4c68d5df
      Jehan authored
      It should now be possible to fully export our symbolic icons from a
      single central file.
      My long-standing bug of librsvg#250 is still opened and unfixed, but it
      turns out most issues I encountered are anyway also problems when
      recoloring symbolic icons in GTK+ (like using strokes instead of
      fills!). So let's just bypass all problems at once by accounting for
      these issues in the design.
      4c68d5df
    • Jehan's avatar
      icons: fix many icons for proper recoloring. · 8811b0d9
      Jehan authored
      I tried to fix all the icons I could see which had issues regarding all
      recoloring matters (using fill not stroke, change circle/ellipses to
      paths, etc.) when looking at a blank canvas.
      I'm sure I still miss a lot but that will do for now.
      8811b0d9
    • Jehan's avatar
      icons: force colors on some icons. · 5d5bbeb8
      Jehan authored
      Sometimes even within symbolic icons, parts of the design must keep
      fixed colors, when they are semantic. For instance this is the case for
      the color-picker-(black|gray|white) icons or the gimp-default-colors.
      
      The trick used by GTK+ to recolor is by supplying an additional CSS
      style to icons which overrides inline CSS thanks to "! important"
      keyword. Our own trick to circumvent this trick is to set "!important"
      in inline CSS when one wishes not to have it overrided by the general
      colors.
      Right now I am doing the edit by hand with vim because Inkscape doesn't
      seem to validate this keyword if I add it manually in its XML editor. So
      what I did is add the "color-important" label on such object, and I will
      later modify my SVG export tool to add !important on such object "fill"
      values at export time.
      5d5bbeb8
  10. 22 Jun, 2018 1 commit
    • Jehan's avatar
      icons: fix various symbolic icons not properly recolored. · fd460182
      Jehan authored
      The current recolorization code only recolors paths and rectangles. In
      particular it leaves circles and ellipses as-is.
      I opened the merge request gtk!214 for this issue. But in the meantime,
      it is quite easy to change circles and ellipses into path with "object
      to path" in Inkscape.
      
      A second problem is that it only recolors fills, not strokes, as
      previously stated. So I need to remove strokes from icons, or transform
      them to paths.
      fd460182
  11. 19 Jun, 2018 4 commits
    • Jehan's avatar
      icons: larger spacing between broken chains. · a5afb045
      Jehan authored
      It seems not wide enough to differentiate easily the broken and
      non-broken chains. So let's make this gap bigger.
      a5afb045
    • Jehan's avatar
      icons: fixing more icons. · 2bb8afd1
      Jehan authored
      This time, 2 icons still had problems because of visible rectangles.
      Fixing "gimp-prefs-folders" and "gimp-prefs-folders-mypaint-brushes".
      2bb8afd1
    • Jehan's avatar
      icons: fix various icons broken when recoloring with CSS. · 4b6869dd
      Jehan authored
      For anyone wishing to help me fix icons, here is the trick: apparently
      GTK+ would fill the paths with CSS colors, not stroke them. So when we
      have icon drawing based on path-stroking, they don't end up as expected.
      In Inkscape, just run "Stroke to Path" to transform a stroke design in a
      fill design.
      I am fixing "gimp-tool-cage", "document-revert", "gimp-image-reload",
      "gimp-reset" and "view-refresh". More to follow as we discover them, I
      guess.
      4b6869dd
    • Jehan's avatar
      icons: make gimp-tool-ellipse-select symmetric. · 45f46db8
      Jehan authored
      I may not be an icon designer, but this icon be so clearly asymmetric
      always deeply annoyed me.
      45f46db8
  12. 14 Jun, 2018 1 commit
  13. 13 Jun, 2018 1 commit
  14. 30 May, 2018 6 commits
  15. 15 Apr, 2018 1 commit
  16. 13 Apr, 2018 1 commit
  17. 23 Feb, 2018 1 commit
    • Aryeom's avatar
      icons: new symbolic icons gimp-attach and gimp-detach. · a542bb1e
      Aryeom authored
      These are simple on purpose since the smaller size they are displayed at
      is 12 px (in overlay dialogs) so it needs to be simple shapes.
      
      Note by Jehan: gimpicons.h and Makefile.am not updated yet. Waiting for
      the color icons first.
      a542bb1e
  18. 05 Jan, 2018 2 commits
  19. 28 Dec, 2017 1 commit
  20. 27 Dec, 2017 3 commits
  21. 19 Dec, 2017 1 commit
    • Ell's avatar
      app, menus, icons: add dashboard dockable · 981e8dcd
      Ell authored
      The dashboard dockable shows the current GEGL cache and swap sizes,
      and their recent history.  It has options to control the update
      rate and history duration of the data, and an option to warn (by
      raising/blinking the dialog) when the swap size approaches its
      limit.
      981e8dcd
  22. 23 Nov, 2017 1 commit
  23. 11 Sep, 2017 1 commit
    • Jehan's avatar
      icons: start completing the main Symbolic icons SVG file. · 677e5c23
      Jehan authored
      It's not finished yet, but I have already added all the individual
      Freedesktop and GTK+ icons. The goal will be to have all the Symbolic
      icons in this one file so that in the future we can just extract
      individual SVG files from object IDs.
      This was the original plan but librsvg was just too buggy and would not
      extract the proper viewbox for some icons. Fortunately it seems that the
      bug reports I made are finally starting to be taken into account so I am
      hoping for a usable librsvg soon and starts the work which should have
      been done from the start.
      677e5c23