1. 08 Nov, 2001 1 commit
    • Michael Natterer's avatar
      build display/ before tools/. · 02fde14c
      Michael Natterer authored
      2001-11-08  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am: build display/ before tools/.
      
      	* app/devices.c: devices_check_change(): added all events
      	which have a GdkDevice pointer.
      
      	* app/gimpprogress.c: include "display-types.h" instead of
      	"core-types.h".
      
      	* app/core/Makefile.am
      	* app/core/gimpdrawable-bucket-fill.[ch]: new files: the bucket_fill
      	stuff taken from tools/gimpbucketfilltool.[ch].
      
      	* app/core/core-types.h: added "BucketFillMode".
      
      	* app/core/gimpimage-mask-select.[ch]: cleanup.
      
      	* app/core/gimpmarshal.list: added more marshallers for GimpTool's
      	new signal signatures.
      
      	* app/core/gimpmarshal.[ch]: regenerated.
      
      	* app/display/Makefile.am
      	* app/display/gimpdisplayshell-dnd.[ch]
      	* app/display/gimpdisplayshell-layer-select.[ch]: new files: the
      	canvas drop callbacks from gimpdisplayshell-callbacks.[ch] and
      	the stuff formerly knows as gui/layer-select.[ch].
      
      	* app/display/gimpdisplay.h: don't include "gui/gui-types.h".
      
      	* app/display/gximage.c: include "display-types.h".
      
      	* app/display/gimpdisplay-foreach.c
      	* app/display/gimpdisplayshell.[ch]: call gdsplay_delete(), don't
      	destroy the shell widget.
      
      	* app/gui/Makefile.am
      	* app/gui/layer-select.[ch]: removed.
      
      	* app/gui/gradients-commands.c: fixed "Save as POV" fprintf()s.
      
      	* app/gui/preferences-dialog.c: removed the layer_select stuff
      	because it is useless with the new preview system.
      
      	* app/gui/tool-options-dialog.c: send the correct data to the
      	close_callback.
      
      	* app/gui/tools-commands.c: changed to follow the new
      	gimp_tool_initialize() semantics (see below).
      
      	Tool & canvas event handling chainsawing:
      
      	* app/tools/tools-types.h: new struct GimpCoords which contains
      	x, y, pressure, tilt etc.
      
      	* app/display/gimpdisplayshell-callbacks.[ch]: added utility
      	functions which transparently retreive the current event's
      	GimpCoords or take it from the device directly if the event has
      	none. Pass GimpCoords _in_image_coordinates_ to all tool
      	functions.
      
      	Most important: don't pass GdkEvents and display coordinates to
      	tools any more.
      
      	* app/tools/gimptool.[ch]: changed virtual functions to take
      	GimpCoords, time and state separately instead of GdkEvents.
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbucketfilltool.[ch]
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpconvolvetool.c
      	* app/tools/gimpcroptool.[ch]
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimpdrawtool.c
      	* app/tools/gimpeditselectiontool.[ch]
      	* app/tools/gimperasertool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpfreeselecttool.[ch]
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimppathtool.[ch]
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpselectiontool.[ch]
      	* app/tools/gimpsmudgetool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.[ch]
      	* app/tools/path_tool.[ch]
      	* app/tools/selection_options.c: tons and tons of changes:
      
      	- changed to use the new virtual function parameters.
      	- removed zillions of gdisplay_untransform_coords().
      	- get the active drawable's offsets manually in many cases.
      	  (questionable, but IMHO ok because it's obvious and not simply a
      	  "TRUE" passed to some function)
      	- reordered some functions to be consistent across tools.
      	- some tools had to be changed to work on image coords, not
      	  display ones (esp. crop).
      	- fixed strange rotate tool behaviour which should be backported
      	  to stable.
      	- some stuff i came across.
      	- indentation and other paranoia.
      	- rounding of coordinated may be broken in some tools.
      	- new bugs guaranteed.
      
      	* app/tools/tool_manager.[ch]: new semantic of
      	tool_manager_initialize_active() (looked at the places where it
      	was used from and put common code together). Should be a bit
      	better now :)
      
      	* app/tools/gimpblendtool.c
      	* app/tools/transform_options.c: use the new GTK+ feature that a
      	widget (toggle button) can be a frame's title for this tools' tool
      	options.
      
      	* app/widgets/widgets-types.h: stuff.
      
      	* themes/Default/gtkrc: s/GtkDialog/GimpDialog/.
      
      	* tools/pdbgen/Makefile.am: don't scan tools/gimpbucketfilltool.h
      	any more.
      
      	* tools/pdbgen/enums.pl: regenerated.
      
      	* tools/pdbgen/pdb/tools.pdb: changed bucket_fill wrapper.
      
      	* app/pdb/tools_cmds.c: regenerated.
      02fde14c
  2. 22 Oct, 2001 1 commit
    • Michael Natterer's avatar
      General cleanup of the selection tools and their PDB wrappers: · 99e78c70
      Michael Natterer authored
      2001-10-22  Michael Natterer  <mitch@gimp.org>
      
      	General cleanup of the selection tools and their PDB wrappers:
      
      	* app/core/Makefile.am
      	* app/core/gimpimage-contiguous-region.[ch]
      	* app/core/gimpimage-mask-select.[ch]: new files providing a clean,
      	uniform API for the selection functionalities. Changed order of
      	parameters to be consistent, removed code duplication.
      
      	The region returned by the "by_color" function is not really
      	contiguous but the API is so similar to "by_seed" and it's used
      	in the same context so it's fair enough to put them together.
      
      	Also, I'm not sure if the two is_pixel_sufficiently_different()
      	I've optimized away were meant to do *exactly* the same. Added
      	a comment there to remember the former difference.
      
      	* app/core/gimpchannel.[ch] (gimp_channel_feather): removed the
      	"output" channel parameter and made it optionally push an undo
      	(like the other channel operations do).
      
      	* app/core/gimpimage-mask.c: call gimp_channel_feather() with
      	"push_undo == TRUE", removed some useless comments.
      
      	* app/tools/gimpbycolorselecttool.[ch]
      	* app/tools/gimpellipseselecttool.[ch]
      	* app/tools/gimpfreeselecttool.[ch]
      	* app/tools/gimpfuzzyselecttool.[ch]
      	* app/tools/gimprectselecttool.[ch]: removed all the actual
      	selection functionality and call the new gimp_image_mask_select_*()
      	and gimp_image_contiguous_region_*() functions instead.
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpiscissorstool.c: use new function
      	gimp_image_mask_select_channel() instead of doing the same manually.
      
      	* app/tools/gimpbucketfilltool.c: find_contiguous_region() ->
      	gimp_image_contiguous_region_by_seed().
      
      	* tools/pdbgen/Makefile.am
      	* tools/pdbgen/groups.pl
      	* tools/pdbgen/pdb/selection_tools.pdb: added new group "Selection
      	Tools" which depends only on "core/" stuff (not on "tools/" any
      	more, brrrr).
      
      	* tools/pdbgen/pdb/text_tool.pdb: don't include "appenv.h"
      
      	* tools/pdbgen/pdb/tools.pdb: removed the selection tools.
      
      	* app/pdb/Makefile.am
      	* app/pdb/selection_tools_cmds.c: new file.
      
      	* app/pdb/internal_procs.c
      	* app/pdb/text_tool_cmds.c
      	* app/pdb/tools_cmds.c: regenerated.
      
      	* libgimp/Makefile.am
      	* libgimp/gimp_pdb.h
      	* libgimp/gimpselectiontools_pdb.[ch]: new files.
      
      	* libgimp/gimptools_pdb.[ch]: regenerated
      
      	Misc cleanups:
      
      	* app/app_procs.c: call splash_create() with "no_splash_image"
      	as parameter.
      
      	* app/display/gimpdisplay-render.c
      	* app/display/gximage.c: don't include "appenv.h".
      
      	* app/gui/gui.c: call session_restore() only if "restore_session"
      	is TRUE.
      
      	* app/gui/session.c: don't "if(restore_session)" here and don't
      	include "appenv.h"
      
      	* app/gui/splash.[ch]: added "gboolean show_image" parameter to
      	splash_create(), don't include "appenv.h"
      
      	* app/tools/gimppainttool.[ch]: added a "GimpGradient" parameter
      	to gimp_paint_tool_get_color_from_gradient().
      
      	* app/tools/gimppaintbrushtool.c: pass the gradient.
      
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/tool_manager.c: s/GDisplay/GimpDisplay/.
      
      	* app/widgets/gimpcontainergridview.[ch]: removed the "white_style"
      	class variable and don't fiddle around with colors and styles...
      
      	* themes/Default/gtkrc: ...do the same here with a simple rc style.
      99e78c70