1. 03 Dec, 2001 1 commit
    • Sven Neumann's avatar
      Michael Natterer <mitch@gimp.org> · 4ba6db4e
      Sven Neumann authored
      2001-12-03  Sven Neumann  <sven@gimp.org>
      	    Michael Natterer <mitch@gimp.org>
      
      	* app/paint-funcs/paint-funcs-mmx.h: removed redefiniton of HAS_ALPHA
      	macro.
      
      	* app/core/gimp.c: reverted Daniel's change; it doesn't make the code
      	simpler, only more error-prone.
      
      	* app/gui/info-dialog.h
      	* app/gui/resize-dialog.h
      	* app/core/gimp.h
      	* app/core/gimpbrushgenerated.h
      	* app/core/gimpbrushpipe.h
      	* app/core/gimpchannel.[ch]
      	* app/core/gimpcontainer.h
      	* app/core/gimpcoreconfig.h
      	* app/core/gimpdata.h
      	* app/core/gimpdatafactory.[ch]
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable.[ch]
      	* app/core/gimpimage.h
      	* app/core/gimpimagefile.h
      	* app/core/gimplayer.h
      	* app/core/gimplayermask.h
      	* app/core/gimpmoduleinfo.h
      	* app/core/gimppalette.h
      	* app/core/gimpundo.h
      	* app/widgets/gimpbrushfactoryview.h
      	* app/widgets/gimpconstrainedhwrapbox.h
      	* app/widgets/gimpcontainermenu.h
      	* app/widgets/gimpcontainerview.h
      	* app/widgets/gimpdialogfactory.h
      	* app/widgets/gimpimagedock.h
      	* app/widgets/gimplistitem.h
      	* app/widgets/gimpmenuitem.h
      	* app/widgets/gimpnavigationpreview.h
      	* app/widgets/gimppreview.h
      	* app/gimprc.h
      	* app/pathP.h
      	* app/tools/gimpbezierselecttool.h
      	* app/tools/gimpcolorbalancetool.h
      	* app/tools/gimpcurvestool.h
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimpfreeselecttool.h
      	* app/tools/gimphuesaturationtool.h
      	* app/tools/gimpinktool-blob.h
      	* app/tools/gimpinktool.h
      	* app/tools/gimpiscissorstool.h
      	* app/tools/gimpmagnifytool.h
      	* app/tools/gimpmeasuretool.h
      	* app/tools/gimppainttool.h
      	* app/tools/gimppathtool.h
      	* app/tools/gimprectselecttool.h
      	* app/tools/gimpthresholdtool.h
      	* app/tools/gimptool.h
      	* app/tools/gimptransformtool.h
      	* app/base/base-config.h
      	* app/base/gimplut.[ch]
      	* app/base/pixel-region.h
      	* app/base/pixel-surround.[ch]
      	* app/base/temp-buf.[ch]
      	* app/base/tile-manager-private.h
      	* app/base/tile-manager.[ch]
      	* app/base/tile-private.h
      	* app/base/tile.[ch]
      	* app/display/gimpdisplay.h
      	* app/display/gimpdisplayshell-selection.h
      	* app/display/gimpdisplayshell.h
      	* app/gui/brush-select.h
      	* app/gui/gradient-editor.h
      	* app/gui/gradient-select.h: reverted most of Daniel's changes.
      
      	There's no reason to use unsigned integers here and in lots of places
      	it is even wrong.
      
      	Then it's way too early to convert gbooleans into bitfields. This
      	change may make sense in a few places but can happen later when the
      	API has settled and the code is more stable.
      
      	* app/gimprc.c: reverted Daniel's change. This is a GCC-ism and this
      	code is about to die soon anyway.
      4ba6db4e
  2. 02 Dec, 2001 1 commit
    • Daniel Egger's avatar
      Convert ugly comments into named structure fields. Much cleaner and less · 1ed91801
      Daniel Egger authored
      2001-12-02  Daniel Egger  <degger@fhm.edu>
      
      	* app/gimprc.c: Convert ugly comments into named structure fields.
      	Much cleaner and less errorprone though may cause troubles on
      	older compilers and then needs to be reverted. Please report!
      
      	* app/base/base-types.h: Add FIXME reminder.
      
      	* app/base/gimplut.c: Use CLAMP macro instead of if-cascade.
      
      	* app/base/temp-buf.c: Remove duplicated calculations and simplify
      	checks.
      
      	* app/base/tile-manager.c:
      	- (tile_manager_get_tile_num): Return success and take an additional
      	  pointer for the tilenumber.
      	- Simplify logic in the rest of the file as a result.
      	- Remove rotten debugging cruft.
      
      	* app/core/gimpbrushgenerated.c: Fix two stylistic nits.
      
      	* app/app_procs.c: Include <stdlib.h> for exit () prototype.
      
      	* app/core/gimpdrawable-blend.c: Include <stdlib.h> for abs ()
      	prototype.
      
      	* app/display/gimpdisplay.c: Include <string.h> for memcpy ()
      	prototype.
      
      	* app/core/gimpimage-convert.c: (HIST_RGB): First parameter is
      	not const. Fixes a gcc warning for a wrong return value.
      
      	* libgimpwidgets/gimpunitmenu.c
      	* app/core/gimpunit.c: Add suggested (by gcc 3.1 cvs) parentheses
      	to group correct logic tests together.
      
      	* app/paint-funcs/paint-funcs-generic.h: Fix my HAS_ALPHA macro
      	to avoid gcc 3.1 cvs warning.
      
      	* app/gimprc.h
      	* pathP.h
      	* base-config.h
      	* app/base/boundary.h
      	* app/base/gimplut.[ch]
      	* app/base/pixel-region.h
      	* app/base/pixel-surround.[ch]
      	* app/base/temp-buf.[ch]
      	* app/base/tile-manager-private.h
      	* app/base/tile-manager.c
      	* app/base/tile-private.h
      	* app/base/tile.[ch]
      	* app/core/gimp.h
      	* app/core/gimpbrushgenerated.h
      	* app/core/gimpbrushpipe.h
      	* app/core/gimpchannel.[ch]
      	* app/core/gimpcontainer.h
      	* app/core/gimpcoreconfig.h
      	* app/core/gimpdata.h
      	* app/core/gimpdatafactory.[ch]
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable.[ch]
      	* app/core/gimpimage.h
      	* app/core/gimpimagefile.h
      	* app/core/gimplayer.h
      	* app/core/gimplayermask.h
      	* app/core/gimpmoduleinfo.h
      	* app/core/gimppalette.h
      	* app/core/gimpundo.h
      	* app/display/gimpdisplay.h
      	* app/display/gimpdisplayshell-selection.h
      	* app/display/gimpdisplayshell.h
      	* app/gui/brush-select.h
      	* app/gui/gradient-editor.h
      	* app/gui/gradient-select.h
      	* app/gui/info-dialog.h
      	* app/gui/resize-dialog.h
      	* app/tools/gimpbezierselecttool.h
      	* app/tools/gimpcolorbalancetool.h
      	* app/tools/gimpcolorpickertool.h
      	* app/tools/gimpcurvestool.h
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimpfreeselecttool.h
      	* app/tools/gimpfuzzyselecttool.h
      	* app/tools/gimphuesaturationtool.h
      	* app/tools/gimpinktool-blob.h
      	* app/tools/gimpinktool.h
      	* app/tools/gimpiscissorstool.h
      	* app/tools/gimpmagnifytool.h
      	* app/tools/gimpmeasuretool.h
      	* app/tools/gimppainttool.h
      	* app/tools/gimppathtool.h
      	* app/tools/gimprectselecttool.h
      	* app/tools/gimpthresholdtool.h
      	* app/tools/gimptool.h
      	* app/tools/gimptransformtool.h
      	* app/tools/path_toolP.h
      	* app/widgets/gimpbrushfactoryview.h
      	* app/widgets/gimpconstrainedhwrapbox.h
      	* app/widgets/gimpcontainermenu.h
      	* app/widgets/gimpcontainerview.h
      	* app/widgets/gimpdialogfactory.h
      	* app/widgets/gimpimagedock.h
      	* app/widgets/gimplistitem.h
      	* app/widgets/gimpmenuitem.h
      	* app/widgets/gimpnavigationpreview.h
      	* app/widgets/gimppreview.h: Unsignify lots of variables and
      	parameters and use bitfields in structs where possible. First
      	part of a huge cleanup all over the code...
      1ed91801
  3. 11 Jul, 2001 1 commit
    • Michael Natterer's avatar
      app/Makefile.am app/gimpunit.c removed... · 16671498
      Michael Natterer authored
      2001-07-11  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/gimpunit.c
      	* app/unitrc.h: removed...
      
      	* app/core/Makefile.am
      	* app/core/gimpunit.[ch]: ...re-added here.
      
      	* app/core/gimp.[ch]: added the image and drawable hash tables,
      	next_image_ID, next_guide_ID and next_drawable_ID, added a
      	GimpCoreConfig pointer which is now initalized dynamically.
      
      	* app/core/gimpcoreconfig.[ch]: don't provide a global core_config
      	variable any more (need to access gimp->config now).
      
      	* app/gdisplay.[ch]
      	* app/core/gimpdrawable.[ch]
      	* app/core/gimpimage.[ch]: removed all global variables from
      	gimpimage.c and gimpdrawable.c, pass a Gimp* to all *_get_by_ID()
      	functions.
      
      	* tools/pdbgen/app.pl: pass Gimp* to all _get_by_ID() functions.
      
      	* app/app_procs.c
      	* app/file-open.c
      	* app/file-save.c
      	* app/gimprc.c
      	* app/libgimp_glue.c
      	* app/module_db.c
      	* app/plug_in.c
      	* app/undo.c
      	* app/user_install.c
      	* app/core/core-types.h
      	* app/core/gimpcontext.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-new.c
      	* app/core/gimpparasite.c
      	* app/gui/file-new-dialog.c
      	* app/gui/file-open-dialog.c
      	* app/gui/info-window.c
      	* app/gui/preferences-dialog.c
      	* app/gui/resize-dialog.c
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c
      	* app/xcf/xcf.c
      	* app/widgets/gimpdnd.c
      
      	* app/pdb/channel_cmds.c
      	* app/pdb/color_cmds.c
      	* app/pdb/convert_cmds.c
      	* app/pdb/display_cmds.c
      	* app/pdb/drawable_cmds.c
      	* app/pdb/edit_cmds.c
      	* app/pdb/fileops_cmds.c
      	* app/pdb/floating_sel_cmds.c
      	* app/pdb/guides_cmds.c
      	* app/pdb/image_cmds.c
      	* app/pdb/layer_cmds.c
      	* app/pdb/parasite_cmds.c
      	* app/pdb/paths_cmds.c
      	* app/pdb/selection_cmds.c
      	* app/pdb/text_tool_cmds.c
      	* app/pdb/tools_cmds.c
      	* app/pdb/undo_cmds.c
      	* app/pdb/unit_cmds.c
      
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/unit.pdb: changed accordingly.
      16671498
  4. 07 Jul, 2001 1 commit
    • Michael Natterer's avatar
      app/Makefile.am removed. · 1bcd3e18
      Michael Natterer authored
      2001-07-07  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/context_manager.[ch]: removed.
      
      	* app/app_procs.c: call tool_mananger instead of context_manager
      	functions, pass "the_gimp" to some more functions.
      
      	* app/drawable.[ch]: pass a GimpContext to drawable_fill().
      
      	* app/errors.c: behave according to "stack_trace_mode" when using
      	the debugging signal handler.
      
      	* app/gimprc.[ch]: removed the core/ config variables.
      
      	* app/selection.c: set the selection's state to INVISIBLE in
      	selection_pause().
      
      	* app/core/Makefile.am
      	* app/core/gimpcoreconfig.[ch]: new files (the configuration
      	variables used by core/).
      
      	* app/core/gimpcontext.[ch]: removed the global contexts (user,
      	default, ...) and their functions. It's no longer possible to pass
      	NULL to the context functions to manipulate the current context
      	(gimpcontext.c doesn't know the current context any more).
      
      	* app/core/gimp.[ch]: added them here. The functions are now called
      	gimp_[set|get]_*_context(). Added gimp_create_context() which is
      	the only function to create contexts now.
      
      	* app/gui/dialogs.[ch]
      	* app/gui/gui.[ch]: pass "gimp" to all functions.
      
      	* app/tools/tool_manager.[ch]
      	* app/tools/tools.[ch]: pass "gimp" to lots of functions. Added
      	the "global_tool_context" logic and the global/non-global paint
      	options switching from the context_manager. Pass "gimp" to all
      	tools' "register" functions.
      
      	* app/tools/*: changed accordingly.
      
      	* app/devices.c
      	* app/disp_callbacks.c
      	* app/file-open.[ch]
      	* app/file-save.c
      	* app/gdisplay.c
      	* app/gimage.c
      	* app/libgimp_glue.c
      	* app/module_db.c
      	* app/nav_window.c
      	* app/plug_in.c
      	* app/qmask.c
      	* app/undo.c
      	* app/base/base-config.c
      	* app/core/gimpbrushpipe.c
      	* app/core/gimpdrawable-offset.c
      	* app/core/gimpgradient.c
      	* app/core/gimpimage-duplicate.c
      	* app/core/gimpimage-mask.c
      	* app/core/gimpimage-new.c
      	* app/core/gimpimage.c
      	* app/core/gimppalette.c
      	* app/core/gimptoolinfo.[ch]
      	* app/core/gimpundo.c
      	* app/gui/brush-select.c
      	* app/gui/channels-commands.c
      	* app/gui/color-area.c
      	* app/gui/dialogs-constructors.c
      	* app/gui/file-new-dialog.c
      	* app/gui/file-open-dialog.c
      	* app/gui/gradient-editor.c
      	* app/gui/gradient-select.c
      	* app/gui/info-window.c
      	* app/gui/layers-commands.c
      	* app/gui/menus.c
      	* app/gui/palette-editor.c
      	* app/gui/palette-import-dialog.c
      	* app/gui/palette-select.c
      	* app/gui/paths-dialog.c
      	* app/gui/pattern-select.c
      	* app/gui/preferences-dialog.c
      	* app/gui/resize-dialog.c
      	* app/gui/test-commands.c
      	* app/gui/tool-options-dialog.c
      	* app/gui/toolbox.c
      	* app/gui/tools-commands.c
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c
      	* app/widgets/gimpchannellistview.c
      	* app/widgets/gimpdnd.c
      	* app/widgets/gimpdrawablelistview.[ch]
      	* app/widgets/gimpimagedock.c
      	* app/widgets/gimplayerlistview.c
      	* app/pdb/brushes_cmds.c
      	* app/pdb/drawable_cmds.c
      	* app/pdb/gradient_select_cmds.c
      	* app/pdb/gradients_cmds.c
      	* app/pdb/palette_cmds.c
      	* app/pdb/patterns_cmds.c
      	* app/pdb/procedural_db.c
      	* tools/pdbgen/pdb/brushes.pdb
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/gradient_select.pdb
      	* tools/pdbgen/pdb/gradients.pdb
      	* tools/pdbgen/pdb/palette.pdb
      	* tools/pdbgen/pdb/patterns.pdb: changed accordingly: remove usage
      	of gimp_context_[get|set]_*(NULL), create contexts with
      	gimp_create_context(). Get the user/current context with
      	gimp_get_[user|current]_context(). Added/removed access to the
      	global "the_gimp" variable in some places. Get the core's config
      	variables from "core_config".
      1bcd3e18