1. 02 Sep, 2018 1 commit
    • Ell's avatar
      app, icons, menus: add performance-log recording to the dashboard · 36477bb2
      Ell authored
      Add an option to record a performance log through the dashboard.
      The log contains a series of samples of the dashboard variables, as
      well as the full program backtrace, when available.  As such, it
      essentially acts as a built-in profiler, which allows us to
      correlate program execution with the information available through
      the dashboard.  It is meant to be used for creating logs to
      accompany perofrmance-related bug reports, as well as for profiling
      GIMP during development.
      The sample frequency defaults to 10 samples per second, but can be
      environment variable.  Backtraces are included by default when
      available, but can be suppressed using the
      GIMP_PERFORMANCE_LOG_NO_BACKTRACE environment variable.
      Logs are created through the new "record" button at the bottom of
      the dashboard dialog.  When pressed, a file dialog is opened to
      select the log file, and, once confirmed, data is being recorded to
      the selected file.  Recording is stopped by pressing the "record"
      button again (we use a highlight to indicate that recording is
      While recording, the "reset" button is replaced with an "add marker"
      button, which can be used to add event markers to the log.  These
      can be used to mark events of interest, such as "started painting"
      and "stopped painting", which then appear in the log as part of the
      sample stream.  Markers are numbered sequentually, and the number
      of the next (to-be-added) marker appears on the button.  Shift-
      clicking the button adds an empty (description-less) marker, which
      is only identified by its number; this can be used when markers
      need to be added quickly.
      The log is an XML file, containing some extra information (such as
      the output of "$ gimp -v", and symbol information) in addition to
      the samples.  The data in the file is delta-encoded to reduce the
      file size, meaning that samples (as well as some other elements)
      only specify the changes since the previous sample.  This adds a
      necessary decoding step before data can be processed; the next
      commit adds a tool that does that.
      There are currently no tools to actually analyze the data -- that's
      still TBD -- but at least we can start gathering it.
  2. 31 Aug, 2018 2 commits
  3. 26 Aug, 2018 1 commit
  4. 20 Aug, 2018 2 commits
    • Ell's avatar
      app: add gimp_gtk_container_clear() · fd64aae4
      Ell authored
      ... which removes all non-internal children of a GtkContainer.
    • Michael Natterer's avatar
      app: make GimpDeviceInfo more rubust against broken device listings · 717c183a
      Michael Natterer authored
      gimp_device_info_set_device(): don't just bail out if a device with
      the same name is added again, instead, simply continue and overwrite
      the info's old device with the new one.
      NOTE that this only happens if something is wrong on the USB or udev
      or libinput or whatever side and the same device is present multiple
      times. The only "safe" thing is to assume that devices listed earlier
      are dead and dangling entities and that the last registered device is
      the one actually delivering events.
  5. 19 Aug, 2018 4 commits
  6. 12 Aug, 2018 1 commit
    • Jehan's avatar
      configure: GLIB_COMPILE_RESOURCES is wrong when cross-compiling. · 8e453330
      Jehan authored
      AM_PATH_GLIB_2_0 m4 macro actually computes this value using
      $PKG_CONFIG. Yet $PKG_CONFIG variable is the pkg-config tool looking for
      target libraries (not host), hence it would return the executable
      `glib-compile-resources` built for the target.
      Also using the same variable name invalidates our test: our own
      AC_PATH_PROG was never run as the variable was already set. And no
      environment variable could override this test anymore either. This is
      why I rename the test variable to HOST_GLIB_COMPILE_RESOURCES.
      (cherry picked from commit d1d9eb17)
  7. 09 Aug, 2018 1 commit
  8. 07 Aug, 2018 1 commit
    • Jehan's avatar
      app: display extension long description in the details widget. · 549d8808
      Jehan authored
      AppStream spec says it can only contain <p>, <ol> and <ul> markups.
      Unfortunately these are not pango markups (nor is there any equivalent).
      So I just use newlines and spaces until I figure out anything fancier.
      That's all still quite ugly, but whatever, I'm still in the start.
  9. 06 Aug, 2018 2 commits
    • Jehan's avatar
      app: removing gimp_get_icon_size() now unused. · f6d1380f
      Jehan authored
      It was using deprecated functions regarding how icons used to work, such
      as gtk_icon_set_get_sizes() or gtk_style_context_lookup_icon_set().
      The last uses of this function disappeared in last commit.
    • Jehan's avatar
      libgimpwidgets, app: change "stock-size" property of... · d1372c6c
      Jehan authored
      ... GimpCellRendererToggle into "icon-size".
      In particular making it a pixel size instead of a GtkIconSize. This enum
      is limited to a few presets (registering new values is deprecated since
      GTK+ 3.10), with names completely semantically wrong. It is better to
      specify icon sizes (before scaling) in pixels directly, which goes also
      with named icons instead of stock ones.
  10. 05 Aug, 2018 2 commits
  11. 30 Jul, 2018 2 commits
    • ONO Yoshio's avatar
      MR !19: Add support for vertical text writing. · 587d9bbb
      ONO Yoshio authored
      Squashed commit of the following:
      commit ee1ff7d502658cfa1248a13a3f0348495db07eda
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sun Jul 29 00:31:47 2018 +0900
          Fixed that gimp-text-dir-ttb-* icons are lacked in Symbolic.
      commit d87d012d697628da28fe90199cc04b95b72ba8ef
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 16:23:10 2018 +0900
          Fix a typo.
      commit cf0238bf7df56c384cdf3b7ec69557d14740f853
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 15:50:57 2018 +0900
          Fixed seg fault error.
      commit b07f60d0
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Fri Jul 27 17:15:34 2018 +0900
          Add support for vertical text writing.
    • Michael Natterer's avatar
      Issue 1652 - Empty toolbox has very large minimum height in MWM · 46f52813
      Michael Natterer authored
      Adjust size negotiation of GimpToolPalette to take the monitor's
      workarea into account: request space for enough columns so that the
      widget's height is never more than 70% of the workarea height, and
      enough rows so that it's never wider than 90% of the workarea.
  12. 25 Jul, 2018 4 commits
    • Jehan's avatar
      app: show relevant files only by default. · 6b4b3bad
      Jehan authored
      Just like it was until now, the default filtering should not be all
      files, but only relevant files (i.e. XCF when saving, exportable images
      when exporting and loadable images/XCF when opening).
      Now all files will only be available through the "Show All Files"
      This is simpler than previous implementations where the list was
      proposing "All Files", "All Images" and "All XCF/export images". That is
      just too much.
      With this default, I get the "All Files" checkbox out of the expander so
      that it is visible immediately even when the format list is unexpanded
      (you don't want people to get pissed when not finding how to display all
      their files).
    • Jehan's avatar
      Issue #1160: file dialog view filter getting confused with file... · 63694458
      Jehan authored
      ... format selection.
      Second step: add a "Show All Files" checkbox so that one can still
      prevent view filtering even when forcing a load format.
      This is useful when loading files with unusual extensions, for instance.
    • Jehan's avatar
      app: force the extra widget to take as much place as possible. · 193a49a6
      Jehan authored
      I am separating this from previous commit since it cannot be backported
      to GTK+2.
    • Jehan's avatar
      Issue #1160: file dialog view filter getting confused with file... · 9ae7827f
      Jehan authored
      ... format selection.
      As discussed, the first step is to get rid of the filter list. Our extra
      widget now has both roles of filtering the file list and forcing a
      loading procedure.
  13. 24 Jul, 2018 1 commit
    • Ell's avatar
      app: in GimpDial, add "clockwise-angles" property ... · 0c477564
      Ell authored
      ... and rename "clockwise" to "clockwise-delta"
      Add a boolean "clockwise-angles" property to GimpDial, which, when
      set, causes the dial legs' angles to be measured clockwise, rather
      than counter-clockwise.  The property is FALSE by default.
      Rename the "clockwise" property, which controls the direction of
      the measured delta between the two angles, to "clockwise-delta", to
      avoid confusion, and adapt the rest of the code.
  14. 21 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Initial space invasion commit in GIMP · e09e563a
      Michael Natterer authored
      All babl formats now have a space equivalent to a color profile,
      determining the format's primaries and TRCs. This commit makes GIMP
      aware of this.
      - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
        as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
        NON_LINEAR and PERCPTUAL for each encoding, matching the babl
        encoding variants RGB, R'G'B' and R~G~B~.
      - gimp_color_transform_can_gegl_copy() now returns TRUE if both
        profiles can return a babl space, increasing the amount of fast babl
        color conversions significantly.
      - TODO: no solution yet for getting libgimp drawable proxy buffers in
        the right format with space.
      - follow the GimpPrecision change.
      - TODO: everything else unchanged and partly broken or sub-optimal,
        like setting a new image's color profile too late.
      - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
        replacement for all "linear" booleans.
      - change gimp-babl functions to take babl spaces and GimpTRCType
        parameters and support all sorts of new perceptual ~ formats.
      - a lot of places changed in the early days of goat invasion didn't
        take advantage of gimp-babl utility functions and constructed
        formats manually. They all needed revisiting and many now use much
        simpler code calling gimp-babl API.
      - change gimp_babl_format_get_color_profile() to really extract a
        newly allocated color profile from the format, and add
        gimp_babl_get_builtin_color_profile() which does the same as
        gimp_babl_format_get_color_profile() did before. Visited all callers
        to decide whether they are looking for the format's actual profile,
        or for one of the builtin profiles, simplifying code that only needs
        builtin profiles.
      - drawables have a new get_space_api(), get_linear() is now get_trc().
      - images now have a "layer space" and an API to get it,
        gimp_image_get_layer_format() returns formats in that space.
      - an image's layer space is created from the image's color profile,
        change gimpimage-color-profile to deal with that correctly
      - change many babl_format() calls to babl_format_with_space() and take
        the space from passed formats or drawables
      - add function gimp_layer_fix_format_space() which replaces the
        layer's buffer with one that has the image's layer format, but
        doesn't change pixel values
      - use gimp_layer_fix_format_space() to make sure layers loaded from
        XCF and created by plug-ins have the right space when added to the
        image, because it's impossible to always assign the right space upon
        layer creation
      - "assign color profile" and "discard color profile" now require use
        of gimp_layer_fix_format_space() too because the profile is now
        embedded in all formats via the space.  Add
        gimp_image_assign_color_profile() which does all that and call it
        instead of a simple gimp_image_set_color_profile(), also from the
        PDB set-color-profile functions, which are essentially "assign" and
        "discard" calls.
      - generally, make sure a new image's color profile is set before
        adding layers to it, gimp_image_set_color_profile() is more than
        before considered know-what-you-are-doing API.
      - take special precaution in all places that call
        gimp_drawable_convert_type(), we now must pass a new_profile from
        all callers that convert layers within the same image (such as
        image_convert_type, image_convert_precision), because the layer's
        new space can't be determined from the image's layer format during
        the call.
      - change all "linear" properties to "trc", in all config objects like
        for levels and curves, in the histogram, in the widgets. This results
        in some GUI that now has three choices instead of two.
        TODO: we might want to reduce that back to two later.
      - keep "linear" boolean properties around as compat if needed for file
        pasring, but always convert the parsed parsed boolean to
      - TODO: the image's "enable color management" switch is currently
        broken, will fix that in another commit.
  15. 18 Jul, 2018 1 commit
  16. 17 Jul, 2018 2 commits
    • Jehan's avatar
      app: set overrided system extensions as unsensitive. · acdf169d
      Jehan authored
      When a user extension with same id as a system extension is installed,
      set the system extension unsensitive in the GUI (as well as extensions
      with missing requirements, though it is not implemented yet).
      The reason why I broke this change in 2 commits (with the previous
      commit) is because it will allow to easily cherry-pick the core code
      commits whereas the GTK+ code will have to be reimplemented for
      gimp-2-10 since this widget uses GTK+3 API.
    • Ell's avatar
      app: fix dynamics editor "fade" curve color · b2a9bb46
      Ell authored
      In the dynamics editor, use the neutral curve color, which depends
      on the current theme, for the "fade" curve, instead of hard-coding
      it to dark gray, which is hardly visible with dark themes.
  17. 15 Jul, 2018 4 commits
  18. 14 Jul, 2018 2 commits
  19. 11 Jul, 2018 1 commit
  20. 09 Jul, 2018 2 commits
  21. 08 Jul, 2018 1 commit
  22. 07 Jul, 2018 2 commits
    • Michael Natterer's avatar
      Issue #1805 - Sample Points keep resetting themselves to "Pixel" · 370680f9
      Michael Natterer authored
      Don't destroy the color frames when the number of points changes.
      Instead, simply hide them so they keep their color model, but add an
      upper limit of an arbitrary number of 16 frames to keep around.
    • Jehan's avatar
      app: new GimpExtensionDetails widget. · 22099db2
      Jehan authored
      The extension dialog will show details about an extension (long
      description, screenshot, upstream URLs, etc.) with this widget.
      Update the GimpExtensionList to send a "extension-activated" signal on
      double click, and make the extensions dialog react on it to display the
      extension details for the activated extension.
      This is all still mostly a skeleton GUI, but it is starting to get into