1. 14 Nov, 2018 1 commit
  2. 10 Sep, 2018 1 commit
  3. 08 Aug, 2018 1 commit
  4. 06 Aug, 2018 1 commit
  5. 21 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Initial space invasion commit in GIMP · e09e563a
      Michael Natterer authored
      All babl formats now have a space equivalent to a color profile,
      determining the format's primaries and TRCs. This commit makes GIMP
      aware of this.
      - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
        as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
        NON_LINEAR and PERCPTUAL for each encoding, matching the babl
        encoding variants RGB, R'G'B' and R~G~B~.
      - gimp_color_transform_can_gegl_copy() now returns TRUE if both
        profiles can return a babl space, increasing the amount of fast babl
        color conversions significantly.
      - TODO: no solution yet for getting libgimp drawable proxy buffers in
        the right format with space.
      - follow the GimpPrecision change.
      - TODO: everything else unchanged and partly broken or sub-optimal,
        like setting a new image's color profile too late.
      - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
        replacement for all "linear" booleans.
      - change gimp-babl functions to take babl spaces and GimpTRCType
        parameters and support all sorts of new perceptual ~ formats.
      - a lot of places changed in the early days of goat invasion didn't
        take advantage of gimp-babl utility functions and constructed
        formats manually. They all needed revisiting and many now use much
        simpler code calling gimp-babl API.
      - change gimp_babl_format_get_color_profile() to really extract a
        newly allocated color profile from the format, and add
        gimp_babl_get_builtin_color_profile() which does the same as
        gimp_babl_format_get_color_profile() did before. Visited all callers
        to decide whether they are looking for the format's actual profile,
        or for one of the builtin profiles, simplifying code that only needs
        builtin profiles.
      - drawables have a new get_space_api(), get_linear() is now get_trc().
      - images now have a "layer space" and an API to get it,
        gimp_image_get_layer_format() returns formats in that space.
      - an image's layer space is created from the image's color profile,
        change gimpimage-color-profile to deal with that correctly
      - change many babl_format() calls to babl_format_with_space() and take
        the space from passed formats or drawables
      - add function gimp_layer_fix_format_space() which replaces the
        layer's buffer with one that has the image's layer format, but
        doesn't change pixel values
      - use gimp_layer_fix_format_space() to make sure layers loaded from
        XCF and created by plug-ins have the right space when added to the
        image, because it's impossible to always assign the right space upon
        layer creation
      - "assign color profile" and "discard color profile" now require use
        of gimp_layer_fix_format_space() too because the profile is now
        embedded in all formats via the space.  Add
        gimp_image_assign_color_profile() which does all that and call it
        instead of a simple gimp_image_set_color_profile(), also from the
        PDB set-color-profile functions, which are essentially "assign" and
        "discard" calls.
      - generally, make sure a new image's color profile is set before
        adding layers to it, gimp_image_set_color_profile() is more than
        before considered know-what-you-are-doing API.
      - take special precaution in all places that call
        gimp_drawable_convert_type(), we now must pass a new_profile from
        all callers that convert layers within the same image (such as
        image_convert_type, image_convert_precision), because the layer's
        new space can't be determined from the image's layer format during
        the call.
      - change all "linear" properties to "trc", in all config objects like
        for levels and curves, in the histogram, in the widgets. This results
        in some GUI that now has three choices instead of two.
        TODO: we might want to reduce that back to two later.
      - keep "linear" boolean properties around as compat if needed for file
        pasring, but always convert the parsed parsed boolean to
      - TODO: the image's "enable color management" switch is currently
        broken, will fix that in another commit.
  6. 11 Jul, 2018 1 commit
  7. 21 Jun, 2018 1 commit
  8. 25 May, 2018 2 commits
    • Ell's avatar
      app: use gimp_gegl_buffer_copy() all over the place · 08ff2ac8
      Ell authored
      Replace all uses of gegl_buffer_copy() in app/ with
      gimp_gegl_buffer_copy(), added in the previous commit.
    • Ell's avatar
      app: add gimp_gegl_buffer_copy() · fded25b3
      Ell authored
      ... which is a drop-in replacement for gegl_buffer_copy(),
      parallelizing the copy operation when the source and destination
      formats are different, requiring a conversion.
  9. 18 May, 2018 1 commit
  10. 07 Apr, 2018 1 commit
  11. 05 Apr, 2018 1 commit
    • Ell's avatar
      app: fix smudge tool artifacts · f7c2ce9b
      Ell authored
      Commit cb239e60 introduced
      artifacts when using the smudge tool with multithreads.  Fix this
      (caused by a wrong offset passed to an iterator) plus indentation
  12. 04 Apr, 2018 2 commits
  13. 03 Sep, 2017 1 commit
  14. 17 Aug, 2017 1 commit
    • Ell's avatar
      app: move libappgegl's SSE2 bits to a separate library · 64ade977
      Ell authored
      Split libappgegl into libappgegl-generic and libappgegl-sse2, and
      move the SSE2 code (part of the newly added smudge code) to the
      latter, so that the rest of the code can be compiled without SSE2
      compiler flags.  This allows building GIMP with SSE acceleration
      enabled, while running the resulting binary on a target with no
      SSE accelration.
  15. 06 Aug, 2017 1 commit
    • Ell's avatar
      Bug 785890 - libappgegl doesn't use SSE2 compiler flags ... · 7ecd3f27
      Ell authored
      ... causing compilation to fail on 32 bit targets
      Use SSE2 compiler flags when building libappgegl, since it's used by
      the new smudge tool code.
      Avoid using SSE for the smudge tool if SSE acceleration is disabled
      at runtime, or if the buffers are not properly aligned.
  16. 23 Jul, 2017 1 commit
  17. 27 Apr, 2017 1 commit
    • Ell's avatar
      Bug 781804 - Dodge/Burn tool produces artifacts with negative channel values · e0dcf538
      Ell authored
      The halftones transfer mode of dodge/burn uses pow(), which produces
      NaN for negative input values.  This tool doesn't really have OOG
      values in mind, but using an odd power function fixes this issue,
      and is in line with the behavior of the other modes w.r.t. OOG
  18. 05 Jun, 2016 1 commit
  19. 26 May, 2016 3 commits
    • Michael Natterer's avatar
      libgimpcolor: add gimp_color_transform_can_gegl_copy() · ca349f88
      Michael Natterer authored
      Which takes two profiles and returns TRUE if converting between
      them works correctly without a GimpColorTransform. Use it in
      gimp_color_transform_new() to return a NULL transform if none
      is needed. Took the code from gimp-gegl-loops.c.
    • Michael Natterer's avatar
    • Michael Natterer's avatar
      libgimpcolor: add new object GimpColorTransform · cc928879
      Michael Natterer authored
      which encapsulates a cmsHTRANSFORM and does all the pixel format
      conversion magic. It has API to create transforms and proofing
      transforms, and to convert pixels arrays and GeglBuffers.
      Before, each place which has a transform had to keep around the
      transform and its input and output Babl formats, and had to implement
      lots of stuff itself. Now all that lives in GimpColorTransform,
      removing lots of logic from many places, and pretty much removing lcms
      from the public API entirely.
      This removes including <lcms2.h>, LCMS_LIBS and LCMS_CFLAGS from
      almost all directories and potentially allows to replace lcms by
      something else.
  20. 23 May, 2016 1 commit
  21. 09 Apr, 2016 1 commit
    • Michael Natterer's avatar
      Bug 756389 - Color-managing grayscale images · f34aa5fa
      Michael Natterer authored
      Rename profile constructors to say "d65_gray" instead of just "gray",
      "srgb_trc" instead of "srgb_gamma", and drop the "srgb" from
      "srgb_linear" because we now say "d65". This should be a naming scheme
      that doesn't conflict with whatever future functions we might add.
  22. 27 Dec, 2015 1 commit
  23. 15 Dec, 2015 1 commit
  24. 14 Dec, 2015 1 commit
    • Michael Natterer's avatar
      Bug 756389 - Color-managing grayscale images · 50983384
      Michael Natterer authored
      Allow to set profiles on grayscale images. Change profile validation
      to check for image type and profile type. Actually the patch simply
      makes some pieces of code less restrictive. Change user-visible
      strings in the profile dialogs accordingly. Change PDB docs
  25. 18 Oct, 2015 1 commit
  26. 02 Sep, 2015 1 commit
  27. 25 Aug, 2015 1 commit
  28. 14 Aug, 2015 1 commit
    • Michael Natterer's avatar
      app: add gimp_gegl_convert_color_profile() · b03f0fc6
      Michael Natterer authored
      which converts a buffer with a profile into another one with another
      profile. The function tries to avoid the lcms transform by checking if
      a simple gegl_buffer_copy() has the same result.
  29. 18 Mar, 2015 1 commit
  30. 12 Nov, 2014 1 commit
  31. 02 Jul, 2014 1 commit
  32. 29 Apr, 2014 1 commit
    • Michael Natterer's avatar
      libgimpbase,*: clean up enum values in gimpbaseenums.h · 22c22229
      Michael Natterer authored
      GIMP_ADD_foo_MASK -> GIMP_ADD_MASK_foo
      GIMP_foo_MODE -> GIMP_BLEND_foo
      GIMP_foo_CLONE -> GIMP_CLONE_foo
      GIMP_foo -> GIMP_DODGE_BURN_TYPE_foo
      GIMP_foo -> GIMP_TRANSFER_foo
      Add compat values for the old names and compat code to script-fu
      and pygimp.
  33. 13 Sep, 2013 1 commit
    • Daniel Sabo's avatar
      app, plug-ins: Don't modify iter->length · 34c50b0f
      Daniel Sabo authored
      The new by-row iteration doesn't re-write the length
      value for each row. In general it is not safe to modify
      the iterator data because the internal logic depends
      on the public data, but this specific case is new.
  34. 23 Jun, 2013 1 commit
    • Michael Natterer's avatar
      Add support for both gamma-corrected and linear for all bit depths · caf73f5f
      Michael Natterer authored
      - Add new enum GimpComponentType which contains u8, u16, u32 etc.
      - Change GimpPrecision to be u8-linear, u8-gamma, u16-linear etc.
      - Add all the needed formats to gimp-babl.c
      - Bump the XCF version to 5 and make sure version 4 with the old
        GimpPrecision enum values is loaded correctly
      This change blows up the precision enums in "New Image" and
      Image->Precision so we can test all this stuff. It is undecided what
      format will be user-visible options in 2.10.
  35. 19 Dec, 2012 1 commit
  36. 08 Dec, 2012 1 commit