1. 18 Nov, 2004 1 commit
    • Michael Natterer's avatar
      added boolean property "value-variable" which specifies if the · 567bb7b2
      Michael Natterer authored
      2004-11-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpenumaction.[ch]: added boolean property
      	"value-variable" which specifies if the GimpEnumAction::selected()
      	signal may be emitted with arbirtary values (value-variable = TRUE)
      	or *only* with enum_action->value (value-variable = FALSE).
      
      	* app/widgets/gimpactiongroup.[ch]: added "gboolean
      	value_variable" to GimpEnumActionEntry and set it in
      	gimp_action_group_add_enum_actions().
      
      	* app/actions/channels-actions.c
      	* app/actions/colormap-editor-actions.c
      	* app/actions/context-actions.c
      	* app/actions/drawable-actions.c
      	* app/actions/edit-actions.c
      	* app/actions/error-console-actions.c
      	* app/actions/gradient-editor-actions.c
      	* app/actions/image-actions.c
      	* app/actions/layers-actions.c
      	* app/actions/palette-editor-actions.c
      	* app/actions/plug-in-actions.c
      	* app/actions/vectors-actions.c
      	* app/actions/view-actions.c: set "variable" to FALSE for all enum
      	actions except those which are used with the GIMP_ACTION_SELECT_SET
      	voodoo.
      
      	* app/widgets/gimpcontrollers.c (gimp_controllers_event_mapped):
      	fall back to gtk_action_activate() if the action specified in a
      	GIMP_CONTROLLER_EVENT_VALUE mapping is not variable. Enables
      	triggering of enum actions from GIMP_CONTROLLER_EVENT_VALUE events
      	(like midi note-on and note-off).
      567bb7b2
  2. 24 Oct, 2004 1 commit
    • Michael Natterer's avatar
      app/widgets/gimpgradienteditor.[ch] added public APIs for zooming the · 714771d4
      Michael Natterer authored
      2004-10-24  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpgradienteditor.[ch]
      	* app/widgets/gimppaletteeditor.[ch]: added public APIs for
      	zooming the editors. Use gimp_editor_add_action_button() to create
      	all buttons. Removed all button callbacks and all duplicated
      	button sensitivity logic.
      
      	* app/widgets/gimpdataeditor.c (gimp_data_editor_set_data): update
      	the editor's UI manager if it exists.
      
      	* app/actions/gradient-editor-actions.c
      	* app/actions/gradient-editor-commands.[ch]: added zoom actions
      	and callback and call gimp_gradient_editor_zoom(). Fixed
      	gradient_editor_actions_update() to actually set all items'
      	sensitivity (it was possible to modify read-only gradients and
      	even to crash GIMP).
      
      	* app/actions/palette-editor-actions.c
      	* app/actions/palette-editor-commands.[ch]: changed "new" and
      	"zoom" actions to actually do their job instead of calling
      	gtk_button_clicked(editor->foo_button).
      714771d4
  3. 18 Oct, 2004 1 commit
    • Michael Natterer's avatar
      Action code review and pre-release consistency cleanup: · c49df22e
      Michael Natterer authored
      2004-10-18  Michael Natterer  <mitch@gimp.org>
      
      	Action code review and pre-release consistency cleanup:
      
      	* app/actions/*-actions.c: added some missing and resolved
      	conflicting mnemonics, added missing help IDs. Cleaned up the
      	*_actions_update() functions.
      
      	* app/actions/channels-actions.c
      	* app/actions/layers-actions.c
      	* app/actions/vectors-actions.c (*_actions_update): simplified
      	the code that figures the prev and next channel,layer,vectors.
      
      	* app/actions/qmask-actions.c: use the same accelerator for
      	"qmask-active" and "qmask-toggle". Fixed action sensitivity.
      
      	* app/actions/channels-commands.c
      	* app/actions/dockable-commands.c
      	* app/actions/documents-commands.c
      	* app/actions/gradients-commands.c
      	* app/actions/layers-commands.c
      	* app/actions/palettes-commands.c
      	* app/actions/image-commands.c
      	* app/actions/select-commands.c
      	* app/actions/vectors-commands.c: folded tons of private utility
      	functions into their only callers (they used to be public and
      	called from outside before the switch to action based menus).
      	Renamed functions and variables saying "query" or "qbox" to
      	"dialog". Moved static functions to the end of the files. Misc
      	minor cleanups.
      
      	* app/actions/drawable-actions.c
      	* app/actions/drawable-commands.c: made the "drawable-visible" and
      	"drawable-linked" actions affect the layer if the active drawable
      	is a layer mask.
      
      	* app/actions/select-commands.c: added action to stroke with the
      	last values used in an attempt to address bug #135746 but #if 0'ed
      	it because the approach is too ugly.
      
      	* app/tools/gimpiscissorstool.c: changed mnemonic from I to S.
      
      	* menus/image-menu-xml.in: added more stuff to the (commented out)
      	"context" menu.
      c49df22e
  4. 23 May, 2004 1 commit
    • Michael Natterer's avatar
      reoedered to somehow reflect the class hierarchy. · 43cdd54d
      Michael Natterer authored
      2004-05-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/widgets-types.h: reoedered to somehow reflect the
      	class hierarchy.
      
      	Some dockable context handling cleanup:
      
      	* app/widgets/gimpdocked.[ch]: removed "prev_context" parameter
      	from GimpDocked::set_context(). Widgets which need the old context
      	to disconnect from should remember it themselves.
      
      	* app/widgets/gimpdockable.c (gimp_dockable_set_context): don't
      	pass the old context to gimp_docked_set_context().
      	Some cleanup.
      
      	* app/widgets/gimpcontainerbox.c
      	* app/widgets/gimpcontainereditor.c: changed accordingly.
      
      	* app/display/gimpnavigationview.[ch]
      	* app/widgets/gimpimageeditor.[ch]
      	* app/widgets/gimpitemtreeview.[ch]: added a "context" member
      	which holds the context set by GimpDocked::set_context().
      
      	* app/widgets/gimpdrawabletreeview.c: use the view's context
      	instead of gimp_get_user_context().
      
      	* app/widgets/gimpcoloreditor.[ch]: removed separate API to
      	set the context because it implements the GimpDockedInterface.
      
      	* app/widgets/gimpcomponenteditor.c
      	* app/widgets/gimperrorconsole.c: pass "menu-factory",
      	"menu-identifier" and "ui-path" to g_object_new() instead of
      	calling gimp_editor_create_menu() later.
      
      	Action cleanup partly related to the context stuff above:
      
      	* app/actions/actions.c (action_data_get_gimp): get the Gimp from
      	context->gimp, not gimage->gimp because gimage may be NULL.
      
      	(action_data_get_context): changed to use the new context members
      	added above.
      
      	* app/actions/channels-actions.c (channels_actions_update): cleanup.
      
      	* app/actions/edit-actions.c (edit_actions_update): fixed
      	sensitivity of "edit-undo-clear".
      
      	* app/actions/vectors-actions.c (vectors_actions_update): make
      	"vectors-merge-visible" sensitive only if there is more than one
      	GimpVectors in the image.
      
      	* app/actions/colormap-editor-actions.c
      	* app/actions/gradient-editor-actions.c
      	* app/actions/palette-editor-actions.c: added FG/BG color previews
      	to actions which take colors from them. Changed code to be safe
      	against "context" being NULL.
      
      	* app/actions/drawable-commands.c:
      	s/active_drawable/drawable/g. Makes the code more readable.
      
      	* app/actions/select-commands.[ch]
      	* app/actions/vectors-commands.[ch]: removed public stroke utility
      	functions and other stuff which is not needed any more because
      	dialog buttons invoke the correct actions now. Moved the
      	functions' code to the resp. action callbacks.
      43cdd54d
  5. 02 May, 2004 1 commit
    • Michael Natterer's avatar
      added help IDs to all actions representing the toplevel popups and menus · 9377b26e
      Michael Natterer authored
      2004-05-02  Michael Natterer  <mitch@gimp.org>
      
      	* app/actions/*-actions.c: added help IDs to all actions
      	representing the toplevel popups and menus (as fallbacks for the
      	still-to-be-written help system intrgration of GimpUIManager).
      
      	* app/display/gimpdisplayshell.c (gimp_display_shell_new): removed
      	call to gtk_ui_manager_ensure_update() because that's done by
      	gimp_ui_manager_ui_get() now.
      
      	* app/widgets/gimpmenufactory.[ch]: removed API to register and
      	create item factories.
      
      	* app/gui/menus.c: changed accordingly.
      
      	* app/gui/dialogs.c
      	* app/actions/plug-in-commands.c
      	* app/gui/file-dialog-utils.c
      	* app/gui/file-save-dialog.c
      	* app/widgets/gimpdataeditor.c
      	* app/widgets/gimpdockable.c
      	* app/widgets/gimpdockbook.[ch]
      	* app/widgets/gimpimagedock.c
      	* app/widgets/gimpitemtreeview.c: removed leftover item factory
      	cruft.
      
      	* app/widgets/widgets-types.h: removed item factory typedefs...
      
      	* app/widgets/gimpitemfactory.h: ...and added them here.
      
      	* app/widgets/gimpactiongroup.[ch]: added new function
      	gimp_action_group_add_plug_in_actions().
      
      	* app/actions/plug-in-actions.c: use it here instead of adding
      	the actions manually.
      
      	* app/widgets/gimptoolbox.c: ported the code which dynamically
      	updates the tool button tooltips on accelerator changes to
      	GtkAction. Disabled the whole stuff because GTK+ lacks
      	gtk_action_get_accel_closure().
      9377b26e
  6. 27 Apr, 2004 1 commit
    • Michael Natterer's avatar
      app/widgets/Makefile.am app/widgets/widgets-types.h new GtkAction subclass · aae726ee
      Michael Natterer authored
      2004-04-27  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/Makefile.am
      	* app/widgets/widgets-types.h
      	* app/widgets/gimppluginaction.[ch]: new GtkAction subclass which
      	remembers the PlugInProcDef.
      
      	* app/widgets/gimpactiongroup.[ch]: added "gpointer user_data" to
      	the GimpActionGroup struct and to gimp_action_group_new(). Removed
      	the user_data parameter from gimp_action_group_add_*_actions().
      
      	* app/widgets/gimpactionfactory.[ch]: changed accordingly.
      
      	* app/actions/*-actions.[ch]: removed user_data from all setup_funcs.
      
      	* app/actions/plug-in-actions.c: use a GimpPlugInAction and
      	finally use the right user_data for the callback so plug-in
      	callbacks have a proper context.
      
      	* app/gui/plug-in-menus.[ch]: renamed plug_in_menus_create2() to
      	plug_in_menus_setup().
      
      	* app/gui/image-menu.c
      	* app/gui/toolbox-menu.c: changed accordingly.
      aae726ee
  7. 22 Apr, 2004 1 commit
    • Michael Natterer's avatar
      implemented gimp_action_group_set_action_color() and · 42f79826
      Michael Natterer authored
      2004-04-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpactiongroup.[ch]: implemented
      	gimp_action_group_set_action_color() and
      	gimp_action_group_set_action_viewable().
      
      	* app/actions/*-actions.c: added stock IDs to all actions which
      	represent toplevel popup menus. Fixed typos.
      
      	* menus/brushes-menu.xml
      	* menus/colormap-editor-menu.xml
      	* menus/dockable-menu.xml
      	* menus/gradients-menu.xml
      	* menus/patterns-menu.xml
      	* menus/toolbox-menu.xml: fixed typos.
      42f79826
  8. 21 Apr, 2004 1 commit
    • Michael Natterer's avatar
      forgot to register the "patterns" actions. · 2c601c7d
      Michael Natterer authored
      2004-04-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/actions/actions.c: forgot to register the "patterns" actions.
      
      	* app/actions/*-actions.c: added actions representing the toplevel
      	menus (popups and menubars). Fixed some typos.
      
      	* menus/*-menu.xml: added action="foo" attributes to all toplevel
      	menus. Fixed typos here too.
      
      	* menus/gtkuimanager.dtd: fixed possible attributes.
      2c601c7d
  9. 20 Apr, 2004 1 commit
    • Michael Natterer's avatar
      removed... · 661f6dde
      Michael Natterer authored
      2004-04-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/*-commands.[ch]: removed...
      
      	* app/actions/*-commands.[ch]: ...and added here.
      
      	* app/gui/Makefile.am
      	* app/gui/*-menu.c
      	* app/gui/dialogs-constructors.c
      	* app/gui/gui.c
      	* app/gui/menus.c
      	* app/actions/Makefile.am
      	* app/actions/*-actions.c: changed accordingly.
      
      	* app/actions/plug-in-actions.[ch]
      	* app/actions/tools-actions.[ch]: new files.
      
      	* app/Makefile.am: had to add more -u evilness because gui/
      	and actions/ have cyclic dependencies.
      
      	* menus/image-menu.xml: added some more items.
      661f6dde
  10. 19 Apr, 2004 1 commit
    • Michael Natterer's avatar
      More GtkAction stuff (still unused): · 8848558f
      Michael Natterer authored
      2004-04-19  Michael Natterer  <mitch@gimp.org>
      
      	More GtkAction stuff (still unused):
      
      	* configure.in: added new directories menus/ and app/actions/
      
      	* Makefile.am: build menus/
      
      	* menus/.cvsignore
      	* menus/Makefile.am
      	* menus/*-menu.xml: new files: XML menu descriptions for each menu
      	which is now defined in gui/*-menu.c.
      
      	* app/widgets/widgets-types.h: some typedefs for GimpActionGroup.
      
      	* app/widgets/gimpactiongroup.[ch]: added a "Gimp" construct-only
      	property. Added APIs to set actions visible/sensitive/active
      	and an unimplemented stub for setting the action's color.
      
      	* app/Makefile.am: build actions/ and link libappactions.a
      
      	* app/actions/.cvsignore
      	* app/actions/Makefile.am
      	* app/actions/*-actions.[ch]: new files: GtkActions for each
      	*-commands.c file in gui/. Ported all "update" functions from the
      	*-menu.c files.
      	(everything completely unused, untested and partly #if 0'ed)
      
      	* app/core/gimpimage.[ch]: for reasons of (action-) symmetry, added
      	API to raise/lower channels/vectors to top/bottom.
      
      	* app/gui/channels-commands.[ch]
      	* app/gui/vectors-commands.[ch]: added callbacks for the new
      	to top/bottom functions.
      
      	* app/gui/Makefile.am
      	* app/gui/dockable-commands.[ch]: new files split out of
      	dialogs-commands.[ch].
      
      	* app/gui/dialogs-commands.[ch]
      	* app/gui/dialogs-menu.c: changed accordingly.
      
      	* app/gui/edit-commands.[ch]: added edit_paste_into_cmd_callback()
      	and remove usage of "guint action".
      
      	* app/gui/image-menu.c: changed accordingly.
      
      	* app/gui/palette-editor-commands.[ch]: split
      	+palette_editor_new_color_cmd_callback() into separate callbacks
      	for adding from FG and BG.
      
      	* app/gui/palette-editor-menu.c: changed accordingly.
      8848558f