1. 07 Apr, 2018 5 commits
    • Ell's avatar
      Makefiles: don't use -xobjective-c when compiling C++ files on Mac · 06950be7
      Ell authored
      On Mac, pass -xobjective-c to the compiler through AM_CFLAGS, not
      AM_CPPFLAGS, so that it's only used for C sources, and not C++
      sources.  In the latter case, it clashes with the -std=... flag,
      spewing an error.  Thanks, Partha :)
      06950be7
    • Ell's avatar
      app: throttle statusbar progress updates · bea27171
      Ell authored
      Statusbar progress updates that update the progress bar are
      relatively expensive, slowing down operations that report progress
      frequently.  Only update the progress bar if a certain amount of
      time has passed since the last update, to counter that.
      bea27171
    • Ell's avatar
      Bug 795048 - Image->mode->Grayscale results in a black or transparent image · 87a10aaf
      Ell authored
      In gimp_gegl_convert_color_profile(), when src/dest_rect is NULL,
      use the extents of src/dest_buffer, instead of passing a NULL area
      to gimp_parallel_distribute_area(), which results in a CRITICAL.
      
      Additionally, only report progress on the main thread.
      87a10aaf
    • Massimo Valentini's avatar
      app: silence gcc warning · 81e1e396
      Massimo Valentini authored
      gimp-templates.c:143:15: warning: ‘strncpy’ output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation]
                     strncpy (dpi, "ppi", 3);
                     ^~~~~~~~~~~~~~~~~~~~~~~
      81e1e396
    • Michael Natterer's avatar
      Bug 770424 - Themes: insensitive menu item are not readable · 2dd2f2f3
      Michael Natterer authored
      Need to check if we must override PixbufStyle's draw_layout() after
      each theme change, not only at the beginning of themes_init(), so it
      works also when the the pixbuf engine was not already loaded at
      startup.
      2dd2f2f3
  2. 06 Apr, 2018 5 commits
  3. 05 Apr, 2018 11 commits
  4. 04 Apr, 2018 18 commits
    • Jehan's avatar
      NEWS: keep up-to-date. · b88170b9
      Jehan authored
      b88170b9
    • Jehan's avatar
      Bug 794949 - Plugin crash when opening png, jpeg or tiff with... · ba06a0fe
      Jehan authored
      ... non-latin unicode path.
      g_win32_locale_filename_from_utf8() was sometimes returning NULL for
      some paths on Windows. Then the call to gexiv2_metadata_open_path() with
      a NULL value was crashing plug-ins.
      This commit only prevents from crashing by simply failing to load
      metadata when this occurs, which means losing metadata support on
      Windows depending on filenames. A proper solution will have to be
      implemented.
      ba06a0fe
    • Ell's avatar
      app: parallelize gimp-gegl-loops.cc · cb239e60
      Ell authored
      Ditto.
      cb239e60
    • Ell's avatar
      app: switch gimp-gegl-loops.c to C++ · 828b99b5
      Ell authored
      Ditto.
      828b99b5
    • Ell's avatar
      app: parallelize gimppaintcore-loops.cc · 3df757ff
      Ell authored
      Ditto.
      3df757ff
    • Ell's avatar
      app: switch gimppaintcore-loops.c to C++ · e8a14dee
      Ell authored
      Ditto.
      e8a14dee
    • Ell's avatar
      app: parallelize gimpbrush-transform.cc · c8d4c079
      Ell authored
      Use gimp_parallel_distribute_foo() to parallelize the brush
      transform functions.
      c8d4c079
    • Ell's avatar
      app: switch gimpbrush-transform.c to C++ · 565f1f2a
      Ell authored
      The next commit is going to parallelize gimpbrush-transform using
      the gimp_parallel_distribute_foo() functions.  To spare us a lot of
      boilerplate code, we're going to use C++ lambdas as callback
      arguments to these functions.
      
      This commit does the initial conversion of gimpbrush-transform.c to
      C++, renaming it to gimpbrush-transform.cc.  We do this in a
      separate commit, so that the changes are small enough for git to
      register this as a renamed file, rather than a new file, so that we
      don't lose the file's history.
      565f1f2a
    • Ell's avatar
      app: add gimp-parallel · 86b89cf6
      Ell authored
      Add gimp-parallel.[cc,h], which provides a set of parallel
      algorithms.
      
      These currently include:
      
        - gimp_parallel_distribute():  Calls a callback function in
          parallel on multiple threads, passing it the current thread
          index, and the total number of threads.  Allows specifying the
          maximal number of threads used.
      
        - gimp_parallel_distribute_range():  Splits a range of integers
          between multiple threads, passing the sub-range to a callback
          function.  Allows specifying the minimal sub-range size.
      
        - gimp_parallel_distribute_area():  Splits a rectangular area
          between multiple threads, passing the sub-area to a callback
          function.  Allows specifying the minimal sub-area.
      
      The callback function is passed using an appropriately-typed
      function pointer, and a user-data pointer.  Additionally, when used
      in a C++ file, each of the above functions has an overloaded
      template version, taking the callback through a generic parameter,
      without a user-data pointer, which allows using function objects.
      86b89cf6
    • Ell's avatar
      configure.ac: require a C++11 compiler · 700cc33b
      Ell authored
      The following commits use C++11 lambdas.
      700cc33b
    • Ell's avatar
      394c930f
    • Jehan's avatar
      libgimp: add an exception handler for Windows. · fa02a2c6
      Jehan authored
      Drmingw already added its own exception handler which generates crash
      traces in a text file, for plug-ins as well. This additional handler is
      run after Drmingw handler and allows us to do things on our own, and in
      particular we could display the content of the debug traces.
      
      Right now it simply prints these to stderr, which actually won't be of
      much use on Win32, first because the console is deactivated on stable
      releases, also because after tests, it doesn't look like even running
      GIMP from cmd outputs to console either.
      
      We currently don't use the same debug dialog as the core on purpose,
      because we don't want everyone to send us traces for every unmaintained
      third party plug-ins out there. But we should definitely allow easier
      trace possibilities at some point, first to improve/debug our own core
      plug-ins, and also to help third party plug-in developers!
      So this commit is not making visible changes yet but is actually a first
      step towards these debugging goals.
      fa02a2c6
    • Jehan's avatar
      libgimp: various warning fixes for Win32. · 76bce77d
      Jehan authored
      76bce77d
    • Jehan's avatar
      libgimp: do not end the fatal and signal handlers with gimp_quit(). · 9c8a8ae5
      Jehan authored
      When ending with gimp_quit(), GIMP was not displaying the "Plug-in
      crashed" error dialog, which is not good, since we lose the crash
      feedback for plug-ins. Just let the plug-in continue its normal run in
      order to get the error dialog.
      Also protect the tracing functions, which are not working on Win32.
      9c8a8ae5
    • Jehan's avatar
      libgimp: add a gimp_fatal_func() allowing stack tracing plug-ins on... · e98b9376
      Jehan authored
      ... various crashes.
      e98b9376
    • Jehan's avatar
      devel-docs: update debugging-tips.txt regarding --stack-trace-mode... · 6bcb30e1
      Jehan authored
      ... for plug-in debugging as well.
      6bcb30e1
    • Jehan's avatar
      libgimp: properly catch SIGABRT signal. · c4621119
      Jehan authored
      SIGABRT was in the switch list in gimp_plugin_sigfatal_handler(), but it
      had not been properly handled with gimp_signal_private(), making this
      switch case useless. Fix this oversight, and while doing so, move it in
      the "fatal error" list for which we may generate stack traces, similarly
      to core signal handling. Indeed this signal can definitely happen during
      various kinds of common bugs and needs to be debugged.
      c4621119
    • Jehan's avatar
      plug-ins: minor fix of an error string. · 6936a655
      Jehan authored
      Was reading this part of the code when I saw this: the error happens
      when loading not exporting a PNG.
      6936a655
  5. 03 Apr, 2018 1 commit