Commit d9cd4b61 authored by Jehan's avatar Jehan

Bug 791352 - Screenshot delay is broken for region-grab screenshot.

Fix first the delay in X11.
Actually both for region and window screenshots, it makes no sense to
delay *before* region or window selection. Usually when one uses a
delay, the point is to prepare in-between selection and shot. For
instance, I often used a delay to snap the contents of a menu because
PrintScreen key would not work when a menu is opened. So I would set a
delay, select my window/region, then quickly open the menu before the
delay is counting down. This would not be possible with the way delay
occurred (before selection), which just has no use that I can see of.
parent ef6559b3
...@@ -572,9 +572,6 @@ screenshot_x11_shoot (ScreenshotValues *shootvals, ...@@ -572,9 +572,6 @@ screenshot_x11_shoot (ScreenshotValues *shootvals,
if (screen == NULL) if (screen == NULL)
screen = gdk_screen_get_default (); screen = gdk_screen_get_default ();
if (shootvals->select_delay > 0)
screenshot_delay (shootvals->select_delay);
if (shootvals->shoot_type != SHOOT_ROOT && ! shootvals->window_id) if (shootvals->shoot_type != SHOOT_ROOT && ! shootvals->window_id)
{ {
shootvals->window_id = select_window (shootvals, screen); shootvals->window_id = select_window (shootvals, screen);
...@@ -583,6 +580,9 @@ screenshot_x11_shoot (ScreenshotValues *shootvals, ...@@ -583,6 +580,9 @@ screenshot_x11_shoot (ScreenshotValues *shootvals,
return GIMP_PDB_CANCEL; return GIMP_PDB_CANCEL;
} }
if (shootvals->select_delay > 0)
screenshot_delay (shootvals->select_delay);
display = gdk_screen_get_display (screen); display = gdk_screen_get_display (screen);
screen_rect.x = 0; screen_rect.x = 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment