Commit 73cd120a authored by Michael Natterer's avatar Michael Natterer 😴

Issue #3912 - Object proxy management not happy with bindings

Don't drop references we do not own. Turns out bindings can have
things referenced even after all procedure code has returned. Keep the
old code there in #if 0 and keep the debug warning for now, maybe we
can do something generic about this.
parent f1a13b49
Pipeline #114272 passed with stages
in 18 minutes and 19 seconds
......@@ -1465,9 +1465,17 @@ gimp_plug_in_destroy_proxies (GHashTable *hash_table,
"by plug-in, it MUST NOT do that!\n",
G_STRFUNC, G_OBJECT_TYPE_NAME (object), id);
#if 0
/* the code used to do this, but it appears that some bindings
* keep references around until later, let's keep this for
* reference and as a reminder to figure if we can do anything
* generic about it that works for all bindings.
*/
while (object->ref_count > 1)
g_object_unref (object);
#else
g_object_unref (object);
#endif
g_hash_table_iter_remove (&iter);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment