Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4k
    • Issues 4k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 97
    • Merge requests 97
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !754

Issue #1206: Use floating point values in pdb.gimp_vectors_stroke_translate()

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alx Sa requested to merge alxsa-stroke-translate-api into master Oct 07, 2022
  • Overview 0
  • Commits 1
  • Pipelines 8
  • Changes 4

This small patch attempts to resolve the API issue noted in #1206 (closed).

gimp_vectors_stroke_translate () is the public facing version of gimp_stroke_translate (), which uses floating point values for its x and y offset parameters. However, gimp_vectors_stroke_translate () defines those parameters as ints, truncating the possible values to whole numbers. This patch converts the parameters to gdoubles instead of gints.

Per #1206 (comment 219047), this API can be updated for 3.0. The only part of GIMP that currently calls this method is one instance in the selection to path plugin, and updating the API did not have a noticeable effect on its output.

Edited Oct 07, 2022 by Alx Sa
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: alxsa-stroke-translate-api