Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,769
    • Issues 3,769
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 78
    • Merge requests 78
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !729

check_for_updates: fixes update check macos #7325

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Lukas Oberhuber requested to merge lukaso/gimp:gimp-2-10-fix-updates-check into gimp-2-10 Sep 01, 2022
  • Overview 26
  • Commits 3
  • Pipelines 6
  • Changes 3

This fixes #7325 (closed)

The current implementation is special cased for MacOS although libcurl has been added to the build system for all platforms.

So there are a few more options:

  • The build system could be special cased to MacOS.
  • We could completely replace the current update system with the libcurl one.
  • We could port the libcurl system to GLib. However that would require adding a new dependency into GLib and not using the synchronous libcurl API that is being employed here.

At this stage looking for feedback on approach (although this is fully working so could be merged as is, hence it is not Draft.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gimp-2-10-fix-updates-check