Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.9k
    • Issues 3.9k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !633

Convert CMYK Color Selector to use babl

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nikc requested to merge NikcDc/gimp:cmyk-color-selector-babl into master Apr 30, 2022
  • Overview 45
  • Commits 1
  • Pipelines 52
  • Changes 9

This patch attempts to provide a solution to the first issue noted in #7899 (closed). It converts the CMYK Color Selector to use babl for color conversions rather than using GimpColorTransform.

It also resolves an issue noted in this comment: When a CMYK profile is assigned, the color values are accidentally divided by 100.0 twice (so 100 becomes 1). The GUI spin scales move in steps of 1 and have a range of 0 - 100. Therefore, it is currently not possible to manually adjust the CMYK values with the sliders if a CMYK color profile is set. This patch resolves the issue as part of the conversion to babl.

Note that unlike !589 (merged), this patch does not add support for using the soft-proofing profiles in the View menu. I thought it would be better to submit the self-contained babl conversion first, then follow up with the soft-proofing profile changes once a decision has been made about how to handle them.

Now we also use the Image's soft-proofing color profile, and reach to changes accordingly.

Edited Aug 03, 2022 by Nikc
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cmyk-color-selector-babl