Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4k
    • Issues 4k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 97
    • Merge requests 97
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !589

Converting CMYK sample points to babl + profile

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nikc requested to merge NikcDc/gimp:master into master Mar 03, 2022
  • Overview 51
  • Commits 1
  • Pipelines 51
  • Changes 7

Attempts to fix several issues related to CMYK support in GimpColorFrames:

  1. Internally, switches the color conversion code to use babl rather than gimp_color_transform_process_pixels ()

  2. Now reacts to changes in the Soft-Proofing profile set in the View menu. "Preferred CMYK Profile" in Preferences is still used if no CMYK soft-proof profile is set in the View Menu. See a video of it in action here.

  3. Now displays the current active profile (or "No Profile" if none selected) as another label in the GimpColorFrame

  4. Now has consistent output scales when a CMYK profile is active versus when it isn't (Previously, applying a color profile would divide the values by 100; see this comment for an example)

As some of these changes require GimpColorFrame to be aware of the user context, small changes are also made to GimpSamplePointEditor, GimpColorPicker, and GimpCursorView to pass the context into GimpColorFrame when they create it.

Edited Mar 20, 2022 by Nikc
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master