Skip to content

libgimpcolor: GIMP built-in sRGB profiles now generated by babl.

Jehan requested to merge wip/Jehan/reproducible-profile into master

@ok

So we realized that the built-in color profiles have a timestamp, created by LittleCMS API and AFAICS, there is no API to override this timestamp. Unfortunately it makes files created by GIMP with these profiles non-reproducible (see gimp-data#7).

On the other hand, the ICC data generated by babl for "sRGB" and "scRGB" is always bit-identical to itself. So the current MR moves our code away from using LittleCMS and using babl for our built-in profiles.

Now I do see that babl code has this comment when creating sRGB space:

/* hard-coded pre-quantized values - to match exactly what is used in standards see issue #18 */

And indeed babl#18 seems to say that our sRGB in babl may not be strictly identical to the standard. Therefore I am not 100% sure if it should be merged and if therefore there was a good reason to use LittleCMS for our default spaces.

Merge request reports

Loading