Windows installer text completely broken since gettext port
Environment/Versions
- GIMP version: master
- Package: Windows installer
- Operating System: Windows
Description of the bug
The installer text is completely garbled. It seems to contain all langs mixed and with encoding completely broken.
You can for instance test this with this recent installer: https://gitlab.gnome.org/GNOME/gimp/-/jobs/2110511/artifacts/browse/build/windows/installer/_Output/
@nielsdg So it seems your recent gettext port messed up the .isl
file. They must not be generated the same as they used to be. Do you generate .isl
files with a BOM? This is the only way that InnoSetup has currently to know a file is UTF-8. E.g. see commit 3e1b783a.
Could it be it? Or if it's another problem, it should be dealt with, because now this is a Blocker issue as we can't release a 2.99.12 version with completely broken Windows installer.
Reproduction
Is the bug reproducible? Always
Reproduction steps:
- Run one of the recent Windows installer constructed by the CI (it is based off the meson process as this is our recommended process on Windows now).
Expected result: Readable text.
Actual result: Unreadable.
Additional information
This is happening whatever the chosen language in the installer (even the default, i.e. English). Text is just completely borked, in all langs. Apart from this, the installer works fine (if you manage to guess which button has the focus or not and click with arrows/Enter, not by clicking, since the broken text also kind of breaks the UI).
Some screenshots: