Skip to content

Paint dynamics editor: fade curve invisible on light themes

Environment/Versions

  • GIMP version: 98b22162
  • Package: Built from source
  • Operating System: Linux

Description of the bug

One more theme issue found when dogfooding css changes. In the Paint dynamics editor the Fade curve is invisible on light theme variants, both Default and System.

Paint-dynamics-editor-fade-invisible

Above: invisible Fade curve in light theme.

Paint-dynamics-editor-fade-visible

Above: same Fade curve in dark theme, now visible.

This curve's color is set in gimpdynamicsoutputeditor.c:

This was changed in ed8f80bf to { "use-fade", "fade-curve", N_("Fade"), { 0.5, 0.5, 0.5, 0.0 } } to be visible in dark themes. This works fine for the existing themes in GIMP 2.10.x, but probably some change in the theme overhaul to GIMP 3 broke it.

I don't know if there still is some "neutral curve" like mentioned in that commit that can be used.

Otherwise, the quest is to find some color that is sufficiently distinct from the other defined curves, and also is visible on both light, midgray and dark themes.

If no "neutral" solution is found the following gray values are somewhat visible on all system and default theme variants (see image below):

{ "use-fade", "fade-curve", N_("Fade"), { 0.35, 0.35, 0.35, 1.0 } }

curvecomp

Reproduction

Is the bug reproducible? Always

Reproduction steps:

  1. Paint Dynamic Menu
  2. Edit dynamic
  3. Set the Fade curve

…

Expected result: Curve to always be visible

Actual result: Curve is invisible in light themes