2.99.16 fails to compile with gcc 14.x (due to -Wincompatible-pointer-types being an error)
Looks like last version build fails with latest gcc 14.x which is now used in fedora rawhide.
Build fails with
[6/21] Compiling C object extensions/goat-exercises/goat-exercise-vala.p/meson-generated_goat-exercise-vala.c.o
FAILED: extensions/goat-exercises/goat-exercise-vala.p/meson-generated_goat-exercise-vala.c.o
/usr/bin/gcc -Iextensions/goat-exercises/goat-exercise-vala.p -Iextensions/goat-exercises -I../extensions/goat-exercises -I. -I.. -Ilibgimp -I../libgimp -I/home/tkloczko/rpmbuild/BUILD/gimp-2.99.16/libgimp -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gegl-0.4 -I/usr/include/gio-unix-2.0 -I/usr/include/json-glib-1.0 -I/usr/include/babl-0.1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -Wabsolute-value -Wdeclaration-after-statement -Wenum-conversion -Wno-strict-prototypes -Wold-style-definition -Wunused-function -Wunused-value -Werror=implicit-function-declaration -fdiagnostics-show-option -fno-common -Wformat -Wformat-security -Winit-self -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wpointer-arith -Wreturn-type -Wtype-limits -DHAVE_CONFIG_H -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security -pthread '-DGETTEXT_PACKAGE="org.gimp.extension.goat-exercises"' -MD -MQ extensions/goat-exercises/goat-exercise-vala.p/meson-generated_goat-exercise-vala.c.o -MF extensions/goat-exercises/goat-exercise-vala.p/meson-generated_goat-exercise-vala.c.o.d -o extensions/goat-exercises/goat-exercise-vala.p/meson-generated_goat-exercise-vala.c.o -c extensions/goat-exercises/goat-exercise-vala.p/goat-exercise-vala.c
../extensions/goat-exercises/goat-exercise-vala.vala: In function ‘goat_real_create_procedure’:
../extensions/goat-exercises/goat-exercise-vala.vala:42:112: error: passing argument 4 of ‘gimp_image_procedure_new’ from incompatible pointer type [-Wincompatible-pointer-types]
42 | var procedure = new Gimp.ImageProcedure(this, name, Gimp.PDBProcType.PLUGIN, this.run);
| ^
| |
| GimpValueArray * (*)(GimpProcedure *, GimpRunMode, GimpImage *, gint, GimpDrawable **, GimpValueArray *, void *) {aka struct _GimpValueArray * (*)(struct _GimpProcedure *, GimpRunMode, struct _GimpImage *, int, struct _GimpDrawable **, struct _GimpValueArray *, void *)}
In file included from ../libgimp/gimp.h:47,
from extensions/goat-exercises/goat-exercise-vala.p/goat-exercise-vala.c:27:
../libgimp/gimpimageprocedure.h:88:66: note: expected ‘GimpRunImageFunc’ {aka ‘struct _GimpValueArray * (*)(struct _GimpProcedure *, GimpRunMode, struct _GimpImage *, int, struct _GimpDrawable **, const struct _GimpValueArray *, void *)’} but argument is of type ‘GimpValueArray * (*)(GimpProcedure *, GimpRunMode, GimpImage *, gint, GimpDrawable **, GimpValueArray *, void *)’ {aka ‘struct _GimpValueArray * (*)(struct _GimpProcedure *, GimpRunMode, struct _GimpImage *, int, struct _GimpDrawable **, struct _GimpValueArray *, void *)’}
88 | GimpRunImageFunc run_func,
| ~~~~~~~~~~~~~~~~~~^~~~~~~~
../extensions/goat-exercises/goat-exercise-vala.vala: In function ‘goat_run’:
../extensions/goat-exercises/goat-exercise-vala.vala:85:10: error: assignment to ‘GtkBox *’ {aka ‘struct _GtkBox *’} from incompatible pointer type ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} [-Wincompatible-pointer-types]
85 | dialog.get_content_area().add(box);
| ^
[20/21] Generating devel-docs/g-ir-docs/g-ir-Gimp-python-html with a custom command
ninja: build stopped: cannot make progress due to previous errors.