1. 27 Oct, 2020 4 commits
  2. 26 Oct, 2020 17 commits
  3. 25 Oct, 2020 13 commits
  4. 24 Oct, 2020 6 commits
    • Jehan's avatar
      Issue #5322: [Wayland] broken splash size. · 7e6ced5c
      Jehan authored
      This is not a fix, only an extra-ugly workaround so that at the very
      least we don't end up with a splash screen taking the whole display on
      Wayland.
      
      Basically by setting 1/3 as the max splash size, a Wayland desktop with
      no scale ratio will have a splash taking a third of the screen while it
      would take 2/3 of the screen with a scale ratio of ×2 (of course, it
      will still be very broken with a scale ratio of ×3 but are there
      displays needing such high scaling?). The real fix will be when GTK/GDK
      fix their API so that it returns what the docs says it should (i.e. a
      size in "application pixels" not "device pixels"), as it does on X11,
      Windows, macOS… Then we won't create random max size and we will be able
      to properly control our splash size.
      
      Note that this neither fixes nor works around the position issue on
      Wayland (in my case, the splash was just always on top-left of the
      display).
      7e6ced5c
    • Jacob Boerema's avatar
      plug-ins: use g_message instead of g_printerr when there is data loss. · f336f86f
      Jacob Boerema authored
      After discussion with Jehan we concluded that it is better to report
      these data loss messages to the user using g_message.
      f336f86f
    • Jehan's avatar
      app: fix some glitches in the splash status text. · 3a50e52a
      Jehan authored
      These small glitches have bothered me for a while now, so I finally
      fixed these before the dev release!
      Basically there were 2 fixes:
      1. use the ink extents to compute any drawn area as this is what will be
         actually drawn.
      2. Not only expose the drawn area of the new text, but also the one of
         the previous text in order to be sure all text pixels are correctly
         reset (in case the new text is smaller than previous one). I.e. we
         must expose the smallest rectangle containing both previous and new
         area of text.
      3a50e52a
    • Jacob Boerema's avatar
    • Jacob Boerema's avatar
      plug-ins: don't try to read tiff pages with an invalid directory. · e4514567
      Jacob Boerema authored
      We didn't check whether TIFFSetDirectory succeeded nor did
      we check TIFFReadScanline for failure which can cause
      unresponsiveness.
      
      We will not try to read a tiff page if setting its directory fails
      and we will stop reading a page if reading scanline fails.
      e4514567
    • Jehan's avatar
      Issue #4922: install software-update-available from Adwaita on hicolor. · c6063183
      Jehan authored
      I took the icon directly from Adwaita repository as of today's version:
      https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/blob/master/Adwaita/scalable/status/software-update-available-symbolic.svg
      
      By being installed on our local GIMP-only hicolor, this gets picked up
      after any custom theme software-update-available version. I didn't
      install it inside the Symbolic or Color theme because anyway Adwaita
      seems only to provide a single vector version. There is a color version,
      yet as PNG icons and installed in the legacy/ section. I don't think it
      makes sense to use an icon considered as legacy by its author and
      without vector version. So I just install the symbolic version and all
      themes can fallback to it (be them symbolic icon themes or not).
      
      This icon comes from the Adwaita repository and is therefore licensed
      under the terms of either the GNU LGPL v3 or Creative Commons
      Attribution-Share Alike 3.0 United States License. See:
      https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/blob/master/COPYING
      c6063183