1. 02 May, 2003 1 commit
    • Michael Natterer's avatar
      added new function gimp_dialog_factory_add_foreign() which adds a dialog · fefaf61b
      Michael Natterer authored
      2003-05-02  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpdialogfactory.[ch]: added new function
      	gimp_dialog_factory_add_foreign() which adds a dialog that was not
      	created by the factory itself. Its identifier however must be
      	registered with the factory. Connect to all toplevel dialogs'
      	"configure_event" and remember the resulting window geometry so we
      	get session management for *all* dialogs, not only for those which
      	were open on exit.
      
      	* app/gui/dialogs.c: added the "File New" dialog. Added foreign
      	entries (without constructor) for all dialogs opened by tools.
      
      	* app/gui/dialogs-constructors.[ch]: added a constructor for
      	the file_new dialog.
      
      	* app/gui/file-new-dialog.[ch]: renamed file_new_dialog_create()
      	to file_new_dialog_new() and removed the gimage and template
      	paramaters. Adder new function file_new_dialog_set() to set
      	gimage and template after creation.
      
      	* app/gui/file-commands.c
      	* app/gui/templates-commands.c: changed accordingly.
      
      	* app/tools/gimpimagemaptool.[ch]
      	* app/tools/gimptransformtool.[ch]: added
      	"const gchar *shell_identifier" to the tool structs. Register the
      	tool dialogs using gimp_dialog_factory_add_foreign().
      
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c
      	* app/tools/gimpthresholdtool.c: set "shell_identifier" so the
      	dialogs become session managed. Fixes bug #61091.
      
      	* app/tools/gimpcroptool.c: register the crop dialog with the
      	dialog factory. Fixes bug #52849.
      
      	* app/tools/gimpcolorpickertool.c: ditto.
      
      	Unrelated:
      
      	* app/tools/gimptool.c: no need to cast the return value of
      	g_object_new().
      fefaf61b
  2. 15 Apr, 2003 1 commit
    • Michael Natterer's avatar
      check for GIMP_IS_DISPLAY(gdisp) again. · 8cee4963
      Michael Natterer authored
      2003-04-15  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptool.c: check for GIMP_IS_DISPLAY(gdisp) again.
      
      	* app/tools/gimptool.h: don't #include "gimptoolcontrol.h"
      
      	* app/tools/[all tools].c: #include "gimptoolcontrol.h"
      8cee4963
  3. 25 Mar, 2003 1 commit
    • Sven Neumann's avatar
      Makefile.am removed this header file. · 28fddfd5
      Sven Neumann authored
      2003-03-25  Sven Neumann  <sven@gimp.org>
      
      	* Makefile.am
      	* gimpintl.h: removed this header file.
      
      	* gimpmiscui.c: include libgimp-intl.h.
      
      	* gimp.c (gimp_main): call setlocale() and bind to the libgimp
      	textdomain so that plug-ins don't need to do that explicitely.
      
      	* libgimp/stdplugins-intl.h: added the functionality that used to
      	live in gimpintl.h and removed the libgimp related stuff. Got rid
      	of the INIT_I18N_UI() macro.
      
      	* plug-ins/*/*.c: removed all occurances of INIT_I18N_UI().
      	Plug-ins simply call INIT_I18N() once in their run() function.
      
      	* plug-ins/script-fu/script-fu-intl.h: added the functionality
      	that used to live in gimpintl.h and removed the libgimp related
      	stuff.
      
      	* app/Makefile.am
      	* app/gimp-intl.h: new file that defines the gettext macros for
      	the GIMP core.
      
      	* app/*/*.c: include gimp-intl.h instead of libgimp/gimpintl.h.
      
      	* plug-ins/script-fu/scripts/test-sphere.scm: fixed typos.
      28fddfd5
  4. 28 Feb, 2003 1 commit
    • Manish Singh's avatar
      app/tools/gimpbucketfilltool.c app/tools/gimpconvolvetool.c · 5bc3a7a3
      Manish Singh authored
      2003-02-27  Manish Singh  <yosh@gimp.org>
      
              * app/tools/gimpbucketfilltool.c
              * app/tools/gimpconvolvetool.c
              * app/tools/gimpcroptool.c
              * app/tools/gimpdodgeburntool.c
              * app/tools/gimperasertool.c
              * app/tools/gimpfliptool.c
              * app/tools/gimpfuzzyselecttool.c
              * app/tools/gimpinkoptions.c
              * app/tools/gimpmagnifytool.c
              * app/tools/gimpmovetool.c
              * app/tools/gimprectselecttool.c
              * app/tools/gimpselectiontool.c
              * app/tools/gimptexttool.c
              * app/tools/gimptransformtool.c
              * app/widgets/gimpcellrendererviewable.c
              * app/widgets/gimpcontainertreeview.c: remove unecessary G_OBJECT()
              from g_object_set calls.
      
              * plug-ins/common/bumpmap.c: use g_signal_handlers_(un)block_by_func
              instead of gtk_signal_handler_(un)block_by_data.
      5bc3a7a3
  5. 26 Feb, 2003 2 commits
    • Sven Neumann's avatar
      added a writeable field to GimpData and set it from · 0ceeeb02
      Sven Neumann authored
      2003-02-26  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpdata.[ch]: added a writeable field to GimpData and
      	set it from gimp_data_set_filename().
      
      	* app/gui/brushes-menu.c
      	* app/gui/gradients-menu.c
      	* app/gui/palettes-menu.c
      	* app/gui/patterns-menu.c
      	* app/widgets/gimpbrushfactoryview.c
      	* app/widgets/gimpdatafactoryview.c
      	* app/widgets/gimpgradienteditor.c: look at data->writeable when
      	setting widgets sensitivity.
      
      	* app/gui/user-install-dialog.c (user_install_dialog_create): reduce
      	some of the dialog clutter by not showing the directories created for
      	plug-ins.
      
      	* app/core/gimpviewable.[ch]: added a default_stock_id to
      	GimpViewableClass so we don't need to hold a copy in each instance.
      	Added accessor functions to set and get the stock_id.
      
      	* app/core/gimptoolinfo.c
      	* app/gui/dialogs-constructors.c
      	* app/gui/image-menu.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimphistogramtool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimptransformtool.c
      	* app/widgets/gimpcellrendererviewable.c
      	* app/widgets/gimppreview.c
      	* app/widgets/gimptoolbox.c: use gimp_viewable_get_stock_id().
      
      	* app/text/gimptextlayer.c: set a text icon as default stock_id.
      0ceeeb02
    • Michael Natterer's avatar
      added "gchar *stock_id" to the GimpViewable struct. It is used by the GUI · 305db405
      Michael Natterer authored
      2003-02-26  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpviewable.[ch]: added "gchar *stock_id" to the
      	GimpViewable struct. It is used by the GUI if the get_preview()
      	functions return NULL. Default to GTK_STOCK_DIALOG_QUESTION.
      
      	* app/core/gimptoolinfo.[ch]: set the tool's stock_id. Removed
      	the cached GdkPixbuf. Don't implement any preview function
      	so the GUI uses the stock_id.
      
      	* app/tools/tool_manager.c: removed GdkPixbuf creation, removed
      	the #warning about the buggy way we created the pixbuf.
      
      	* app/gui/dialogs-constructors.c
      	* app/gui/image-menu.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimphistogramtool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimptransformtool.c
      	* app/widgets/gimptoolbox.c: use viewable->stock_id instead
      	of tool_info->stock_id.
      
      	* app/core/gimpbrush.c
      	* app/core/gimpgradient.c
      	* app/core/gimpimagefile.c
      	* app/core/gimpundo.c: simplified get_preview() implementations:
      
      	- never scale previews up, only down.
      	- don't render white or checks backgrounds but simply return
      	  TempBufs with alpha and let the preview system do its job.
      	- don't add padding but simply return previews smaller than
      	  requested.
      
      	* app/display/gimpdisplayshell-render.[ch]: added
      	"render_blend_white", a 2d lookup table for blending on white,
      	just as the check lookup tables. Added "render_white_buf".
      
      	* app/widgets/gimppreview.[ch]: changed a lot:
      
      	- don't render the preview's border into the buffer.
      	- added "GdkGC *border_gc" and draw the preview's border in expose()
      	  using gdk_draw_rectangle().
      	- added "GdkPixbuf *no_preview_pixbuf" and create it in
      	  gimp_preview_real_render() if gimp_viewable_get_preview()
      	  returned NULL.
      	- factored the actual preview rendering out to
      	  gimp_preview_render_to_buffer(). Added configurable background
      	  rendering for the preview itself and it's padding area
      	  (the area the preview is larger than the buffer returned
      	  by gimp_viewable_get_preview()).
      	- changed gimp_preview_render_and_flush() to
      	  gimp_preview_render_preview() and added "inside_bg" and
      	  "outside_bg" parameters.
      	- use the new render buffers for blending on white.
      
      	* app/widgets/gimpbrushpreview.c
      	* app/widgets/gimpbufferpreview.c
      	* app/widgets/gimpdrawablepreview.c
      	* app/widgets/gimpgradientpreview.c
      	* app/widgets/gimpimagepreview.c
      	* app/widgets/gimppalettepreview.c
      	* app/widgets/gimppatternpreview.c: don't create large white
      	TempBufs to center the previews in but simply set the TempBuf's
      	offsets to get them centered. Simplified & cleaned up many preview
      	render functions. Pass the correct GimpPreviewBG modes to
      	gimp_preview_render_preview().
      
      	* app/widgets/gimpcellrendererviewable.[ch]: new GtkCellRenderer
      	class derived from GtkCellRendererPixbuf which knows how
      	to use gimp_viewable_get_preview_size() and renders the
      	viewable's stock item if no preview can be created.
      
      	* app/widgets/gimpcontainertreeview.c: added a GtkTreeCellDataFunc
      	which creates the preview pixbuf if needed so we don't create it
      	unconditionally upon item insertion. Fixed preview size assertion
      	to use GIMP_PREVIEW_MAX_SIZE, not "64". Block "selection_changed"
      	while reordering the selected item.
      
      	* app/widgets/gimpcontainerview.c: cosmetic.
      
      	* app/widgets/gimpimagefilepreview.[ch]
      	* app/widgets/gimptoolinfopreview.[ch]
      	* app/widgets/gimpundopreview.[ch]: removed because the default
      	implementation is good enough.
      
      	* app/widgets/Makefile.am
      	* app/widgets/widgets-types.h
      	* app/widgets/gimppreview-utils.c: changed accordingly.
      
      	* app/gui/dialogs-constructors.[ch]
      	* app/gui/dialogs-menu.c
      	* app/gui/dialogs.c
      	* app/gui/image-menu.c
      	* app/gui/toolbox-menu.c: register grid and tree view variants
      	of the document history.
      
      	Unrelated:
      
      	* app/gui/gui.c (gui_exit_finish_callback): disconnect from
      	signals earlier.
      
      	* app/gui/user-install-dialog.c: create the "tool-options" subdir
      	of the user's ~/.gimp-1.3 directory.
      305db405
  6. 14 Feb, 2003 1 commit
    • Michael Natterer's avatar
      Moved the undo step implementations to the core and pass around lots of · 7a6a8d9d
      Michael Natterer authored
      2003-02-14  Michael Natterer  <mitch@gimp.org>
      
      	Moved the undo step implementations to the core and pass around
      	lots of "const gchar *undo_desc". Fixes bug #104367.
      
      	* app/Makefile.am
      	* app/undo.[ch]: removed...
      
      	* app/core/Makefile.am
      	* app/core/gimpimage-undo-push.[ch]: ...and added here.
      
      	* app/paint/Makefile.am
      	* app/tools/Makefile.am
      	* app/paint/gimppaintcore-undo.[ch]
      	* app/tools/gimptransformtool-undo.[ch]: new files for the
      	paint and transform undos.
      
      	* app/core/gimppaintinfo.[ch]: added a blurb.
      
      	* app/paint/gimpairbrush.c
      	* app/paint/gimpclone.c
      	* app/paint/gimpconvolve.c
      	* app/paint/gimpdodgeburn.c
      	* app/paint/gimperaser.c
      	* app/paint/gimppaintbrush.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimppencil.c
      	* app/paint/gimpsmudge.c
      	* app/paint/paint-types.h
      	* app/paint/paint.c: pass the blurb when registering the core.
      
      	* app/core/gimpdrawable.[ch]
      	* app/core/gimpimage.[ch]
      	* app/core/gimpimage-mask-select.[ch]
      	* app/core/gimpimage-mask.[ch]
      	* app/core/gimpimagemap.[ch]
      	* app/core/gimplayer-floating-sel.[ch]: added "undo_desc" parameters
      	to all undo pushing helper functions.
      
      	* app/undo_history.c
      	* app/core/gimpchannel.c
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable-bucket-fill.c
      	* app/core/gimpdrawable-desaturate.c
      	* app/core/gimpdrawable-equalize.c
      	* app/core/gimpdrawable-invert.c
      	* app/core/gimpdrawable-offset.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-guides.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-qmask.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage-undo.c
      	* app/core/gimpitem.c
      	* app/core/gimplayer.c
      	* app/core/gimplayermask.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/file/file-open.c
      	* app/file/file-save.c
      	* app/gui/channels-commands.c
      	* app/gui/file-commands.c
      	* app/gui/file-open-dialog.c
      	* app/gui/image-commands.c
      	* app/gui/layers-commands.c
      	* app/gui/paths-dialog.c
      	* app/gui/select-commands.c
      	* app/gui/vectors-commands.c
      	* app/text/gimptext-compat.c
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c
      	* app/widgets/gimpchannellistview.c
      	* app/widgets/gimpdrawablelistview.c
      	* app/widgets/gimpselectioneditor.c
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/guides.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/selection.pdb
      	* tools/pdbgen/pdb/selection_tools.pdb: changed accordingly: pass
      	"undo_desc" strings, changed includes or simply removed inclusion
      	of "undo.h". Some random cleanups.
      
      	* tools/pdbgen/pdb/guides.pdb: cleaned up a lot. Fixed
      	gimp_image_find_next_guide() to not return guides with
      	position < 0 (and made it shorter and readable).
      
      	* app/pdb/color_cmds.c
      	* app/pdb/drawable_cmds.c
      	* app/pdb/guides_cmds.c
      	* app/pdb/layer_cmds.c
      	* app/pdb/selection_cmds.c
      	* app/pdb/selection_tools_cmds.c: regenerated.
      7a6a8d9d
  7. 13 Feb, 2003 1 commit
    • Michael Natterer's avatar
      changed FOO_UNDO enum values to GIMP_UNDO_FOO. · b600fd86
      Michael Natterer authored
      2003-02-13  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/core-enums.[ch]: changed FOO_UNDO enum values to
      	GIMP_UNDO_FOO.
      
      	* app/undo.[ch]: removed the undo group wrappers.
      
      	* app/undo_history.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-mask.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-qmask.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage-undo.c
      	* app/core/gimpimage.c
      	* app/core/gimpitem.c
      	* app/core/gimplayer-floating-sel.c
      	* app/core/gimplayer.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/gui/channels-commands.c
      	* app/gui/image-commands.c
      	* app/gui/layers-commands.c
      	* app/paint/gimppaintcore.c
      	* app/text/gimptext-compat.c
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/undo.pdb: changed accordingly. Pass meaningful
      	undo names to gimp_image_undo_group_start().
      
      	* app/pdb/layer_cmds.c
      	* app/pdb/undo_cmds.c: regenerated.
      b600fd86
  8. 10 Feb, 2003 1 commit
    • Michael Natterer's avatar
      connect to GimpTransformOptions' "notify" signal and update grid and path · 58d780e0
      Michael Natterer authored
      2003-02-10  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptransformtool.[ch]: connect to GimpTransformOptions'
      	"notify" signal and update grid and path drawing accordingly.
      
      	* app/tools/gimptransformoptions.c: removed the same stuff here.
      	Doesn't depend on the tool_manager any more.
      
      	* app/tools/gimpselectionoptions.c
      	* app/tools/paint_options.c: don't #include "tool_manager.h"
      58d780e0
  9. 08 Feb, 2003 1 commit
    • Michael Natterer's avatar
      app/tools/transform_options.[ch] removed... · d24dac68
      Michael Natterer authored
      2003-02-08  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/transform_options.[ch]
      	* app/tools/selection_options.[ch]: removed...
      
      	* app/tools/gimpselectionoptions.[ch]
      	* app/tools/gimptransformoptions.[ch]: ...and added here.
      
      	* app/tools/Makefile.am
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpellipseselecttool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimpsheartool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectoroptions.h: changed accordingly.
      
      	* app/tools/gimpinkoptions.[ch]: renamed "sensitivity" to
      	"size_sensitivity". Reordered properties. Added utility
      	constructors blob_button_new() and brush_widget_new().
      
      	* app/tools/gimpinktool.c: changed accordingly.
      d24dac68
  10. 07 Feb, 2003 1 commit
    • Michael Natterer's avatar
      Added object properties for almost all tool_options values and registered · eeec3ced
      Michael Natterer authored
      2003-02-07  Michael Natterer  <mitch@gimp.org>
      
      	Added object properties for almost all tool_options values
      	and registered lots of enums with the type system:
      
      	Part I (enum and type cleanup):
      
      	* app/core/core-enums.[ch]
      	* app/core/core-types.h: removed InternalOrientaionType and
      	register GimpOrientationType. Register GimpChannelOps.
      	Removed GimpToolOptionsGUIFunc.
      
      	* app/xcf/xcf-private.h: added XcfOrientationType with the
      	same values as the old InternalOrientationType
      
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c: translate between GimpOrientationType and
      	XcfOrientationType.
      
      	* app/core/gimpdrawable-transform-utils.[ch]
      	* app/core/gimpdrawable-transform.[ch]
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-duplicate.c
      	* app/core/gimpimage-guides.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage.h
      	* app/display/gimpdisplayshell.c
      	* tools/pdbgen/stddefs.pdb
      	* tools/pdbgen/pdb/transform_tools.pdb: changed accordingly.
      
      	* app/pdb/guides_cmds.c
      	* app/pdb/transform_tools_cmds.c
      	* libgimp/gimpenums.h
      	* libgimpproxy/gimpproxytypes.h
      	* plug-ins/script-fu/script-fu-constants.c
      	* tools/pdbgen/enums.pl: regenerated.
      
      	* libgimptool/gimptoolenums.[ch]: added GimpTransformGridType.
      
      	* libgimptool/gimptooltypes.h: removed GimpToolOptionsResetFunc,
      	added GimpToolOptionsGUIFunc.
      
      	Part II (tool options changes):
      
      	* app/config/gimpconfig-utils.c (gimp_config_reset_properties):
      	don't reset object properties because they have NULL as default
      	value.
      
      	* app/widgets/gimppropwidgets.[ch]: added
      	gimp_prop_[enum|boolean]_radio_frame_new(),
      	gimp_prop_paint_mode_menu_new() and gimp_prop_scale_entry_new(),
      	which are all needed by the new tool options GUI code.
      
      	* app/tools/tool_options.[ch]: removed the "reset_func" since
      	the virtual reset() method is used now.
      
      	* app/paint/gimpairbrushoptions.[ch]
      	* app/paint/gimpcloneoptions.[ch]
      	* app/paint/gimpconvolveoptions.[ch]
      	* app/paint/gimpdodgeburnoptions.[ch]
      	* app/paint/gimperaseroptions.[ch]
      	* app/paint/gimppaintoptions.[ch]
      	* app/paint/gimpsmudgeoptions.[ch]: added properties all over the
      	place and removed the widget and default_value members from
      	the structs. Renamed some values (e.g. s/type/clone_type/).
      	Don't #include <gtk/gtk.h>.
      
      	* app/paint/gimpairbrush.c
      	* app/paint/gimpclone.c
      	* app/paint/gimpconvolve.c
      	* app/paint/gimpdodgeburn.c
      	* app/paint/gimperaser.c
      	* app/paint/gimppaintbrush.c
      	* app/paint/gimppaintcore-stroke.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimppencil.c
      	* app/paint/gimpsmudge.c
      	* app/paint/paint-types.h
      	* app/paint/paint.c: changed accordingly. Don't #include <gtk/gtk.h>.
      
      	* tools/pdbgen/pdb/paint_tools.pdb: changed accordingly.
      
      	* app/pdb/paint_tools_cmds.c: regenerated.
      
      	* app/tools/gimpblendoptions.[ch]
      	* app/tools/gimpbucketfilloptions.[ch]
      	* app/tools/gimpcolorpickeroptions.[ch]
      	* app/tools/gimpcropoptions.[ch]
      	* app/tools/gimpflipoptions.[ch]
      	* app/tools/gimpinkoptions.c
      	* app/tools/gimpmagnifyoptions.[ch]
      	* app/tools/gimpmeasureoptions.[ch]
      	* app/tools/gimpmoveoptions.[ch]
      	* app/tools/gimptextoptions.c
      	* app/tools/paint_options.[ch]
      	* app/tools/selection_options.[ch]
      	* app/tools/transform_options.[ch]: ditto: added properties and
      	removed widget and default_value stuff. Removed most reset functions.
      	Use gimp_prop widgets all over the place, renamed some values
      	as above.
      
      	* app/tools/Makefile.am
      	* app/tools/gimpairbrushtool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpconvolvetool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimperasertool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimpsheartool.c
      	* app/tools/gimpsmudgetool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectoroptions.c: changed accordingly. Ported
      	the paint_options GUI constructors to gimp_prop widgets.
      
      	* app/widgets/gimpselectioneditor.c
      	* app/gui/tool-options-dialog.c: changed accordingly.
      eeec3ced
  11. 05 Feb, 2003 1 commit
    • Michael Natterer's avatar
      Made GimpToolOptions a GimpContext subclass and objectified all tool · aa9f82d1
      Michael Natterer authored
      2003-02-05  Michael Natterer  <mitch@gimp.org>
      
      	Made GimpToolOptions a GimpContext subclass and objectified
      	all tool options types.
      
      	* app/core/core-types.h: replaced GimpToolOptionsNewFunc by
      	GimpToolOptionsGUIFunc.
      
      	* libgimpproxy/gimpproxytypes.h: regenerated.
      
      	* app/core/gimppaintinfo.[ch]: added "GType paint_options_type".
      
      	* app/core/gimptoolinfo.[ch]: added "GType tool_options_type",
      	removed tool_info->context since GimpToolOptions are a GimpContext
      	now. Added "gboolean use_context" as a temp_hack.
      
      	* libgimptool/gimptooltypes.h: added the tool_options_type to
      	the tool registering callback.
      
      	* app/tools/tool_options.[ch]: is a real GimpContext subclass now.
      
      	* app/paint/paint-types.h
      	* app/paint/paint.c: added the paint_options_type to the paint
      	registering stuff.
      
      	* app/paint/gimppaintoptions.[ch]: is a real GimpToolOptions
      	subclass now.
      
      	* app/paint/Makefile.am
      	* app/paint/gimpairbrushoptions.[ch]
      	* app/paint/gimpcloneoptions.[ch]
      	* app/paint/gimpconvolveoptions.[ch]
      	* app/paint/gimpdodgeburnoptions.[ch]
      	* app/paint/gimperaseroptions.[ch]
      	* app/paint/gimpsmudgeoptions.[ch]: new files holding
      	GimpPaintOptions subclasses.
      
      	* app/paint/gimpairbrush.[ch]
      	* app/paint/gimpclone.[ch]
      	* app/paint/gimpconvolve.[ch]
      	* app/paint/gimpdodgeburn.[ch]
      	* app/paint/gimperaser.[ch]
      	* app/paint/gimppaintbrush.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimppencil.[ch]
      	* app/paint/gimpsmudge.[ch]: removed paint options stuff, lots
      	of related changed & cleanups.
      
      	* tools/pdbgen/pdb/paint_tools.pdb: changed accordingly.
      
      	* app/pdb/paint_tools_cmds.c: regenerated.
      
      	* app/tools/Makefile.am
      	* app/tools/gimpblendoptions.[ch]
      	* app/tools/gimpbucketfilloptions.[ch]
      	* app/tools/gimpcolorpickeroptions.[ch]
      	* app/tools/gimpcropoptions.[ch]
      	* app/tools/gimpflipoptions.[ch]
      	* app/tools/gimpinkoptions.[ch]
      	* app/tools/gimpmagnifyoptions.[ch]
      	* app/tools/gimpmeasureoptions.[ch]
      	* app/tools/gimpmoveoptions.[ch]
      	* app/tools/gimptextoptions.[ch]
      	* app/tools/gimpvectoroptions.[ch]: new files holding the various
      	tool options classes.
      
      	* app/tools/selection_options.[ch]
      	* app/tools/transform_options.[ch]: made them objects.
      
      	* app/tools/paint_options.[ch]: contains only the paint_options
      	GUI and reset stuff.
      
      	* app/tools/tools-types.h: removed SelectionOptions typedef for
      	now.
      
      	* app/tools/[all tools]: removed the tool options stuff except
      	some GUI constructors. Tons of related changes.
      
      	* app/tools/tool_manager.[ch]: changed tool registration / restore /
      	switching accordingly.
      
      	* app/widgets/gimpdrawablelistview.c
      	* app/widgets/gimpselectioneditor.c: changed accordingly.
      aa9f82d1
  12. 03 Feb, 2003 1 commit
    • Sven Neumann's avatar
      app/display/gimpdisplayshell-selection.[ch] app/tools/gimpblendtool.c · 2c708aca
      Sven Neumann authored
      2003-02-04  Sven Neumann  <sven@gimp.org>
      
      	* app/display/gimpdisplayshell-selection.[ch]
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpthresholdtool.c
      	* app/tools/gimptransformtool.c: misc trivial changes and cleanup.
      
      	* app/widgets/gimppropwidgets.[ch]: added gimp_prop_unit_menu_new()
      	and removed the scale widget again.
      
      	* app/tools/gimptexttool.c: replaced the size scale entry with a
      	spinbutton and made the unit menu working.
      
      	* app/text/gimptext.c: increased the upper boundary for the font
      	size again now that we don't use a scale any longer.
      2c708aca
  13. 03 Jan, 2003 1 commit
    • Michael Natterer's avatar
      don't set paused_count to 0. · ef3f572a
      Michael Natterer authored
      2003-01-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptoolcontrol.c (gimp_tool_control_halt): don't
      	set paused_count to 0.
      
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimppathtool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectortool.c
      	* app/tools/tool_manager.c: removed comments about doing so.
      ef3f572a
  14. 17 Dec, 2002 1 commit
    • Michael Natterer's avatar
      app/tools/gimptransformtool.c replaced the totally unclear (to the user) · 6af7df62
      Michael Natterer authored
      2002-12-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptransformtool.c
      	* app/tools/transform_options.[ch]: replaced the totally unclear
      	(to the user) way we used to calculate the number of grid lines
      	from the value entered in the "Density" spinbutton by a system
      	where the user has the choice between the number of grid lines to
      	display and the spacing between the displayed grid lines. Replaced
      	the "Show Grid" toggle by an option menu to choose the grid type
      	from. (idea from drc on #gimp).
      6af7df62
  15. 18 Nov, 2002 1 commit
    • Michael Natterer's avatar
      removed public function gimp_transform_tool_transform_tiles() and made it · c8a98076
      Michael Natterer authored
      2002-11-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptransformtool.[ch]: removed public function
      	gimp_transform_tool_transform_tiles() and made it the default
      	implementation of the transform() virtual function. Added
      	"const gchar *progress_text" to GimpTransformTool so it is
      	available for the new default implementation. Cleanup.
      
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: removed transform() implementations
      	and set transform_tool->progress_text accordingly. Even more
      	cleanup.
      c8a98076
  16. 17 Nov, 2002 1 commit
    • Michael Natterer's avatar
      compare the old and new angle using an epsilon of 0.0001 degrees so we · 7476328f
      Michael Natterer authored
      2002-11-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimprotatetool.c (roatate_angle_changed): compare the
      	old and new angle using an epsilon of 0.0001 degrees so we don't
      	get double "angle changed" because of rounding foobar.
      
      	* app/tools/gimptransformtool.c: made GimpTransformTool subclasses
      	which don't use the grid (namely the flip tool) work correctly
      	again by looking at transform_tool->use_grid more often.
      7476328f
  17. 14 Nov, 2002 1 commit
    • Michael Natterer's avatar
      Transform tool cleanup: · 7ee99ea3
      Michael Natterer authored
      2002-11-14  Michael Natterer  <mitch@gimp.org>
      
      	Transform tool cleanup:
      
      	* libgimptool/gimptoolenums.[ch]: removed the TransformState enum.
      
      	* app/tools/gimptransformtool.[ch]: don't dispatch everything
      	through the transform() virtual function. Added new vitrual
      	functions dialog(), prepare(), motion() and recalc(). Do only the
      	actual transform in transform(). Moved lots of logic which was
      	duplicated in each subclass' transform() here. Cleanup.
      
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: changed accordingly: moved code from
      	transform() to the other method imlementations. Removed duplicated
      	logic which is now done by our parent class. Makes everything
      	smaller and more readable.
      
      	InfoDialog cleanup:
      
      	* app/gui/info-dialog.c: removed the "delete_event" callback so
      	InfoDialog users can decide themselves what to do.
      
      	* app/gui/info-window.c
      	* app/tools/gimpmeasuretool.c: changed accordingly.
      
      	* app/tools/gimpcolorpickertool.c: ditto. Moved info_dialog
      	creation to a utility function to improve code readbility.
      
      	* app/tools/gimpcroptool.c: ditto. Added a "Cancel" button which
      	really cancels the tool instead of just hiding the dialog.
      
      	* app/tools/gimptransformtool.c: added a "Cancel" button here too.
      7ee99ea3
  18. 01 Sep, 2002 1 commit
    • Michael Natterer's avatar
      GimpViewableDialogs everywhere, cleanup: · ce956702
      Michael Natterer authored
      2002-09-01  Michael Natterer  <mitch@gimp.org>
      
      	GimpViewableDialogs everywhere, cleanup:
      
      	* libgimpwidgets/gimpstock.c: added texts for the RESIZE, SCALE
      	and CROP stock items.
      
      	* app/widgets/gimpviewabledialog.c: update the title when the
      	viewable's name changes.
      
      	* app/gui/color-notebook.[ch]: added color_notebook_viewable_new()
      	which creates a GimpViewableDialog.
      
      	* app/widgets/gimpgradienteditor.[ch]
      	* app/gui/colormap-editor-commands.c
      	* app/gui/file-new-dialog.c
      	* app/gui/gradient-editor-commands.c
      	* app/gui/palette-editor-commands.c
      	* app/undo_history.c: use GimpViewableDialogs and the new
      	color_notebook constructor.
      
      	* app/gui/convert-dialog.c: #include "widgets/gimpviewabledialog.h"
      
      	* app/gui/image-commands.c
      	* app/gui/info-dialog.c
      	* app/gui/resize-dialog.c: minor cleanups.
      
      	* app/gui/info-window.c: cleaned up the whole thing, esp. the
      	"Extended" page. Added HSV color display to the color picker
      	frame.  Set the icons as frame titles, stuff...
      
      	* app/tools/gimpimagemaptool.[ch]: removed "shell_title",
      	"shell_name" and "stock_id" from the GimpImageMapTool struct
      	because they can be obtained from the tool's GimpToolInfo object.
      
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimpthresholdtool.c: changed accordingly.
      
      	* app/tools/gimphistogramtool.c: same here: take values from
      	tool->tool_info instead of hardcoding them.
      
      	* app/tools/gimpcroptool.[ch]: removed the static crop dialog
      	variables and added them to the GimpCropTool struct. Feels safer
      	and makes the callback code much simpler. Use stock items for the
      	dialog's "Resize" and "Crop" buttons.
      
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimprotatetool.c: for consistency don't name the tools
      	"Blah Tool", also the dialog titles need to match the menu
      	entries.
      
      	Unrelated:
      
      	* libgimpwidgets/gimpwidgets.c: the recently changed, gtk-doc
      	comment was correct, as gtk-doc takes the parameter names from
      	the header, not the .c file.
      
      	* app/tools/gimptransformtool.c: set the transform tool's state to
      	TRANSFORM_CREATING after changing displays, so the initial matrix
      	components are saved correctly for the "Reset" function.
      ce956702
  19. 16 Jun, 2002 1 commit
    • Michael Natterer's avatar
      Fix for #85201: · aa7be287
      Michael Natterer authored
      2002-06-16  Michael Natterer  <mitch@gimp.org>
      
      	Fix for #85201:
      
      	* app/tools/gimpfliptool.c: set the toggle_cursor correctly.
      
      	* app/tools/gimptransformtool.c: if "use_grid" is FALSE, skip the
      	cursor update stuff and chain up directly.
      
      	Misc tool->control options fixes:
      
      	* app/tools/gimppainttool.c: set "motion_mode" to
      	GIMP_MOTION_MODE_EXACT.
      
      	* app/tools/gimpairbrushtool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpconvolvetool.c
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimperasertool.c
      	* app/tools/gimppaintbrushtool.c
      	* app/tools/gimpsmudgetool.c: don't touch "motion_mode" here.
      
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimptransformtool.c: set "scroll_lock" to TRUE and
      	"preserve" to FALSE.
      
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: don't touch them here.
      
      	* app/tools/gimphistogramtool.[ch]: derive it from GimpImageMapTool
      	so it inherits it's control settings.
      
      	* app/tools/gimpellipseselecttool.c: don't set "preserve" to TRUE.
      
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmovetool.c: code formating paranoia.
      
      	* app/tools/gimptoolcontrol.c: fixed indentation.
      aa7be287
  20. 10 May, 2002 1 commit
    • Hans Breuer's avatar
      add appconfig.lib. Statically link libgimptool/gimptool.lib. · 8522a847
      Hans Breuer authored
      2001-05-11  Hans Breuer  <hans@breuer.org>
      
      	* app/makefile.msc : add appconfig.lib. Statically
      	link libgimptool/gimptool.lib.
      
      	* app/main.c : use gimp_locale_directory()
      
      	* app/config/gimpconfig-utils.c : <string.h>
      
      	* app/config/makefile.msc : add gimpscanner
      
      	* app/core/gimpimagefile.c : some G_OS_WIN32 mess to get
      	mkdir() and chmod()
      
      	* app/display/gimpdisplayshell.c
      	  app/plug-in/plug-in-progrss.c
      	  app/tool/gimpcolorpickertool.c
      	  app/tool/gimpcroptool.c
      	  app/tool/gimpmeasuretool.c
      	  app/tool/gimpperspectivetool.c
      	  app/tool/gimprotatetool.c
      	  app/tool/gimpscaletool.c
      	  app/tool/gimpsheartool.c
      	  app/tool/gimptransformtool.c
      	  app/widgets/gimpcolormapeditor.c
      	  app/widgets/gimpcolorpanel.c
      	  app/widgets/gimptoolbox-color-area.c
      	add #ifdef __GNUC__ to avoid breaking on non standard
      	pragma #warning
      
      	* app/tools/makefile.msc : add gimptoolcontrol remove
      	tools-enum
      
      	* app/tools/tool_manager.c : need to include
      	libgimptool/gimptoolcontrol.h after core includes
      	otherwise we would compile without prototypes or
      	break miserably
      
      	* app/gui/plug-in-menus.c : replace LOCALEDIR with
      	gimp_locale_directory ()
      
      	* app/gui/preferences-dialog.c (prefs_notebook_append_page) :
      	only try to gdk_pixbuf_new_from_file() with a valid filename.
      	It should simply return NULL otherwise, but fails if the
      	filename is an empty string.
      
      	* app/paint-funcs/makefile.msc : add -FImsvc_recommended_pragmas.h
      
      	* app/widgets/gimpcolormapeditor.c : the 'row'
      	allocated needs to be 'xn * cellsize * 2' (to avoid
      	accessing unowned memory) not only width, which has
      	become allocation.width by someone commenting out
      	the correct size calculation
      
      	* app/widgets/gimpdialogfactory.c : varargs to macros
      	are GCCism or at least non standard. #define DEBUG
      	to g_print or nothing - without arguments - does fix
      	it somewhat dirty as the compiler needs to tolerate
      	the '(blah, foo, bar);' statement than
      
      	* app/widgets/makefile.msc : updated
      
      	* app/xcf/makefile.msc : add -FImsvc_recommended_pragmas.h
      
      	* etc/gimprc.win32 : use ';' to separate theme-path
      
      	* libgimpbase/gimpenv.c : #include <stdio.h>
      	for sprintf()
      
      	* app/widgets/gimpdnd.c (gimp_dnd_set_file_data) :
      	the passed in vals chunk is not always null-terminated
      	(at least not on win32). Use the length parameter too
      	to avoid reading junk filenames.
      
      	* libgimp/gimp.def : export gimp_image_get_name()
      
      	* libgimpbase/gimpbase.def : export gimp_locale_directory()
      	* libgimpbase/gimpenv.[ch] : added gimp_locale_directory ()
      
      	* libgimpbase/makefile.msc : define DATADIR and SYSCONFDIR
      	to empty string to let gimp find its files in the common
      	place (win32: relative to the top level gimp dir)
      
      	* plug-ins/common/pixelize.c : <string.h>
      
      	* plug-ins/flame/cmap.c : #include <glib.h> for g_random_int()
      
      	* plug-ins/makefile.msc : -FImsvc_recommended_pragams.h
      	and a little hack to give imagemap the prototypes it
      	desires without changing the lexed source
      
      	* themes/Default/images/makefile.msc : now added (see below)
      
      	* themes/Default/images/stock-button-reset.png : made it binary
      8522a847
  21. 08 May, 2002 1 commit
    • Michael Natterer's avatar
      Started to get rid of the gdisplays_foo() functions in · a3bb0b0d
      Michael Natterer authored
      2002-05-08  Michael Natterer  <mitch@gimp.org>
      
      	Started to get rid of the gdisplays_foo() functions in
      	app/display/gimpdisplay-foreach.[ch]. Work in progress...
      
      	* app/core/gimp.[ch]: added the display list to the Gimp object
      	(as a GimpList of GimpObjects). This way we get more independent
      	from whether there is GUI or not, as gimp->displays will simply
      	be an empty list for the --no-interface case.
      
      	* app/display/gimpdisplay.[ch]: Removed the global "display_list"
      	and "display_num" variables. Use gimp->displays instead.
      
      	* app/display/gimpdisplay-foreach.[ch]: renamed most functions
      	from gdisplays_foo() to gimp_displays_foo() and pass them a Gimp
      	pointer.
      
      	* app/core/gimpimage.[ch]: added a "flush" signal.
      
      	* app/display/gimpdisplay-handlers.c: connect to "flush" and call
      	gimp_display_flush() in the callback.
      
      	* tools/pdbgen/pdb/display.pdb: use gimp_displays_flush(gimp)
      	here and only here.
      
      	* app/pdb/display_cmds.c: regenerated.
      
      	* app/app_procs.c
      	* app/gui/gui.c
      	* app/gui/preferences-dialog.c:
      	s/gdislays_foo()/gimp_displays_foo(gimp)/
      
      	* app/image_map.c
      	* app/undo_history.c
      	* app/display/gimpdisplayshell-callbacks.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/display/gimpdisplayshell-layer-select.c
      	* app/display/gimpdisplayshell-scale.c
      	* app/gui/channels-commands.c
      	* app/gui/colormap-editor-commands.c
      	* app/gui/convert-dialog.c
      	* app/gui/drawable-commands.c
      	* app/gui/edit-commands.c
      	* app/gui/file-commands.c
      	* app/gui/image-commands.c
      	* app/gui/layers-commands.c
      	* app/gui/offset-dialog.c
      	* app/gui/qmask-commands.c
      	* app/gui/select-commands.c
      	* app/gui/vectors-commands.c
      	* app/paint/gimpairbrush.c
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimpthresholdtool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectortool.c
      	* app/widgets/gimpbufferview.c
      	* app/widgets/gimpchannellistview.c
      	* app/widgets/gimpcomponentlistitem.c
      	* app/widgets/gimpdocumentview.c
      	* app/widgets/gimpdrawablelistitem.c
      	* app/widgets/gimpdrawablelistview.c
      	* app/widgets/gimpimageview.c
      	* app/widgets/gimpitemlistitem.c
      	* app/widgets/gimpitemlistview.c
      	* app/widgets/gimplayerlistitem.c
      	* app/widgets/gimplayerlistview.c
      	* app/widgets/gimpvectorslistview.c: replaced gdisplays_flush()
      	with calls to gimp_image_flush(gimage). Removed inclusion of
      	"display/gimpdisplay-foreach.h" from most files.
      a3bb0b0d
  22. 03 May, 2002 2 commits
    • Michael Natterer's avatar
      devel-docs/Makefile.am new file documenting the core's include policy. · a74a8997
      Michael Natterer authored
      2002-05-03  Michael Natterer  <mitch@gimp.org>
      
      	* devel-docs/Makefile.am
      	* devel-docs/includes.txt: new file documenting the core's
      	include policy.
      
      	* HACKING: mention it here.
      
      	* libgimptool/gimptooltypes.h: removed GimpToolOptions here.
      
      	* app/core/core-types.h: and added it here. This is a temp hack
      	needed because GimpToolInfo needs to know the GimpToolOptions
      	type.
      
      	* libgimpproxy/gimpproxytypes.h: regenerated.
      
      	* libgimptool/gimptoolmodule.h: don't include gimptooltypes.h here...
      	* libgimptool/gimptoolmodule.c: ...but here.
      
      	* app/config/gimpconfig-params.c: include "libgimpbase/gimpbase.h"
      	entirely, not single files from it.
      
      	* app/core/gimp.c
      	* app/core/gimpcontext.c
      	* app/core/gimpcoreconfig.c
      	* app/core/gimpdatafactory.c
      	* app/core/gimpdocuments.c
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable-bucket-fill.c
      	* app/core/gimpdrawable-offset.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpdrawable.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-duplicate.c
      	* app/core/gimpimage-guides.c
      	* app/core/gimpimage-mask.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-new.c
      	* app/core/gimpimage-projection.c
      	* app/core/gimpimage-qmask.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage.c
      	* app/core/gimpitem.c
      	* app/core/gimpmodules.c
      	* app/core/gimppaintinfo.c
      	* app/core/gimpparasite.c
      	* app/core/gimppreviewcache.c
      	* app/core/gimptoolinfo.c
      	* app/core/gimpunit.c: include "core-types.h" and no other types file.
      
      	* app/display/gimpdisplay.c
      	* app/display/gimpdisplayshell-callbacks.c
      	* app/display/gimpdisplayshell.c: include "tools/tools-types.h"
      	instead of "libgimptool/gimptooltypes.h", warn about inclusion
      	on "gui/gui-types.h"
      
      	* app/file/file-open.c
      	* app/file/file-save.c: don't include "libgimptool/gimptooltypes.h".
      
      	* app/gui/about-dialog.c
      	* app/gui/brush-select.c
      	* app/gui/brushes-commands.c
      	* app/gui/color-select.c
      	* app/gui/data-commands.c
      	* app/gui/device-status-dialog.c
      	* app/gui/dialogs.c
      	* app/gui/gradients-commands.c
      	* app/gui/help-commands.c
      	* app/gui/info-window.c
      	* app/gui/palettes-commands.c
      	* app/gui/patterns-commands.c
      	* app/gui/resize-dialog.c
      	* app/gui/tips-dialog.c
      	* app/gui/tool-options-dialog.c: include "gui-types.h" and no
      	other types file.
      
      	* app/paint/gimpairbrush.c
      	* app/paint/gimpclone.c
      	* app/paint/gimpconvolve.c
      	* app/paint/gimpdodgeburn.c
      	* app/paint/gimperaser.c
      	* app/paint/gimppaintbrush.c
      	* app/paint/gimppaintcore-stroke.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimppaintoptions.c
      	* app/paint/gimppencil.c
      	* app/paint/gimpsmudge.c
      	* app/paint/paint.c: include "paint-types.h" and no other types file.
      
      	* app/pdb/pdb-types.h: don't include "libgimptool/gimptooltypes.h".
      
      	* app/plug-in/plug-in-progress.c: warn about inclusion of
      	"display/display-types.h"
      
      	* app/tools/tools-types.h: include "libgimptool/gimptooltypes.h".
      
      	* app/tools/gimpairbrushtool.c
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpconvolvetool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimpdrawtool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpellipseselecttool.c
      	* app/tools/gimperasertool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimphistogramtool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppaintbrushtool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimppathtool.c
      	* app/tools/gimppenciltool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimpsheartool.c
      	* app/tools/gimpsmudgetool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimpthresholdtool.c
      	* app/tools/gimptoolcontrol.c
      	* app/tools/gimptoolcontrol.h
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectortool.c
      	* app/tools/tools.c: include "tools-types.h" and no other types file,
      	warn about inclusion of "gui/gui-types.h".
      
      	* app/widgets/gimpcolorpanel.c
      	* app/widgets/gimptoolbox-color-area.c: warn about inclusion of
      	"gui/gui-types.h".
      
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf.c: don't include "libgimptool/gimptooltypes.h".
      
      	Split tool-safe-mode up in two files, one including libgimpproxy,
      	one libgimp.
      
      	* plug-ins/tools/Makefile.am
      	* plug-ins/tools/tool-safe-mode-plug-in.[ch]: new files including
      	libgimp/ stuff only.
      
      	* plug-ins/tools/tool-safe-mode.[ch]: include libgimpproxy/ and
      	libgimptool/ but don't include libgimp/ because of conflicting
      	declarations.
      
      	Unrelated:
      
      	* app/tools/gimpclonetool.c: create the clone core so we don't crash.
      
      	* app/gui/file-open-dialog.c: changed the way we create previews
      	so that only out-of-date previews are created on a click in the
      	preview area. Unconditional creation can still be forced by
      	<Ctrl>+click. Changed the tooltip to document this.
      a74a8997
    • Sven Neumann's avatar
      app/tools/gimpairbrushtool.[ch] app/tools/gimpbezierselecttool.[ch] · 84e1810a
      Sven Neumann authored
      2002-05-03  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpairbrushtool.[ch]
      	* app/tools/gimpbezierselecttool.[ch]
      	* app/tools/gimpblendtool.[ch]
      	* app/tools/gimpbrightnesscontrasttool.[ch]
      	* app/tools/gimpbucketfilltool[.ch]
      	* app/tools/gimpbycolorselecttool[.ch]
      	* app/tools/gimpclonetool[.ch]
      	* app/tools/gimpcolorbalancetool[.ch]
      	* app/tools/gimpcolorpickertool[.ch]
      	* app/tools/gimpconvolvetool[.ch]
      	* app/tools/gimpcroptool[.ch]
      	* app/tools/gimpcurvestool[.ch]
      	* app/tools/gimpdodgeburntool[.ch]
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpellipseselecttool[.ch]
      	* app/tools/gimperasertool[.ch]
      	* app/tools/gimpfliptool[.ch]
      	* app/tools/gimpfreeselecttool[.ch]
      	* app/tools/gimpfuzzyselecttool[.ch]
      	* app/tools/gimphistogramtool[.ch]
      	* app/tools/gimphuesaturationtool[.ch]
      	* app/tools/gimpinktool[.ch]
      	* app/tools/gimpiscissorstool[.ch]
      	* app/tools/gimplevelstool[.ch]
      	* app/tools/gimpmagnifytool[.ch]
      	* app/tools/gimpmeasuretool[.ch]
      	* app/tools/gimpmovetool[.ch]
      	* app/tools/gimppaintbrushtool[.ch]
      	* app/tools/gimppainttool.c
      	* app/tools/gimppathtool[.ch]
      	* app/tools/gimppenciltool[.ch]
      	* app/tools/gimpperspectivetool[.ch]
      	* app/tools/gimpposterizetool[.ch]
      	* app/tools/gimprectselecttool[.ch]
      	* app/tools/gimprotatetool[.ch]
      	* app/tools/gimpscaletool[.ch]
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimpsheartool[.ch]
      	* app/tools/gimpsmudgetool[.ch]
      	* app/tools/gimptexttool[.ch]
      	* app/tools/gimpthresholdtool[.ch]
      	* app/tools/gimptool.c
      	* app/tools/gimptoolcontrol.h
      	* app/tools/gimptoolmodule[.ch]
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectortool[.ch]
      	* app/tools/path_tool.c
      	* app/tools/tool_manager[.ch]
      	* app/tools/tools.c
      	* libgimptool/gimptool.c
      	* libgimptool/gimptoolcontrol.h
      	* libgimptool/gimptoolmodule.h: removed tons of warnings. Do we need
      	to add -Werror to the CFLAGS to avoid such a mess in the future ?!
      	Also had to enforce the GIMP coding style in lots of places :-(
      
      	* libgimp/gimppixelrgn.c: got sick and tired of debugging plug-ins,
      	so I've added checks for most parameters passed to the GimpPixelRgn
      	functions. This will slow down plug-in execution a little bit but
      	should help to find bugs early.
      84e1810a
  23. 21 Apr, 2002 1 commit
    • Nate Summers's avatar
      app/tools/gimptoolcontrol.[ch] resurrected the motion hints and cursor · 810b9831
      Nate Summers authored
      
       	* app/tools/gimptoolcontrol.[ch]
       	* libgimptool/gimptool.c: resurrected the motion hints and cursor
       	changing code.
      
       	app/tools/gimpairbrushtool.c
      	app/tools/gimpbezierselecttool.c
       	app/tools/gimpblendtool.c
       	app/tools/gimpbucketfilltool.c
       	app/tools/gimpbycolorselecttool.c
       	app/tools/gimpclonetool.c
       	app/tools/gimpcolorbalancetool.c
       	app/tools/gimpcolorpickertool.c
       	app/tools/gimpconvolvetool.c
       	app/tools/gimpcroptool.c
       	app/tools/gimpcurvestool.c
       	app/tools/gimpdodgeburntool.c
       	app/tools/gimpeditselectiontool.c
       	app/tools/gimpellipseselecttool.c
       	app/tools/gimperasertool.c
       	app/tools/gimpfliptool.c
       	app/tools/gimpfuzzyselecttool.c
       	app/tools/gimphistogramtool.c
       	app/tools/gimphuesaturationtool.c
       	app/tools/gimpimagemaptool.c
       	app/tools/gimpinktool.c
       	app/tools/gimpiscissorstool.c
       	app/tools/gimplevelstool.c
       	app/tools/gimpmagnifytool.c
       	app/tools/gimpmeasuretool.c
       	app/tools/gimpmovetool.c
       	app/tools/gimppaintbrushtool.c
       	app/tools/gimppainttool.c
       	app/tools/gimppathtool.c
       	app/tools/gimppenciltool.c
       	app/tools/gimpperspectivetool.c
       	app/tools/gimprectselecttool.c
       	app/tools/gimprotatetool.c
       	app/tools/gimpscaletool.c
       	app/tools/gimpselectiontool.c
       	app/tools/gimpsheartool.c
       	app/tools/gimpsmudgetool.c
       	app/tools/gimptexttool.c
       	app/tools/gimptransformtool.c
       	app/tools/gimpvectortool.c: set the motion mode; fix a few parameters
      
       	* app/tools/gimpinktool.c (gimp_ink_tool_button_press): uncommented
       	some code I had temporarily commented out and didn't uncomment before
       	committing
      
       	* libgimptool/gimptoolcontrol.h
       	* app/tools/gimptoolcontrol-displayshell.[ch]: merged with
       	gimptoolcontrol.[ch].  The distinction was fairly arbitrary.
      
       	* plug-ins/tools/gimptoolcontrol.c: added some stubs
      
              * app/tools/Makefile.am
       	* app/tools/tool_manager.c
       	* app/display/gimpdisplayshell-callbacks.c: changed accordingly
      
       	* libgimp/gimpimage_pdb.c: applied a patch from Pippen to correct
       	documentation on the undo operations
      810b9831
  24. 29 Mar, 2002 1 commit
  25. 23 Feb, 2002 1 commit
    • Michael Natterer's avatar
      General undo cleanup: · a3c3e7d3
      Michael Natterer authored
      2002-02-23  Michael Natterer  <mitch@gimp.org>
      
      	General undo cleanup:
      
      	* app/undo.[ch]: made all undo structs private. Changed all
      	undo_push_foo() functions to take useful parameters instead of
      	"gpointer foo_ptr" and create the undo structs internally.
      	Renamed lots of functions so they are more self-explanatory
      	(like undo_push_gimage_mod -> undo_push_image_size). Added some
      	undo functions (channel reordering is undoable now).  Never pass
      	in a UndoType, as they are reseved for groups now (see below).
      	Lots of cleanup and stuff...
      
      	* app/undo_types.h: is a private header now which defines "enum
      	UndoImplType" which is reserved for actual undo operations.
      	All enum values are named "FOO_UNDO".
      
      	* app/core/core-types.h: added the "UndoType" enum here and don't
      	include "undo_types.h" any more. The UndoType values are all
      	named "FOO_UNDO_GROUP" and are reserved for undo groups.
      
      	The ID space of actual undo operations and undo groups
      	is now strictly disjunct.
      
      	* app/core/gimpchannel.h
      	* app/core/gimpimage.h
      	* app/core/gimplayer.h
      	* app/core/gimplayermask.h
      	* app/paint/gimppaintcore.h
      	* app/tools/gimptransformtool.h: removed undo stuct definitions.
      
      	* app/undo_history.c
      	* app/path_transform.h
      	* app/core/gimpchannel.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-mask.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-qmask.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage.c
      	* app/core/gimplayer-floating-sel.c
      	* app/core/gimplayer.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/gui/channels-commands.c
      	* app/gui/image-commands.c
      	* app/gui/layers-commands.c
      	* app/gui/paths-dialog.c
      	* app/paint/gimppaintcore.c
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c
      	* tools/pdbgen/pdb/guides.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/undo.pdb: changed accordingly.
      
      	* app/pdb/guides_cmds.c
      	* app/pdb/layer_cmds.c
      	* app/pdb/undo_cmds.c: regenerated.
      
      	* app/core/gimpimage.[ch]: added infrastructure for holding a
      	GimpList of GimpVectors objects. The API is the same as for layers
      	and channels. Not used yet.
      a3c3e7d3
  26. 22 Feb, 2002 1 commit
    • Michael Natterer's avatar
      app/Makefile.am removed... · ac0c4af0
      Michael Natterer authored
      2002-02-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/gimpprogress.[ch]: removed...
      
      	* app/display/Makefile.am
      	* app/display/gimpprogress.[ch]: ...and added here. Prefixed
      	everything with "gimp_".
      
      	* app/gui/image-commands.c
      	* app/plug-in/plug-in.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimptransformtool.c: changed accordingly.
      ac0c4af0
  27. 21 Feb, 2002 1 commit
    • Michael Natterer's avatar
      app/Makefile.am removed... · 9f9fa587
      Michael Natterer authored
      2002-02-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/floating_sel.[ch]: removed...
      
      	* app/core/Makefile.am
      	* app/core/gimplayer-floating-sel.[ch]: ...and added here.
      
      	* app/undo.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-convert.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-duplicate.c
      	* app/core/gimpimage-mask.c
      	* app/core/gimpimage-merge.c
      	* app/core/gimpimage-projection.c
      	* app/core/gimpimage-qmask.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage.c
      	* app/core/gimplayer.c
      	* app/gui/layers-commands.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c
      	* plug-ins/tools/common/gimpbrushselecttool.c
      	* tools/pdbgen/pdb/floating_sel.pdb
      	* tools/pdbgen/pdb/layer.pdb: changed includes accordingly.
      
      	* app/pdb/floating_sel_cmds.c
      	* app/pdb/layer_cmds.c: regenerated.
      9f9fa587
  28. 19 Feb, 2002 1 commit
    • Michael Natterer's avatar
      Fixed #10466 (disappearing pixels when rotating by 90 deg): · 8d0af04c
      Michael Natterer authored
      2002-02-19  Michael Natterer  <mitch@gimp.org>
      
      	Fixed #10466 (disappearing pixels when rotating by 90 deg):
      
      	* app/core/gimpdrawable-transform.c: when transforming backwards
      	to find the destination line's sub-pixel source coordinates, we
      	need to transform the pixels _center_, not it's upper left corner.
      
      	* app/core/gimpdrawable-transform-utils.[ch]: added
      	gimp_drawable_transform_matrix_rotate_center() which takes double
      	center coordinates instead of an integer pixel bounding box.
      
      	* app/tools/gimptransformtool.[ch]: use double instead of int for
      	all coordinates except the original bounding box.
      
      	* app/tools/gimprotatetool.c: use double whenever touching the
      	"center" value, so it can be sub-pixel positioned.
      8d0af04c
  29. 18 Feb, 2002 1 commit
    • Michael Natterer's avatar
      app/tools/tools-types.h chain up unconditionally in control(), · bec4c725
      Michael Natterer authored
      2002-02-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/tools-types.h
      	* app/tools/*.[ch]: chain up unconditionally in control(),
      	s/ToolAction/GimpToolAction/g, s/ToolState/GimpToolState/g.
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimppainttool.c: don't touch tool->paused_count
      	(setting it to 0 was a hack which should no longer be needed).
      
      	* app/tools/gimpdrawtool.c: check if the draw tool has actually
      	been started (draw_tool->gdisp != NULL) before calling it's
      	draw() function.
      
      	* app/tools/tool_manager.c: simplified tool_manager_control_active():
      	simply call gimp_tool_control() if gdisp == tool->gdisp.
      
      	* app/tools/gimptool.[ch]: gimp_tool_control(): do all the PAUSE,
      	RESUME and HALT voodoo here.
      
      	* app/tools/gimppainttool.c: implemented #9902 (Drawing straight
      	lines does not work between different views). It's an evil hack,
      	but clearly marked in the source.
      bec4c725
  30. 12 Feb, 2002 1 commit
    • Michael Natterer's avatar
      Made the interpolation type configurable in the scale and transform · 733d6335
      Michael Natterer authored
      2002-02-12  Michael Natterer  <mitch@gimp.org>
      
      	Made the interpolation type configurable in the scale and
      	transform options dialogs (#69251):
      
      	* app/base/base-config.[ch]
      	* app/config/gimpbaseconfig.[ch]: removed interpolation_type here...
      
      	* app/core/gimpcoreconfig.[ch]
      	* app/config/gimpcoreconfig.[ch]: ...and added it here.
      
      	* app/gimprc.c
      	* app/gui/preferences-dialog.c: changed accordingly.
      
      	* app/paint-funcs/paint-funcs.[ch]: scale_region: take an
      	interpolation_type parameter.
      
      	* app/core/gimpchannel.[ch]
      	* app/core/gimpdrawable-transform.[ch]
      	* app/core/gimpimage-scale.[ch]
      	* app/core/gimplayer.[ch]: pass interpolation_type parameters to all
      	scale and transform functions.
      
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/transform_tools.pdb: changed accordingly.
      
      	* app/gui/resize-dialog.[ch]
      	* app/tools/transform_options.[ch]: added an interpolation_type menu.
      
      	* app/gui/image-commands.c
      	* app/gui/layers-commands.c
      	* app/tools/gimptransformtool.c: changed accordingly.
      
      	* app/pdb/image_cmds.c
      	* app/pdb/layer_cmds.c
      	* app/pdb/transform_tools_cmds.c: regenerated.
      733d6335
  31. 07 Feb, 2002 1 commit
    • Sven Neumann's avatar
      app/gui/file-new-dialog.c app/gui/resize-dialog.c · c51c98d9
      Sven Neumann authored
      2002-02-07  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/file-new-dialog.c
      	* app/gui/resize-dialog.c
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimpthresholdtool.c
      	* app/tools/gimptransformtool.c: moved Cancel button to the left.
      
      	* data/images/Makefile.am
      	* data/images/tips_wilber.png: removed ...
      	* data/images/wilber-tips.png: ... and readded under a new name.
      
      	* app/gui/tips-dialog.c: changed accordingly.
      
      	* data/images/wilber-wizard.png: new wilber for the user installation
      	dialog.
      
      	* app/gui/user-install-dialog.c: use the new wilber icon. We still
      	need a good new eeek wilber.
      
      	* themes/Default/gtkrc: don't change the default font size.
      c51c98d9
  32. 05 Feb, 2002 1 commit
    • Michael Natterer's avatar
      Removed pointer grabbing from all tools: · 967d3e4e
      Michael Natterer authored
      2002-02-05  Michael Natterer  <mitch@gimp.org>
      
      	Removed pointer grabbing from all tools:
      
      	* app/tools/gimptool.[ch]: added "gboolean perfectmouse" which
      	defaults to FALSE but can be set to TRUE in a tool's instance_init
      	function.
      
      	* app/display/gimpdisplayshell-callbacks.c: look at
      	active_tool->perfectmouse and gimprc.perfectmouse and do the
      	pointer grab/ungrab here. The pointer is now grabbed right before
      	dispatching the button_press to the tool and ungrabbed after
      	the tool's button_release has returned. It is also grabbed
      	*always*, not only if tool->state got ACTIVE by button_press,
      	which makes it all much simpler...
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimppathtool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c: removed
      	gdk_pointer_grab()/ungrab() calls all over the place. Also removed
      	inclusion of "display/gimpdisplayshell.h" from most of them.
      967d3e4e
  33. 04 Feb, 2002 1 commit
    • Michael Natterer's avatar
      added fields for both the tool's toggled and untoggled GdkCursorType, · 989d80e7
      Michael Natterer authored
      2002-02-04  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptool.[ch]: added fields for both the tool's
      	toggled and untoggled GdkCursorType, GimpToolCursorType and
      	GimpCursorModifier. Added a default implementation of
      	gimp_tool_cursor_update() which uses the new fields. Added
      	gimp_tool_set_cursor() as simple wrapper around the resp.
      	GimpDisplayShell functions so tools don't need to know them.
      
      	Tool implementations can either set the new fields in their
      	cursor_update() function and chain up or call the new wrapper.
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpconvolvetool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimperasertool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.[ch]
      	* app/tools/gimppathtool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimpsmudgetool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c: changed accordingly:
      
      	- set default values in the tools' instance_init functions.
      	- changed the cursor_update() stuff.
      	- removed inclusion of subclasses in gimppainttool.c
      	- the cursor_update() functions are better than before but still evil.
      	- i probably broke some of them...
      989d80e7
  34. 03 Feb, 2002 1 commit
    • Michael Natterer's avatar
      app/display/Makefile.am app/display/display-types.h new widget derived · 0440bbbf
      Michael Natterer authored
      2002-02-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/display/Makefile.am
      	* app/display/display-types.h
      	* app/display/gimpstatusbar.[ch]: new widget derived from
      	GtkStatusbar.  Contains the coordinates display, a progress bar
      	which is also used for status message display and a cancel button.
      	Added a simplified API for pushing/popping messages which takes a
      	string as context_id and does the conversion to guint internally
      	on each call.
      
      	* app/display/gimpdisplayshell.[ch]: removed the status bar code.
      
      	* app/display/gimpdisplayshell-callbacks.c
      	* app/display/gimpdisplayshell-handlers.c
      	* app/display/gimpdisplayshell-scale.c
      	* app/gui/view-commands.c
      	* app/gimpprogress.c: changed accordingly.
      
      	Removed knowledge about GimpDisplayShell from tools:
      
      	* app/tools/gimptool.[ch]: added gimp_tool_push_status() and
      	gimp_tool_pop_status() so tools don't need to fiddle with
      	display details.
      
      	* app/tools/gimpdrawtool.[ch]: pass a GimpDisplay instead of
      	a GdkWindow to gimp_draw_tool_start() (the window passed was
      	always gdisp->shell->canvas->window).
      
      	* app/tools/gimpbezierselecttool.c
      	* app/tools/gimpblendtool.[ch]
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpcroptool.[ch]
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpfuzzyselecttool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmagnifytool.c
      	* app/tools/gimpmeasuretool.[ch]
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.[ch]
      	* app/tools/gimppathtool.c
      	* app/tools/gimprectselecttool.[ch]
      	* app/tools/gimptransformtool.c: changed accordingly:
      
      	- pass GimpDisplay to gimp_draw_tool_start().
      	- use GimpTool's new status push/pop functions.
      	- removed the statusbar context_id from all tool structs.
      
      	* app/gui/dialogs-constructors.[ch]: a bit cleanup in preparation
      	of dockable editor dialogs.
      0440bbbf
  35. 29 Nov, 2001 1 commit
    • Michael Natterer's avatar
      replaced the QMask radio buttons ba a single check button. Still needs · bf6e5a4b
      Michael Natterer authored
      2001-11-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/display/gimpdisplayshell.[ch]: replaced the QMask radio
      	buttons ba a single check button. Still needs some tuning.
      
      	* app/display/gimpdisplayshell-handlers.c
      	* app/display/gimpdisplayshell-qmask.[ch]: changed accordingly.
      
      	* app/tools/gimptool.[ch]: added "gboolean handle_empty_image" to
      	the GimpTool structure.
      
      	* app/tools/gimpmovetool.c: set it to TRUE.
      
      	* app/tools/gimpfuzzyselecttool.c: don't gimp_[set|unset]_busy()
      	while calculating the selection but set the busy cursor on the
      	display manually (we have the pointer grabbed anyway).
      
      	* app/display/gimpdisplayshell-callbacks.c: don't check for
      	GIMP_IS_MODE_TOOL(active_tool) but look at
      	active_tool->handle_empty_image. Removed the checks for
      	GIMP_IS_FUZZY_SELECT_TOOL(active_tool) because fuzzy_select
      	doesn't set GIMP busy while it's active any more.
      
      	* app/tools/transform_options.[ch]
      	* app/tools/gimptransformtool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c: added widgets for the transform tools'
      	constraints (one more #51108 issue fixed).
      
      	* app/tools/gimperasertool.c: cosmetic.
      
      	* app/widgets/gimpdockbook.c: don't hardcode GtkNotebook's
      	tab_border to 0 but add a style property for it...
      
      	* themes/Default/gtkrc: ...and set it to 0 here.
      bf6e5a4b
  36. 28 Nov, 2001 1 commit
    • Michael Natterer's avatar
      s/gimage_mask/gimp_image_mask/g · f7bbdc3e
      Michael Natterer authored
      2001-11-28  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage-mask.[ch]: s/gimage_mask/gimp_image_mask/g
      
      	* app/floating_sel.c
      	* app/undo.c
      	* app/undo_history.c
      	* app/core/gimpchannel.c
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable-transform.c
      	* app/core/gimpdrawable.c
      	* app/core/gimpedit.c
      	* app/core/gimpimage-crop.c
      	* app/core/gimpimage-mask-select.c
      	* app/core/gimpimage-resize.c
      	* app/core/gimpimage-scale.c
      	* app/core/gimpimage.c
      	* app/display/gimpdisplayshell-qmask.c
      	* app/display/gimpdisplayshell-selection.c
      	* app/display/gimpdisplayshell.c
      	* app/gui/channels-commands.c
      	* app/gui/edit-commands.c
      	* app/gui/layers-commands.c
      	* app/gui/select-commands.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpbycolorselecttool.c
      	* app/tools/gimpclonetool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpfliptool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpinktool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimprectselecttool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptransformtool.c
      	* app/widgets/gimpchannellistview.c
      	* app/xcf/xcf-save.c
      	* tools/pdbgen/pdb/edit.pdb
      	* tools/pdbgen/pdb/selection.pdb: changed accordingly.
      
      	* app/pdb/edit_cmds.c
      	* app/pdb/selection_cmds.c: regenerated.
      f7bbdc3e
  37. 22 Nov, 2001 2 commits
    • Michael Natterer's avatar
      added stock *items* (not only icons) for all tools so they can be used as · 80492e66
      Michael Natterer authored
      2001-11-22  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpstock.c: added stock *items* (not only icons)
      	for all tools so they can be used as action buttons.
      
      	* app/tools/gimptransformtool.[ch]: added
      	transform_tool->use_center so subclasses can switch on/off center
      	detection/cursor_update . Added an oper_update() implementation
      	and figure the current handle out there. Reordered button_press()
      	so we don't need to call it recursively.
      
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: use the new stock items instead of
      	_("Rotate") etc.
      
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimpscaletool.c: allow the whole thing being dragged
      	around by handling the center separately.
      
      	* app/tools/gimpdrawtool.c: gimp_draw_tool_on_handle(): need to
      	use the radius, not the diameter to check if being over a
      	GIMP_HANDLE_CIRCLE handle.
      80492e66
    • Michael Natterer's avatar
      use "gimp-item-data" instead of "user_data" as data key when attaching · a08f3ac0
      Michael Natterer authored
      2001-11-22  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpwidgets.[ch]: use "gimp-item-data" instead of
      	"user_data" as data key when attaching values to radio buttons or
      	menu items. (For backward compat, attach "user_data" additionally,
      	but don't use it to _get_data()).
      	Added gimp_radio_group_set_active() which works like
      	gimp_options_menu_set_history() and sets the active item by
      	attached "gimp-item-data" value.
      
      	* app/gui/brush-select.c
      	* app/gui/file-new-dialog.c
      	* app/gui/info-window.c
      	* app/gui/preferences-dialog.c
      	* app/gui/resolution-calibrate-dialog.c
      	* app/tools/gimpbucketfilltool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/paint_options.c
      	* app/tools/selection_options.c
      	* app/widgets/gimplayerlistview.c: removed all kinds of
      	"user_data" stuff and evil hacks to find a radio button by the
      	value it represents (simply call gimp_radio_group_set_active()).
      
      	* app/tools/gimpdrawtool.c: added a g_return_if_fail().
      
      	* app/tools/gimpfliptool.c: don't set draw_tool_class->draw to NULL,
      
      	* app/tools/gimptransformtool.[ch]: fixed some stuff i broke when
      	removing the old "interactive" boolean (there is no
      	non-interactive transform tool any more).  Put the info_dialog
      	pointer and the old_trans_info array into the GimpTransformTool
      	instance. Added gimp_transform_tool_info_dialog_connect(). Don't
      	include any subclasses any more.
      
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: use
      	gimp_transform_tool_info_dialog_connect() to create and connect
      	the info dialogs' action_area.
      a08f3ac0