1. 23 Oct, 2004 10 commits
    • Michael Natterer's avatar
      don't g_return_if_fail() if there is no active drawable, just silently · fa79ae28
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/actions/file-commands.c (file_save_cmd_callback): don't
      	g_return_if_fail() if there is no active drawable, just silently
      	return.
      
      	* app/actions/image-commands.c: remember the last merge_type of
      	the "Merge Visible Layers" dialog.
      
      	* app/actions/layers-commands.c: remeber the last values of the
      	"Add Layer Mask" dialog.
      
      	* app/actions/select-commands.c: renamed a bunch of static
      	variables to be consistent with other variables used to remember
      	dialog values.
      
      	* app/actions/view-commands.c (view_fullscreen_cmd_callback): it's
      	useless to update the "view-fullscreen" actions here because the
      	"fullscreen" state of the shell changes asynchronously
      fa79ae28
    • Michael Natterer's avatar
      app/dialogs/image-merge-layers-dialog.c made them not resizable. · a01c6883
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/image-merge-layers-dialog.c
      	* app/dialogs/layer-add-mask-dialog.c: made them not resizable.
      
      	* app/dialogs/convert-dialog.c
      	* app/dialogs/offset-dialog.c: renamed ugly variables.
      
      	* app/dialogs/image-new-dialog.c
      	* app/dialogs/stroke-dialog.c: irrelevant pedantic code reordering.
      a01c6883
    • Michael Natterer's avatar
      app/dialogs/Makefile.am one more dialog split out of actions/. · f50d4763
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/image-merge-layers-dialog.[ch]: one more dialog split
      	out of actions/.
      
      	* app/actions/image-commands.c: removed it here. Some cleanup.
      f50d4763
    • Sven Neumann's avatar
      libgimpthumb/gimpthumb-utils.[ch] libgimpthumb/gimpthumbnail.[ch] added · ea273aad
      Sven Neumann authored
      2004-10-23  Sven Neumann  <sven@gimp.org>
      
      	* libgimpthumb/gimpthumb-utils.[ch]
      	* libgimpthumb/gimpthumbnail.[ch]
      	* libgimpthumb/gimpthumb.def: added missing API, mainly for deleting
      	thumbnails.
      
      	* app/core/gimpimagefile.[ch]: when saving a thumbnail, delete a
      	failure thumbnail if one exists. Unless the thumbnail was created
      	explicitely, remove all other thumbnails for this image.
      
      	* app/actions/documents-commands.c: changed accordingly.
      
      	* app/file/file-open.c: only save a thumbnail if there isn't a
      	valid thumbnail already.
      
      	* app/widgets/gimpthumbbox.c: before attempting to create a new
      	thumbnail, check if there's an uptodate failure thumbnail.
      ea273aad
    • Michael Natterer's avatar
      app/dialogs/Makefile.am one more dialog split out of actions/. · cbaf441f
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/layer-add-mask-dialog.[ch]: one more dialog split
      	out of actions/.
      
      	* app/actions/layers-commands.c: removed it here. Some cleanup.
      cbaf441f
    • Michael Natterer's avatar
      don't tell nonsense by printing "I am going to run ./configure with no · 6d9d93e1
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* autogen.sh: don't tell nonsense by printing "I am going to run
      	./configure with no arguments", because we always pass at least
      	--enable-maintainer-mode. Instead, simply always print all
      	arguments. Also removed --copy from the calls to glib-gettextize
      	and intltoolize.
      6d9d93e1
    • Michael Natterer's avatar
      don't tell nonsense by printing "I am going to run ./configure with no · 6c0fd1dd
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* autogen.sh: don't tell nonsense by printing "I am going to run
      	./configure with no arguments", because we always pass at least
      	--enable-maintainer-mode. Instead, simply always print all
      	arguments.
      6c0fd1dd
    • Michael Natterer's avatar
      added labels ("_Stroke") to the SLEECTION_STROKE and PATH_STROKE stock · 6e9d0cfa
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpstock.c: added labels ("_Stroke") to the
      	SLEECTION_STROKE and PATH_STROKE stock items so they can be used
      	in action areas.
      
      	* app/widgets/gimpstrokeeditor.c: changed mnemonic to no clash
      	with "_Stroke" and reordered some code.
      
      	* app/dialogs/stroke-dialog.[ch]: use the passed stock_id instead
      	of GTK_STOCK_OK. Added parameters to specify the dialog's title
      	so it doesn't say "Stroke Options".
      
      	* app/actions/select-commands.c
      	* app/actions/vectors-commands.c
      	* app/tools/gimpvectortool.c: pass "Stroke Selection" and "Stroke
      	Path" as dialog titles.
      6e9d0cfa
    • Michael Natterer's avatar
      When there are variants of actions with and without dialog, let the · fd6d30fd
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	When there are variants of actions with and without dialog, let
      	the dialog-less actions try to use the values from the last dialog
      	invocation:
      
      	* app/actions/channels-actions.c
      	* app/actions/channels-commands.[ch]
      	* app/actions/layers-actions.c
      	* app/actions/layers-commands.[ch]
      	* app/actions/vectors-actions.c
      	* app/actions/vectors-commands.[ch]: renamed the foo-new-defaults
      	actions to foo-new-last-values and use the last values entered in
      	the dialogs.
      
      	* app/widgets/gimpchanneltreeview.c
      	* app/widgets/gimpitemtreeview.c
      	* app/widgets/gimplayertreeview.c
      	* app/widgets/gimpvectorstreeview.c: changed accordingly. Show
      	the dialog on clicking "New" and call the last-values action on
      	<shift>+click.
      
      	* app/actions/select-actions.c
      	* app/actions/vectors-commands.c: renamed the foo-stroke-last-vals
      	to -last-values.
      
      	* app/widgets/gimpselectioneditor.c
      	* app/widgets/gimpvectorstreeview.c: stroke with last values on
      	<shift> clicking the stroke buttons.
      fd6d30fd
    • Sven Neumann's avatar
      save to a temporary file and rename to avoid problems with concurrent · 00ff7e3f
      Sven Neumann authored
      2004-10-23  Sven Neumann  <sven@gimp.org>
      
      	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_save): save to a
      	temporary file and rename to avoid problems with concurrent
      	thumbnail creation.
      00ff7e3f
  2. 22 Oct, 2004 9 commits
    • Michael Natterer's avatar
      app/dialogs/Makefile.am the new/edit layer dialog. · 5346f26b
      Michael Natterer authored
      2004-10-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/layer-options-dialog.[ch]: the new/edit layer dialog.
      
      	* app/actions/layers-commands.c: use it here.
      5346f26b
    • Sven Neumann's avatar
      app/tools/gimpimagemaptool.[ch] app/tools/gimpcurvestool.c allow to · 43a46299
      Sven Neumann authored
      2004-10-22  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpimagemaptool.[ch]
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimplevelstool.c: allow to Shift-click the Load and
      	Save buttons to skip the file chooser dialog and reuse the last
      	used filename. Fixes bug #75558.
      43a46299
    • Michael Natterer's avatar
      app/dialogs/Makefile.am the new/edit template dialog. · d1ce0a16
      Michael Natterer authored
      2004-10-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/template-options-dialog.[ch]: the new/edit template
      	dialog.
      
      	* app/actions/templates-commands.c: removed the code here and use
      	template_options_dialog_new(). Removed utility functions. Some
      	cleanup.
      d1ce0a16
    • Michael Natterer's avatar
      make sure the button_box is always interted at the very bottom of the · 59bd4305
      Michael Natterer authored
      2004-10-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpeditor.c (gimp_editor_ensure_button_box): make
      	sure the button_box is always interted at the very bottom of the
      	editor.
      
      	* app/widgets/gimpviewabledialog.c: changed the "description"
      	property from CONSTRUCT_ONLY to CONSTRUCT.
      
      	* app/widgets/gimpcolormapeditor.c: show the index of the edited
      	color in the color dialog and use the correct icon. Replaced label
      	"Hex triplet" by "HTML notation" to be consistent with the color
      	dialog. Removed wrong 2 pixel border around the table below the
      	preview.
      59bd4305
    • Sven Neumann's avatar
      fixed non-interactive call with default values. · 0b43e493
      Sven Neumann authored
      2004-10-22  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/wmf.c: fixed non-interactive call with default
      	values.
      0b43e493
    • Sven Neumann's avatar
      app/actions/colormap-editor-actions.c app/actions/dialogs-actions.c · 341b6da9
      Sven Neumann authored
      2004-10-22  Sven Neumann  <sven@gimp.org>
      
      	* app/actions/colormap-editor-actions.c
      	* app/actions/dialogs-actions.c
      	* app/core/gimpimage-colormap.c
      	* app/dialogs/convert-dialog.c
      	* app/dialogs/dialogs.c
      	* app/widgets/gimpcolormapeditor.c: use the term "Colormap"
      	instead of "Indexed Palette". Fixes bug #155829.
      341b6da9
    • Sven Neumann's avatar
      applied a patch by Karine Proot that adds a preview to the load dialog and · 9fdf9b4a
      Sven Neumann authored
      2004-10-22  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/wmf.c: applied a patch by Karine Proot that adds
      	a preview to the load dialog and a similar UI as the SVG loader.
      	Fixes bug #133519 and bug #133521.
      9fdf9b4a
    • Michael Natterer's avatar
      added new enum GimpStrokeMethod which can be one of { LIBART, PAINT_CORE · 06447c00
      Michael Natterer authored
      2004-10-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/core-enums.[ch]: added new enum GimpStrokeMethod which
      	can be one of { LIBART, PAINT_CORE }.
      
      	* app/core/Makefile.am
      	* app/core/core-types.h
      	* app/core/gimpstrokedesc.[ch]: new object which encapsulates
      	the params and setup logic for the different stroke methods.
      
      	* app/core/gimpitem.[ch]: use it in GimpItem::stroke() and
      	in the gimp_item_stroke() wrapper.
      
      	* app/core/gimpchannel.c (gimp_channel_stroke)
      	* app/core/gimpselection.c (gimp_selection_stroke)
      	* app/vectors/gimpvectors.c (gimp_vectors_stroke): changed accprdingly.
      
      	* app/actions/select-commands.c
      	* app/actions/vectors-commands.c
      	* app/dialogs/stroke-dialog.c
      	* tools/pdbgen/pdb/edit.pdb
      	* tools/pdbgen/pdb/paths.pdb: use GimpStrokeDesc. Simplifies the
      	code quite a bit.
      
      	* app/pdb/edit_cmds.c
      	* app/pdb/paths_cmds.c: regenerated.
      06447c00
    • Michael Natterer's avatar
      remember the param_spec with each radio button instead of with the · 14a2a2aa
      Michael Natterer authored
      2004-10-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimppropwidgets.c: remember the param_spec with each
      	radio button instead of with the box/frame around them.
      14a2a2aa
  3. 21 Oct, 2004 2 commits
  4. 20 Oct, 2004 4 commits
    • Michael Natterer's avatar
      app/actions/select-actions.c app/actions/select-commands.[ch] · ff02c7af
      Michael Natterer authored
      2004-10-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/actions/select-actions.c
      	* app/actions/select-commands.[ch]
      	* app/actions/vectors-actions.c
      	* app/actions/vectors-commands.[ch]: added actions and callbacks
      	to stroke with the last values used without showing the stroke
      	dialog. The actions have no menu entries but can be called via
      	shortcuts. Fixes bug #135746.
      
      	(Disclaimer: the uglyness of the callbacks shows the need for a
      	stroke API overhaul).
      ff02c7af
    • Michael Natterer's avatar
      Replacing the call to gimp_channel_is_empty() by a simple · 7ab5fe29
      Michael Natterer authored
      2004-10-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpdrawable-stroke.c
      	(gimp_drawable_stroke_scan_convert): Replacing the call to
      	gimp_channel_is_empty() by a simple gimp_drawable_mask_intersect()
      	was wrong because gimp_channel_is_empty() makes sure that the
      	selection doesn't mask itself while being stroked.
      7ab5fe29
    • Michael Natterer's avatar
      ported to GimpPreviewArea. · 560c8215
      Michael Natterer authored
      2004-10-20  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/common/raw.c: ported to GimpPreviewArea.
      560c8215
    • Michael Natterer's avatar
      new plug-in from Tim Copperfield, made work with the GIMP 2.1 API by · f469155d
      Michael Natterer authored
      2004-10-20  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/common/raw.c: new plug-in from Tim Copperfield, made
      	work with the GIMP 2.1 API by Philipp Gühring, then heavily
      	cleaned up and undeprecated by myself. Fixes bug #144943.
      
      	(still uses GtkPreview, but i wanted a sane state in cvs to diff
      	 against before replacing it)
      
      	* plug-ins/common/plugin-defs.pl: changed accordingly.
      
      	* plug-ins/common/Makefile.am: regenerated.
      f469155d
  5. 19 Oct, 2004 7 commits
    • Michael Natterer's avatar
      Fixed bug #155733 for libgimp: · 62ec8b35
      Michael Natterer authored
      2004-10-20  Michael Natterer  <mitch@gimp.org>
      
      	Fixed bug #155733 for libgimp:
      
      	* tools/pdbgen/pdb/drawable.pdb: export drawable_mask_intersect()
      	to the PDB and improved documentation for drawable_mask_bounds().
      
      	* app/pdb/drawable_cmds.c
      	* app/pdb/internal_procs.c
      	* libgimp/gimpdrawable_pdb.[ch]: regenerated.
      
      	* libgimp/gimp.def: changed accordingly.
      62ec8b35
    • Michael Natterer's avatar
      added gimp_drawable_mask_intersect() which returns the same bounding box · cb48cef8
      Michael Natterer authored
      2004-10-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpdrawable.[ch]: added gimp_drawable_mask_intersect()
      	which returns the same bounding box as gimp_drawable_mask_bounds(),
      	but returns TRUE only if there is a non-empty intersection between
      	the drawable and the selection, or no selection at all. It also
      	returns the intersection as x,y,width,height instead of the
      	eeky x1,y1,x2,y2.
      
      	* app/core/gimp-edit.c
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable-bucket-fill.c
      	* app/core/gimpdrawable-desaturate.c
      	* app/core/gimpdrawable-equalize.c
      	* app/core/gimpdrawable-histogram.c
      	* app/core/gimpdrawable-invert.c
      	* app/core/gimpdrawable-stroke.c
      	* app/core/gimpimagemap.c
      	* app/core/gimpselection.c
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/transform_tools.pdb: either switch from
      	gimp_drawable_mask_bounds() to _intersect() or check the return
      	values of _mask_bounds() manually to avoid operations on empty
      	areas. Return successfully because it's a nop, not a failure.
      	Fixes bug #155733 for the core.
      
      	* app/pdb/color_cmds.c
      	* app/pdb/transform_tools_cmds.c: regenerated.
      cb48cef8
    • Michael Natterer's avatar
      removed 3 mnemonics. No other tool options label has a mnemonic. Addresses · 5507c47c
      Michael Natterer authored
      2004-10-19  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptextoptions.c (gimp_text_options_gui): removed
      	3 mnemonics. No other tool options label has a mnemonic.
      	Addresses bug #155861.
      5507c47c
    • Michael Natterer's avatar
      app/dialogs/Makefile.am one more dialog split out of actions/. · 00401dcf
      Michael Natterer authored
      2004-10-19  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/vectors-options-dialog.[ch]: one more dialog split
      	out of actions/.
      
      	* app/actions/vectors-commands.c: removed it here. Merged more
      	utility functions into their only callers.
      
      	* app/actions/dockable-commands.c
      	* app/actions/edit-commands.c
      	* app/actions/file-commands.c
      	* app/actions/palettes-commands.c
      	* app/actions/tool-options-commands.c
      	* app/actions/view-commands.c: renamed "qbox" and "query_box"
      	variables to "dialog".
      00401dcf
    • Michael Natterer's avatar
      don't forget to set the mnemonic widgets for the labels. Fixes bug · c6094aff
      Michael Natterer authored
      2004-10-19  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/common/screenshot.c (shoot_dialog): don't forget to set
      	the mnemonic widgets for the labels. Fixes bug #155811.
      c6094aff
    • Michael Natterer's avatar
      app/dialogs/Makefile.am new files implementing the channel options dialog · 39294079
      Michael Natterer authored
      2004-10-19  Michael Natterer  <mitch@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/channel-options-dialog.[ch]: new files implementing
      	the channel options dialog with a horrid number of 13 construction
      	parameters. Still better than having the same code twice, only
      	differing in strings used...
      
      	* app/actions/channels-commands.c
      	* app/actions/qmask-commands.c: removed the dialog code here and
      	use channel_options_dialog_new().
      39294079
    • jaycox's avatar
      don't try to save psd files that are larger than 30000 pixels in either · 165cf42e
      jaycox authored
      
              * plug-ins/common/psd_save.c: don't try to save psd files that are
              larger than 30000 pixels in either direction.  Fixed the rle code
              to compress more compactly.  Fixed a memmory leak in
              save_channel_data.
      165cf42e
  6. 18 Oct, 2004 1 commit
    • Michael Natterer's avatar
      Action code review and pre-release consistency cleanup: · c49df22e
      Michael Natterer authored
      2004-10-18  Michael Natterer  <mitch@gimp.org>
      
      	Action code review and pre-release consistency cleanup:
      
      	* app/actions/*-actions.c: added some missing and resolved
      	conflicting mnemonics, added missing help IDs. Cleaned up the
      	*_actions_update() functions.
      
      	* app/actions/channels-actions.c
      	* app/actions/layers-actions.c
      	* app/actions/vectors-actions.c (*_actions_update): simplified
      	the code that figures the prev and next channel,layer,vectors.
      
      	* app/actions/qmask-actions.c: use the same accelerator for
      	"qmask-active" and "qmask-toggle". Fixed action sensitivity.
      
      	* app/actions/channels-commands.c
      	* app/actions/dockable-commands.c
      	* app/actions/documents-commands.c
      	* app/actions/gradients-commands.c
      	* app/actions/layers-commands.c
      	* app/actions/palettes-commands.c
      	* app/actions/image-commands.c
      	* app/actions/select-commands.c
      	* app/actions/vectors-commands.c: folded tons of private utility
      	functions into their only callers (they us...
      c49df22e
  7. 17 Oct, 2004 4 commits
  8. 16 Oct, 2004 3 commits
    • David Odin's avatar
      smallish cleanups. · 41c1c53c
      David Odin authored
      * plug-ins/common/borderaverage.c: smallish cleanups.
      41c1c53c
    • David Odin's avatar
      Added a preview and minor cleanups. Can someone provide useful testcases · 48d2f01f
      David Odin authored
      * plug-ins/common/displace.c: Added a preview and minor cleanups.
        Can someone provide useful testcases for this plug-in?
      48d2f01f
    • Michael Natterer's avatar
      moved "item_type" and "signal_name" from GimpItemTreeView to · c84475c9
      Michael Natterer authored
      2004-10-16  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpitemtreeview.[ch]: moved "item_type" and
      	"signal_name" from GimpItemTreeView to GimpItemTreeViewClass.
      	Removed them from gimp_item_tree_view_new(). Require the view_type
      	instead of item_type in gimp_item_tree_view_new().
      
      	* app/widgets/gimpitemtreeview.c
      	* app/widgets/gimpdrawabletreeview.c (get_type): made them
      	abstract base classes.
      
      	* app/widgets/gimpchanneltreeview.c
      	* app/widgets/gimplayertreeview.c
      	* app/widgets/gimpvectorstreeview.c (class_init): set the
      	item_type and signal_name members if GimpItemTreeViewClass.
      
      	* app/dialogs/dialogs-constructors.c: changed accordingly.
      c84475c9