1. 13 Oct, 2004 2 commits
    • Kevin Cozens's avatar
      Fixed a spelling error. · f92848d2
      Kevin Cozens authored
      2004-10-13  Kevin Cozens  <kcozens@cvs.gimp.org>
      
          * app/widgets/gimpactionview.c: Fixed a spelling error.
      f92848d2
    • Sven Neumann's avatar
      app/widgets/Makefile.am app/widgets/widgets-types.h added a simple message · 8300c550
      Sven Neumann authored
      2004-10-13  Sven Neumann  <sven@gimp.org>
      
      	* app/widgets/Makefile.am
      	* app/widgets/widgets-types.h
      	* app/widgets/gimpmessagedialog.[ch]: added a simple message
      	dialog to avoid code duplication.
      
      	* app/widgets/gimpmessagebox.c: set the border width to 12 pixels.
      
      	* app/dialogs/file-save-dialog.c
      	* app/dialogs/quit-dialog.c
      	* app/display/gimpdisplayshell-close.c
      	* app/widgets/gimperrordialog.c
      	* app/widgets/gimphelp.c
      	* app/widgets/gimpactionview.c: use the new GimpMessageDialog.
      8300c550
  2. 12 Aug, 2004 1 commit
    • Michael Natterer's avatar
      make sure that all actions, even if they have no menu proxy, can be · 1437f52d
      Michael Natterer authored
      2004-08-12  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpmenufactory.c (gimp_menu_factory_manager_new):
      	make sure that all actions, even if they have no menu proxy, can
      	be invoked by their accelerators. Fixes bug #149938.
      
      	* app/widgets/gimpimagedock.c (gimp_image_dock_constructor):
      	removed the same code here.
      
      	* app/widgets/gimpactionview.[ch] (gimp_action_view_dispose): new
      	function which disconnects from "accel_changed" of the accel_group
      	before upchaining (== before emitting "destroy").
      
      	The above changes make this one redundant, but since the crash in
      	bug #149938 was triggered by "accel_changed" emitted in the middle
      	of g_object_unref(tree_model), it feels better to be paranoic here
      	(fiddling with objects in destruction is no fun).
      
      	(gimp_action_view_accel_edited): don't warn if assigning the same
      	accel to the same action again.
      
      	(gimp_action_view_new): don't leak all accel_closures.
      1437f52d
  3. 22 Jul, 2004 1 commit
    • Sven Neumann's avatar
      rephrased the text for the dialog that appears if a new shortcut collides · b50ea15b
      Sven Neumann authored
      2004-07-22  Sven Neumann  <sven@gimp.org>
      
      	* app/widgets/gimpactionview.c: rephrased the text for the dialog
      	that appears if a new shortcut collides with an existing one.
      
      	* libgimpcolor/gimprgb.[ch]: added new function gimp_rgb_parse_name()
      	which accepts RGB colors in hexadezimal notation or as SVG color
      	keywords.
      b50ea15b
  4. 21 Jul, 2004 3 commits
    • Michael Natterer's avatar
      app/core/gimpmarshal.list added "gboolean delete" parameter to the · e7479951
      Michael Natterer authored
      2004-07-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpmarshal.list
      	* app/widgets/gimpcellrendereraccel.[ch]: added "gboolean delete"
      	parameter to the GimpCellRendererAccel::accel_edited() signal.
      
      	* app/widgets/gimpactionview.c: distinguish between deletion of an
      	accelerator and the user entering an invalid accelerator.
      e7479951
    • Michael Natterer's avatar
      remember the keyboard shortcut dialog and show it only once. · b241a40b
      Michael Natterer authored
      2004-07-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/preferences-dialog.c: remember the keyboard shortcut
      	dialog and show it only once.
      
      	* app/widgets/gimpactionview.c
      	* app/widgets/gimpcellrendereraccel.c: minor cleanups.
      
      	Seems to work pretty well now and thus fixes bug #142922.
      b241a40b
    • Michael Natterer's avatar
      app/core/gimpmarshal.list app/widgets/Makefile.am · 62bf62a1
      Michael Natterer authored
      2004-07-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpmarshal.list
      	* app/widgets/Makefile.am
      	* app/widgets/widgets-types.h
      	* app/widgets/gimpcellrendereraccel.[ch]: new cell renderer
      	which displays an accelerator and allows to edit it (ripped
      	out of libegg and modified).
      
      	* app/widgets/gimpactionview.c: use the new renderer and connect
      	to its "accel-edited" signal (its callback is one huge mess that
      	needs to be cleaned up). Added ugly hack to work around GTK+ API
      	limitation that seems to prevent implementing a shortcut editor in
      	a sane way.
      
      	* app/actions/file-actions.c
      	* app/actions/image-actions.c
      	* app/actions/tools-actions.c: added ugly hacks here, too.
      
      	* app/gui/preferences-dialog.c: relaced Cancel/Ok in the shortcut
      	editor by Close.
      62bf62a1
  5. 20 Jul, 2004 1 commit
    • Michael Natterer's avatar
      app/widgets/gimpactionfactory.[ch] added "label" and "stock-id" properties · 94fc8f15
      Michael Natterer authored
      2004-07-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpactionfactory.[ch]
      	* app/widgets/gimpactiongroup.[ch]: added "label" and "stock-id"
      	properties to GtkActionGroup and allow to register them in the
      	GimpActionFactory.
      
      	* app/actions/actions.c: register user visible labels and icons
      	with all action groups.
      
      	* app/widgets/Makefile.am
      	* app/widgets/widgets-types.h
      	* app/widgets/gimpactionview.[ch]: new widget which shows a
      	treeview of action groups and their actions & shortcuts.
      
      	* app/widgets/gimpaction.[ch]: added gimp_action_name_compare()
      	utility function.
      
      	* app/widgets/gimpwidgets-utils.[ch]: added
      	gimp_get_accel_string() utility function.
      
      	* app/widgets/gimpcontrollers.[ch]: added
      	gimp_controllers_get_ui_manager() which will be used for setting
      	up the controller mapping dialog.
      
      	* app/gui/preferences-dialog.c: added a "Configure Keyboard
      	Shortcuts" button which pops up a GimpControllerView. Work in
      	progress...
      94fc8f15