1. 28 Nov, 2016 2 commits
  2. 27 Nov, 2016 2 commits
  3. 26 Nov, 2016 4 commits
  4. 25 Nov, 2016 10 commits
    • skal's avatar
      Bug 775026 - webp-save: expose more saving options in the UI · 136ef67b
      skal authored and Jehan's avatar Jehan committed
      webp-save: Add UI elements for 'minimize size' toggle, and a dependent
      'max key-frame distance' setting.
      * If 'minimize size' is active, max-kf is disabled (which is equivalent to
        setting it to infinity). Key-frame cost file size, that's why.
      * If 'minimize size' is disabled, you get to choose how far key-frames
        (=cue points) will be inserted at max.
      136ef67b
    • Michael Natterer's avatar
      app: add GimpDockContainer::get_dialog_factory() · 2e635336
      Michael Natterer authored
      and use it where possible instead of gimp_dialog_factory_get_singleton().
      Also reduce using this function in some other places.
      2e635336
    • Thomas Manni's avatar
    • Jehan's avatar
      Revert "app: handle gtk_accel_map_change_entry () failure..." · 4a9a0723
      Jehan authored
      This reverts commit eab4929a.
      
      Oups it would seem gtk_accel_map_change_entry() could return FALSE even
      when the expected shortcut is correctly set (my guess is that it was
      already the same shortcut, so indeed no "change" happened, though it is
      not a failure either; yet I haven't checked if that is the actual
      reason).
      Let's just revert this. It's not always a good thing to be too thorough!
      Sorry for this!
      4a9a0723
    • Jehan's avatar
      app: clean out many tabs under app/core/. · 84ee79c7
      Jehan authored
      84ee79c7
    • Jehan's avatar
      app: do not allow Alt+[0-9] shortcuts. · 31ae4238
      Jehan authored
      These are used for display switching, and even though you could
      remap these shortcuts, it would work only until you close an image,
      open a new one, or reorder tabs in SWM, in which case your shortcut
      would end up forcefully overrided, which is a bad user experience.
      If we want to give more flexibility and allow one to map these
      shortcuts, we must also make sure the display showing actions won't
      override customized shortcuts. In the meantime, it is better to
      simply forbid these in our preferences.
      31ae4238
    • Jehan's avatar
      app: handle gtk_accel_map_change_entry () failure... · eab4929a
      Jehan authored
      ... for "windows-display-*" actions.
      I should not happen, but let's be thorough and properly handle failure
      with a message since this is a runtime issue.
      eab4929a
    • Jehan's avatar
      app: remove transient actions with gimp_action_group_remove_action(). · 2081de5a
      Jehan authored
      gtk_action_group_remove_action() removes the action from the group while
      not actually cleaning any accelerator. This is a problem for transient
      actions which have only a meaning within the current session, such as
      the display switching actions named with the display ID (unique within
      the session only).
      Current commit, combined with the previous one (commit c0ee9599), fix
      "windows-display-*" actions being saved inside menurc.
      2081de5a
    • Jehan's avatar
      app: save menurc after having deleted all the displays. · c0ee9599
      Jehan authored
      Some actions are not meant to be saved, in particular the
      "windows-display-*" which have only a meaning during a same session
      since display IDs are session-dependent. So let display deletion
      happen first so that proper cleaning of action is done when writing
      menurc.
      c0ee9599
    • Jehan's avatar
      app: cleaning out tabs. · 94a5b7c9
      Jehan authored
      94a5b7c9
  5. 24 Nov, 2016 5 commits
    • Michael Natterer's avatar
      Bug 774890 - "Keyboard shortcuts" dialog does not show all actions · 6131b00b
      Michael Natterer authored
      Revert "app: action search should search accross all available actions."
      
      This reverts commit 53b3673b.
      
      Had to revert these two commits, quoting comment 6 of the bug:
      
      Thinking again, that entire change is unfortunately wrong, the only
      right UI manager is in fact
      
      gimp_ui_managers_from_name ("<Image>")->data
      
      because it's the global popup <Image> UI manager which is independent
      of a display and it always in the right state for the currently
      active image, all other UI managers are wrong.
      6131b00b
    • Michael Natterer's avatar
      Bug 774890 - "Keyboard shortcuts" dialog does not show all actions · 1517a095
      Michael Natterer authored
      Revert "app: do not show the actions from <Dockable> GimpUIManager."
      
      This reverts commit b795ae22.
      1517a095
    • Michael Natterer's avatar
    • Jehan's avatar
      app: better defaults for image dimension. · 7a60fd0d
      Jehan authored
      Current defaults are from another time. Acceptable defaults could be
      common screen resolutions. 1366x768 is apparently the most common
      (according to various stats on the web), but since we target advanced
      graphics artists, let's go for 1920x1080, which is the second most
      common resolution, also known as Full HD.
      For unstable builds, let's have at least one odd number, uncommon ratio
      and higher values, encouraging tests with less common numbers and bigger
      images. I chose 2001x1984. Feel free to update to any other funky values
      following these "unstable" rules.
      7a60fd0d
    • Jehan's avatar
      Bug 774906 - Replace File>New default ppi of 72... · 39190807
      Jehan authored
      ... with something more suitable.
      72 PPI is from a time where people thought this was a common screen
      resolution. This is not the case nowadays, and anyway images targetted
      for screen display should not bother with PPI resolution at all, only
      with actual pixel dimensions.
      PPI resolution is more useful for printing. And for this case, 300 is
      quite an accepted OK value for most cases. So this is likely a better
      default for GIMP.
      39190807
  6. 23 Nov, 2016 8 commits
  7. 22 Nov, 2016 7 commits
  8. 21 Nov, 2016 2 commits
    • Jehan's avatar
      Bug 774733 - segmentation fault when discarding text information. · 3e85121e
      Jehan authored
      Always check pointer before dereferencing it, when it can be NULL.
      3e85121e
    • Jehan's avatar
      app: check and clean out duplicate accelerators on startup. · 2a232398
      Jehan authored
      Duplicate accelerators are not supposed to happen. It is not possible
      to set them through the GUI in particular. Nevertheless
      gtk_accel_map_load() would apparently let duplicates pass, which could
      happen after editing the menurc directly, or using the development
      version (no action name migration happens there), or simply after a
      potential bug. This is then very annoying because you may see several
      actions displaying the same shortcut but only one actually work. And
      trying to re-set through GUI the shortcut to the one action you wish to
      run does not fix the duplicate issue (you have to laboriously find which
      other action use the same accelerator and delete it first).
      Better be safe than sorry and make a quick check at startup, then delete
      the accelerator on one of the duplicates (you can't guess which one was
      actually wanted, but at least you will facilitate manual reset through
      the GUI).
      2a232398