1. 18 Jan, 2004 9 commits
    • Michael Natterer's avatar
      app/vectors/gimpstroke.c use the GIMP_TYPE_FOO macros instead of · d9b7d7ee
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/vectors/gimpstroke.c
      	* app/xcf/xcf-load.c: use the GIMP_TYPE_FOO macros instead of
      	gimp_foo_get_type(). Minor cleanups.
      d9b7d7ee
    • Michael Natterer's avatar
      in the spirit of the fix for bug #131721 below, don't try to figure · d528848f
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_add_layer,remove_layer): in the
      	spirit of the fix for bug #131721 below, don't try to figure
      	manually if "alpha_changed" needs to be emitted but simply compare
      	the old and new values of gimp_image_has_alpha().
      
      	* app/gui/preferences-dialog.c (prefs_dialog_new): follow
      	"foo-window-type" -> "foo-window-hint" change.
      d528848f
    • Michael Natterer's avatar
      also return the color's alpha byte if it has alpha, not only the converted · 9efe077c
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.[ch] (gimp_image_get_color): also return the
      	color's alpha byte if it has alpha, not only the converted RGB
      	values.  Return OPAQUE_OPACITY for drawables without alpha.
      	Fixes bug #131706.
      
      	* app/core/gimpdrawable.c (gimp_drawable_get_color_at)
      	* app/core/gimpimage-contiguous-region.c
      	(gimp_image_contiguous_region_by_color)
      	* app/core/gimpimage-projection.c (gimp_image_projection_get_color_at)
      	* app/core/gimpimagemap.c (gimp_image_map_get_color_at)
      	* app/paint/gimpclone.c (gimp_clone_line_image): removed separate
      	handling of the alpha byte from all users of gimp_image_get_color().
      9efe077c
    • Michael Natterer's avatar
      use gimp_drawable_bytes_with_alpha(). · b2c661e3
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/paint/gimppaintcore.c (gimp_paint_core_get_paint_area): use
      	gimp_drawable_bytes_with_alpha().
      b2c661e3
    • Michael Natterer's avatar
      don't allow to select anything but the floating selection. Fixes bug · 370a16fa
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_set_active_layer): don't allow
      	to select anything but the floating selection. Fixes bug #128025.
      
      	(gimp_image_set_active_layer,channel,vectors): allow to pass NULL
      	to unselect the active item. Removed the silly feature that
      	passing some random item of another image would select the first
      	item in the list (was unused anyway).
      
      	(gimp_image_unset_active_channel): use gimp_image_set_active_channel()
      	now that it accepts NULL.
      
      	(gimp_image_add_layer,channel,vectors): cleaned up / simplified.
      
      	(gimp_image_remove_layer,channel,vectors): cleanup,
      	simplification, use gimp_image_set_active_layer,channel,vectors()
      	now that they accept NULL, make sure the item next to the removed
      	item becomes the active one (and not the first in the list, which
      	was a severe usability problem in the dialogs).
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer,channel): pass
      	NULL to the set_active functions, cleanup.
      
      	* app/core/gimpimage-duplicate.c: attach the floating selection
      	before setting the active layer. Code relied on broken
      	gimp_image_set_active_layer() behaviour before.
      
      	* app/core/gimplayer-floating-sel.c: no need to set
      	gimage->floating_sel before calling gimp_image_add_layer(). The
      	weird GUI mentioned in the comment existed in 1.2 only.
      
      	* app/display/gimpdisplayshell-layer-select.c (layer_select_advance):
      	don't assume that setting the active_layer always succeeds.
      
      	* tools/pdbgen/pdb/image.pdb: behave as the documentation says
      	and return an execution error if setting the active layer or
      	channel failed.
      
      	Unrelated:
      
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb: removed leftover cruft from the old
      	guchar based color API.
      
      	* tools/pdbgen/pdb/channel.pdb: simplified code which handles the
      	channel's color.
      
      	* app/pdb/channel_cmds.c
      	* app/pdb/image_cmds.c: regenerated.
      370a16fa
    • Simon Budig's avatar
      fixed typo. · b18e38c7
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
              * app/gui/about-dialog.c: fixed typo.
      b18e38c7
    • Simon Budig's avatar
      make sure we always properly use the size of the logo image. Place the · 8cdcee96
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
      	* app/gui/about-dialog.c: make sure we always properly use
      	the size of the logo image. Place the text at the bottom
      	of the image when the size changes (position of the version
      	string needs to be adjusted manually still...).
      
      	* data/images/gimp_logo.png: slightly tweaked.
      
      	* data/images/gimp1_0_logo.png: added for historical reasons.
      8cdcee96
    • Sven Neumann's avatar
      redone to make it work again. · 15d4c9f4
      Sven Neumann authored
      2004-01-18  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/file-open-dialog.c (file_open_create_thumbnail): redone
      	to make it work again.
      
      	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_load_thumb): fixed
      	stupid mistake that caused thumbnails not to load under certain
      	circumstances.
      15d4c9f4
    • Michael Natterer's avatar
      removed broken code which tried to figure manually whether "alpha_changed" · f8e9fbc1
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer): removed broken
      	code which tried to figure manually whether "alpha_changed" should
      	be emitted. Instead, simply compare the return values of
      	gimp_image_has_alpha() before and after adding/removing the
      	layer. Fixes bug #131721.
      f8e9fbc1
  2. 17 Jan, 2004 6 commits
  3. 16 Jan, 2004 9 commits
    • Manish Singh's avatar
      Fix typo · 7656d6bb
      Manish Singh authored
      7656d6bb
    • Sven Neumann's avatar
      app/config/gimpguiconfig.[ch] app/config/gimprc-blurbs.h · bfe567c4
      Sven Neumann authored
      2004-01-17  Sven Neumann  <sven@gimp.org>
      
      	* app/config/gimpguiconfig.[ch]
      	* app/config/gimprc-blurbs.h
      	* app/widgets/gimpdock.c
      	* app/widgets/gimptoolbox.c
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/widgets-enums.[ch]: GTK+-2.4 will allow to request
      	windows to be kept above. This change prepares the code so that we
      	can optionally do this for docks and the toolbox as soon as we
      	depend on GTK+-2.4 (see bug #131672).
      bfe567c4
    • Dave Neary's avatar
      Apply a (modified) patch from Pablo d'Angelo to enable saving of a · c40b7bb0
      Dave Neary authored
      
      
      2004-01-16  Dave Neary  <bolsh@gimp.org>
      
              * plug-ins/common/tiff.c: Apply a (modified) patch from Pablo
              d'Angelo to enable saving of a non-premultiplied alpha channel
              and provide an UI to use it (a checkbox and extra PDB
              procedure). Fixes bug #131030.
      c40b7bb0
    • Sven Neumann's avatar
      do a proper fix for bug #131680. · 4a234e44
      Sven Neumann authored
      2004-01-16  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpcroptool.c (crop_recalc): do a proper fix for bug
      	#131680.
      4a234e44
    • David Odin's avatar
      bloc some signals before destroying the info dialog box, to prevent · 04d7e139
      David Odin authored
      * app/tools/gimpcroptool.c: bloc some signals before destroying the
      info dialog box, to prevent accessing to freed memory fixes bug #131680
      04d7e139
    • Sven Neumann's avatar
      fixed typo (bug #131670). · ddbc0908
      Sven Neumann authored
      2004-01-16  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/menus.c (menus_init): fixed typo (bug #131670).
      ddbc0908
    • Dave Neary's avatar
      Update NEWS file again. · 480d921d
      Dave Neary authored
      
      
      2004-01-16  Dave Neary  <bolsh@gimp.org>
      
              * NEWS: Update NEWS file again.
      480d921d
    • Michael Natterer's avatar
      converted tabs to spaces. · b6683376
      Michael Natterer authored
      2004-01-16  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/edit-commands.[ch]: converted tabs to spaces.
      
      	(cut,copy_named_buffer_callback): unref the buffer after adding it
      	to gimp->named_buffers. Seems we leaked all named buffers...
      
      	Removed code duplication I have just introduced:
      
      	* app/gui/edit-commands.[ch] removed
      	edit_paste_into_cmd_callback(). Instead, pass the "paste_into"
      	boolean as "guint action" to gimp_edit_paste_cmd_callback().
      
      	* app/gui/image-menu.c: changed accordingly.
      
      	* app/widgets/gimpbufferview.c: added utility function
      	gimp_buffer_view_paste() and call it from the paste and paste_into
      	callbacks.
      b6683376
    • Jan Morén's avatar
      Updated Swedish translation. · 6f96feba
      Jan Morén authored
      2004-01-16  Jan Morén  <jan.moren@lucs.lu.se>
      
               * sv.po: Updated Swedish translation.
      6f96feba
  4. 15 Jan, 2004 16 commits
    • Manish Singh's avatar
      Minor cleanup, add note about using pango_fc_font_description_from_pattern · d7c8844c
      Manish Singh authored
      2004-01-15  Manish Singh  <yosh@gimp.org>
      
              * app/text/gimpfontlist.c: Minor cleanup, add note about using
              pango_fc_font_description_from_pattern from pango 1.4 when we
              can.
      d7c8844c
    • David Odin's avatar
      Do not display the color button or the "Random Hue" range when applying to · 32ee5e7c
      David Odin authored
      	* plug-ins/common/nova.c: Do not display the color button or the
      	"Random Hue" range when applying to a grayscale image.
      32ee5e7c
    • Pedro Gimeno's avatar
      Removed the code that disables save formats conditionally, making all of · 465e4372
      Pedro Gimeno authored
      2004-01-15  Pedro Gimeno  <pggimeno@wanadoo.es>
      
      	* app/gui/file-save-menu.c (file_save_menu_update): Removed the
      	code that disables save formats conditionally, making all of
      	them available. Fixes bug #110610.
      465e4372
    • David Odin's avatar
    • Manish Singh's avatar
      Set PangoStretch from FC_WIDTH. This partially addresses #131561 (namely, · cc2534b1
      Manish Singh authored
      2004-01-15  Manish Singh  <yosh@gimp.org>
      
              * app/text/gimpfontlist.c: Set PangoStretch from FC_WIDTH. This
              partially addresses #131561 (namely, the gimp side).
      cc2534b1
    • Michael Natterer's avatar
      added plug-ins/helpbrowser/domain.c · 8137bbcf
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	* POTFILES.in: added plug-ins/helpbrowser/domain.c
      8137bbcf
    • Michael Natterer's avatar
      removed GIMP_HELP_DEFAULT_DOMAIN #define... · c7fbda34
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/helpbrowser/helpbrowser.c: removed
      	GIMP_HELP_DEFAULT_DOMAIN #define...
      
      	* plug-ins/helpbrowser/domain.h: ...and added it here.
      
      	* plug-ins/helpbrowser/domain.c: fixed the fix for bug #128112:
      	don't compare the help domain's base uri (which is variable) but
      	the help domain's name (which is constant). Re-added removed
      	information to the error message while keeping its user
      	readability. Marked g_message() strings for translation.
      c7fbda34
    • David Odin's avatar
    • Michael Natterer's avatar
      Fixed bug #78732 (don't paste off screen): · 0af39061
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	Fixed bug #78732 (don't paste off screen):
      
      	* app/display/gimpdisplayshell-transform.[ch]: added new function
      	gimp_display_shell_untransform_viewport() which returns the
      	visible rectangle of the image in image coordinates.
      
      	* app/core/gimp-edit.[ch] (gimp_edit_paste): added viewport
      	parameters and changed positioning of the pasted layer as follows:
      
      	- if there is a selection, center on the selection (just as before).
      	- if there is no viewport, center on the active drawable.
      	- if the viewport intersects with the active drawable, center
      	  on the intersection.
      	- if the viewport does *not* intersect with the active drawable,
      	  center on the active drawable (off-screen, but better than pasting
      	  something that will be invisible due to floating selection clipping).
      	- if there is no active drawable, center on the viewport.
      	- if there is no active drawable and no viewport, center on the image.
      
      	* app/widgets/gimpbufferview.c (gimp_buffer_view_paste_clicked)
      	(gimp_buffer_view_paste_into_clicked)
      	* app/display/gimpdisplayshell-dnd.c (gimp_display_shell_drop_buffer)
      	* app/gui/edit-commands.c (edit_paste_cmd_callback)
      	(edit_paste_into_cmd_callback): ask the shell for the viewport
      	and pass it to gimp_edit_paste().
      
      	* app/display/gimpdisplayshell-dnd.c
      	(gimp_display_shell_drop_drawable): center the created layer on
      	the viewport.
      
      	* app/tools/gimpmovetool.c (gimp_move_tool_button_release): use
      	gimp_display_shell_untransform_viewport() (its code was taken from
      	here).
      
      	* tools/pdbgen/pdb/edit.pdb: pass "no viewport" to gimp_edit_paste().
      
      	* app/pdb/edit_cmds.c: regenerated.
      0af39061
    • Dave Neary's avatar
      Now that we're in pre-release mode, list all the bugs fixed in this · a1fd8fb4
      Dave Neary authored
      
      2004-01-15  Dave Neary  <bolsh@gimp.org>
      
              * NEWS: Now that we're in pre-release mode, list all the bugs fixed
              in this release, rather than features added. Commits which don't fix
              bugs are listed in the "Other contributions" section. Bugs were added
              in chronological order according to when the fix was committed (so
              the first bug in the list was the one committed soonest after the
              2.0pre1 release).
      a1fd8fb4
    • Dave Neary's avatar
      Now that we're in pre-release mode, list all the bugs fixed in this · c038ba10
      Dave Neary authored
      
      
      2004-01-15  Dave Neary  <bolsh@gimp.org>
      
              * NEWS: Now that we're in pre-release mode, list all the bugs fixed
              in this release, rather than features added. Commits which don't fix
              bugs are listed in the "Other contributions" section. Bugs were added
              in chronological order according to when the fix was committed (so
              the first bug in the list was the one committed soonest after the
              2.0pre1 release).
      c038ba10
    • Michael Natterer's avatar
      moved initialization of the gimage->visible[] and gimage->active[] arrays · d994e904
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c: moved initialization of the
      	gimage->visible[] and gimage->active[] arrays from
      	gimp_image_new() to gimp_image_init(). Use gimp_rgba_set()
      	to initialize gimage->qmask_color.
      d994e904
    • Dave Neary's avatar
      Modify error messages shown when help files cannot be opened. For the main · 955de22e
      Dave Neary authored
      
      
      2004-01-15  Dave Neary  <bolsh@gimp.org>
      
              * plug-ins/helpbrowser/domain.c: Modify error messages shown when
      	help files cannot be opened. For the main GIMP help domain, the
              error message is now "Failed to open help files:\nTheGIMP help files
              are not installed." and in the general case "Failed to open help
              files:\nThe requested help file %s could not be opened.\nPlease check
              your installation." This fixes bug #128112.
      955de22e
    • Sven Neumann's avatar
      added a "validate" rule that attempts to validate the generated · 2d775c66
      Sven Neumann authored
      2004-01-15  Sven Neumann  <sven@gimp.org>
      
      	* data/misc/Makefile.am: added a "validate" rule that attempts to
      	validate the generated gimp.desktop file using desktop-file-validate
      	(from desktop-file-utils). Run it on 'make dist'.
      
      	* tips/Makefile.am: for consistency, moved the existing validation
      	code to a rule called "validate".
      2d775c66
    • Danilo Šegan's avatar
      Updated Serbian translation. · bbd01ccd
      Danilo Šegan authored
      bbd01ccd
    • Manish Singh's avatar
      #include "file/file-utils.h" for file_utils_filename_to_utf8. · 35f1fd42
      Manish Singh authored
      2004-01-14  Manish Singh  <yosh@gimp.org>
      
              * app/config/gimpconfig-utils.c: #include "file/file-utils.h" for
              file_utils_filename_to_utf8.
      35f1fd42