GitLab

The fix was bogusly destroying a region that is still needed
for the last end_change() if the change count is > 1.

Instead of doing it in gimp_display_shell_set_padding() from where
it's called.

Remove gimp_display_shell_draw_grid().

It was correct only for the currently existing use cases.

Change the generated tag names to use #rrggbb notation and compare the
colors on an 8 bit basis to make sure the comparison and the tag names
exist in the same set of values (otherwise the text buffer gets into
an inconsistent state that can even lead to crashes).

Shouldn't change anything, just be slightly faster in some cases.

and use it to set visibility of guides and sample points, so this
reression is fixed.

- return NULL extents for invisible items and never draw them
- do nothing for invisible items in more places, like the group

While hacking this, it turned out that it was a braino to collect an
item's region before and after a change in
dispatch_properties_changed(), so a new update had to be devised:

- add a "change count" and new API begin_change()/end_change()
- in begin_change(), remember the item's extents before the change
- in end_change(), combine old and current extents and emit "update"
- add some protected function to emit "update", and to figure if
  it makes sense at all to emit "update" on an item.

because constructing the region can be expensive. Also make sure not
to use g_object_set() if nothing would change to further reduce
"update" emissions.

which gets emitted when the item wants to be redrawn:

- Emit "update" it when any item property changes
- Groups connect to their children and forward "update" for them
- The shell connects to its group of canvas items and exposed
  the affected area
- Remove gimp_display_shell_expose_item()
- Move all the shell's item group code into gimpdisplayshell-items.c

because each item has a shell now. Keep the parameter in the virtual
functions though because that saves a lot of code in the subclasses.

and use it in all tools which have groups.

and pass it to all constructors. The GimpDisplayShell is needed
because items are going to become more powerful soon.

- Add signals GimpImage::guide_added(), removed() and moved()
- Remove singal GimpImage::update_guide()
- Adapt core code to emit the new signals instead of update_guide()
- Have the shell connect to the new signals and update guide canvas
  items as needed
- Remove gimp_display_shell_draw_guides()

- Add GimpImage signal "sample-point-moved" and emit it when needed
- Let the shell connect to the sample point add, remove and move signals
  and update the canvas items accordingly
- Remove gimp_display_shell_draw_sample_points()

which is a group that keeps a mapping between arbitrary pointers and
canvas items. No MVC whatsoever yet, just a simple hash table.

For consistency Use a static GParam array for the return values
in all plug-ins.

God knows how many other plug-ins have this.

and add it to gimpcanvassamplepoint.c, it doesn't need to be public
any longer.

and remove gimp_display_shell_expose_guide() and _sample_point().

and use it in the color tool. Also rename
gimp_draw_tool_add_guide_line() to gimp_draw_tool_add_guide().

and draw all sample points in gimp_display_shell_draw_sample_points().

and use it in gimp_display_shell_draw_sample_point().