1. 21 May, 2006 5 commits
    • Michael Natterer's avatar
      prefix with GIMP_TOOL_ACTION_ · b3c20ed2
      Michael Natterer authored
      2006-05-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/tools-enums.h (enum GimpToolAction): prefix with
      	GIMP_TOOL_ACTION_
      
      	* app/display/gimpdisplay.c
      	* app/display/gimpdisplayshell.c
      	* app/tools/gimpaligntool.c
      	* app/tools/gimpcolorpickertool.c
      	* app/tools/gimpcolortool.c
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpdrawtool.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/tools/gimpfreeselecttool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimpiscissorstool.c
      	* app/tools/gimpmeasuretool.c
      	* app/tools/gimpmovetool.c
      	* app/tools/gimpnewrectselecttool.c
      	* app/tools/gimppainttool.c
      	* app/tools/gimpselectiontool.c
      	* app/tools/gimptexttool.c
      	* app/tools/gimptool.c
      	* app/tools/gimptransformtool.c
      	* app/tools/gimpvectortool.c
      	* app/tools/tool_manager.c: changed accordingly. Introduce a
      	common style for GimpTool::control()'s switch() block. Some
      	minor cleanups.
      b3c20ed2
    • Michael Natterer's avatar
      don't try to reset the active tool by destroying and re-creating it · 57df85fa
      Michael Natterer authored
      2006-05-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/tool_manager.c (tool_manager_image_clean_dirty): don't
      	try to reset the active tool by destroying and re-creating it
      	because this doesn't work while gimp->busy is TRUE. Call
      	tool_manager_control_active(HALT) instead, which is the right way
      	to do it anyway. Fixes bug #330083.
      
      	Sprinkled some local variables all over the place to get rid of a
      	gazillion tool_manager->active_tool.
      57df85fa
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 00aad904
      William Skaggs authored
      	* app/tools/gimpaligntool.c: get rid of "dispose" method, use
      	tool-control-halt to shut things down instead.
      00aad904
    • Michael Natterer's avatar
      One of the following changes fixes a crash on exit when there is a cut · a5de974a
      Michael Natterer authored
      2006-05-21  Michael Natterer  <mitch@gimp.org>
      
      	One of the following changes fixes a crash on exit when there is a
      	cut buffer and a clipboard manager is runnig. I don't care which,
      	since they are all the right thing to do:
      
      	* app/widgets/gimpdialogfactory.c (gimp_dialog_factory_finalize):
      	don't remove the factory from the hash table of all factories here...
      
      	(gimp_dialog_factory_dispose): ...but here. Use the right key for
      	the toolbox factory.
      
      	(gimp_dialog_factories_set_busy)
      	(gimp_dialog_factories_unset_busy): check the return value of
      	g_type_class_ref() before using it.
      
      	Unrelated:
      
      	(gimp_dialog_factory_dispose): free the list of open dialogs here,
      	not in dispose(). Don't leak all the factory's session infos.
      a5de974a
    • Michael Natterer's avatar
      app/core/Makefile.am new files with functions to translate, flip, rotate, · 3e5b6e0e
      Michael Natterer authored
      2006-05-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/Makefile.am
      	* app/core/gimpimage-item-list.[ch]: new files with functions to
      	translate, flip, rotate, transform and align a list of items
      	inside an undo group.
      
      	(gimp_image_item_list_get_list): returns a list of items matching
      	any combination of GimpItemTypeMask and GimpItemSet.
      
      	* app/core/gimpitem.[ch]: added new function gimp_item_is_in_set().
      
      	* app/core/gimpitem-linked.[ch]: use the new functions. Removed
      	gimp_item_linked_get_list().
      
      	* app/tools/gimpeditselectiontool.c: use
      	gimp_image_item_list_get_list() instead of
      	gimp_item_linked_get_list().
      
      	* app/core/gimpimage-resize.c
      	* app/tools/gimpaligntool.c: use the new functions instead of
      	creating and iterating the lists manually.
      3e5b6e0e
  2. 20 May, 2006 1 commit
    • Manish Singh's avatar
      Fixes to address -ansi -pedantic compilation (bug #342390). Thanks goes to · b9416956
      Manish Singh authored
      2006-05-20  Manish Singh  <yosh@gimp.org>
      
              Fixes to address -ansi -pedantic compilation (bug #342390).
              Thanks goes to Daniel Richard G. for noticing and suggesting
              fixes.
      
              * libgimpbase/gimpsignal.c: #include "config.h" and define
              __POSIX_SOURCE for sigaction stuff.
      
              * app/base/tile-swap.c (tile_swap_test): use more portable
              S_IRUSR and S_IWUSR, instead of S_IREAD and S_IWRITE.
      
              * plug-ins/common/ripple.c
              * plug-ins/imagemap/imap_main.c: use C89 comments.
      
              * plug-ins/Lighting/lighting_preview.h: don't define spin widget
              variables here...
      
              * plug-ins/Lighting/lighting_ui.[ch]: ... and instead take care
              of them here.
      b9416956
  3. 19 May, 2006 10 commits
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 1beec263
      William Skaggs authored
      	* libgimpwidgets/gimpwidgets.c (gimp_coordinates_callback):
      	use ROUND() to prevent incorrect chainbutton logic.  Fixes
      	bug #336259.
      1beec263
    • Sven Neumann's avatar
      use the same rounding to determine width and height from the TransInfo · 419087b3
      Sven Neumann authored
      2006-05-19  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpscaletool.c (gimp_scale_tool_dialog_update,
      	gimp_scale_tool_size_notify): use the same rounding to determine
      	width and height from the TransInfo struct.
      419087b3
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 5e78e9a2
      William Skaggs authored
      	* plug-ins/common/vpropagate.c: swap meanings of "dilate"
      	and "erode"; fixes bug #156545.
      5e78e9a2
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 34e144e1
      William Skaggs authored
      	* plug-ins/common/tga.c: gracefully handle incorrect alpha
      	info in header; fixes bug #306675.
      34e144e1
    • Michael Natterer's avatar
      remove enum GimpItemLinkedMask... · 42ff7f49
      Michael Natterer authored
      2006-05-19  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpitem-linked.h: remove enum GimpItemLinkedMask...
      
      	* app/core/core-enums.[ch]: ...and add it here as GimpItemTypeMask.
      	Renamed enum GimpImageResizeLayers to GimpItemSet.
      
      	* app/core/gimpitem-linked.[ch]
      	* app/core/gimpimage-resize.[ch]
      	* app/dialogs/resize-dialog.[ch]
      	* app/actions/image-commands.c
      	* app/actions/layers-commands.c
      	* app/tools/gimpeditselectiontool.c: changed accordingly.
      42ff7f49
    • Sven Neumann's avatar
      tools/pdbgen/pdb/convert.pdb do not use enum values in C syntax to · 36ea51a2
      Sven Neumann authored
      2006-05-19  Sven Neumann  <sven@gimp.org>
      
      	* tools/pdbgen/pdb/convert.pdb
      	* tools/pdbgen/pdb/image.pdb: do not use enum values in C syntax
      	to describe the image mode.
      
      	* app/pdb/convert_cmds.c
      	* app/pdb/image_cmds.c
      	* libgimp/gimpconvert_pdb.c
      	* libgimp/gimpimage_pdb.c: regenerated.
      36ea51a2
    • Michael Natterer's avatar
      turn c_style_procedure_names() in $proc->{help} into · ca1fb7b7
      Michael Natterer authored
      2006-05-19  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/app.pl: turn c_style_procedure_names() in
      	$proc->{help} into 'canonical-procedure-names'.
      
      	* tools/pdbgen/pdb/color.pdb: std_pdb_deprecated() expects
      	canonical procedure names.
      
      	* app/pdb/color_cmds.c
      	* app/pdb/drawable_cmds.c
      	* app/pdb/drawable_transform_cmds.c
      	* app/pdb/edit_cmds.c
      	* app/pdb/paths_cmds.c
      	* app/pdb/progress_cmds.c: regenerated.
      ca1fb7b7
    • Sven Neumann's avatar
      removed one of the two constrain properties. · fec7ca95
      Sven Neumann authored
      2006-05-19  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimptransformoptions.[ch]: removed one of the two
      	constrain properties.
      
      	* app/tools/gimprotatetool.c
      	* app/tools/gimptransformtool.c: changed accordingly.
      
      	* app/tools/gimpscaletool.c: sync "constrain" with the size-box's
      	"keep-aspect" property.
      fec7ca95
    • Sven Neumann's avatar
      connect to the chain-button and update the "keep-aspect" property when it · 414e6616
      Sven Neumann authored
      2006-05-19  Sven Neumann  <sven@gimp.org>
      
      	* app/widgets/gimpsizebox.c: connect to the chain-button and
      	update the "keep-aspect" property when it is toggled.
      414e6616
    • Sven Neumann's avatar
      actually use the new tool icon. · c6d8d492
      Sven Neumann authored
      2006-05-19  Sven Neumann  <sven@gimp.org>
      
              * app/tools/gimpaligntool.c (gimp_align_tool_register): actually
              use the new tool icon.
      c6d8d492
  4. 18 May, 2006 8 commits
    • Kevin Cozens's avatar
      tinyscheme/CHANGES tinyscheme/scheme.c Updated to version 1.37 of · bddb9779
      Kevin Cozens authored
      2006-05-18  Kevin Cozens  <kcozens@cvs.gnome.org>
      
      	* tinyscheme/CHANGES
      	* tinyscheme/scheme.c
      	* tinyscheme/scheme.h: Updated to version 1.37 of TinyScheme. Adds
      	'reserve_cells' to TinyScheme interface, moves the comment handling
      	which fixes an obscure bug, and a patch for the allocator.
      bddb9779
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · c0446247
      William Skaggs authored
      	* app/dialogs/file-save-dialog.c: make sure to disconnect
      	callback added in previous change.
      c0446247
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · ae2e871b
      William Skaggs authored
      	* app/dialogs/file-save-dialog.c: make sure dialog has
      	not been destroyed when setting sensitive; fixes
      	bug #322978.
      ae2e871b
    • Sven Neumann's avatar
      use the enum's name instead of the nick, strip the "GIMP_" prefix and · 03f0f655
      Sven Neumann authored
      2006-05-18  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpparamspecs-desc.c: use the enum's name instead of
      	the nick, strip the "GIMP_" prefix and canonicalize it.
      03f0f655
    • Sven Neumann's avatar
      typos · 7b5484fc
      Sven Neumann authored
      7b5484fc
    • Sven Neumann's avatar
      reverted one aspect of the last change and always load the scripts again. · 847131f1
      Sven Neumann authored
      2006-05-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/script-fu/script-fu.c (script_fu_run): reverted one
      	aspect of the last change and always load the scripts again.
      847131f1
    • Sven Neumann's avatar
      tools/pdbgen/app.pl removed code that used to fiddles with the argument · fae8657c
      Sven Neumann authored
      2006-05-18  Sven Neumann  <sven@gimp.org>
      
      	* tools/pdbgen/app.pl
      	* tools/pdbgen/lib.pl: removed code that used to fiddles with
      the
      	argument descriptions.
      
      	* tools/pdbgen/pdb/*.pdb: removed %%desc%% placeholder, added
      some
      	missing argument descriptions.
      
      	* app/pdb/*_cmds.c
      	* libgimp/gimpdrawabletransform_pdb.c
      	* libgimp/gimpfloatingsel_pdb.c
      	* libgimp/gimpgradient_pdb.c
      	* libgimp/gimppainttools_pdb.c: regenerated.
      
      	* app/core/Makefile.am
      	* app/core/gimpparamspecs-desc.[ch] (gimp_param_spec_get_desc):
      	new function that creates a parameter description for the PDB.
      
      	* app/pdb/gimppdb-query.c
      	* app/pdb/procedural_db_cmds.c: use the new function to create
      the
      	descriptions on the fly.
      fae8657c
    • Michael Natterer's avatar
      add tooltips to all hue partition radio buttons. · ac20627c
      Michael Natterer authored
      2006-05-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimphuesaturationtool.c: add tooltips to all hue
      	partition radio buttons.
      
      	* app/tools/gimptextoptions.[ch]
      	* app/tools/gimpvectoroptions.[ch]: add the widgets that are
      	needed by the tools as members to the options structs instead of
      	attaching them with g_object_set_data().
      
      	* app/tools/gimptexttool.c
      	* app/tools/gimpvectortool.c: access the struct members instead of
      	using g_object_get_data().
      ac20627c
  5. 17 May, 2006 13 commits
    • Kevin Cozens's avatar
      Added quotes in two AM_CONDITIONAL lines to avoid complaints of "test: too · 160f04c4
      Kevin Cozens authored
      2006-05-17  Kevin Cozens  <kcozens@cvs.gnome.org>
      
      	* configure.in: Added quotes in two AM_CONDITIONAL lines to avoid
      	complaints of "test: too many arguments" when running ./configure.
      160f04c4
    • Michael Natterer's avatar
      move the align tool after the move tool. · f42487cf
      Michael Natterer authored
      2006-05-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimp-tools.c (gimp_tools_init): move the align tool
      	after the move tool.
      f42487cf
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 6477f2c1
      William Skaggs authored
      	* themes/Default/images/tools/stock-tool-align-16.png
      	* themes/Default/images/tools/stock-tool-align-22.png
      	* libgimpwidgets/gimpstock.c
      	* libgimpwidgets/gimpstock.h
      	* themes/Default/images/Makefile.am: add new (ugly) icon
      	for alignment tool.
      
      	* app/tools/gimpaligntool.c: use the new icon; change
      	"pressed" to "clicked" for buttons.
      6477f2c1
    • Michael Natterer's avatar
      use the same method as the newly added text tool code for finding a · cecc9556
      Michael Natterer authored
      2006-05-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimpvectortool.c (gimp_vector_tool_set_vectors): use
      	the same method as the newly added text tool code for finding a
      	suitable display for the vectors.
      cecc9556
    • Michael Natterer's avatar
      app/core/gimpbrushclipboard.c (gimp_brush_clipboard_buffer_changed) limit · aebf12df
      Michael Natterer authored
      2006-05-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpbrushclipboard.c
      	(gimp_brush_clipboard_buffer_changed)
      	* app/core/gimppatternclipboard.c
      	(gimp_pattern_clipboard_buffer_changed): limit the size of
      	clipboard brushes and patterns to 512x512 pixels to prevent OOM
      	conditions when copying from huge drawables.
      aebf12df
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 0f77a496
      William Skaggs authored
      	* app/tools/gimpaligntool.[ch]: major change in ui, to make
      	this tool behave like alignment tools found in vector apps.
      	now you select items by clicking or drawing a rubber-band
      	rectangle, add items by holding down shift, and then press
      	a button to align all the selected items.
      0f77a496
    • Michael Natterer's avatar
      moved the collection of plug-in args to a utilty function. Add another · 633897f5
      Michael Natterer authored
      2006-05-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/actions/plug-in-commands.c: moved the collection of plug-in
      	args to a utilty function. Add another function that is called
      	when the plug-in lives in <Brushes>, <Palettes> etc. and pass the
      	active object's name to the plug-in.
      
      	* plug-ins/pygimp/plug-ins/Makefile.am
      	* plug-ins/pygimp/plug-ins/palette-offset.py
      	* plug-ins/pygimp/plug-ins/palette-sort.py
      	* plug-ins/pygimp/plug-ins/palette-to-gradient.py: added new
      	scripts written by Joao S. O. Bueno Calligaris and fixed by Carol
      	Spears. Changed them myself again. The stuff doesn't work as
      	expected because python-fu has too much asumptions in its
      	register() code, and the sort script doesn't implement all modes
      	of Adrian's palette sorting perl script. Addresses bug #104639.
      633897f5
    • Michael Natterer's avatar
      app/core/gimpbrushclipboard.c (gimp_brush_clipboard_buffer_changed) remove · 1b60573f
      Michael Natterer authored
      2006-05-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpbrushclipboard.c
      	(gimp_brush_clipboard_buffer_changed)
      	* app/core/gimppatternclipboard.c
      	(gimp_pattern_clipboard_buffer_changed): remove calls to
      	gimp_data_dirty() because the emission of "name-changed" takes
      	care of that.
      1b60573f
    • Sven Neumann's avatar
      app/core/gimpbrushclipboard.c (gimp_brush_clipboard_buffer_changed) emit · 5084a123
      Sven Neumann authored
      2006-05-17  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpbrushclipboard.c
      	(gimp_brush_clipboard_buffer_changed)
      	* app/core/gimppatternclipboard.c
      	(gimp_pattern_clipboard_buffer_changed): emit "name-changed" so that
      	the description is being updated.
      5084a123
    • Michael Natterer's avatar
      add a clipboard pattern to the pattern factory (forgot to commit this · 10976751
      Michael Natterer authored
      2006-05-17  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimp.c (gimp_real_initialize): add a clipboard pattern
      	to the pattern factory (forgot to commit this file).
      10976751
    • Manish Singh's avatar
      po-libgimp/Makefile.in.in po-plug-ins/Makefile.in.in · b6a9aa63
      Manish Singh authored
      2006-05-17  Manish Singh  <yosh@gimp.org>
      
              * po-libgimp/Makefile.in.in
              * po-plug-ins/Makefile.in.in
              * po-script-fu/Makefile.in.in
              * po-tips/Makefile.in.in: revert previous changes, it doesn't
              look straightforward to change these without bumping up the
              intltool dependency.
      b6a9aa63
    • Sven Neumann's avatar
      synced function names with the header file. · 33abaee8
      Sven Neumann authored
      2006-05-17  Sven Neumann  <sven@gimp.org>
      
      	* libgimpwidgets/gimpresolutionentry.c: synced function names with
      	the header file.
      
      	* libgimpwidgets/gimpwidgets.def: added missing entries.
      33abaee8
    • Manish Singh's avatar
      po-libgimp/Makefile.in.in po-plug-ins/Makefile.in.in · c33345bf
      Manish Singh authored
      2005-05-16  Manish Singh  <yosh@gimp.org>
      
              * po-libgimp/Makefile.in.in
              * po-plug-ins/Makefile.in.in
              * po-script-fu/Makefile.in.in
              * po-tips/Makefile.in.in: synchronized with po/Makefile.in.in.
      
              * gimptool-2.0.in
              * gimptool-win32.c.in: add reference to datarootdir.
      c33345bf
  6. 16 May, 2006 3 commits
    • Michael Natterer's avatar
      app/core/Makefile.am app/core/core-types.h new GimpPattern subclass that · d7cd890c
      Michael Natterer authored
      2006-05-16  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/Makefile.am
      	* app/core/core-types.h
      	* app/core/gimppatternclipboard.[ch]: new GimpPattern subclass
      	that auto-updates its contents from gimp->global_buffer.
      
      	* app/core/gimp.c (gimp_real_initialize): add a clipboard pattern
      	to the pattern factory.
      
      	* app/widgets/gimpaction.c (gimp_action_set_proxy): replace the
      	GimpView by a new one if the viewable type changes, instead of
      	running into a warning (didn't happen before because this is only
      	used for imagefiles and patterns, which didn't have subclasses).
      d7cd890c
    • Karine Delvare's avatar
      check if the tool has a display before using it · f1d058df
      Karine Delvare authored
      2006-05-16  Karine Delvare  <edhel@gimp.org>
      
      	* app/tools/gimprectangletool.c: check if the tool has a display
      	before using it
      f1d058df
    • Michael Natterer's avatar
      app/paint-funcs/paint-funcs-generic.h implement copy_color() and · d15a6191
      Michael Natterer authored
      2006-05-16  Michael Natterer  <mitch@gimp.org>
      
      	* app/paint-funcs/paint-funcs-generic.h
      	* app/paint-funcs/paint-funcs.[ch]: implement copy_color() and
      	copy_color_pixels() which copy only the color bytes into a dest
      	that has one byte less than src. Renamed component_pixels() to
      	copy_component_pixels().
      
      	* app/core/Makefile.am
      	* app/core/core-types.h
      	* app/core/gimpbrushclipboard.[ch]: new GimpBrush subclass that
      	auto-updates its contents from gimp->global_buffer.
      
      	* app/core/gimp.c (gimp_real_initialize): add a clipboard brush to
      	the brush factory. Fixes bug #111082.
      d15a6191