GitLab

By the Dicom Standard, elements which would be odd in length must be
padded to an even length. Patch from Paul Epperson.

Don't store layer offsets in the PNG, or honor them on loading. The layer
position is given by the OpenRaster layer attributes alone. This caused a bug
where the offsets were applied twice, positioning the layer wrong.

With the same limitation as for guides in the last commit.

Doesn't really clip yet for guide drawing, but at least doesn't bother
to draw them when they are outside the expose region's bounding box.

because we now guarantee to only pass in-image areas to draw.

and as a "side effect", speed up rendering the image significantly:

- disable double buffering on the canvas widget.
- implement background clearing ourselves (needed after turning off
  double buffering).
- remove any fiddling with clipping regions on the tool drawing GCs
  and pull the pause/resume code out of the actual image expose
  function.
- if there are overlay widgets on the canvas, implement double
  buffering manually to aviod flicker, but do it in a way that keeps
  pausing/resuming the active tool *outside* the double buffered
  drawing.

gimp_overlay_child_expose(): clip drawing to event->region.

gimp_overlay_child_damage(): transform and invalidate event->region's
rectangles individually to avoid redundant invalidations.

This reverts commit cc60d331.

This reverts commit 2525e304.

I had to remove the asserrt in tool preset constructor, because with it
it wasnt possible to initalize an empty model object for the editor.
At init time the gimp object passed to the constructor is not yet available.

Remove the draw timeout in GObject::dispose() to be safe.

currently respects the fact that FG/BG are always global and the
global brush,pattern,... settings from gimprc. This should probably
not change, but rather be overridable on a per-preset basis as
suggested.

Use a real g_warning() because this is a programming error. Please
report all warnings.

with bogus values from contextrc, we want them to always match the
tool option's type.

but don't set any tool options yet because that is a lot more tricky.

Override GimpContext's "tool" property and add an evil function that
makes sure we don't set a tool that doesn't match the options. Needed
because tool options are read from disk and thus unreliable per se,
additional we were stupid and wrote wrong tool options to disk.