1. 02 Jan, 2001 2 commits
  2. 01 Jan, 2001 1 commit
    • Michael Natterer's avatar
      app/commands.[ch] app/fileops.[ch] app/gdisplay.c Implemented "Save a Copy · 9ccab852
      Michael Natterer authored
      2001-01-02  Michael Natterer  <mitch@gimp.org>
      
      	* app/commands.[ch]
      	* app/fileops.[ch]
      	* app/gdisplay.c
      	* app/menus.c: Implemented "Save a Copy as..." which saves the image
      	without changing it's filename.
      
      	* app/layers_dialogP.h: export layers_dialog_layer_merge_query()
      	here instead of defining it in commands.c
      
      	* TODO.xml: mark this entry as done :)
      9ccab852
  3. 30 Dec, 2000 1 commit
    • Michael Natterer's avatar
      removed all the "typedef gimage_function gimp_image_function" stuff so we · 4a0f7c58
      Michael Natterer authored
      2000-12-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/gimage.[ch]: removed all the
      	"typedef gimage_function gimp_image_function" stuff so we can clearly
      	see what is really a GImage function.
      	Removed gimage_get_ID(). Use pdb_id_to_image() instead.
      
      	* app/airbrush.c
      	* app/desaturate.c
      	* app/disp_callbacks.c
      	* app/equalize.c
      	* app/fileops.c
      	* app/floating_sel.c
      	* app/gdisplay_ops.c
      	* app/gimpdrawable.c
      	* app/global_edit.c
      	* app/image_map.c
      	* app/invert.c
      	* app/lc_dialog.c
      	* app/paths_dialog.c
      	* app/plug_in.c
      	* app/xcf.c
      
      	* app/color_cmds.c
      	* app/convert_cmds.c
      	* app/image_cmds.c
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/convert.pdb
      	* tools/pdbgen/pdb/image.pdb: changed accordingly.
      4a0f7c58
  4. 29 Dec, 2000 1 commit
    • Michael Natterer's avatar
      app/Makefile.am app/channel_pvt.h app/drawable_pvt.h app/gdisplayF.h · 8d6c335f
      Michael Natterer authored
      2000-12-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/channel_pvt.h
      	* app/drawable_pvt.h
      	* app/gdisplayF.h
      	* app/gimpdrawableP.h
      	* app/gimpimageP.h
      	* app/layer_pvt.h
      	* app/toolsF.h: removed these files.
      
      	* app/apptypes.h
      	* tools/pdbgen/enums.pl: added tons of opaque typedefs and enums.
      
      	* tools/pdbgen/pdb/brush_select.pdb
      	* tools/pdbgen/pdb/brushes.pdb
      	* tools/pdbgen/pdb/channel.pdb
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/convert.pdb
      	* tools/pdbgen/pdb/display.pdb
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/fileops.pdb
      	* tools/pdbgen/pdb/gradient_select.pdb
      	* tools/pdbgen/pdb/gradients.pdb
      	* tools/pdbgen/pdb/help.pdb
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/pattern_select.pdb
      	* tools/pdbgen/pdb/patterns.pdb
      	* tools/pdbgen/pdb/selection.pdb
      	* tools/pdbgen/pdb/tools.pdb
      	* app/*: chainsaw #include cleanup:
      
      	- Never (never!!) include stuff in header files except where we
      	  need access to structures' contents (like derived objects).
      	- Added prototypes and proper formating in many files.
      	- The #include order in *all* *.c files is as follows:
      
      	#include "config.h"
      
      	#include <system stuff>
      
      	#include <gtk/gtk.h>
      
      	#include "apptypes.h"
      
      	#include "gimp stuff"
      
      	#include "libgimp stuff"
      
      	#include "libgimp/gimpintl.h"
      
      	By following this scheme we can easily see a file's dependencies
      	from it's #include's and can grep for the inclusion to find out
      	where a file is used.
      
      	* tools/pdbgen/app.pl: changed to follow the include scheme above.
      
      	* libgimp/Makefile.am
      	* libgimp/gimpuitypes.h: new file, included from libgimp/gimpui.h
      	and from app/apptypes.h.
      
      	* libgimp/gimpcolorbutton.[ch]
      	* libgimp/gimpdialog.[ch]
      	* libgimp/gimphelpui.[ch]
      	* libgimp/gimpparasite.[ch]
      	* libgimp/gimppatheditor.[ch]
      	* libgimp/gimpprotocol.c
      	* libgimp/gimpquerybox.[ch]
      	* libgimp/gimpsizeentry.[ch]
      	* libgimp/gimptypes.h
      	* libgimp/gimpui.h
      	* libgimp/gimpunit.h
      	* libgimp/gimpunitmenu.[ch]
      	* libgimp/gimpwidgets.[ch]: changed accordingly.
      
      	* plug-ins/FractalExplorer/Dialogs.c
      	* plug-ins/gdyntext/message_window.c
      	* plug-ins/imagemap/imap_default_dialog.c
      	* plug-ins/imagemap/imap_file.c: these files used to include
      	"libgimp/gimpui.h" without including "libgimp/gimp.h". This is
      	no longer possible because the libgimpui headers don't inlcude
      	"libgimp/gimpunit.h" any more.
      8d6c335f
  5. 28 Dec, 2000 1 commit
    • Michael Natterer's avatar
      app/channel.[ch] app/drawable.h app/gimpdrawable.[ch] app/gimpdrawableP.h · 0d440e10
      Michael Natterer authored
      2000-12-28  Michael Natterer  <mitch@gimp.org>
      
      	* app/channel.[ch]
      	* app/drawable.h
      	* app/gimpdrawable.[ch]
      	* app/gimpdrawableP.h
      	* app/gimpimage.[ch]
      	* app/gimpimageP.h
      	* app/layer.[ch]
      	* app/layer_pvt.h: started a major cleanup of all image/drawable
      	files. Added tons of "const GimpImage *" declarations and properly
      	formated the headers.
      
      	* app/bezier_select.c
      	* app/channels_dialog.c
      	* app/crop.c
      	* app/fileops.[ch]
      	* app/fuzzy_select.c
      	* app/gdisplay.c
      	* app/layers_dialog.c
      	* app/move.c
      	* app/paint_funcs.[ch]
      	* app/qmask.c
      	* app/undo.c: changed accordingly plus the usual portion of coding
      	style paranoia. This is not finished but Sven promised to buy me
      	a beer if I commit now ;)
      0d440e10
  6. 16 Dec, 2000 1 commit
    • Sven Neumann's avatar
      Last-minute cleanup: · dfa2bed5
      Sven Neumann authored
      2000-12-16  Sven Neumann  <sven@gimp.org>
      
      	Last-minute cleanup:
      
      	* app/gimpdrawableF.h
      	* app/gimphistogramF.h
      	* app/gimpimageF.h
      	* app/gimplistF.h
      	* app/gimplutF.h
      	* app/gimpobjectF.h
      	* app/gimpsetF.h
      	* app/layerF.h
      	* app/parasitelistF.h: removed these files
      
      	* app/Makefile.am
      	* tools/pdbgen/Makefile.am: changed accordingly
      
      	* app/[almost every file]: include cleanup
      dfa2bed5
  7. 15 Dec, 2000 1 commit
  8. 11 Dec, 2000 1 commit
    • Sven Neumann's avatar
      check for NULL pointer · d7c90b6d
      Sven Neumann authored
      2000-12-11  Sven Neumann  <sven@gimp.org>
      
      	* app/channel.c (channel_invalidate_previews): check for NULL pointer
      
      	* app/fileops.c: if saving and loading images at the same time, the
      	PDB obviously manages to mangle return values. By checking the
      	validity of the returned image id we avoid to crash as described in
      	bug #26788.
      
      	* app/module_db.c: unload modules from the idle_loop as suggested
      	by Austin in #5745.
      d7c90b6d
  9. 18 Nov, 2000 1 commit
    • Michael Natterer's avatar
      app/fileops.c Make sure that we don't try to destroy query_boxes twice or · cdd0a514
      Michael Natterer authored
      2000-11-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/fileops.c
      	* libgimp/gimpquerybox.[ch]: Make sure that we don't try to destroy
      	query_boxes twice or try to disconnect not-any-more connected
      	handlers.
      
      	* app/color_notebook.c
      	* app/gimpcontext.[ch]
      	* app/gimphelp.[ch]
      	* app/lc_dialog.[ch]
      	* app/menus.h
      	* app/preferences_dialog.c
      	* app/tools.[ch]
      	* libgimp/gimpcolorbutton.[ch]
      	* libgimp/gimpdialog.[ch]
      	* libgimp/gimpexport.[ch]
      	* libgimp/gimpfileselection.[ch]
      	* libgimp/gimphelpui.[ch]
      	* libgimp/gimppatheditor.[ch]
      	* libgimp/gimppixmap.[ch]
      	* libgimp/gimpsizeentry.[ch]
      	* libgimp/gimpui.[ch]
      	* libgimp/gimpunitmenu.[ch]
      	* libgimp/gimpwidgets.[ch]: in a coding attack, changed help_data
      	and many other strings passed to UI functions to (const gchar *).
      	As a consequence, I had to fix lots of warnings ;)
      
      	* plug-ins/common/tga.c
      	* plug-ins/imagemap/imap_main.c: fixed warnings.
      
      	Code cleanup and indentation all over the place.
      cdd0a514
  10. 15 Nov, 2000 1 commit
  11. 09 Nov, 2000 1 commit
  12. 25 Sep, 2000 1 commit
  13. 23 Aug, 2000 1 commit
    • Sven Neumann's avatar
      make the file_save dialog sensitive again if the user clicked "No" when · 5b205f17
      Sven Neumann authored
      2000-08-23  Sven Neumann  <sven@gimp.org>
      
      	* app/fileops.c: make the file_save dialog sensitive again if the
      	user clicked "No" when asked if he wishes to overwrite a file.
      
      	* app/gimpimage.c: when saving an undoable parasite, just do it
      	without calling undo_push_cantundo(). Undoable parasites are used
      	by many save plug-ins to attach a comment, but this operation
      	shouldn't prevent the user from using the undo_stack afterwards.
      	The JPEG plug-in has an additional bug that I couldn't solve, so
      	undoing after a Save As JPEG is still impossible.
      
      	* app/undo_history.c: lame attempt to draw the clean symbol at the
      	correct undo step. Not perfect but much better as before...
      5b205f17
  14. 18 Aug, 2000 1 commit
    • BST 2000 Austin Donnelly's avatar
      fix nasty bug where if overwriting a file and also changing the format, · 42839da3
      BST 2000 Austin Donnelly authored
      Fri Aug 18 18:14:35 BST 2000 Austin Donnelly <austin@gimp.org>
      
      	* app/fileops.c: fix nasty bug where if overwriting a file and
      	    also changing the format, gimp would use the old format
          	    rather than the newly selected one.  To repeat: save a new
          	    image as (eg) jpeg by typing foo.jpg<RET>, then Save As XCF by
          	    using the pop-up menu and clicking OK, then Save As jpeg by
          	    using pop-up and clicking OK, and OK again to allow the file
          	    to be overwritten.  You should find that foo.jpg contains an
          	    XCF version of the image.  This was because the "overwrite"
          	    path through the code was subtly different from the standard
          	    way through, meaning that gimage_set_save_proc() was never
          	    called.  Now unified into new function file_save_with_proc().
      42839da3
  15. 17 Aug, 2000 1 commit
  16. 11 May, 2000 1 commit
  17. 08 May, 2000 1 commit
  18. 07 May, 2000 1 commit
    • Michael Natterer's avatar
      app/app_procs.c named all public functions document_index_*(). Don't · 031e3dea
      Michael Natterer authored
      2000-05-07  Michael Natterer  <mitch@gimp.org>
      
      	* app/app_procs.c
      	* app/docindex.[ch]: named all public functions document_index_*().
      	Don't loop/segfault when opening an old "ideas" file but silently
      	skip the first line.
      
      	* app/fileops.[ch]: do some file access sanity checks before
      	actually calling the load/save proc. Show the full file name
      	in all error messages. Use a query_boolean_box for the overwrite
      	warning. Made file_save() static.
      	Also copied some Win32 #define's from libgimp/gimpenv.c for the
      	file access stuff. Tor, could you have a look at them please?
      031e3dea
  19. 27 Apr, 2000 1 commit
    • Michael Natterer's avatar
      app/color_select.c app/colormaps.[ch] removed unused global variables · c73b233f
      Michael Natterer authored
      2000-04-26  Michael Natterer  <mitch@gimp.org>
      
      	* app/color_select.c
      	* app/colormaps.[ch]
      	* app/context_manager.c: removed unused global variables
      	[foreground|background]_pixel and [old|new]_color_pixel.
      
      	Initialize the colormap and visual stuff with GdkRGB instead of
      	GtkPreview functions (which are deprecated).
      
      	* app/[62 files]: removed #include's (started with colormaps.h and
      	couldn't stop). Also ordered them consistently and did some small
      	unrelated cleanups.
      	Removed variuos <stdlib.h> et.al. but checked the files carefully
      	before doing so. If I was too radical and you get warnings on your
      	platform, please flame me or just put them back :)
      c73b233f
  20. 07 Apr, 2000 1 commit
    • Sven Neumann's avatar
      implemented the changes Nick Lamb suggested: If the background layer has · 62546d89
      Sven Neumann authored
      * libgimp/gimpexport.c: implemented the changes Nick Lamb
      suggested:  If the background layer has no alpha channel,
      suggest "Flatten" instead of "Merge Visible Layers".
      
      * app/fileops.c: In the MRU list and the doc_index always store
      the absolute path to images, so you can open files from the
      command-line and gimp will find them later if started from another
      dir. Added tooltips that show the full path.
      
      * app/menus.c: fixed a memleak (list entries were not freed on
      removal from the MRU list).
      
      * app/main.c
      * app/user_install.[ch]: renamed functions and variables to match
      the new filename.
      
      
      --Sven
      62546d89
  21. 06 Apr, 2000 1 commit
  22. 28 Mar, 2000 1 commit
  23. 27 Mar, 2000 1 commit
  24. 21 Mar, 2000 1 commit
  25. 12 Mar, 2000 1 commit
  26. 10 Mar, 2000 1 commit
    • Sven Neumann's avatar
      applied a bunch of patches: · 24bbdbef
      Sven Neumann authored
      Simon Budigs patch sent to the list Sun, 20 Feb 2000
      gimp-kirchgessner-000217-0
      gimp-cosmin-20000212
      gimp-mattias-000227-0
      
      
      --Sven
      24bbdbef
  27. 23 Feb, 2000 1 commit
  28. 20 Feb, 2000 1 commit
  29. 26 Jan, 2000 1 commit
  30. 25 Jan, 2000 1 commit
    • Michael Natterer's avatar
      configure.in po-plug-ins/POTFILES.in plug-ins/common/Makefile.am · fa30ba04
      Michael Natterer authored
      2000-01-25  Michael Natterer  <mitch@gimp.org>
      
      	* configure.in
      	* po-plug-ins/POTFILES.in
      	* plug-ins/common/Makefile.am
      	* plug-ins/common/plugin-defs.pl
      	* plug-ins/megawidget/*: removed. (There were only 3 functions
      	left which were used by ~5 plugins, so I moved the resp. functions
      	to the plugins). More preview stuff to come...
      
      	* app/airbrush_blob.c
      	* modules/colorsel_triangle.c
      	* modules/colorsel_water.c: use G_PI instead of M_PI.
      
      	* app/procedural_db.h
      	* libgimp/gimpenums.h
      	* plug-ins/script-fu/script-fu-constants.c
      	* tools/pdbgen/enums.pl: new PDB return value STATUS_CANCEL which
      	indicates that "Cancel" was pressed in a plugin dialog. (Useful
      	only for file load/save plugins).
      
      	* app/fileops.[ch]
      	* app/menus.c: changes to handle STATUS_CANCEL correctly. Did some
      	code cleanup in fileops.[ch]. Pop up a warning if File->Save
      	failed.
      
      	* app/plug_in.c: return_val[0] is of type PDB_STATUS, not
      	PDB_INT32.
      
      	* libgimp/gimpmath.h: new constant G_MAXRAND which equals to
      	RAND_MAX if it exists or to G_MAXINT otherwise.
      
      	* libgimp/gimpwidgets.[ch]: new function gimp_random_seed_new()
      	which creates a spinbutton and a "Time" toggle.
      	Call the function which does the "set_sensitive" magic from the
      	radio button callback.
      
      	* plug-ins/[75 plugins]:
      
      	- Return STATUS_CANCEL in all file load/save dialogs if "Cancel"
      	  was pressed.
      	- Standardized the file plugins' "run" functions.
      	- Use G_PI and G_MAXRAND everywhere.
      	- Added tons of scales and spinbuttons instead of text entries.
      	- Applied uniform packing/spacings all over the place.
      	- Reorganized some UIs (stuff like moving the preview to the top
      	  left corner of the dialog).
      	- Removed many ui helper functions and callbacks and use the stuff
      	  from libgimp instead.
      	- I tried not to restrict the range of possible values when I
      	  replaced entries with spinbuttons/scales but may have failed,
      	  though in some cases. Please test ;-)
      	- #include <libgimp/gimpmath.h> where appropriate and use it's
      	  constants.
      	- Indentation, s/int/gint/ et.al., code cleanup.
      
      	RFC: The plugins are definitely not useable with GIMP 1.0 any
      	     more, so shouldn't we remove all the remaining compatibility
      	     stuff ??? (like "#ifdef GIMP_HAVE_PARASITES")
      fa30ba04
  31. 06 Jan, 2000 1 commit
    • Michael Natterer's avatar
      app/[all files using the dialog or action area constructors] added a · 884f2235
      Michael Natterer authored
      2000-01-06  Michael Natterer  <mitch@gimp.org>
      
      	* app/[all files using the dialog or action area constructors]
      	* libgimp/gimpdialog.[ch]: added a "slot_object" agrument to the
      	constructors' va_args lists to allow the action area buttons to be
      	connected wich gtk_signal_connect_object().
      
      	* libgimp/gimphelp.c: show the correct help page for plugins.
      
      	* plug-ins/common/CEL.c
      	* plug-ins/common/CML_explorer.c
      	* plug-ins/common/Makefile.am
      	* plug-ins/common/aa.c
      	* plug-ins/common/align_layers.c
      	* plug-ins/common/animationplay.c
      	* plug-ins/common/apply_lens.c
      	* plug-ins/common/blinds.c
      	* plug-ins/common/blur.c
      	* plug-ins/common/bumpmap.c
      	* plug-ins/common/checkerboard.c
      	* plug-ins/common/colorify.c
      	* plug-ins/common/colortoalpha.c
      	* plug-ins/common/compose.c
      	* plug-ins/common/convmatrix.c
      	* plug-ins/common/csource.c
      	* plug-ins/common/cubism.c
      	* plug-ins/common/curve_bend.c
      	* plug-ins/common/decompose.c
      	* plug-ins/common/deinterlace.c
      	* plug-ins/common/depthmerge.c
      	* plug-ins/common/despeckle.c
      	* plug-ins/common/destripe.c
      	* plug-ins/common/diffraction.c
      	* plug-ins/common/displace.c
      	* plug-ins/common/grid.c
      	* plug-ins/helpbrowser/Makefile.am
      	* plug-ins/helpbrowser/helpbrowser.c: use the dialog constructor
      	and enable the "F1" help key.
      884f2235
  32. 01 Jan, 2000 1 commit
  33. 30 Dec, 1999 1 commit
  34. 29 Dec, 1999 1 commit
  35. 14 Dec, 1999 2 commits
  36. 27 Nov, 1999 1 commit
  37. 23 Nov, 1999 1 commit
    • Michael Natterer's avatar
      app/app_procs.c app/channels_dialog.c app/fileops.c app/gdisplay.c · b6a3dd5a
      Michael Natterer authored
      1999-11-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/app_procs.c
      	* app/channels_dialog.c
      	* app/fileops.c
      	* app/gdisplay.c
      	* app/gdisplay_ops.c
      	* app/layers_dialog.c
      	* app/menus.[ch]
      	* app/paths_dialog.c
      	* app/plug_in.c: removed
      	menus_set_[sensitive|state]_glue(). Removed the N_()'s from all
      	menu paths which are not eventually passed to
      	gtk_item_factory_create_item().
      
      	* app/tool_options.c: minor updates.
      
      	* app/file_new_dialog.c: reordered the action_area buttons.
      b6a3dd5a
  38. 20 Nov, 1999 1 commit
    • Michael Natterer's avatar
      Reorganized the core menu items (everything except <Image>/Filters). · e46eaf86
      Michael Natterer authored
      1999-11-20  Michael Natterer  <mitch@gimp.org>
      
      	Reorganized the core menu items (everything except
      	<Image>/Filters). Everything is of course trivial to change again,
      	so please comment on the new "menu feeling" ;-)
      
      	* app/menus.[ch]:
      
      	- Applied the suggestions collected by Olof.
      	- Added "..." to all items which open a dialog.
      	- Introduced some additional separators (e.g. in "Dialogs").
      	- Reorder some plugins and the color correct tools after
      	  initialisation.
      	- A menu entry to invoke the tooltips inspector.
      	- A debugging menu entry which dumps the menu paths and their help
      	  pages (will of course go away when the help sys is consistent).
      
      	There are currently two identical "Help" menus because
      	<Toolbox>/Help trashes the menu bar if the toolbox is too narrow
      	(gtk doesn't seem to support multi-line menubars, any idea?)
      
      	* app/app_procs.c: call menus_reorder_plugins() after loading the
      	plugins to beautify the "Xtns" menu.
      
      	* app/commands.[ch]: reordered some functions to match the new
      	menu structure (for easier source navigation) and renamed some to
      	be consistent (e.g. all help functions are now called help_*).
      
      	Show/Hide the rulers with ordinary gtk_widget_[show|hide]()
      	commands. I've tested it several times and it looks exactly the
      	same as the old code which used internal gtk knowledge.
      
      	* app/gdisplay.c: applied the menu changes to
      	gdisplay_set_menu_sensitivity().
      
      	* app/gimphelp.[ch]: new public function gimp_context_help() which
      	invokes the tooltips inspector. Code cleanup.
      
      	* app/resize.c: changed the dialogs' titles to match the menu entries.
      
      	* app/session.c: renamed the gradient selection cmd callback to be
      	consistent with brushes/patterns.
      
      	* app/tools.c: added "..." to the menu paths of the tools which
      	have dialogs.
      
      	* app/fileops.c
      	* app/channels_dialog.c
      	* app/layers_dialog.c
      	* app/paths_dialog.c: added some "...".
      
      	* plug-ins/common/align_layers.c
      	* plug-ins/common/autostretch_hsv.c
      	* plug-ins/common/c_astretch.c
      	* plug-ins/common/color_enhance.c
      	* plug-ins/common/compose.c
      	* plug-ins/common/decompose.c
      	* plug-ins/common/mail.c
      	* plug-ins/common/normalize.c
      	* plug-ins/common/threshold_alpha.c
      	* plug-ins/dbbrowser/dbbrowser.c
      	* plug-ins/fp/fp.c
      	* plug-ins/print/print.c
      	* plug-ins/rcm/rcm.c: changed the menu paths and added "...".
      e46eaf86