1. 31 Mar, 2006 7 commits
    • Sven Neumann's avatar
      app/dialogs/Makefile.am app/dialogs/dialogs-types.h app/dialogs/dialogs.c · 9996bb7a
      Sven Neumann authored
      2006-03-31  Sven Neumann  <sven@gimp.org>
      
      	* app/dialogs/Makefile.am
      	* app/dialogs/dialogs-types.h
      	* app/dialogs/dialogs.c
      	* app/dialogs/info-dialog.[ch]: good bye InfoDialog.
      
      	* app/tools/gimpperspectivetool.[ch]
      	* app/tools/gimprotatetool.[ch]
      	* app/tools/gimpsheartool.[ch]
      	* app/tools/gimptransformtool.[ch]: use GimpToolDialog instead of
      	InfoDialog and add the widgets manually.
      
      	* app/tools/gimpscaletool.c: commented out use of InfoDialog. This
      	tools still needs to be ported to GimpToolDialog.
      9996bb7a
    • Michael Natterer's avatar
      added gimp_procedure_new() and gimp_procedure_free() functions. · 49da8cb2
      Michael Natterer authored
      2006-03-31  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/gimpprocedure.[ch]: added gimp_procedure_new() and
      	gimp_procedure_free() functions.
      
      	* app/plug-in/plug-in-proc-def.h (struct PlugInProcDef): use a
      	ProcRecord pointer instead of including the entire struct.
      
      	* app/plug-in/plug-in-proc-def.c: use the new() and free()
      	functions above to allocate/free the ProcRecord.
      
      	* app/actions/plug-in-actions.c
      	* app/actions/plug-in-commands.c
      	* app/menus/plug-in-menus.c
      	* app/plug-in/plug-in-message.c
      	* app/plug-in/plug-in-rc.c
      	* app/plug-in/plug-in-run.c
      	* app/plug-in/plug-in.c
      	* app/plug-in/plug-ins-query.c
      	* app/plug-in/plug-ins.c
      	* app/xcf/xcf.c: changed accordingly.
      
      	Unrelated:
      
      	* app/pdb/gimpprocedure.c (gimp_procedure_execute): be more verbose
      	when warning about out-of-bounds parameter values.
      
      	* tools/pdbgen/pdb/fileops.pdb: allow GIMP_RUN_WITH_LAST_VALS for
      	file_save because indirect saving (e.g. remote or compressed)
      	needs it.
      
      	* app/pdb/fileops_cmds.c: regenerated.
      49da8cb2
    • Sven Neumann's avatar
      fixed compiler warning and sprinkled some empty lines for readability. · 20a48412
      Sven Neumann authored
      2006-03-31  Sven Neumann  <sven@gimp.org>
      
      	* app/paint-funcs/scale-funcs.c: fixed compiler warning and
      	sprinkled some empty lines for readability.
      20a48412
    • Michael Natterer's avatar
      always set dockable->blurb to NULL, also if its memory is shared with · 87e7cb1f
      Michael Natterer authored
      2006-03-31  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimpdockable.c (gimp_dockable_destroy): always set
      	dockable->blurb to NULL, also if its memory is shared with
      	dockable->name.
      87e7cb1f
    • Sven Neumann's avatar
      use "gtk-dialog-question" instead of "gimp-wilber-eek" to indicate a · bb28d144
      Sven Neumann authored
      2006-03-31  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpimagefile.c (gimp_imagefile_get_new_pixbuf): use
      	"gtk-dialog-question" instead of "gimp-wilber-eek" to indicate a
      	missing thumbnail.
      bb28d144
    • Michael Natterer's avatar
      app/pdb/Makefile.am new files containing the functions operating on *one* · 1dac2783
      Michael Natterer authored
      2006-03-31  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/Makefile.am
      	* app/pdb/gimpprocedure.[ch]: new files containing the functions
      	operating on *one* procedure. Factored out of procedural_db.[ch]
      	and renamed to gimp_procedure_foo().
      
      	* app/pdb/procedural_db.[ch]: removed them here.
      
      	* app/pdb/procedural-db-query.c
      	* app/batch.c
      	* app/actions/plug-in-commands.c
      	* app/actions/vectors-commands.c
      	* app/core/gimppdbprogress.c
      	* app/file/file-open.c
      	* app/file/file-save.c
      	* app/plug-in/plug-in-message.c
      	* app/plug-in/plug-in-proc-def.[ch]
      	* app/plug-in/plug-in-progress.c
      	* app/plug-in/plug-in-rc.c
      	* app/plug-in/plug-in-run.c
      	* app/plug-in/plug-ins.c
      	* app/widgets/gimpfiledialog.c
      	* app/widgets/gimphelp.c
      	* app/widgets/gimppdbdialog.c
      	* app/xcf/xcf.c
      	* tools/pdbgen/pdb/fileops.pdb
      	* tools/pdbgen/app.pl: changed #includes and function calls
      	accordingly. No logic changed.
      
      	* app/pdb/*_cmds.c: regenerated.
      1dac2783
    • Sven Neumann's avatar
      applied a patch from Guillermo S. Romero that adds basic support for · 5e969a4a
      Sven Neumann authored
      2006-03-31  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/psd_save.c: applied a patch from Guillermo
      	S. Romero that adds basic support for saving layer masks.
      5e969a4a
  2. 30 Mar, 2006 11 commits
    • Sven Neumann's avatar
      use doubles for src coordinates. Added properties for "src-drawable", · 0b12c776
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* app/paint/gimpclone.[ch]: use doubles for src coordinates. Added
      	properties for "src-drawable", "src-x" and "src-y".
      
      	* tools/pdbgen/pdb/paint_tools.pdb: resurrected cloning from
      	drawables over the PDB. This used to be broken for quite a while.
      
      	* app/pdb/paint_tools_cmds.c: regenerated.
      0b12c776
    • Michael Natterer's avatar
      don't memset(0) the array of return values if the procedure didn't · 4b24ca37
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.c (procedural_db_execute_proc): don't
      	memset(0) the array of return values if the procedure didn't
      	succeed. GValues don't like to be treated like that and I don't
      	understand what the memsetting is good for. It just looks like a
      	very bad hack.
      
      	* app/file/file-open.c: additionally, don't access return_vals[>0]
      	unless the procedure returned successfully.
      
      	* app/core/gimppdbprogress.c
      	* app/widgets/gimppdbdialog.c: procedural_db_run_proc() always
      	returns non-NULL, no need to check for it.
      4b24ca37
    • Michael Natterer's avatar
      got rid of one more (the last?) perl utility function. · eed050e4
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/procedural_db.pdb: got rid of one more (the
      	last?) perl utility function.
      eed050e4
    • Sven Neumann's avatar
      0b309182
    • Sven Neumann's avatar
      added gimp_get_temp_filename(). · acc84675
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimp-utils.[ch]: added gimp_get_temp_filename().
      
      	* tools/pdbgen/pdb/fileops.pdb (temp_name): removed the
      	implementation here and call gimp_get_temp_filename() instead.
      
      	* app/pdb/fileops_cmds.c: regenerated.
      acc84675
    • Michael Natterer's avatar
      renamed member "arg_type" to "type". · 55578d0d
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.h (structs Argument and ProcArg): renamed
      	member "arg_type" to "type".
      
      	* app/pdb/procedural_db.c
      	* app/pdb/procedural-db-query.c
      	* app/actions/plug-in-commands.c
      	* app/core/gimppdbprogress.c
      	* app/plug-in/plug-in-params.c
      	* app/plug-in/plug-in-progress.c
      	* app/plug-in/plug-in-rc.c
      	* tools/pdbgen/pdb/fileops.pdb
      	* tools/pdbgen/pdb/procedural_db.pdb: changed accordingly.
      
      	* app/pdb/fileops_cmds.c
      	* app/pdb/procedural_db_cmds.c: regenerated.
      55578d0d
    • Sven Neumann's avatar
      actually increment the tile counter used to limit the number of progress · 0768628a
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* app/base/siox.c (siox_foreground_extract): actually increment
      	the tile counter used to limit the number of progress updates.
      0768628a
    • Michael Natterer's avatar
      also unref the ProcRecord's GParamSpecs. · 9a6273f9
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.c (procedural_db_free_entry): also
      	unref the ProcRecord's GParamSpecs.
      9a6273f9
    • Sven Neumann's avatar
      return FALSE in case of a valid parasite. · 1c88d72f
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpparamspecs.c (gimp_param_parasite_validate): return
      	FALSE in case of a valid parasite.
      1c88d72f
    • Sven Neumann's avatar
      sprinkled a few G_UNLIKELY() macros to help the compiler. · 75737492
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* libgimpbase/gimpwire.c (gimp_wire_read, gimp_wire_write):
      	sprinkled a few G_UNLIKELY() macros to help the compiler.
      75737492
    • Sven Neumann's avatar
      actually free the memory allocated for the procedure entry. · 7aec70eb
      Sven Neumann authored
      2006-03-30  Sven Neumann  <sven@gimp.org>
      
      	* app/pdb/procedural_db.c (procedural_db_free_entry): actually
      	free the memory allocated for the procedure entry.
      7aec70eb
  3. 29 Mar, 2006 14 commits
    • Michael Natterer's avatar
      replace the value union by a GValue. · afd88f0b
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.[ch] (struct Argument): replace the value
      	union by a GValue.
      
      	(procedural_db_argument_init)
      	(procedural_db_compat_arg_init): new functions to initialize
      	an Argument. They call g_value_init() on the Argument's value.
      
      	(procedural_db_arguments)
      	(procedural_db_return_values): initialize the returned Argument
      	arrays so their GValues are ready to use. Allow to get the
      	(unsuccessful) return values of a NULL ProcRecord.
      
      	(procedural_db_destroy_args): g_value_unset() the values. Added a
      	"gboolean full_destroy" parameter. Its only effect is to destroy
      	PDB arrays, everything else is nicely memory managed by GValue.
      
      	(procedural_db_execute)
      	(procedural_db_run_proc): do GValue stuff. Added n_args and
      	n_return_vals parameters to execute().
      
      	(procedural_db_execute_proc): private function to execute a
      	procedure. Validates the passed in arguments using the registered
      	GParamSpecs before passing them to the resp. exec method.
      
      	* app/plug-in/plug-in-params.[ch] (plug_in_params_to_args): needs
      	an array of ProcArgs now in order to initialize the Arguments'
      	GValues correctly. Passing NULL ProcArgs uses
      	procedural_db_compat_arg_init(), so procedures (plug-ins)
      	returning more values than expected work.
      
      	(plug_in_args_to_params): do GValue stuff here too.
      
      	(plug_in_args_destroy): removed this function,
      	procedural_db_destroy_args() does the same now.
      
      	* app/plug-in/plug-in-message.c (plug_in_handle_proc_run):
      	simplified quite a bit because everything returns n_return_values
      	now. Call plug_in_params_to_args() only of the procedure was found.
      
      	(plug_in_handle_proc_return_priv): pass ProcRecs to
      	plug_in_params_to_args().
      
      	* app/batch.c
      	* app/actions/plug-in-commands.c
      	* app/actions/vectors-commands.c
      	* app/core/gimppdbprogress.c
      	* app/dialogs/about-dialog.c
      	* app/file/file-open.c
      	* app/file/file-save.c
      	* app/plug-in/plug-ins.c
      	* app/plug-in/plug-in-progress.c
      	* app/plug-in/plug-in-run.[ch]
      	* app/widgets/gimphelp.c
      	* app/widgets/gimppdbdialog.c
      	* app/xcf/xcf.c
      	* tools/pdbgen/pdb/fileops.pdb: changed accordingly: don't
      	g_new/g_free Argument arrays, always use procedural_db_foo()
      	functions. Use GValue functions to get/set Arguments.
      
      	* tools/pdbgen/pdb.pl: added get_value_func and set_value_func to
      	all PDB types. Removed id_func, id_ret_func and check_func. Added
      	flags which indicated that a type is an ID. Removed unused utility
      	functions.
      
      	* tools/pdbgen/lib.pl: use the flag instead of looking at
      	functions and value types.
      
      	* tools/pdbgen/app.pl: use the get_value_func and set_value_func
      	to marshal inargs and outargs. Removed all checks performed on
      	inargs because that's done by GParamSpec validation now. Added the
      	missing bits to register excluded values with GimpParamSpecEnum.
      
      	* app/pdb/*_cmds.c: regenerated.
      afd88f0b
    • Michael Natterer's avatar
      can't just cast the GPParamDefs to ProcArgs any more, their struct layouts · d69e93ce
      Michael Natterer authored
      2006-03-30  Michael Natterer  <mitch@gimp.org>
      
      	* app/plug-in/plug-in-params.c (plug_in_param_defs_check): can't
      	just cast the GPParamDefs to ProcArgs any more, their struct
      	layouts are different now. Convert them into temporary ProcArgs
      	before calling plug_in_proc_args_check()
      d69e93ce
    • Michael Natterer's avatar
      added GimpParamSpecEnum, which is a GParamSpecEnum plus the possibility to · b4695095
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpparamspecs.[ch]: added GimpParamSpecEnum, which is
      	a GParamSpecEnum plus the possibility to exclude values.
      	Fixed lots of validation functions.
      	Made all structs and macros public.
      b4695095
    • Michael Natterer's avatar
      switch to g_return_val_if_fail() because it got a return value. · 0d383b18
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.c (procedural_db_init_proc): switch to
      	g_return_val_if_fail() because it got a return value.
      0d383b18
    • Michael Natterer's avatar
      pass the filename, not a GimpImage to file_utils_filename_to_uri(). Fixes · 393343ac
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/fileops.pdb (file_save): pass the filename, not
      	a GimpImage to file_utils_filename_to_uri(). Fixes bug #336527.
      
      	* app/pdb/fileops_cmds.c: regenerated.
      393343ac
    • Sven Neumann's avatar
      dropped the extension from the icon name (bug #336498). · 2a825f36
      Sven Neumann authored
      2006-03-29  Sven Neumann  <sven@gimp.org>
      
      	* desktop/gimp.desktop.in.in: dropped the extension from the icon
      	name (bug #336498).
      2a825f36
    • Michael Natterer's avatar
      fixed forgotten antique enum values (RGBA_GIMAGE -> GIMP_RGB_IMAGE etc.) · f580468c
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/drawable.pdb (drawable_type_with_alpha): fixed
      	forgotten antique enum values (RGBA_GIMAGE -> GIMP_RGB_IMAGE etc.)
      
      	* app/pdb/drawable_cmds.c: regenerated.
      f580468c
    • Michael Natterer's avatar
      return the procedure. · 396f92b8
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/pdb/procedural_db.[ch] (procedural_db_init_proc): return the
      	procedure.
      
      	* tools/pdbgen/app.pl: use a local ProcRecord* variable so the
      	generated code becomes more readable.
      
      	* app/pdb/*_cmds.c: regenerated.
      396f92b8
    • Michael Natterer's avatar
      add newline to g_printerr(). · d624560f
      Michael Natterer authored
      2006-03-29  Michael Natterer  <mitch@gimp.org>
      
      	* libgimp/gimp.c (gimp_run_procedure2): add newline to g_printerr().
      d624560f
    • Sven Neumann's avatar
      added an explicit dependency to force creation of gimp-wilber-pixbufs.h. · 3c704917
      Sven Neumann authored
      2006-03-29  Sven Neumann  <sven@gimp.org>
      
      	* libgimpwidgets/Makefile.am: added an explicit dependency to
      	force creation of gimp-wilber-pixbufs.h.
      3c704917
    • Sven Neumann's avatar
      remove the build rules for wilber-pixbufs.h · 443996f9
      Sven Neumann authored
      443996f9
    • Sven Neumann's avatar
      desktop/Makefile.am removed. · ca8ef2e3
      Sven Neumann authored
      2006-03-29  Sven Neumann  <sven@gimp.org>
      
              * desktop/Makefile.am
              * desktop/gimp.png: removed.
      
              * desktop/16x16/gimp.png
              * desktop/22x22/gimp.png
              * desktop/24x24/gimp.png
              * desktop/32x32/gimp.png
              * desktop/48x48/gimp.png
              * desktop/64x64/gimp.png
              * desktop/scalable/gimp.svg: new application icons in different
              sizes, contributed by Jakub Steiner.
      
              * themes/Default/images/Makefile.am
              * themes/Default/images/stock-wilber-32.png
              * themes/Default/images/stock-wilber-48.png: removed.
      
              * libgimpwidgets/Makefile.am
              * libgimpwidgets/wilber-16.png
              * libgimpwidgets/wilber-32.png
              * libgimpwidgets/wilber-48.png
              * libgimpwidgets/wilber-64.png: new window icons, identical to the
              new application icons.
      
              * libgimpwidgets/gimpwidgets-private.c: use the new window icons.
      ca8ef2e3
    • Sven Neumann's avatar
      app/plug-in/plug-in-message.c app/plug-in/plug-in-params.c string review. · 25f5647e
      Sven Neumann authored
      2006-03-29  Sven Neumann  <sven@gimp.org>
      
      	* app/plug-in/plug-in-message.c
      	* app/plug-in/plug-in-params.c
      	* app/plug-in/plug-in.c: string review.
      25f5647e
    • Tor Lillqvist's avatar
      Make it compile again, add missing parameter to gimp_install_procedure(). · a569559b
      Tor Lillqvist authored
      2006-03-29  Tor Lillqvist  <tml@novell.com>
      
      	* plug-ins/common/winprint.c (query): Make it compile again, add
      	missing parameter to gimp_install_procedure().
      a569559b
  4. 28 Mar, 2006 8 commits