1. 28 Jun, 2018 11 commits
  2. 27 Jun, 2018 10 commits
  3. 26 Jun, 2018 8 commits
  4. 25 Jun, 2018 6 commits
    • Adrián Pérez de Castro's avatar
      plug-ins: port web-page to WebKitGTK+ 2 · d37f3528
      Adrián Pérez de Castro authored and Michael Natterer's avatar Michael Natterer committed
      This is the minimum set of changes needed to make the web-page plug-in
      buildable again using WebKitGTK+ 2.x. Tested as building with WebKitGTK+
      version 2.20.3, but unfortunately I cannot test the plug-in as GIMP will
      produce an error when trying to use it.
    • Adrián Pérez de Castro's avatar
      plug-ins: port help-browser to WebKitGTK+ 2 · d34f46b3
      Adrián Pérez de Castro authored and Michael Natterer's avatar Michael Natterer committed
      This is the minimum set of changes needed to update help-browser to the
      WebKitGTK+ 2 API. Fortunately, the plug-in did not use parts of the old
      API which would have been difficult to port (DOM bindings, for example),
      and therefore the code translates quite well to the new API. The main
      differences are:
      - WebKitWebFrame is gone, most of its methods are now in WebKitWebView.
      - Searching for text inside Web pages has to be done now through the
        WebKitFindController object.
      - Checking whether there is selected text that can be copied now goes
        through WebKitEditorState.
      - The WebKitWebView::title-changed signal is no more, the callback is
        connected to notify::title instead.
      - The load-started and load-finished pair of signals are now merged
        into WebKitWebView::load-changed.
      - There are no methods to zoom a WebKitWebView in and out, instead
        the zoom-level property is set. The updated code ensures that the
        zoom lovel stays inside the [0.1, 10.0] range.
      - Page visit history now goes through WebKitBackForwardList.
      The updated plug-in was successfully built in tested with WebKitGTK+
      version 2.20.3.
    • Michael Natterer's avatar
      Issue #1714 - When GIMP starts, default brush hardness is always at 100 · cb0e6c65
      Michael Natterer authored
      We should not have essential signal connections (such as setting tool
      options from brush properties) implemented in the tool options GUI
      files, because they are not active until the options GUI is created.
      Also, that magic is simply too hidden in the options GUI files.
      Move the signal connections and the brush property copying code to
      gimppaintoptions.c where is can also be done cleaner.
      However, this must only be done for the main tool options instance
      that is used for the GUI. Therefore, add a "gui_mode" boolean to
      GimpToolOptions and set it to TRUE for all main tool options.
      (this is ugly, but much less ugly and much less hidden than all the
      places where code lives (like tool_manager.c) that can now be moved
      into GimpToolOptions and its subclasses, and implemented cleanly
    • Jehan's avatar
      app: add an assertion test on result of gimp_widget_load_icon(). · aad82d1a
      Jehan authored
      Actually since we make this function so that it should never return
      NULL, we may as well return a test at the end. If pixbuf is NULL, then
      it is an implementation bug somewhere and we should fix it.
    • Jehan's avatar
      app: reorganize a bit gimp_widget_load_icon(). · 80d2a02b
      Jehan authored
      Massimo spotted some warning with clang in #1608 about pixbuf being used
      initialized. Rather than just initializing it, I am actually
      reorganizing a bit more the function because there was a bit of a logics
      bug. In some weird case, it would have still been possible for this
      function to return NULL instead of a magenta square (the case was: the
      icon was not present in the icon theme; then wilber-eek was either not
      present or failed to load).
      This new code organization is more clearer, as a step by step, should
      better identify the various failure cases and always return an allocated
    • Alex Samorukov's avatar
      Fix screen resolution detection on OSX · 5b612614
      Alex Samorukov authored and Jehan's avatar Jehan committed
      GTK always returns 72 dpi due to API used. This patch using Cocoa
      directly instead. Tested on Retina and non-hidpi displays.
  5. 24 Jun, 2018 5 commits
    • Jehan's avatar
      libgimpbase: fix declaration after statement and reset safecheck... · 49b4b1a5
      Jehan authored
      ... after each successful read().
      I completely missed this declaration after a statement during the review
      of !13 even though I saw another similar issue!
      Also let's reset the error counter to 0 each time a successful read()
      happens so that we can continue reading even if a lot of EINTR were to
      happen, as long as we globally go forward. Only consecutive errors
      increment the counter.
      Finally add a small comment to explain why we let EINTR pass instead of
      breaking directly.
    • Alex Samorukov's avatar
      Fix empty lldb backtrace on OSX · 559d9b89
      Alex Samorukov authored and Jehan's avatar Jehan committed
      When lldb attaching to the process it triggers few "-1" errors on read with
      EINTR error. After 1-2 errors read() call works again.
      Also this patch fixing TID detection, syscall SYS_gettid is oficially deprecated
      now and does not work. Also adding safecheck to avoid enldless loop.
    • Jehan's avatar
      libgimpwidgets: do not free the GtkAdjustment when finalizing... · 792b27af
      Jehan authored
      ... GimpMemsizeEntry.
      A GtkAdjustment is a GInitiallyUnowned, which means it is created as a
      floating reference. GtkSpinButton assumes its ownership by calling
      g_object_ref_sink() in gtk_spin_button_new() implementation. Thus it
      will take care of freeing it and when we try to unref it in finalize(),
      the object already doesn't exist.
      Alternatively we could keep another ref (by calling g_object_ref_sink()
      ourselves) but since the spin button is a child of the entry, it will
      live all the way until the entry is freed. There is no need to increment
      the references. So instead, simplify the code, and don't try to free an
      object we don't own anymore.
      This fixes CRITICAL assertions:
      > g_object_unref: assertion 'G_IS_OBJECT (object)' failed
    • Jehan's avatar
      Issue #1712: Add translator comment for string "Export Exif... · 50bcc8db
      Jehan authored
      ... metadata by default".
      Also for other metadata, and doing it both for the tooltip and the label
      of the option.
    • Piotr Drąg's avatar
      Update Polish translation · 25a6ec29
      Piotr Drąg authored