1. 04 Jul, 2017 1 commit
  2. 02 Jul, 2017 1 commit
    • Michael Natterer's avatar
      app: add virtual function GimpFilterTool::config_notify() · 00a9659c
      Michael Natterer authored
      and call it from GimpFilterTool's "notify" callback. Remove signal
      connections from all subblasses and instead implement ::config_notify().
      
      The config object belongs to GimpFilterTool, and only GimpFilterTool
      should know when it's created and can be connected to.
      00a9659c
  3. 05 Jun, 2017 1 commit
  4. 31 May, 2017 1 commit
  5. 30 May, 2017 1 commit
    • Ell's avatar
      app: fix curves tool color picking · f876f3b5
      Ell authored
      Since commit bc458996, GimpFilterTool
      assumes that color picking is only ever enabled through color picker
      toggles, created using gimp_filter_tool_add_color_picker().  However,
      the curves tool enables color picking using the color tool functions
      directly.  CRITICALS ensued.
      
      Use the new gimp_filter_tool_enable_color_picking() function, added
      in the previous commit, and handle picking through the filter tool
      interface, instead of the color tool interface.  This fixes the
      issue.
      f876f3b5
  6. 25 Mar, 2017 1 commit
  7. 05 Mar, 2017 1 commit
  8. 09 Feb, 2017 1 commit
  9. 29 Jan, 2017 1 commit
    • Thomas Manni's avatar
      Bug 777880 - better handling of sensitivity functions for channel combobox on... · 0d4dd11e
      Thomas Manni authored
      Bug 777880 - better handling of sensitivity functions for channel combobox on threshold, levels and curves tools
      
      - set the filter_tool->drawable before showing the tool gui.
      - set the sensitivity functions for channel combobox of threshold,
        levels and curves tools dialogs only once during dialog creations.
      - use the filter_tool->drawable inside the sensitivity functions
      0d4dd11e
  10. 26 Dec, 2016 1 commit
    • Michael Natterer's avatar
      app: allow to toggle the histogram dialog between gamma and linear · fc9da4c9
      Michael Natterer authored
      Change GimpHistogram to take a "gboolean linear" parameter and always
      honor that parameter, so both kinds of histograms can now be created
      for all drawables.
      
      Add a horrible "Linear" toggle to the histogram dockable which always
      defaults to the active layer's actual pixel format, but can be
      switched at any time. This UI is ugly and needs to change.
      
      On the PDB, default to gamma-corrected if the plug-in is unaware of
      higher precision, and to the drawable's native pixel format otherwise.
      
      Other places using histograms (e.g. levels, curves) are unchanged.
      fc9da4c9
  11. 13 May, 2016 1 commit
    • Michael Natterer's avatar
      app: clean up a lot of werid code in GimpColorOptions and GimpFilterOptions · 13b1e6aa
      Michael Natterer authored
      First of all, derive GimpFilterOptions from GimpColorOptions, not the
      other way around, which was a sick way of magically showing the right
      options for various tools. That approach has failed and needed
      additional hacks to do the right thing. Simply have the right class
      hierarchy and call the right tool options GUI constructors and done.
      
      Remove gimp_histogram_options_gui(), we don't need histogram scale
      controls in tool options when we already have them next to the
      histograms in the tool dialogs.
      
      Also remove gimp_histogram_options_connect_view() and use a simple
      g_object_bind_property() instead.
      13b1e6aa
  12. 10 May, 2016 1 commit
  13. 18 Apr, 2016 1 commit
  14. 14 Apr, 2016 1 commit
  15. 24 Jan, 2016 1 commit
  16. 22 Jan, 2016 1 commit
    • Michael Natterer's avatar
      app: move stuff from GimpOperationTool to GimpImageMapTool · 8c09210d
      Michael Natterer authored
      Add new string members to GimpImageMapTool and use them instead of the
      resp. fields of GimpToolInfo. Change ::get_operation() to return the
      operation name and a lot of strings for the UI, and create both the
      GeglNode and the config object in GimpOperationTool. Lots of various
      cleanups in GimpImageMapTool subclasses. This is an intermediate state
      on the way of making the whole filter applying mechanism more generic
      and less depending on subclasses.
      8c09210d
  17. 28 Dec, 2015 1 commit
  18. 05 Nov, 2015 1 commit
    • Jehan's avatar
      app: enable GimpCurvesTool on construction. · 011c6db3
      Jehan authored
      The Curves tool is to be considered "enabled" as soon as it is selected,
      not when it is initialized (usually at the first click on the image).
      One of the main consequence of not being "enabled" was that the tool
      cursor was wrong at selection.
      011c6db3
  19. 17 Oct, 2015 1 commit
    • Michael Natterer's avatar
      app: get rid of hardcoding GDK_SHIFT_MASK in tools/ · 7ec04e4a
      Michael Natterer authored
      gimp_suggest_modifiers(): change "shift_format" and "control_format"
      parameters to "extend_selection_format" and "toggle_behavior_format",
      which fixes the longstanding problem that the function did the right
      thing only by accident.
      
      tools: use gimp_get_extend_selection_mask() instead of GDK_SHIFT_MASK
      which is not 100% semantically correct in all cases, but at least a
      step in the right direction to make the tool modifiers easier to
      improve.
      7ec04e4a
  20. 25 Aug, 2015 1 commit
  21. 14 Jun, 2015 1 commit
    • Michael Natterer's avatar
      Bug 750953 - The Curves dialog should present per channel lines... · 014cd08c
      Michael Natterer authored
      ...when opened by the "Edit these settings as Curves" button on the
      Levels dialog
      
      The code to configure the entire GUI correctly was not even called
      when initially creating the curves dialog (the color bars probably
      looked right just because of default values of their own).
      
      Factor out gimp_curves_tool_update_channel() which properly updates
      the GUI. Call it after the dialog has been created, and when the
      active channel changes.
      014cd08c
  22. 21 Sep, 2014 1 commit
    • Michael Natterer's avatar
      Bug 737008 - Curve color always black · 90c967a3
      Michael Natterer authored
      Don't hardcode "black" for the "Value" curve in GimpCurvesTool.
      Instead, pass a NULL color to GimpCurveView, which is then interpreted
      as the theme's text color (the curve's background is the theme's text
      background color). We still hardcode pure red, green and blue for the
      other curves.
      90c967a3
  23. 04 Jul, 2014 2 commits
  24. 02 Jul, 2014 1 commit
  25. 01 Jul, 2014 1 commit
  26. 07 May, 2014 1 commit
  27. 26 Dec, 2013 1 commit
  28. 23 Jun, 2013 1 commit
    • Michael Natterer's avatar
      Add support for both gamma-corrected and linear for all bit depths · caf73f5f
      Michael Natterer authored
      - Add new enum GimpComponentType which contains u8, u16, u32 etc.
      - Change GimpPrecision to be u8-linear, u8-gamma, u16-linear etc.
      - Add all the needed formats to gimp-babl.c
      - Bump the XCF version to 5 and make sure version 4 with the old
        GimpPrecision enum values is loaded correctly
      
      This change blows up the precision enums in "New Image" and
      Image->Precision so we can test all this stuff. It is undecided what
      format will be user-visible options in 2.10.
      caf73f5f
  29. 12 Jun, 2013 1 commit
  30. 11 Jun, 2013 2 commits
  31. 30 May, 2013 1 commit
  32. 25 Apr, 2013 1 commit
  33. 16 Apr, 2013 2 commits
  34. 05 Jul, 2012 1 commit
  35. 10 May, 2012 1 commit
  36. 02 May, 2012 2 commits