1. 25 Jan, 2004 1 commit
    • Sven Neumann's avatar
      don't update the fields here... · 8915bbad
      Sven Neumann authored
      2004-01-25  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/info-window.c (info_window_create): don't update the fields
      	here...
      
      	* app/gui/view-commands.c (view_info_window_cmd_callback): ... but
      	here when the info window is connected to the display shell. Patch
      	from Shlomi Fish; fixes bug #132329.
      
      	* app/gui/info-window.c (info_window_update_extended): fixed update
      	of info window in automatic mode. Bug #118084, patch by Shlomi Fish.
      
      	* autogen.sh: check for automake-1.8 also.
      
      	* HACKING: note that automake-1.8 should work as well.
      8915bbad
  2. 24 Jan, 2004 1 commit
    • Michael Natterer's avatar
      fiddle with the passed channel index only for GRAYA drawables, not for all · 00c525ab
      Michael Natterer authored
      2004-01-24  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/color.pdb (levels, curves): fiddle with the
      	passed channel index only for GRAYA drawables, not for all GRAY
      	drawables. Fixes bug #132322.
      
      	* tools/pdbgen/pdb/color.pdb: regenerated.
      
      	* app/tools/gimpcurvestool.[ch]
      	* app/tools/gimplevelstool.[ch]: fixed the same bug here. It never
      	occured because the "channel" field was accidentially initialized
      	with the correct value and never changed after.
      00c525ab
  3. 23 Jan, 2004 1 commit
    • Michael Natterer's avatar
      app/app_procs.c app/errors.c app/main.c app/config/gimpconfigwriter.c · 57911bbc
      Michael Natterer authored
      2004-01-23  Michael Natterer  <mitch@gimp.org>
      
      	* app/app_procs.c
      	* app/errors.c
      	* app/main.c
      	* app/config/gimpconfigwriter.c
      	* app/core/gimpdata.c
      	* app/core/gimpdatafactory.c
      	* app/gui/user-install-dialog.c
      	* app/plug-in/plug-ins.c
      	* app/vectors/gimpvectors-import.c: some more gimp_filename_to_utf8().
      
      	* libgimp/gimp.c
      	* libgimpmodule/gimpmodule.c
      	* libgimpmodule/gimpmoduledb.c: use it here, too, now that is in
      	libgimpbase.
      57911bbc
  4. 22 Jan, 2004 3 commits
    • Manish Singh's avatar
      modernized, made a lot of things m4 macros, and made versioning a lot more · 9db6153f
      Manish Singh authored
      2004-01-21  Manish Singh  <yosh@gimp.org>
      
              * configure.in: modernized, made a lot of things m4 macros, and made
              versioning a lot more finegrained, in anticipation for post-2.0.
      
              * autogen.sh: bumped up libtool and glib minimum requirements to match
              reality.
      
              * gimp-2.0.pc.in
              * gimpthumb-2.0.pc.in
              * gimpui-2.0.pc.in: adapted to new versioning variables, and bring
              in RT_LIBS when needed.
      
              * */*/Makefile.am: adapted to new versioning variables.
      9db6153f
    • Michael Natterer's avatar
      explicitly activate the drawable the floating selection was attached to · 72d7aaae
      Michael Natterer authored
      2004-01-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimplayer-floating-sel.c (floating_sel_anchor):
      	explicitly activate the drawable the floating selection was
      	attached to (function was relying on implicit voodoo that
      	happened 1.2). Fixes bug #132162.
      72d7aaae
    • Michael Natterer's avatar
      added "gboolean use_default_values" to GimpItem::stroke(). · f3c91918
      Michael Natterer authored
      2004-01-22  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpitem.[ch]: added "gboolean use_default_values"
      	to GimpItem::stroke().
      
      	* app/core/gimpselection.c: changed accordingly.
      
      	* app/core/gimpchannel.c
      	* app/vectors/gimpvectors.c: if use_default_values is TRUE, don't
      	use the GimpPaintOptions passed in the GimpPaintInfo, but create a
      	new one.
      
      	* app/gui/stroke-dialog.c: pass FALSE so the values as set in the
      	tool options are used.
      
      	* tools/pdbgen/pdb/edit.pdb
      	* tools/pdbgen/pdb/paths.pdb: pass TRUE so tool options settings
      	don't affect PDB stroke calls. Fixes part 2 of bug #132145.
      
      	* app/pdb/edit_cmds.c
      	* app/pdb/paths_cmds.c: regenerated.
      f3c91918
  5. 21 Jan, 2004 8 commits
    • Simon Budig's avatar
      replaced the indexed palette in the default "Layers, Channels, Paths"-Dock · f1348dc2
      Simon Budig authored
      2004-01-22  Simon Budig  <simon@gimp.org>
      
      	* app/gui/dialogs-commands.c: replaced the indexed palette in
      	the default "Layers, Channels, Paths"-Dock (as created by the
      	menu in the toolbox) with the Undo History, since the indexed
      	palette is pretty useless most of the time and the new setup
      	at least matches the upper half of the dockable that comes up
      	after a new user starts the Gimp the first time.
      f1348dc2
    • Michael Natterer's avatar
      show the image menu in newly created layers, channels & paths docks. · edff0480
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/dialogs-commands.c: show the image menu in newly created
      	layers, channels & paths docks.
      edff0480
    • Michael Natterer's avatar
      added boolean return value to GimpTool::initialize(). Returning FALSE · 613e328f
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimptool.[ch]: added boolean return value to
      	GimpTool::initialize(). Returning FALSE means the tool could not
      	be initialized and doesn't want to receive button events.
      	Return TRUE from the default implementation.
      
      	* app/tools/tool_manager.[ch]: added boolean return value to
      	tool_manager_initialize_active(). Don't set the tool's display or
      	drawable if initialize() returns FALSE.
      
      	* app/display/gimpdisplayshell-callbacks.c: don't send button
      	events to the tool if initialize() returns FALSE.
      
      	* app/tools/gimpbrightnesscontrasttool.c
      	* app/tools/gimpcolorbalancetool.c
      	* app/tools/gimpcolorizetool.c
      	* app/tools/gimpcurvestool.c
      	* app/tools/gimphuesaturationtool.c
      	* app/tools/gimplevelstool.c
      	* app/tools/gimpposterizetool.c
      	* app/tools/gimpthresholdtool.c: return FALSE for NULL and indexed
      	drawables.
      
      	* app/tools/gimpimagemaptool.c: always return TRUE because our
      	subclasses already checked if the active drawable is OK.
      
      	* app/tools/gimptransformtool.c: return FALSE for layers with
      	masks. Fixes bug #132089. Some random cleanups.
      613e328f
    • Michael Natterer's avatar
      use RINT() instead of ROUND() to calculate the coordinates of the · bcf85df8
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpdrawable-transform.c: use RINT() instead of ROUND()
      	to calculate the coordinates of the transformed tiles to avoid
      	off-by-one errors when affine-transforming, flipping and rotating
      	drawables with negative offsets.
      	Fixes the off-by-one part of bug #132089.
      bcf85df8
    • Tor Lillqvist's avatar
      Fix undefined behaviour. Fixes crash in bringing up the Preferences dialog · d9b2478c
      Tor Lillqvist authored
      2004-01-21  Tor Lillqvist  <tml@iki.fi>
      
      	* app/gui/themes.c (themes_list_themes_foreach): Fix undefined
      	behaviour. Fixes crash in bringing up the Preferences dialog when
      	compiled with Sun's compiler.
      d9b2478c
    • Michael Natterer's avatar
      call gimp_drawable_invalidate_boundary() because the drawable's size may · 7c652c0e
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpdrawable-transform.c (gimp_drawable_transform_paste):
      	call gimp_drawable_invalidate_boundary() because the drawable's
      	size may have changed. Fixes bug #132077. Removed call to
      	floating_sel_invalidate() which is now redundant.
      7c652c0e
    • Michael Natterer's avatar
      renamed info_dialog_popdown() to info_dialog_hide() and · 73d258eb
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/info-dialog.[ch]: renamed info_dialog_popdown() to
      	info_dialog_hide() and info_dialog_popup() to info_dialog_present().
      	Added info_dialog_show() which just shows the dialog without
      	calling gtk_window_present().
      
      	* app/gui/info-window.c
      	* app/gui/view-commands.c
      	* app/tools/gimptransformtool.c: changed accordingly.
      
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: use info_dialog_show() so the dialog
      	doesn't grab the focus away from the canvas. Fixes bug #132041.
      73d258eb
    • Simon Budig's avatar
      removed the call to art_vpath_perturb, since it apparently is responsible · 6861a681
      Simon Budig authored
      2004-01-21  Simon Budig  <simon@gimp.org>
      
      	* app/core/gimpscanconvert.c: removed the call to
      	art_vpath_perturb, since it apparently is responsible for the
      	artefacts described in bug #132036. I don't really understand
      	why these artefacts were happening in the first place, because
      	in theory art_vpath_perturb should not do any harm.
      
      	Also properly close closed polygons.
      
      	Hopefully fixes #132036, please test this.
      6861a681
  6. 20 Jan, 2004 4 commits
    • Michael Natterer's avatar
      added help IDs for the libgimp export and unit dialogs. · 04187503
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimphelp-ids.h: added help IDs for the libgimp
      	export and unit dialogs.
      
      	* libgimp/gimpexport.c
      	* libgimpwidgets/gimpunitmenu.c: replaced html links by the new
      	help IDs.
      
      	* plug-ins/*/*.c: replaced all html help links by help IDs. A
      	plug-in's help ID is its procedure name with '_' relaced by '-'.
      
      	(e.g. file_tiff_save's help ID is file-tiff-save)
      
      	Did some random indentation and whitespace cleanup.
      04187503
    • Michael Natterer's avatar
      changed "prog_name" parameter of gimp_help() to "help_domain". It's · ebcb621c
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/help.pdb: changed "prog_name" parameter of
      	gimp_help() to "help_domain". It's useless to pass the plug-in's
      	executable name to the core because the core already knows it.
      	Instead, enabled accessing arbitrary help domains via the
      	PDB. Passing NULL as help_domain will use the domain the plug-in
      	registered, or the GIMP main help domain if it didn't register a
      	domain.
      
      	* app/pdb/help_cmds.c
      	* libgimp/gimphelp_pdb.[ch]: regenerated.
      
      	* libgimp/gimpui.c (gimp_ui_help_func): pass NULL as help_domain.
      ebcb621c
    • Michael Natterer's avatar
      app/gui/file-open-menu.c app/gui/file-save-menu.c app/gui/image-menu.c · cf136155
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/file-open-menu.c
      	* app/gui/file-save-menu.c
      	* app/gui/image-menu.c
      	* app/gui/menus.c
      	* app/gui/plug-in-menus.c: when dynamically creating menu entries,
      	pass static_entry == FALSE to gimp_item_factory_create_item() so a
      	*copy* of the the help_id is attached to the menu item.
      	Fixes help for plug-in menu entries.
      cf136155
    • Michael Natterer's avatar
      changed member "ProcRec *current_temp_proc" to "GList *temp_proc_recs", a · e8b27df0
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/plug-in/plug-in.[ch]: changed member
      	"ProcRec *current_temp_proc" to "GList *temp_proc_recs", a stack
      	of temporary procedures, just as the "temp_main_loops" member is
      	supposed to be the stack of main loops for waiting for the
      	temp_procs' return values.
      
      	* app/plug-in/plug-in-run.c (plug_in_temp_run): changed accordingly.
      
      	* app/plug-in/plug-in-message.c
      	* app/plug-in/plug-in-run.c
      	* libgimp/gimp.c: added #define ENABLE_TEMP_RETURN 1.
      
      	Enables return values for temporary procedures. On the libgimp
      	side, this just enables the code which returns the values, on the
      	app side it enables per-plug-in stacks of proc_recs and main_loops
      	and a message handler for the GP_TEMP_PROC_RETURN message.
      	A temp_proc's caller now blocks until the proc is finished.
      	Fixes bug #50649.
      
      	Left the #ifdefs there so it can be easily disabled if things
      	break. Please play with Script-Fu and test this.
      e8b27df0
  7. 19 Jan, 2004 6 commits
  8. 18 Jan, 2004 12 commits
    • Sven Neumann's avatar
      code cleanup; draw in the expose_event handler only. · 2eafd750
      Sven Neumann authored
      2004-01-19  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimplevelstool.[ch]: code cleanup; draw in the
      	expose_event handler only.
      2eafd750
    • Michael Natterer's avatar
      when scaling an indexed image/layer, add a label telling the user that · f9cb4af7
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/resize-dialog.c: when scaling an indexed image/layer,
      	add a label telling the user that indexed layers are always scaled
      	without interpolation. Can't simply make the option menu
      	insensitive because channels and layer masks are still scaled with
      	the chosen interpolation type. Fixes bug #131779.
      f9cb4af7
    • Michael Natterer's avatar
      use gimp_drawable_bytes_with_alpha(). · 65c83a6c
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimpinktool.c (ink_set_paint_area): use
      	gimp_drawable_bytes_with_alpha().
      65c83a6c
    • Michael Natterer's avatar
      app/vectors/gimpstroke.c use the GIMP_TYPE_FOO macros instead of · d9b7d7ee
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/vectors/gimpstroke.c
      	* app/xcf/xcf-load.c: use the GIMP_TYPE_FOO macros instead of
      	gimp_foo_get_type(). Minor cleanups.
      d9b7d7ee
    • Michael Natterer's avatar
      in the spirit of the fix for bug #131721 below, don't try to figure · d528848f
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_add_layer,remove_layer): in the
      	spirit of the fix for bug #131721 below, don't try to figure
      	manually if "alpha_changed" needs to be emitted but simply compare
      	the old and new values of gimp_image_has_alpha().
      
      	* app/gui/preferences-dialog.c (prefs_dialog_new): follow
      	"foo-window-type" -> "foo-window-hint" change.
      d528848f
    • Michael Natterer's avatar
      also return the color's alpha byte if it has alpha, not only the converted · 9efe077c
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.[ch] (gimp_image_get_color): also return the
      	color's alpha byte if it has alpha, not only the converted RGB
      	values.  Return OPAQUE_OPACITY for drawables without alpha.
      	Fixes bug #131706.
      
      	* app/core/gimpdrawable.c (gimp_drawable_get_color_at)
      	* app/core/gimpimage-contiguous-region.c
      	(gimp_image_contiguous_region_by_color)
      	* app/core/gimpimage-projection.c (gimp_image_projection_get_color_at)
      	* app/core/gimpimagemap.c (gimp_image_map_get_color_at)
      	* app/paint/gimpclone.c (gimp_clone_line_image): removed separate
      	handling of the alpha byte from all users of gimp_image_get_color().
      9efe077c
    • Michael Natterer's avatar
      use gimp_drawable_bytes_with_alpha(). · b2c661e3
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/paint/gimppaintcore.c (gimp_paint_core_get_paint_area): use
      	gimp_drawable_bytes_with_alpha().
      b2c661e3
    • Michael Natterer's avatar
      don't allow to select anything but the floating selection. Fixes bug · 370a16fa
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_set_active_layer): don't allow
      	to select anything but the floating selection. Fixes bug #128025.
      
      	(gimp_image_set_active_layer,channel,vectors): allow to pass NULL
      	to unselect the active item. Removed the silly feature that
      	passing some random item of another image would select the first
      	item in the list (was unused anyway).
      
      	(gimp_image_unset_active_channel): use gimp_image_set_active_channel()
      	now that it accepts NULL.
      
      	(gimp_image_add_layer,channel,vectors): cleaned up / simplified.
      
      	(gimp_image_remove_layer,channel,vectors): cleanup,
      	simplification, use gimp_image_set_active_layer,channel,vectors()
      	now that they accept NULL, make sure the item next to the removed
      	item becomes the active one (and not the first in the list, which
      	was a severe usability problem in the dialogs).
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer,channel): pass
      	NULL to the set_active functions, cleanup.
      
      	* app/core/gimpimage-duplicate.c: attach the floating selection
      	before setting the active layer. Code relied on broken
      	gimp_image_set_active_layer() behaviour before.
      
      	* app/core/gimplayer-floating-sel.c: no need to set
      	gimage->floating_sel before calling gimp_image_add_layer(). The
      	weird GUI mentioned in the comment existed in 1.2 only.
      
      	* app/display/gimpdisplayshell-layer-select.c (layer_select_advance):
      	don't assume that setting the active_layer always succeeds.
      
      	* tools/pdbgen/pdb/image.pdb: behave as the documentation says
      	and return an execution error if setting the active layer or
      	channel failed.
      
      	Unrelated:
      
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb: removed leftover cruft from the old
      	guchar based color API.
      
      	* tools/pdbgen/pdb/channel.pdb: simplified code which handles the
      	channel's color.
      
      	* app/pdb/channel_cmds.c
      	* app/pdb/image_cmds.c: regenerated.
      370a16fa
    • Simon Budig's avatar
      fixed typo. · b18e38c7
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
              * app/gui/about-dialog.c: fixed typo.
      b18e38c7
    • Simon Budig's avatar
      make sure we always properly use the size of the logo image. Place the · 8cdcee96
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
      	* app/gui/about-dialog.c: make sure we always properly use
      	the size of the logo image. Place the text at the bottom
      	of the image when the size changes (position of the version
      	string needs to be adjusted manually still...).
      
      	* data/images/gimp_logo.png: slightly tweaked.
      
      	* data/images/gimp1_0_logo.png: added for historical reasons.
      8cdcee96
    • Sven Neumann's avatar
      redone to make it work again. · 15d4c9f4
      Sven Neumann authored
      2004-01-18  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/file-open-dialog.c (file_open_create_thumbnail): redone
      	to make it work again.
      
      	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_load_thumb): fixed
      	stupid mistake that caused thumbnails not to load under certain
      	circumstances.
      15d4c9f4
    • Michael Natterer's avatar
      removed broken code which tried to figure manually whether "alpha_changed" · f8e9fbc1
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer): removed broken
      	code which tried to figure manually whether "alpha_changed" should
      	be emitted. Instead, simply compare the return values of
      	gimp_image_has_alpha() before and after adding/removing the
      	layer. Fixes bug #131721.
      f8e9fbc1
  9. 17 Jan, 2004 2 commits
    • Henrik Brix Andersen's avatar
      forgot to change two G_MAXINT to G_MAXDOUBLE. · 8e43a403
      Henrik Brix Andersen authored
      2004-01-17 Henrik Brix Andersen <brix@gimp.org>
      
      * app/core/gimpimage-snap.c (gimp_image_snap_point): forgot to
      change two G_MAXINT to G_MAXDOUBLE.
      8e43a403
    • Henrik Brix Andersen's avatar
      Finally fixed bug #125864: · d22d364d
      Henrik Brix Andersen authored
      2004-01-17 Henrik Brix Andersen <brix@gimp.org>
      
      Finally fixed bug #125864:
      
      * app/core/gimpimage-guides.c (gimp_image_find_guide): iterate
      over the entire list of guides to determine the closest one.
      
      * app/core/gimpimage-snap.c: use gdoubles instead of gints for
      dist and mindist variables to make sure grid and guides with 1px
      spacings work as expected.
      d22d364d
  10. 16 Jan, 2004 2 commits
    • Sven Neumann's avatar
      app/config/gimpguiconfig.[ch] app/config/gimprc-blurbs.h · bfe567c4
      Sven Neumann authored
      2004-01-17  Sven Neumann  <sven@gimp.org>
      
      	* app/config/gimpguiconfig.[ch]
      	* app/config/gimprc-blurbs.h
      	* app/widgets/gimpdock.c
      	* app/widgets/gimptoolbox.c
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/widgets-enums.[ch]: GTK+-2.4 will allow to request
      	windows to be kept above. This change prepares the code so that we
      	can optionally do this for docks and the toolbox as soon as we
      	depend on GTK+-2.4 (see bug #131672).
      bfe567c4
    • Sven Neumann's avatar
      do a proper fix for bug #131680. · 4a234e44
      Sven Neumann authored
      2004-01-16  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpcroptool.c (crop_recalc): do a proper fix for bug
      	#131680.
      4a234e44