1. 21 Jan, 2004 2 commits
    • Michael Natterer's avatar
      renamed info_dialog_popdown() to info_dialog_hide() and · 73d258eb
      Michael Natterer authored
      2004-01-21  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/info-dialog.[ch]: renamed info_dialog_popdown() to
      	info_dialog_hide() and info_dialog_popup() to info_dialog_present().
      	Added info_dialog_show() which just shows the dialog without
      	calling gtk_window_present().
      
      	* app/gui/info-window.c
      	* app/gui/view-commands.c
      	* app/tools/gimptransformtool.c: changed accordingly.
      
      	* app/tools/gimpcroptool.c
      	* app/tools/gimpperspectivetool.c
      	* app/tools/gimprotatetool.c
      	* app/tools/gimpscaletool.c
      	* app/tools/gimpsheartool.c: use info_dialog_show() so the dialog
      	doesn't grab the focus away from the canvas. Fixes bug #132041.
      73d258eb
    • Simon Budig's avatar
      removed the call to art_vpath_perturb, since it apparently is responsible · 6861a681
      Simon Budig authored
      2004-01-21  Simon Budig  <simon@gimp.org>
      
      	* app/core/gimpscanconvert.c: removed the call to
      	art_vpath_perturb, since it apparently is responsible for the
      	artefacts described in bug #132036. I don't really understand
      	why these artefacts were happening in the first place, because
      	in theory art_vpath_perturb should not do any harm.
      
      	Also properly close closed polygons.
      
      	Hopefully fixes #132036, please test this.
      6861a681
  2. 20 Jan, 2004 4 commits
    • Michael Natterer's avatar
      added help IDs for the libgimp export and unit dialogs. · 04187503
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/widgets/gimphelp-ids.h: added help IDs for the libgimp
      	export and unit dialogs.
      
      	* libgimp/gimpexport.c
      	* libgimpwidgets/gimpunitmenu.c: replaced html links by the new
      	help IDs.
      
      	* plug-ins/*/*.c: replaced all html help links by help IDs. A
      	plug-in's help ID is its procedure name with '_' relaced by '-'.
      
      	(e.g. file_tiff_save's help ID is file-tiff-save)
      
      	Did some random indentation and whitespace cleanup.
      04187503
    • Michael Natterer's avatar
      changed "prog_name" parameter of gimp_help() to "help_domain". It's · ebcb621c
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/help.pdb: changed "prog_name" parameter of
      	gimp_help() to "help_domain". It's useless to pass the plug-in's
      	executable name to the core because the core already knows it.
      	Instead, enabled accessing arbitrary help domains via the
      	PDB. Passing NULL as help_domain will use the domain the plug-in
      	registered, or the GIMP main help domain if it didn't register a
      	domain.
      
      	* app/pdb/help_cmds.c
      	* libgimp/gimphelp_pdb.[ch]: regenerated.
      
      	* libgimp/gimpui.c (gimp_ui_help_func): pass NULL as help_domain.
      ebcb621c
    • Michael Natterer's avatar
      app/gui/file-open-menu.c app/gui/file-save-menu.c app/gui/image-menu.c · cf136155
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/file-open-menu.c
      	* app/gui/file-save-menu.c
      	* app/gui/image-menu.c
      	* app/gui/menus.c
      	* app/gui/plug-in-menus.c: when dynamically creating menu entries,
      	pass static_entry == FALSE to gimp_item_factory_create_item() so a
      	*copy* of the the help_id is attached to the menu item.
      	Fixes help for plug-in menu entries.
      cf136155
    • Michael Natterer's avatar
      changed member "ProcRec *current_temp_proc" to "GList *temp_proc_recs", a · e8b27df0
      Michael Natterer authored
      2004-01-20  Michael Natterer  <mitch@gimp.org>
      
      	* app/plug-in/plug-in.[ch]: changed member
      	"ProcRec *current_temp_proc" to "GList *temp_proc_recs", a stack
      	of temporary procedures, just as the "temp_main_loops" member is
      	supposed to be the stack of main loops for waiting for the
      	temp_procs' return values.
      
      	* app/plug-in/plug-in-run.c (plug_in_temp_run): changed accordingly.
      
      	* app/plug-in/plug-in-message.c
      	* app/plug-in/plug-in-run.c
      	* libgimp/gimp.c: added #define ENABLE_TEMP_RETURN 1.
      
      	Enables return values for temporary procedures. On the libgimp
      	side, this just enables the code which returns the values, on the
      	app side it enables per-plug-in stacks of proc_recs and main_loops
      	and a message handler for the GP_TEMP_PROC_RETURN message.
      	A temp_proc's caller now blocks until the proc is finished.
      	Fixes bug #50649.
      
      	Left the #ifdefs there so it can be easily disabled if things
      	break. Please play with Script-Fu and test this.
      e8b27df0
  3. 19 Jan, 2004 6 commits
  4. 18 Jan, 2004 12 commits
    • Sven Neumann's avatar
      code cleanup; draw in the expose_event handler only. · 2eafd750
      Sven Neumann authored
      2004-01-19  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimplevelstool.[ch]: code cleanup; draw in the
      	expose_event handler only.
      2eafd750
    • Michael Natterer's avatar
      when scaling an indexed image/layer, add a label telling the user that · f9cb4af7
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/resize-dialog.c: when scaling an indexed image/layer,
      	add a label telling the user that indexed layers are always scaled
      	without interpolation. Can't simply make the option menu
      	insensitive because channels and layer masks are still scaled with
      	the chosen interpolation type. Fixes bug #131779.
      f9cb4af7
    • Michael Natterer's avatar
      use gimp_drawable_bytes_with_alpha(). · 65c83a6c
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/tools/gimpinktool.c (ink_set_paint_area): use
      	gimp_drawable_bytes_with_alpha().
      65c83a6c
    • Michael Natterer's avatar
      app/vectors/gimpstroke.c use the GIMP_TYPE_FOO macros instead of · d9b7d7ee
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/vectors/gimpstroke.c
      	* app/xcf/xcf-load.c: use the GIMP_TYPE_FOO macros instead of
      	gimp_foo_get_type(). Minor cleanups.
      d9b7d7ee
    • Michael Natterer's avatar
      in the spirit of the fix for bug #131721 below, don't try to figure · d528848f
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_add_layer,remove_layer): in the
      	spirit of the fix for bug #131721 below, don't try to figure
      	manually if "alpha_changed" needs to be emitted but simply compare
      	the old and new values of gimp_image_has_alpha().
      
      	* app/gui/preferences-dialog.c (prefs_dialog_new): follow
      	"foo-window-type" -> "foo-window-hint" change.
      d528848f
    • Michael Natterer's avatar
      also return the color's alpha byte if it has alpha, not only the converted · 9efe077c
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.[ch] (gimp_image_get_color): also return the
      	color's alpha byte if it has alpha, not only the converted RGB
      	values.  Return OPAQUE_OPACITY for drawables without alpha.
      	Fixes bug #131706.
      
      	* app/core/gimpdrawable.c (gimp_drawable_get_color_at)
      	* app/core/gimpimage-contiguous-region.c
      	(gimp_image_contiguous_region_by_color)
      	* app/core/gimpimage-projection.c (gimp_image_projection_get_color_at)
      	* app/core/gimpimagemap.c (gimp_image_map_get_color_at)
      	* app/paint/gimpclone.c (gimp_clone_line_image): removed separate
      	handling of the alpha byte from all users of gimp_image_get_color().
      9efe077c
    • Michael Natterer's avatar
      use gimp_drawable_bytes_with_alpha(). · b2c661e3
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/paint/gimppaintcore.c (gimp_paint_core_get_paint_area): use
      	gimp_drawable_bytes_with_alpha().
      b2c661e3
    • Michael Natterer's avatar
      don't allow to select anything but the floating selection. Fixes bug · 370a16fa
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c (gimp_image_set_active_layer): don't allow
      	to select anything but the floating selection. Fixes bug #128025.
      
      	(gimp_image_set_active_layer,channel,vectors): allow to pass NULL
      	to unselect the active item. Removed the silly feature that
      	passing some random item of another image would select the first
      	item in the list (was unused anyway).
      
      	(gimp_image_unset_active_channel): use gimp_image_set_active_channel()
      	now that it accepts NULL.
      
      	(gimp_image_add_layer,channel,vectors): cleaned up / simplified.
      
      	(gimp_image_remove_layer,channel,vectors): cleanup,
      	simplification, use gimp_image_set_active_layer,channel,vectors()
      	now that they accept NULL, make sure the item next to the removed
      	item becomes the active one (and not the first in the list, which
      	was a severe usability problem in the dialogs).
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer,channel): pass
      	NULL to the set_active functions, cleanup.
      
      	* app/core/gimpimage-duplicate.c: attach the floating selection
      	before setting the active layer. Code relied on broken
      	gimp_image_set_active_layer() behaviour before.
      
      	* app/core/gimplayer-floating-sel.c: no need to set
      	gimage->floating_sel before calling gimp_image_add_layer(). The
      	weird GUI mentioned in the comment existed in 1.2 only.
      
      	* app/display/gimpdisplayshell-layer-select.c (layer_select_advance):
      	don't assume that setting the active_layer always succeeds.
      
      	* tools/pdbgen/pdb/image.pdb: behave as the documentation says
      	and return an execution error if setting the active layer or
      	channel failed.
      
      	Unrelated:
      
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb: removed leftover cruft from the old
      	guchar based color API.
      
      	* tools/pdbgen/pdb/channel.pdb: simplified code which handles the
      	channel's color.
      
      	* app/pdb/channel_cmds.c
      	* app/pdb/image_cmds.c: regenerated.
      370a16fa
    • Simon Budig's avatar
      fixed typo. · b18e38c7
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
              * app/gui/about-dialog.c: fixed typo.
      b18e38c7
    • Simon Budig's avatar
      make sure we always properly use the size of the logo image. Place the · 8cdcee96
      Simon Budig authored
      2004-01-18  Simon Budig  <simon@gimp.org>
      
      	* app/gui/about-dialog.c: make sure we always properly use
      	the size of the logo image. Place the text at the bottom
      	of the image when the size changes (position of the version
      	string needs to be adjusted manually still...).
      
      	* data/images/gimp_logo.png: slightly tweaked.
      
      	* data/images/gimp1_0_logo.png: added for historical reasons.
      8cdcee96
    • Sven Neumann's avatar
      redone to make it work again. · 15d4c9f4
      Sven Neumann authored
      2004-01-18  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/file-open-dialog.c (file_open_create_thumbnail): redone
      	to make it work again.
      
      	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_load_thumb): fixed
      	stupid mistake that caused thumbnails not to load under certain
      	circumstances.
      15d4c9f4
    • Michael Natterer's avatar
      removed broken code which tried to figure manually whether "alpha_changed" · f8e9fbc1
      Michael Natterer authored
      2004-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage-undo-push.c (undo_pop_layer): removed broken
      	code which tried to figure manually whether "alpha_changed" should
      	be emitted. Instead, simply compare the return values of
      	gimp_image_has_alpha() before and after adding/removing the
      	layer. Fixes bug #131721.
      f8e9fbc1
  5. 17 Jan, 2004 2 commits
    • Henrik Brix Andersen's avatar
      forgot to change two G_MAXINT to G_MAXDOUBLE. · 8e43a403
      Henrik Brix Andersen authored
      2004-01-17 Henrik Brix Andersen <brix@gimp.org>
      
      * app/core/gimpimage-snap.c (gimp_image_snap_point): forgot to
      change two G_MAXINT to G_MAXDOUBLE.
      8e43a403
    • Henrik Brix Andersen's avatar
      Finally fixed bug #125864: · d22d364d
      Henrik Brix Andersen authored
      2004-01-17 Henrik Brix Andersen <brix@gimp.org>
      
      Finally fixed bug #125864:
      
      * app/core/gimpimage-guides.c (gimp_image_find_guide): iterate
      over the entire list of guides to determine the closest one.
      
      * app/core/gimpimage-snap.c: use gdoubles instead of gints for
      dist and mindist variables to make sure grid and guides with 1px
      spacings work as expected.
      d22d364d
  6. 16 Jan, 2004 5 commits
    • Sven Neumann's avatar
      app/config/gimpguiconfig.[ch] app/config/gimprc-blurbs.h · bfe567c4
      Sven Neumann authored
      2004-01-17  Sven Neumann  <sven@gimp.org>
      
      	* app/config/gimpguiconfig.[ch]
      	* app/config/gimprc-blurbs.h
      	* app/widgets/gimpdock.c
      	* app/widgets/gimptoolbox.c
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/gimpwidgets-utils.[ch]
      	* app/widgets/widgets-enums.[ch]: GTK+-2.4 will allow to request
      	windows to be kept above. This change prepares the code so that we
      	can optionally do this for docks and the toolbox as soon as we
      	depend on GTK+-2.4 (see bug #131672).
      bfe567c4
    • Sven Neumann's avatar
      do a proper fix for bug #131680. · 4a234e44
      Sven Neumann authored
      2004-01-16  Sven Neumann  <sven@gimp.org>
      
      	* app/tools/gimpcroptool.c (crop_recalc): do a proper fix for bug
      	#131680.
      4a234e44
    • David Odin's avatar
      bloc some signals before destroying the info dialog box, to prevent · 04d7e139
      David Odin authored
      * app/tools/gimpcroptool.c: bloc some signals before destroying the
      info dialog box, to prevent accessing to freed memory fixes bug #131680
      04d7e139
    • Sven Neumann's avatar
      fixed typo (bug #131670). · ddbc0908
      Sven Neumann authored
      2004-01-16  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/menus.c (menus_init): fixed typo (bug #131670).
      ddbc0908
    • Michael Natterer's avatar
      converted tabs to spaces. · b6683376
      Michael Natterer authored
      2004-01-16  Michael Natterer  <mitch@gimp.org>
      
      	* app/gui/edit-commands.[ch]: converted tabs to spaces.
      
      	(cut,copy_named_buffer_callback): unref the buffer after adding it
      	to gimp->named_buffers. Seems we leaked all named buffers...
      
      	Removed code duplication I have just introduced:
      
      	* app/gui/edit-commands.[ch] removed
      	edit_paste_into_cmd_callback(). Instead, pass the "paste_into"
      	boolean as "guint action" to gimp_edit_paste_cmd_callback().
      
      	* app/gui/image-menu.c: changed accordingly.
      
      	* app/widgets/gimpbufferview.c: added utility function
      	gimp_buffer_view_paste() and call it from the paste and paste_into
      	callbacks.
      b6683376
  7. 15 Jan, 2004 6 commits
    • Manish Singh's avatar
      Minor cleanup, add note about using pango_fc_font_description_from_pattern · d7c8844c
      Manish Singh authored
      2004-01-15  Manish Singh  <yosh@gimp.org>
      
              * app/text/gimpfontlist.c: Minor cleanup, add note about using
              pango_fc_font_description_from_pattern from pango 1.4 when we
              can.
      d7c8844c
    • Pedro Gimeno's avatar
      Removed the code that disables save formats conditionally, making all of · 465e4372
      Pedro Gimeno authored
      2004-01-15  Pedro Gimeno  <pggimeno@wanadoo.es>
      
      	* app/gui/file-save-menu.c (file_save_menu_update): Removed the
      	code that disables save formats conditionally, making all of
      	them available. Fixes bug #110610.
      465e4372
    • Manish Singh's avatar
      Set PangoStretch from FC_WIDTH. This partially addresses #131561 (namely, · cc2534b1
      Manish Singh authored
      2004-01-15  Manish Singh  <yosh@gimp.org>
      
              * app/text/gimpfontlist.c: Set PangoStretch from FC_WIDTH. This
              partially addresses #131561 (namely, the gimp side).
      cc2534b1
    • Michael Natterer's avatar
      Fixed bug #78732 (don't paste off screen): · 0af39061
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	Fixed bug #78732 (don't paste off screen):
      
      	* app/display/gimpdisplayshell-transform.[ch]: added new function
      	gimp_display_shell_untransform_viewport() which returns the
      	visible rectangle of the image in image coordinates.
      
      	* app/core/gimp-edit.[ch] (gimp_edit_paste): added viewport
      	parameters and changed positioning of the pasted layer as follows:
      
      	- if there is a selection, center on the selection (just as before).
      	- if there is no viewport, center on the active drawable.
      	- if the viewport intersects with the active drawable, center
      	  on the intersection.
      	- if the viewport does *not* intersect with the active drawable,
      	  center on the active drawable (off-screen, but better than pasting
      	  something that will be invisible due to floating selection clipping).
      	- if there is no active drawable, center on the viewport.
      	- if there is no active drawable and no viewport, center on the image.
      
      	* app/widgets/gimpbufferview.c (gimp_buffer_view_paste_clicked)
      	(gimp_buffer_view_paste_into_clicked)
      	* app/display/gimpdisplayshell-dnd.c (gimp_display_shell_drop_buffer)
      	* app/gui/edit-commands.c (edit_paste_cmd_callback)
      	(edit_paste_into_cmd_callback): ask the shell for the viewport
      	and pass it to gimp_edit_paste().
      
      	* app/display/gimpdisplayshell-dnd.c
      	(gimp_display_shell_drop_drawable): center the created layer on
      	the viewport.
      
      	* app/tools/gimpmovetool.c (gimp_move_tool_button_release): use
      	gimp_display_shell_untransform_viewport() (its code was taken from
      	here).
      
      	* tools/pdbgen/pdb/edit.pdb: pass "no viewport" to gimp_edit_paste().
      
      	* app/pdb/edit_cmds.c: regenerated.
      0af39061
    • Michael Natterer's avatar
      moved initialization of the gimage->visible[] and gimage->active[] arrays · d994e904
      Michael Natterer authored
      2004-01-15  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.c: moved initialization of the
      	gimage->visible[] and gimage->active[] arrays from
      	gimp_image_new() to gimp_image_init(). Use gimp_rgba_set()
      	to initialize gimage->qmask_color.
      d994e904
    • Manish Singh's avatar
      #include "file/file-utils.h" for file_utils_filename_to_utf8. · 35f1fd42
      Manish Singh authored
      2004-01-14  Manish Singh  <yosh@gimp.org>
      
              * app/config/gimpconfig-utils.c: #include "file/file-utils.h" for
              file_utils_filename_to_utf8.
      35f1fd42
  8. 14 Jan, 2004 3 commits
    • Dave Neary's avatar
      get the type of the drawable, not the image, when transforming a TempBuf, · 83421682
      Dave Neary authored
      
      
      2004-01-14  Dave Neary  <bolsh@gimp.org>
      
              * app/core/gimpimage.c: get the type of the drawable, not the
              image, when transforming a TempBuf, making dragging & dropping
              patterns on layer masks work correctly. Fixes bug #131146.
      83421682
    • Michael Natterer's avatar
      added GIMP_IMAGE_TYPE_WITHOUT_ALPHA() macro as counterpart to · 9d43b066
      Michael Natterer authored
      2004-01-14  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpimage.h: added GIMP_IMAGE_TYPE_WITHOUT_ALPHA()
      	macro as counterpart to GIMP_IMAGE_TYPE_WITH_ALPHA().
      
      	* app/core/gimpdrawable.[ch]: added
      	gimp_drawable_type_without_alpha() and
      	gimp_drawable_bytes_without_alpha() convenience functions.
      9d43b066
    • Michael Natterer's avatar
      Some code review: · 134efe87
      Michael Natterer authored
      2004-01-14  Michael Natterer  <mitch@gimp.org>
      
      	Some code review:
      
      	* app/core/gimpimage.c: named the gint paramater in all
      	colormap_changed related functions to "color_index", fixed typo in
      	parasite undo description, moved some variables to local scopes,
      	changed the layer raise/lower functions to look like the channel
      	and vector ones, cosmetics.
      
      	* app/core/gimpimage-colorhash.c: removed trailing whitespace,
      	initialize / reset more stuff to 0, cosmetics.
      134efe87