1. 25 Oct, 2020 12 commits
  2. 24 Oct, 2020 9 commits
    • Jehan's avatar
      Issue #5322: [Wayland] broken splash size. · 7e6ced5c
      Jehan authored
      This is not a fix, only an extra-ugly workaround so that at the very
      least we don't end up with a splash screen taking the whole display on
      Basically by setting 1/3 as the max splash size, a Wayland desktop with
      no scale ratio will have a splash taking a third of the screen while it
      would take 2/3 of the screen with a scale ratio of ×2 (of course, it
      will still be very broken with a scale ratio of ×3 but are there
      displays needing such high scaling?). The real fix will be when GTK/GDK
      fix their API so that it returns what the docs says it should (i.e. a
      size in "application pixels" not "device pixels"), as it does on X11,
      Windows, macOS… Then we won't create random max size and we will be able
      to properly control our splash size.
      Note that this neither fixes nor works around the position issue on
      Wayland (in my case, the splash was just always on top-left of the
    • Jacob Boerema's avatar
      plug-ins: use g_message instead of g_printerr when there is data loss. · f336f86f
      Jacob Boerema authored
      After discussion with Jehan we concluded that it is better to report
      these data loss messages to the user using g_message.
    • Jehan's avatar
      app: fix some glitches in the splash status text. · 3a50e52a
      Jehan authored
      These small glitches have bothered me for a while now, so I finally
      fixed these before the dev release!
      Basically there were 2 fixes:
      1. use the ink extents to compute any drawn area as this is what will be
         actually drawn.
      2. Not only expose the drawn area of the new text, but also the one of
         the previous text in order to be sure all text pixels are correctly
         reset (in case the new text is smaller than previous one). I.e. we
         must expose the smallest rectangle containing both previous and new
         area of text.
    • Jacob Boerema's avatar
    • Jacob Boerema's avatar
      plug-ins: don't try to read tiff pages with an invalid directory. · e4514567
      Jacob Boerema authored
      We didn't check whether TIFFSetDirectory succeeded nor did
      we check TIFFReadScanline for failure which can cause
      We will not try to read a tiff page if setting its directory fails
      and we will stop reading a page if reading scanline fails.
    • Jehan's avatar
      Issue #4922: install software-update-available from Adwaita on hicolor. · c6063183
      Jehan authored
      I took the icon directly from Adwaita repository as of today's version:
      By being installed on our local GIMP-only hicolor, this gets picked up
      after any custom theme software-update-available version. I didn't
      install it inside the Symbolic or Color theme because anyway Adwaita
      seems only to provide a single vector version. There is a color version,
      yet as PNG icons and installed in the legacy/ section. I don't think it
      makes sense to use an icon considered as legacy by its author and
      without vector version. So I just install the symbolic version and all
      themes can fallback to it (be them symbolic icon themes or not).
      This icon comes from the Adwaita repository and is therefore licensed
      under the terms of either the GNU LGPL v3 or Creative Commons
      Attribution-Share Alike 3.0 United States License. See:
    • Lloyd Konneker's avatar
      Issue #5809: missing dependency on libm for libgimpwidgets/test-eevl · 2920a136
      Lloyd Konneker authored and Jehan's avatar Jehan committed
    • Jehan's avatar
      app: clean tab indentation. · e676ad46
      Jehan authored
    • Jehan's avatar
      plug-ins: fix a type warning. · 74629453
      Jehan authored
      Since obj->type_data is also int anyway, multiplying by a double value
      is unneeded anyway. So let's just make an integer multiplication.
      Fixes the following warning:
      > warning: using integer absolute value function ‘abs’ when argument is
      > of floating point type ‘double’ [-Wabsolute-value]
  3. 23 Oct, 2020 7 commits
  4. 22 Oct, 2020 10 commits
    • Jehan's avatar
      NEWS: update with new "file-heif-av1-load" procedure. · bca4d434
      Jehan authored
      `gimp-2-10` branch has a common load procedure for HEIC and AVIF, but
      the main file-heif contributor (Daniel Novomesky) considers it better to
      have 2 procedures. Among other things, it helps to allow using a
      separate plug-in for AVIF while this procedure is still used for HEIC.
      This won't be backported to 2.10 because it changes the existing
      procedure usage. So it's a master-only change, hence adding it to NEWS.
    • Jehan's avatar
      app: fix AppStream tag localization. · 68cea846
      Jehan authored
      As AppStream docs says, <description> "tag should be translated
      by-paragraph" in upstream metadata, which is what we have always done
      (i.e. <_p> tags which becomes <p xml:lang="xy">).
      Unfortunately as_app_get_description() is optimized to work for
      Collection Metadata where the 'tag is translated "as a whole"' (again
      cf. specs) for faster parsing. So we were ending up with a text mixing
      the original and all localized texts.
      I have opened a bug report to appstream-glib:
      While waiting for this to be fixed (i.e. when the function will handle
      both cases accordingly to the metadata source), this code makes my own
      locale extraction (defaulting to original text which is assumed to be
      the previous same level tag with no xml:lang if no tag with the exact
      lang attribute was found).
    • Daniel Novomeský's avatar
      HEIF plug-in: runtime detection of supported formats · 35c0d7dc
      Daniel Novomeský authored and Jehan's avatar Jehan committed
    • Jehan's avatar
      gitlab-ci: temporary allow distcheck job failure. · e869a112
      Jehan authored
      I really don't like to flag the distcheck job as allowed to fail, but
      the issue we have with it right now (#5790) is very annoying and I have
      no idea where the weird uncleaned files come from. I can't reproduce
      this locally and these files are seemingly never created here during a
      Since it makes all our pipelines fail, this makes it harder to diagnose
      and find real other bugs, so let's allow failure until we figure this
    • Jehan's avatar
      extensions: goat-exercise appdata depends on po files. · 5c03dd16
      Jehan authored
      Make sure we regenerate the appdata file when po files are updated. It
      should not be too much of a problem for release builds made from
      scratch, but on incremental dev builds, the appdata was not regenerated
      even when new translation got added.
    • Jehan's avatar
      app: unstable versions will check available development releases. · 6c26d39c
      Jehan authored
      Stable versions (i.e. minor version number even, e.g. 2.10.22) will only
      look for higher stable releases. But for unstable versions, we will want
      to look up the development releases too. So for instance GIMP 2.99.2
      will warn if the development version 2.99.4 has been released, but also
      if the stable version 3.0.0 has been released (whatever is the highest,
      which is the stable version in this example).
    • Jehan's avatar
      app: properly free internal strings at finalization and before… · 89db5f65
      Jehan authored
      … overriding their previous value.
    • Jehan's avatar
      app: use gimp_viewable_is_ancestor() instead of gimp_item_is_ancestor(). · 057b94f5
      Jehan authored
      I had recently created gimp_item_is_ancestor() but realize it duplicates
      gimp_viewable_is_ancestor() (which works on GimpItem since it's a parent
      class). No need for duplicate code.
    • Jehan's avatar
      configure: do not show "profile support: yes" when HEIC support is OFF. · fc257093
      Jehan authored
      Same as previous commit but for autotools, in a separate commit for easy
    • Jehan's avatar
      meson: do not show "profile support: yes" when HEIC support is OFF. · e736b5fa
      Jehan authored
      Note that profile support also affect AVIF but since AVIF support came
      anyway after libheif 1.4.0 (which is when color profile support
      appeared), there is no way to differentiate there.
      Thanks to Darix for noting the miss.
      See: #5787 (comment 938976)
  5. 21 Oct, 2020 2 commits
    • Jehan's avatar
      app, pdb: set string arguments to "" *after* the GFile. · 4b9dc93d
      Jehan authored
      Thanks to Wormnest for pushing me to look further. Since gimp-file-save
      is actually redirecting the call to another procedure (save proc for the
      specific format) which might have more arguments, including string
      arguments. When it finds any, it sets it to an empty string "" (which I
      guess is ok as "default value when we don't know what to put there").
      The previous code would not hurt. Starting at the fourth argument
      (GFile), it would just do nothing, then continue with the firth and
      further. Still, starting directly at the fifth arg is the proper code
      for this.
    • Jehan's avatar
      pdb: fix gimp-file-save PDB procedure implementation. · 0f6e43f0
      Jehan authored
      I fixed the wrong file in my previous commit (it's a generated file!).
      This is the right one.