1. 20 Aug, 2008 5 commits
    • Sven Neumann's avatar
      plug-ins/file-psd/psd.c plug-ins/file-psd/psd-load.[ch] · 5e347ed2
      Sven Neumann authored
      2008-08-20  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-psd/psd.c
      	* plug-ins/file-psd/psd-load.[ch]
      	* plug-ins/file-psd/psd-save.c 
      	* plug-ins/file-psd/psd-thumb-load.[ch]: pass error messages 
      with
      	the return values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26671
      5e347ed2
    • Sven Neumann's avatar
      plug-ins/file-jpeg/jpeg.[ch] plug-ins/file-jpeg/jpeg-load.[ch] pass error · 50849396
      Sven Neumann authored
      2008-08-20  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-jpeg/jpeg.[ch]
      	* plug-ins/file-jpeg/jpeg-load.[ch]
      	* plug-ins/file-jpeg/jpeg-save.[ch]: pass error messages with 
      the
      	return values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26670
      50849396
    • Sven Neumann's avatar
      flush the image when done to cause the actions to be updated (in · cdf2726b
      Sven Neumann authored
      2008-08-20  Sven Neumann  <sven@gimp.org>
      
      	* app/file/file-save.c (file_save): flush the image when done to
      	cause the actions to be updated (in particular File->Revert).
      
      
      svn path=/trunk/; revision=26669
      cdf2726b
    • Sven Neumann's avatar
      create GHashTable with destroy notifiers. · 39571e16
      Sven Neumann authored
      2008-08-20  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-ico/ico-save.c: create GHashTable with destroy
      	notifiers.
      
      
      svn path=/trunk/; revision=26668
      39571e16
    • Sven Neumann's avatar
      plug-ins/file-faxg3/faxg3.c plug-ins/file-ico/ico.c · 3f26d82b
      Sven Neumann authored
      2008-08-20  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-faxg3/faxg3.c
      	* plug-ins/file-ico/ico.c
      	* plug-ins/file-ico/ico-load.[ch]
      	* plug-ins/file-ico/ico-save.[ch]: pass error messages with the
      	return values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26667
      3f26d82b
  2. 19 Aug, 2008 6 commits
  3. 18 Aug, 2008 12 commits
    • Sven Neumann's avatar
      Complements the fix for bug #344818: · 369d991f
      Sven Neumann authored
      2008-08-19  Sven Neumann  <sven@gimp.org>
      
      	Complements the fix for bug #344818:
      
      	* libgimpbase/gimpbaseenums.[ch]: added new enum 
      GimpPDBErrorHandler.
      
      	* tools/pdbgen/enums.pl: regenerated.
      
      	* app/plug-in/gimpplugin.[ch]: added error_handler to 
      GimpPlugIn.
      
      	* app/plug-in/gimpplugin-message.c 
      (gimp_plug_in_handle_proc_run):
      	only display an error message for a failed procedure call if the
      	plug-in's error-handler is set to 
      GIMP_PDB_ERROR_HANDLER_INTERNAL.
      	
      	* tools/pdbgen/pdb/plug_in.pdb: added PDB getter and setter for
      	the plug-in's error-handler.
      
      	* app/pdb/plug-in-cmds.c
      	* app/pdb/internal-procs.c
      	* libgimp/gimpenums.c.tail
      	* libgimp/gimpplugin_pdb.[ch]: regenerated.
      
      	* plug-ins/common/file-compressor.c
      	* plug-ins/file-uri/uri.c: set the error-handler to
      	GIMP_PDB_ERROR_HANDLER_PLUGIN as these plug-ins are forwarding 
      the
      	error with their return values.
      
      
      svn path=/trunk/; revision=26656
      369d991f
    • Sven Neumann's avatar
      pass error messages with the return values instead of calling g_message(). · 8b0384a7
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-uri/uri.c: pass error messages with the return
      	values instead of calling g_message().
      
      	* plug-ins/file-uri/uri-backend-libcurl.c
      	* plug-ins/file-uri/uri-backend-gnomevfs.c
      	* plug-ins/file-uri/uri-backend-gvfs.c
      	* plug-ins/file-uri/uri-backend-wget.c: set errors in the 
      	G_FILE_ERROR domain and other minor cleanups.
      
      
      svn path=/trunk/; revision=26655
      8b0384a7
    • Sven Neumann's avatar
      open the temporary file before forking. This allows us to return an error · cc60f022
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-compressor.c: open the temporary file
      	before forking. This allows us to return an error message if the
      	file can't be opened. Also changed the code to not use 
      g_message()
      	from the child process.
      
      
      svn path=/trunk/; revision=26653
      cc60f022
    • Sven Neumann's avatar
      pass some error message with the return values instead of calling · 7c57332c
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-compressor.c: pass some error message 
      with
      	the return values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26652
      7c57332c
    • Sven Neumann's avatar
      plug-ins/common/file-gbr.c plug-ins/common/file-gih.c · a1cbd581
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-gbr.c
      	* plug-ins/common/file-gih.c
      	* plug-ins/common/file-pat.c
      	* plug-ins/common/file-pix.c
      	* plug-ins/common/file-sunras.c: for the most common errors, 
      pass
      	the error message with the return values instead of calling
      	g_message().
      
      
      svn path=/trunk/; revision=26650
      a1cbd581
    • Michael Natterer's avatar
      renamed... ...to this. · 7caea1c8
      Michael Natterer authored
      2008-08-18  Michael Natterer  <mitch@gimp.org>
      
      	* plug-ins/common/compressor.c: renamed...
      	* plug-ins/common/file-compressor.c: ...to this.
      
      	* plug-ins/common/plugin-defs.pl: changed accordingly.
      
      	* plug-ins/common/Makefile.am: regenerated.
      
      
      svn path=/trunk/; revision=26648
      7caea1c8
    • Sven Neumann's avatar
      plug-ins/common/file-xbm.c plug-ins/common/file-xpm.c for the most common · a458135b
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-xbm.c
      	* plug-ins/common/file-xpm.c
      	* plug-ins/common/file-xwd.c: for the most common errors, pass 
      the
      	error message with the return values instead of calling 
      g_message().
      
      
      svn path=/trunk/; revision=26646
      a458135b
    • Sven Neumann's avatar
      pass error message with the return values instead of calling g_message(). · baabae4d
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-wmf.c: pass error message with the return
      	values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26642
      baabae4d
    • Sven Neumann's avatar
      it's g_message(), not gimp_message() · e7f4446b
      Sven Neumann authored
      svn path=/trunk/; revision=26641
      e7f4446b
    • Sven Neumann's avatar
      plug-ins/common/file-raw.c plug-ins/common/file-tga.c · fc059e31
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-raw.c
      	* plug-ins/common/file-tga.c
      	* plug-ins/common/file-tiff-load.c
      	* plug-ins/common/file-tiff-save.c: pass error messages with the
      	return values instead of calling gimp_message().
      
      
      svn path=/trunk/; revision=26640
      fc059e31
    • Sven Neumann's avatar
      plug-ins/common/file-pnm.c plug-ins/common/file-ps.c for the most common · edabd739
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-pnm.c
      	* plug-ins/common/file-ps.c
      	* plug-ins/common/file-psp.c: for the most common errors, pass 
      the
      	error message with the return values instead of calling
      	gimp_message().
      
      
      svn path=/trunk/; revision=26639
      edabd739
    • Sven Neumann's avatar
      plug-ins/common/file-mng.c for the most common errors, pass the error · 592d5976
      Sven Neumann authored
      2008-08-18  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-mng.c
      	* plug-ins/common/file-pcx.c: for the most common errors,
      	pass the error message with the return values instead of calling
      	gimp_message().
      
      	* plug-ins/common/file-gif-save.c
      	* plug-ins/common/file-pdf.c
      	* plug-ins/common/file-png.c: minor cleanup.
      
      
      svn path=/trunk/; revision=26638
      592d5976
  4. 17 Aug, 2008 17 commits
    • Sven Neumann's avatar
      in case of an error, pass the error message with the return values. · d5da6ce8
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-pdf.c: in case of an error, pass the 
      error
      	message with the return values.
      
      
      svn path=/trunk/; revision=26637
      d5da6ce8
    • Sven Neumann's avatar
      plug-ins/common/file-gif-load.c for the most common errors, pass the error · ad828a03
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-gif-load.c
      	* plug-ins/common/file-gif-save.c: for the most common errors,
      	pass the error message with the return values instead of calling
      	gimp_message().
      
      	* plug-ins/common/file-png.c: unmarked a string for translation.
      	This error condition can't possibly happen.
      
      	* plug-ins/common/file-svg.c: also return an error message when
      	the thumbnail can't be loaded.
      
      
      svn path=/trunk/; revision=26636
      ad828a03
    • Sven Neumann's avatar
      for the most common errors, pass the error message with the return values · cb21ecf5
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-dicom.c: for the most common errors, pass
      	the error message with the return values instead of calling
      	gimp_message().
      
      
      svn path=/trunk/; revision=26634
      cb21ecf5
    • Sven Neumann's avatar
      in case of an error, pass the error message with the return values. · c60a4ba5
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-csource.c (save_image): in case of an
      	error, pass the error message with the return values.
      
      
      svn path=/trunk/; revision=26633
      c60a4ba5
    • Sven Neumann's avatar
      don't hardcode the tile size, use gimp.tile_width() instead. · e73fc40c
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/pygimp/plug-ins/whirlpinch.py: don't hardcode the 
      tile
      	size, use gimp.tile_width() instead.
      
      
      svn path=/trunk/; revision=26632
      e73fc40c
    • Sven Neumann's avatar
      formatting. · 00f704f8
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/pygimp/plug-ins/whirlpinch.py: formatting.
      
      
      svn path=/trunk/; revision=26631
      00f704f8
    • Sven Neumann's avatar
      formatting · 1834dcc8
      Sven Neumann authored
      svn path=/trunk/; revision=26627
      1834dcc8
    • Sven Neumann's avatar
      plug-ins/common/file-desktop-link.c · 2c348c7a
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/common/file-desktop-link.c
      
      	* plug-ins/common/file-svg.c: changed to pass error messages 
      with
      	the return values instead of calling g_message().
      
      
      svn path=/trunk/; revision=26626
      2c348c7a
    • Sven Neumann's avatar
      unmarked string for translation. Script-Fu doesn't support i18n outside · 4a206387
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/script-fu/scripts/frosty-logo.scm
      	(apply-frosty-logo-effect): unmarked string for translation.
      	Script-Fu doesn't support i18n outside the register call.
      
      
      svn path=/trunk/; revision=26624
      4a206387
    • Sven Neumann's avatar
      plug-ins/script-fu/scripts/glowing-logo.scm changed the "Alpha to Logo" · 3db928cf
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/script-fu/scripts/glowing-logo.scm
      	* plug-ins/script-fu/scripts/neon-logo.scm: changed the "Alpha 
      to
      	Logo" parts of these scripts so that the user can specify the
      	effect size directly instead of as some multiple of the size.
      
      
      svn path=/trunk/; revision=26623
      3db928cf
    • Sven Neumann's avatar
      dropped the "Alpha to Logo" part of the "Starscape logo script. It had a · b801bc39
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/script-fu/scripts/starscape-logo.scm: dropped the
      	"Alpha to Logo" part of the "Starscape logo script. It had a
      	similar problem as the Starburst script (see bug #486779).
      
      
      svn path=/trunk/; revision=26622
      b801bc39
    • Sven Neumann's avatar
      plug-ins/script-fu/scripts/Makefile.am dropped the "Starburst" logo · 97f281a9
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/script-fu/scripts/Makefile.am
      	* plug-ins/script-fu/scripts/starburst-logo.scm: dropped the
      	"Starburst" logo script. Fixes bug #486779.
      
      
      svn path=/trunk/; revision=26621
      97f281a9
    • Sven Neumann's avatar
      Next step towards fixing bug #344818: · a2cd4b73
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	Next step towards fixing bug #344818:
      
      	* app/pdb/gimpprocedure.c (gimp_procedure_execute): if the error
      	has not already been set, construct one from the error message
      	that is optionally passed with the return values.
      
      	* plug-ins/common/file-png.c: changed to pass an error message
      	with the return values instead of calling g_message() in case of
      	an error.
      
      
      svn path=/trunk/; revision=26620
      a2cd4b73
    • Sven Neumann's avatar
      renamed gimp_plug_in_proc_frame_get_return_vals() to · 04539e92
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* app/plug-in/gimppluginprocframe.[ch]: renamed
      	gimp_plug_in_proc_frame_get_return_vals() to
      	gimp_plug_in_proc_frame_get_return_values().
      
      	* app/plug-in/gimppluginmanager-call.c: changed accordingly.
      
      svn path=/trunk/; revision=26619
      04539e92
    • Sven Neumann's avatar
      changed to use g_set_error(). · 3fa2cbe0
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-psd/psd-util.c (psd_set_error): changed to use
      	g_set_error().
      
      
      svn path=/trunk/; revision=26618
      3fa2cbe0
    • Sven Neumann's avatar
      changed to use g_error_new_literal(). · 1277bb44
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* plug-ins/file-psd/psd-util.c (psd_set_error): changed to use
      	g_error_new_literal().
      
      
      svn path=/trunk/; revision=26617
      1277bb44
    • Sven Neumann's avatar
      introduced a utility function to reduce code duplication. · 51d56e3a
      Sven Neumann authored
      2008-08-17  Sven Neumann  <sven@gimp.org>
      
      	* app/plug-in/gimpplugin-progress.c
      	(gimp_plug_in_progress_cancel_callback): introduced a utility
      	function to reduce code duplication.
      
      	* app/pdb/gimppdb.c (gimp_pdb_execute_procedure_by_name): 
      changed
      	to use g_error_new_literal().
      
      
      svn path=/trunk/; revision=26616
      51d56e3a