1. 02 Dec, 2001 1 commit
    • Daniel Egger's avatar
      Convert ugly comments into named structure fields. Much cleaner and less · 1ed91801
      Daniel Egger authored
      2001-12-02  Daniel Egger  <degger@fhm.edu>
      
      	* app/gimprc.c: Convert ugly comments into named structure fields.
      	Much cleaner and less errorprone though may cause troubles on
      	older compilers and then needs to be reverted. Please report!
      
      	* app/base/base-types.h: Add FIXME reminder.
      
      	* app/base/gimplut.c: Use CLAMP macro instead of if-cascade.
      
      	* app/base/temp-buf.c: Remove duplicated calculations and simplify
      	checks.
      
      	* app/base/tile-manager.c:
      	- (tile_manager_get_tile_num): Return success and take an additional
      	  pointer for the tilenumber.
      	- Simplify logic in the rest of the file as a result.
      	- Remove rotten debugging cruft.
      
      	* app/core/gimpbrushgenerated.c: Fix two stylistic nits.
      
      	* app/app_procs.c: Include <stdlib.h> for exit () prototype.
      
      	* app/core/gimpdrawable-blend.c: Include <stdlib.h> for abs ()
      	prototype.
      
      	* app/display/gimpdisplay.c: Include <string.h> for memcpy ()
      	prototype.
      
      	* app/core/gimpimage-convert.c: (HIST_RGB): First parameter is
      	not const. Fixes a gcc warning for a wrong return value.
      
      	* libgimpwidgets/gimpunitmenu.c
      	* app/core/gimpunit.c: Add suggested (by gcc 3.1 cvs) parentheses
      	to group correct logic tests together.
      
      	* app/paint-funcs/paint-funcs-generic.h: Fix my HAS_ALPHA macro
      	to avoid gcc 3.1 cvs warning.
      
      	* app/gimprc.h
      	* pathP.h
      	* base-config.h
      	* app/base/boundary.h
      	* app/base/gimplut.[ch]
      	* app/base/pixel-region.h
      	* app/base/pixel-surround.[ch]
      	* app/base/temp-buf.[ch]
      	* app/base/tile-manager-private.h
      	* app/base/tile-manager.c
      	* app/base/tile-private.h
      	* app/base/tile.[ch]
      	* app/core/gimp.h
      	* app/core/gimpbrushgenerated.h
      	* app/core/gimpbrushpipe.h
      	* app/core/gimpchannel.[ch]
      	* app/core/gimpcontainer.h
      	* app/core/gimpcoreconfig.h
      	* app/core/gimpdata.h
      	* app/core/gimpdatafactory.[ch]
      	* app/core/gimpdrawable-blend.c
      	* app/core/gimpdrawable.[ch]
      	* app/core/gimpimage.h
      	* app/core/gimpimagefile.h
      	* app/core/gimplayer.h
      	* app/core/gimplayermask.h
      	* app/core/gimpmoduleinfo.h
      	* app/core/gimppalette.h
      	* app/core/gimpundo.h
      	* app/display/gimpdisplay.h
      	* app/display/gimpdisplayshell-selection.h
      	* app/display/gimpdisplayshell.h
      	* app/gui/brush-select.h
      	* app/gui/gradient-editor.h
      	* app/gui/gradient-select.h
      	* app/gui/info-dialog.h
      	* app/gui/resize-dialog.h
      	* app/tools/gimpbezierselecttool.h
      	* app/tools/gimpcolorbalancetool.h
      	* app/tools/gimpcolorpickertool.h
      	* app/tools/gimpcurvestool.h
      	* app/tools/gimpdodgeburntool.c
      	* app/tools/gimpfreeselecttool.h
      	* app/tools/gimpfuzzyselecttool.h
      	* app/tools/gimphuesaturationtool.h
      	* app/tools/gimpinktool-blob.h
      	* app/tools/gimpinktool.h
      	* app/tools/gimpiscissorstool.h
      	* app/tools/gimpmagnifytool.h
      	* app/tools/gimpmeasuretool.h
      	* app/tools/gimppainttool.h
      	* app/tools/gimppathtool.h
      	* app/tools/gimprectselecttool.h
      	* app/tools/gimpthresholdtool.h
      	* app/tools/gimptool.h
      	* app/tools/gimptransformtool.h
      	* app/tools/path_toolP.h
      	* app/widgets/gimpbrushfactoryview.h
      	* app/widgets/gimpconstrainedhwrapbox.h
      	* app/widgets/gimpcontainermenu.h
      	* app/widgets/gimpcontainerview.h
      	* app/widgets/gimpdialogfactory.h
      	* app/widgets/gimpimagedock.h
      	* app/widgets/gimplistitem.h
      	* app/widgets/gimpmenuitem.h
      	* app/widgets/gimpnavigationpreview.h
      	* app/widgets/gimppreview.h: Unsignify lots of variables and
      	parameters and use bitfields in structs where possible. First
      	part of a huge cleanup all over the code...
      1ed91801
  2. 15 May, 2001 1 commit
    • Michael Natterer's avatar
      new directory app/base/ · d240f623
      Michael Natterer authored
      2001-05-15  Michael Natterer  <mitch@gimp.org>
      
      	* configure.in: new directory app/base/
      
      	* app/Makefile.am
      	* app/boundary.[ch]
      	* app/brush_scale.[ch]
      	* app/gimpchecks.h
      	* app/gimplut.[ch]
      	* app/pixel_processor.[ch]
      	* app/pixel_region.[ch]
      	* app/pixel_surround.[ch]
      	* app/temp_buf.[ch]
      	* app/tile.[ch]
      	* app/tile_cache.[ch]
      	* app/tile_manager.[ch]
      	* app/tile_manager_pvt.h
      	* app/tile_pvt.h
      	* app/tile_swap.[ch]: moved to base/
      
      	* app/base/Makefile.am
      	* app/base/base-types.h
      	* app/base/*: new directory for the sub-object pixel maniplation
      	and storage stuff. Does not include Gtk+ or anything outside
      	base/. Did some cleanup in all files.
      
      	* app/appenums.h
      	* app/apptypes.h
      	* app/core/gimpimage.h: removed types which are now in
      	base/base-types.h.
      
      	* app/base/base-config.[ch]
      	* app/gimprc.[ch]: put the config variables for base/ to their own
      	file so base/ doesn not have to include gimprc.h (does not yet
      	work, i.e. the variables are un-configurable right now)
      
      	* app/main.c: set a log handler for "Gimp-Base".
      
      	* app/paint-funcs/Makefile.am
      	* app/paint-funcs/paint-funcs.[ch]: removed the color hash which
      	maps RGB to color indices because it's a totally standalone system
      	which has nothing to do with the paint-funcs and introduced a
      	GimpImage dependency.
      
      	paint-funcs/ should be considered on the same sub-object
      	(glib-only) level as base/, only in a different directory.
      
      	* app/core/Makefile.am
      	* app/core/gimpimage-colorhash.[ch]: put the color hash here.
      
      	* app/gimage.c: don't invalidate the color hash here...
      
      	* app/core/gimpimage.c: ... but in the colormap_changed() default
      	inplementation. Initialize the hash in class_init().
      
      	* tools/pdbgen/Makefile.am: scan app/base/base-types.h for enums.
      
      	* tools/pdbgen/enums.pl: regenerated.
      
      	* app/[lots]
      	* app/core/[of]
      	* app/gui/[files]
      	* app/pdb/[all]
      	* app/tools/[over]
      	* app/widgets/[the]
      	* tools/pdbgen/pdb/[place]: changed #includes accordingly. And use
      	base_config->value instead of the stuff from gimprc.h.
      d240f623
  3. 29 Dec, 2000 1 commit
    • Michael Natterer's avatar
      app/Makefile.am app/channel_pvt.h app/drawable_pvt.h app/gdisplayF.h · 8d6c335f
      Michael Natterer authored
      2000-12-29  Michael Natterer  <mitch@gimp.org>
      
      	* app/Makefile.am
      	* app/channel_pvt.h
      	* app/drawable_pvt.h
      	* app/gdisplayF.h
      	* app/gimpdrawableP.h
      	* app/gimpimageP.h
      	* app/layer_pvt.h
      	* app/toolsF.h: removed these files.
      
      	* app/apptypes.h
      	* tools/pdbgen/enums.pl: added tons of opaque typedefs and enums.
      
      	* tools/pdbgen/pdb/brush_select.pdb
      	* tools/pdbgen/pdb/brushes.pdb
      	* tools/pdbgen/pdb/channel.pdb
      	* tools/pdbgen/pdb/color.pdb
      	* tools/pdbgen/pdb/convert.pdb
      	* tools/pdbgen/pdb/display.pdb
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/fileops.pdb
      	* tools/pdbgen/pdb/gradient_select.pdb
      	* tools/pdbgen/pdb/gradients.pdb
      	* tools/pdbgen/pdb/help.pdb
      	* tools/pdbgen/pdb/image.pdb
      	* tools/pdbgen/pdb/layer.pdb
      	* tools/pdbgen/pdb/pattern_select.pdb
      	* tools/pdbgen/pdb/patterns.pdb
      	* tools/pdbgen/pdb/selection.pdb
      	* tools/pdbgen/pdb/tools.pdb
      	* app/*: chainsaw #include cleanup:
      
      	- Never (never!!) include stuff in header files except where we
      	  need access to structures' contents (like derived objects).
      	- Added prototypes and proper formating in many files.
      	- The #include order in *all* *.c files is as follows:
      
      	#include "config.h"
      
      	#include <system stuff>
      
      	#include <gtk/gtk.h>
      
      	#include "apptypes.h"
      
      	#include "gimp stuff"
      
      	#include "libgimp stuff"
      
      	#include "libgimp/gimpintl.h"
      
      	By following this scheme we can easily see a file's dependencies
      	from it's #include's and can grep for the inclusion to find out
      	where a file is used.
      
      	* tools/pdbgen/app.pl: changed to follow the include scheme above.
      
      	* libgimp/Makefile.am
      	* libgimp/gimpuitypes.h: new file, included from libgimp/gimpui.h
      	and from app/apptypes.h.
      
      	* libgimp/gimpcolorbutton.[ch]
      	* libgimp/gimpdialog.[ch]
      	* libgimp/gimphelpui.[ch]
      	* libgimp/gimpparasite.[ch]
      	* libgimp/gimppatheditor.[ch]
      	* libgimp/gimpprotocol.c
      	* libgimp/gimpquerybox.[ch]
      	* libgimp/gimpsizeentry.[ch]
      	* libgimp/gimptypes.h
      	* libgimp/gimpui.h
      	* libgimp/gimpunit.h
      	* libgimp/gimpunitmenu.[ch]
      	* libgimp/gimpwidgets.[ch]: changed accordingly.
      
      	* plug-ins/FractalExplorer/Dialogs.c
      	* plug-ins/gdyntext/message_window.c
      	* plug-ins/imagemap/imap_default_dialog.c
      	* plug-ins/imagemap/imap_file.c: these files used to include
      	"libgimp/gimpui.h" without including "libgimp/gimp.h". This is
      	no longer possible because the libgimpui headers don't inlcude
      	"libgimp/gimpunit.h" any more.
      8d6c335f
  4. 28 Dec, 2000 1 commit
    • Sven Neumann's avatar
      app/boundaryF.h app/gdisplayP.h app/gimplistP.h app/gimplutP.h · c11acc6c
      Sven Neumann authored
      2000-12-28  Sven Neumann  <sven@gimp.org>
      
      	* app/boundaryF.h
      	* app/gdisplayP.h
      	* app/gimplistP.h
      	* app/gimplutP.h
      	* app/gimpsetP.h
      	* app/parasitelistP.h
      	* app/pixel_regionP.h: removed these files
      
      	* app/Makefile.am
      	* app/apptypes.h
      	* app/boundary.[ch]
      	* app/floating_sel.h
      	* app/gdisplay.c
      	* app/gimplist.h
      	* app/gimplut.[ch]
      	* app/gimpset.[ch]
      	* app/parasitelist.[ch]
      	* app/pixel_processor.c
      	* app/pixel_region.[ch]: moved structure definitions into the
      	normal headers, various cleanups
      c11acc6c
  5. 16 Dec, 2000 1 commit
    • Sven Neumann's avatar
      Last-minute cleanup: · dfa2bed5
      Sven Neumann authored
      2000-12-16  Sven Neumann  <sven@gimp.org>
      
      	Last-minute cleanup:
      
      	* app/gimpdrawableF.h
      	* app/gimphistogramF.h
      	* app/gimpimageF.h
      	* app/gimplistF.h
      	* app/gimplutF.h
      	* app/gimpobjectF.h
      	* app/gimpsetF.h
      	* app/layerF.h
      	* app/parasitelistF.h: removed these files
      
      	* app/Makefile.am
      	* tools/pdbgen/Makefile.am: changed accordingly
      
      	* app/[almost every file]: include cleanup
      dfa2bed5
  6. 09 Apr, 1999 1 commit
    • jaycox's avatar
      build color_cmds, lut_funcs, and pixel_processor feedback in the splash · dde36031
      jaycox authored
      
      	* app/Makefile.am: build color_cmds, lut_funcs, and pixel_processor
      	* app/app_procs.c: feedback in the splash screen when loading
       	parasites.
      	* app/boundary.c: Optimized find_empty_segs.
      
      	* app/brightness_contrast.[ch]
      	* app/levels.[ch]
      	* app/posterize.[ch]:
       	moved pdb and lut calculation code.  These files now contain only
      	GUI functions.
      
      	* app/channel.c: Optimized channel_bounds (fewer compares, better
       	use of registers).  Use color_region instead of channel_*_segment
       	in channel_combine_rect.  Optimized channel_combine_ellipse by
       	skipping pixels inside of the ellipse.  Use
       	pixel_region_process_parallel in channel_combine_mask.  Use a
       	GimpLut in channel_invert, and channel_sharpen.
      
      	* app/invert.c
      	* app/equalize.c: moved the lut functions to lut_funcs.c
      
      	* app/gimpdrawable.c, app/gimpdrawableP.h
      	* app/gimpimage.c, app/gimpimageP.h: removed unused gimpmatrix
      	variables/includes.
      
      	* app/gimplut.[ch]: added new function gimp_lut_process_inline
       	that operates on a single PixelRegion.
      
      	* app/gimpparasite.[ch]: new functions to save/load parasiterc
      
      	* app/parasitelist.[ch]: new functions to save/load ParasiteLists
       	in/from files.
      
      	* libgimp/parasite.[ch]: new functions to load/save parasites.
      
      	* app/internal_procs.c: get some procs from new location in
      	color_cmds.h.
      
      	* app/pixel_region.[ch]: moved pixel_regions_process_parallel
       	related functions to a new file.
      
      	* app/color_cmds.[ch]: new files for PDB
       	definitions/implementations of color correction functions.
      
      	* app/lut_funcs.[ch]: new files to hold lut creation functions.
      
      	* app/pixel_processor.[ch]: new files that contain the
       	pixel_regions_process_parallel routines.  Added some new
       	capabilities that are currently unused.
      dde36031
  7. 16 Feb, 1999 1 commit
    • jaycox's avatar
      new source files that implement pixel Look Up Table functions. · a26f8d3f
      jaycox authored
      
      	* app/gimplut.[ch]: new source files that implement pixel Look Up
       	Table functions.
      
      	* app/Makefile.am: build gimplut.[ch]
      
      
      	* app/brightness_contrast.c
      	* app/curves.c
      	* app/invert.c
      	* app/levels.c
      	* app/posterize.c: Use the new lut functions.  Use
       	pixel_region_process_parallel in the PDB versions of these routines.
      
      	* libgimp/parasite.h
      	* libgimp/parasite.c: new functions parasite_name and
       	parasite_compare.
      
      	* app/gimpdrawable.c:
      	* app/gimpdrawable.h: new function
       	gimp_drawable_get_color_at(...) returns the RGBA[color index]
       	value at a specified position in the drawable.  Don't set the dirty
       	bit on the image if a new parasite is the same as the old.
      
      	* app/gimpimage.c
      	* app/gimpimage.h new function
       	gimp_image_get_color_at(...) returns the RGBA[color index]
       	value at a specified position in the drawable.  Don't set the dirty
       	bit on the image if a new parasite is the same as the old.
      
      	* app/by_color_select.c
      	* app/color_picker.c: use the new gimp_*_get_color_at
       	functions instead of messing with the tiles.
      
      	* app/layer.c: fixed a minor warning.
      
      	* app/commands.c:
      	don't scale the image if the new size == the old size
      
      	* app/channel.c: optimized channel_bounds by only checking the
       	pixels in a tile if it is not already entirely within the
       	currently computed bounds.
      a26f8d3f