Commit c0fed5af authored by Jehan's avatar Jehan
Browse files

desktop: check that no remaining TODOs are in appdata file.

Before each release, we prepare now a <release> tag. Unfortunately some
details are not always well known for sure in advance, in particular the
date of release (plans are made to be broken!), and also the release
news URL (since the date is in the URL). So I usually leave them as TODO
and until now, I never forgot to update them just before release. But
there is always the risk of forgetting.
Now the test for the appdata files will also look for remaining "TODO"
in the file if and only if the micro version is even (which means it's a
release). So we won't ever forget to update the file as long as we run
`make check` on the last commit (which we always do obviously).
parent f83271a3
......@@ -2933,6 +2933,7 @@ desktop/Makefile
desktop/gimp-data-extras.metainfo.xml.in
desktop/gimp.desktop.in
desktop/org.gimp.GIMP.appdata.xml.in
desktop/test-appdata.sh
etc/Makefile
etc/gimprc
m4macros/Makefile
......
......@@ -46,7 +46,7 @@ endif
EXTRA_DIST = \
$(appstream_in_files) \
test-appdata.sh \
test-appdata.sh.in \
test-desktop.sh \
gimp.desktop.in.in \
16x16/gimp.png \
......@@ -75,7 +75,9 @@ validate: gimp.desktop
dist-hook: validate
TESTS_ENVIRONMENT = GIMP_TESTING_ABS_TOP_BUILDDIR=@abs_top_builddir@
TESTS_ENVIRONMENT = \
chmod +x test-appdata.sh; \
GIMP_TESTING_ABS_TOP_BUILDDIR=@abs_top_builddir@
TESTS =
if HAVE_APPSTREAM_UTIL
......
......@@ -3,4 +3,13 @@
# TODO: use validate-strict when the last errors for a strict validation
# are fixed.
appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/org.gimp.GIMP.appdata.xml && \
appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/gimp-data-extras.metainfo.xml
appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/gimp-data-extras.metainfo.xml && \
if [ $(expr @GIMP_MICRO_VERSION@ % 2) = 0 ]; then
grep TODO ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/org.gimp.GIMP.appdata.xml
if [ $? = 0 ]; then
echo "ERROR: stable version with remaining TODOs in appdata."
false
fi
else
true
fi
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment