Skip to content
GitLab
Commit 8712a72d authored by Adam D. Moss's avatar Adam D. Moss
Browse files

Worked around some buggy PSD savers (suspect PS4 on Mac) - ugh. + Fixed a 


	* plug-ins/psd/psd.c: Worked around some buggy PSD savers
	(suspect PS4 on Mac) - ugh.  + Fixed a bug when loading layer
	masks of certain dimensions.
parent fb8fdecc
Hide whitespace changes
Inline Side-by-side
ChangeLog
View file @ 8712a72d
Fri Jul 31 13:42:29 BST 1998 Adam D. Moss <adam@gimp.org>
* plug-ins/psd/psd.c: Worked around some buggy PSD savers
(suspect PS4 on Mac) - ugh. + Fixed a bug when loading layer
masks of certain dimensions.
Tue Jul 28 18:10:33 1998 Scott Goehring <scott@poverty.bloomington.in.us>
* tile_manager.c, tile_manager.h: provided some encapsulations
......
plug-ins/common/psd.c
View file @ 8712a72d
/*
* PSD Plugin version 1.9.9.9b (BETA)
* PSD Plugin version 1.9.9.9e (BETA)
* This GIMP plug-in is designed to load Adobe Photoshop(tm) files (.PSD)
*
* Adam D. Moss <adam@gimp.org> <adam@foxbox.org>
......@@ -36,6 +36,10 @@
/*
* Revision history:
*
* 98.07.31 / v1.9.9.9e / Adam D. Moss
* Worked around some buggy PSD savers (suspect PS4 on Mac) - ugh.
* Fixed a bug when loading layer masks of certain dimensions.
*
* 98.05.04 / v1.9.9.9b / Adam D. Moss
* Changed the Pascal-style string-reading stuff. That fixed
* some file-padding problems. Made all debugging output
......@@ -282,10 +286,11 @@ static glong getglong(FILE *fd, gchar *why);
static void xfread(FILE *fd, void *buf, long len, gchar *why);
static void xfread_interlaced(FILE *fd, guchar *buf, long len, gchar *why,
gint step);
static void *xmalloc(size_t n);
static void* xmalloc(size_t n);
static void read_whole_file(FILE *fd);
static void reshuffle_cmap(guchar *map256);
static guchar *getpascalstring(FILE *fd, gchar *why);
static guchar* getpascalstring(FILE *fd, gchar *why);
static gchar* getstring(size_t n, FILE * fd, gchar *why);
void throwchunk(size_t n, FILE * fd, gchar *why);
void dumpchunk(size_t n, FILE * fd, gchar *why);
......@@ -518,17 +523,41 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
{
do
{
psd_image.aux_channel[psd_image.num_aux_channels].name =
getpascalstring(fd, "alpha channel name");
guchar slen;
gchar* sname;
slen = getguchar (fd, "alpha channel name length");
(*offset)++;
remaining--;
/* Check for (Mac?) Photoshop (4?) file-writing bug */
if (slen > remaining)
{
IFDBG {printf("\nYay, a file bug. "
"Nice one Adobe(tm). "
"I'll work around you.\n");fflush(stdout);}
break;
}
if (slen)
{
sname = getstring(slen, fd, "alpha channel name");
psd_image.aux_channel[psd_image.num_aux_channels].name =
sname;
}
else
{
psd_image.aux_channel[psd_image.num_aux_channels].name =
NULL;
}
if (psd_image.aux_channel[psd_image.num_aux_channels].name
== NULL)
{
IFDBG printf("\t\t\tNull channel name %d.\n",
psd_image.num_aux_channels);
fflush(stdout);
IFDBG
{printf("\t\t\tNull channel name %d.\n",
psd_image.num_aux_channels);fflush(stdout);}
}
if (psd_image.aux_channel[psd_image.num_aux_channels].name)
......@@ -549,7 +578,8 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
if (psd_image.num_aux_channels > MAX_CHANNELS)
{
printf("\nPSD: Sorry - this image has too many aux channels. Tell Adam!\n");
printf("\nPSD: Sorry - this image has too many "
"aux channels. Tell Adam!\n");
gimp_quit();
}
}
......@@ -557,7 +587,11 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
}
if (remaining)
throwchunk(remaining, fd, "alphaname padding 0 throw");
{
dumpchunk(remaining, fd, "alphaname padding 0 throw");
(*offset) += remaining;
remaining = 0;
}
}
break;
case 0x03ef:
......@@ -912,8 +946,6 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
for (layeri=0; layeri<psd_image.num_layers; layeri++)
{
tmpline = xmalloc(psd_image.layer[layeri].width + 1);
for (channeli=0;
channeli<psd_image.layer[layeri].num_channels;
channeli++)
......@@ -931,19 +963,24 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
height = psd_image.layer[layeri].height;
}
tmpline = xmalloc(width + 1);
compression = getgshort(fd, "layer channel compression type");
(*offset)+=2;
IFDBG
printf("\t\t\tLayer (%d) Channel (%d:%d) Compression: %d (%s)\n",
layeri,
channeli,
psd_image.layer[layeri].channel[channeli].type,
compression,
compression==0?"raw":(compression==1?"RLE":"UNKNOWN!"));
IFDBG printf("\t\t\t\tLoading channel data (%d bytes)...\n",
width*height);
{
printf("\t\t\tLayer (%d) Channel (%d:%d) Compression: %d (%s)\n",
layeri,
channeli,
psd_image.layer[layeri].channel[channeli].type,
compression,
compression==0?"raw":(compression==1?"RLE":"UNKNOWN!"));
fflush(stdout);
}
IFDBG {printf("\t\t\t\tLoading channel data (%d bytes)...\n",
width*height);fflush(stdout);}
psd_image.layer[layeri].channel[channeli].data =
xmalloc (width * height);
......@@ -985,12 +1022,15 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
/* we throw this away because in theory we can trust the
data to unpack to the right length... hmm... */
throwchunk(height * 2,
dumpchunk(height * 2,
fd, "widthlist");
(*offset) += height * 2;
blockread = (*offset);
IFDBG {printf("\nHere comes the guitar solo...\n");
fflush(stdout);}
for (linei=0;
linei<height;
linei++)
......@@ -998,7 +1038,7 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
/*printf(" %d ", *offset);*/
unpack_pb_channel(fd, tmpline,
width
/*(width&1)*/,
/*+ (width&1)*/,
offset);
memcpy((psd_image.layer[layeri].channel[channeli].data+
linei * width),
......@@ -1006,18 +1046,22 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
width);
}
IFDBG printf("\t\t\t\t\tActual compressed size was %d bytes\n",
(*offset)-blockread);
IFDBG {printf("\t\t\t\t\tActual compressed size was %d bytes\n"
, (*offset)-blockread);fflush(stdout);}
}
break;
default: /* *unknown* */
IFDBG {printf("\nEEP!\n");fflush(stdout);}
g_message ("*** Unknown compression type in channel.\n");
gimp_quit();
break;
}
}
g_free(tmpline);
if (tmpline)
g_free(tmpline);
else
IFDBG {printf("\nTRIED TO FREE NULL!");fflush(stdout);}
}
}
/* printf("\n[[%ld]]\n", getglong(fd, "uhhhh"));
......@@ -1060,6 +1104,7 @@ do_layer_and_mask(FILE *fd)
do_layers(fd, &offset);
IFDBG {printf("And...?\n");fflush(stdout);}
if (offset < Size)
{
......@@ -2209,17 +2254,17 @@ throwchunk(size_t n, FILE * fd, gchar *why)
}
#if 0
static guchar *
getchunk(size_t n, FILE * fd, gchar *why)
static gchar *
getstring(size_t n, FILE * fd, gchar *why)
{
guchar *tmpchunk;
gchar *tmpchunk;
tmpchunk = xmalloc(n);
tmpchunk = xmalloc(n+1);
xfread(fd, tmpchunk, n, why);
tmpchunk[n]=0;
return(tmpchunk); /* caller should free memory */
}
#endif
static guchar *
......@@ -2232,7 +2277,6 @@ getpascalstring(FILE *fd, gchar *why)
if (len==0)
{
// xfread(fd, &len, 1, why); /* Throw away a byte? */
return (NULL);
}
......@@ -2336,21 +2380,23 @@ xfread_interlaced(FILE* fd, guchar* buf, long len, gchar *why, gint step)
static void *
xmalloc(size_t n)
{
void *p;
if (n == 0)
{
void *p;
if (n == 0)
{
IFDBG
printf("PSD: WARNING: %s: xmalloc asked for zero-sized chunk\n",
prog_name);
return (NULL);
}
if ((p = g_malloc(n)) != NULL)
return p;
printf("%s: out of memory\n", prog_name);
gimp_quit();
return NULL;
return (NULL);
}
if ((p = g_malloc(n)) != NULL)
return p;
printf("%s: out of memory\n", prog_name);
gimp_quit();
return NULL;
}
......
plug-ins/psd/psd.c
View file @ 8712a72d
/*
* PSD Plugin version 1.9.9.9b (BETA)
* PSD Plugin version 1.9.9.9e (BETA)
* This GIMP plug-in is designed to load Adobe Photoshop(tm) files (.PSD)
*
* Adam D. Moss <adam@gimp.org> <adam@foxbox.org>
......@@ -36,6 +36,10 @@
/*
* Revision history:
*
* 98.07.31 / v1.9.9.9e / Adam D. Moss
* Worked around some buggy PSD savers (suspect PS4 on Mac) - ugh.
* Fixed a bug when loading layer masks of certain dimensions.
*
* 98.05.04 / v1.9.9.9b / Adam D. Moss
* Changed the Pascal-style string-reading stuff. That fixed
* some file-padding problems. Made all debugging output
......@@ -282,10 +286,11 @@ static glong getglong(FILE *fd, gchar *why);
static void xfread(FILE *fd, void *buf, long len, gchar *why);
static void xfread_interlaced(FILE *fd, guchar *buf, long len, gchar *why,
gint step);
static void *xmalloc(size_t n);
static void* xmalloc(size_t n);
static void read_whole_file(FILE *fd);
static void reshuffle_cmap(guchar *map256);
static guchar *getpascalstring(FILE *fd, gchar *why);
static guchar* getpascalstring(FILE *fd, gchar *why);
static gchar* getstring(size_t n, FILE * fd, gchar *why);
void throwchunk(size_t n, FILE * fd, gchar *why);
void dumpchunk(size_t n, FILE * fd, gchar *why);
......@@ -518,17 +523,41 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
{
do
{
psd_image.aux_channel[psd_image.num_aux_channels].name =
getpascalstring(fd, "alpha channel name");
guchar slen;
gchar* sname;
slen = getguchar (fd, "alpha channel name length");
(*offset)++;
remaining--;
/* Check for (Mac?) Photoshop (4?) file-writing bug */
if (slen > remaining)
{
IFDBG {printf("\nYay, a file bug. "
"Nice one Adobe(tm). "
"I'll work around you.\n");fflush(stdout);}
break;
}
if (slen)
{
sname = getstring(slen, fd, "alpha channel name");
psd_image.aux_channel[psd_image.num_aux_channels].name =
sname;
}
else
{
psd_image.aux_channel[psd_image.num_aux_channels].name =
NULL;
}
if (psd_image.aux_channel[psd_image.num_aux_channels].name
== NULL)
{
IFDBG printf("\t\t\tNull channel name %d.\n",
psd_image.num_aux_channels);
fflush(stdout);
IFDBG
{printf("\t\t\tNull channel name %d.\n",
psd_image.num_aux_channels);fflush(stdout);}
}
if (psd_image.aux_channel[psd_image.num_aux_channels].name)
......@@ -549,7 +578,8 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
if (psd_image.num_aux_channels > MAX_CHANNELS)
{
printf("\nPSD: Sorry - this image has too many aux channels. Tell Adam!\n");
printf("\nPSD: Sorry - this image has too many "
"aux channels. Tell Adam!\n");
gimp_quit();
}
}
......@@ -557,7 +587,11 @@ dispatch_resID(guint ID, FILE *fd, guint32 *offset, guint32 Size)
}
if (remaining)
throwchunk(remaining, fd, "alphaname padding 0 throw");
{
dumpchunk(remaining, fd, "alphaname padding 0 throw");
(*offset) += remaining;
remaining = 0;
}
}
break;
case 0x03ef:
......@@ -912,8 +946,6 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
for (layeri=0; layeri<psd_image.num_layers; layeri++)
{
tmpline = xmalloc(psd_image.layer[layeri].width + 1);
for (channeli=0;
channeli<psd_image.layer[layeri].num_channels;
channeli++)
......@@ -931,19 +963,24 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
height = psd_image.layer[layeri].height;
}
tmpline = xmalloc(width + 1);
compression = getgshort(fd, "layer channel compression type");
(*offset)+=2;
IFDBG
printf("\t\t\tLayer (%d) Channel (%d:%d) Compression: %d (%s)\n",
layeri,
channeli,
psd_image.layer[layeri].channel[channeli].type,
compression,
compression==0?"raw":(compression==1?"RLE":"UNKNOWN!"));
IFDBG printf("\t\t\t\tLoading channel data (%d bytes)...\n",
width*height);
{
printf("\t\t\tLayer (%d) Channel (%d:%d) Compression: %d (%s)\n",
layeri,
channeli,
psd_image.layer[layeri].channel[channeli].type,
compression,
compression==0?"raw":(compression==1?"RLE":"UNKNOWN!"));
fflush(stdout);
}
IFDBG {printf("\t\t\t\tLoading channel data (%d bytes)...\n",
width*height);fflush(stdout);}
psd_image.layer[layeri].channel[channeli].data =
xmalloc (width * height);
......@@ -985,12 +1022,15 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
/* we throw this away because in theory we can trust the
data to unpack to the right length... hmm... */
throwchunk(height * 2,
dumpchunk(height * 2,
fd, "widthlist");
(*offset) += height * 2;
blockread = (*offset);
IFDBG {printf("\nHere comes the guitar solo...\n");
fflush(stdout);}
for (linei=0;
linei<height;
linei++)
......@@ -998,7 +1038,7 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
/*printf(" %d ", *offset);*/
unpack_pb_channel(fd, tmpline,
width
/*(width&1)*/,
/*+ (width&1)*/,
offset);
memcpy((psd_image.layer[layeri].channel[channeli].data+
linei * width),
......@@ -1006,18 +1046,22 @@ do_layer_pixeldata(FILE *fd, guint32 *offset)
width);
}
IFDBG printf("\t\t\t\t\tActual compressed size was %d bytes\n",
(*offset)-blockread);
IFDBG {printf("\t\t\t\t\tActual compressed size was %d bytes\n"
, (*offset)-blockread);fflush(stdout);}
}
break;
default: /* *unknown* */
IFDBG {printf("\nEEP!\n");fflush(stdout);}
g_message ("*** Unknown compression type in channel.\n");
gimp_quit();
break;
}
}
g_free(tmpline);
if (tmpline)
g_free(tmpline);
else
IFDBG {printf("\nTRIED TO FREE NULL!");fflush(stdout);}
}
}
/* printf("\n[[%ld]]\n", getglong(fd, "uhhhh"));
......@@ -1060,6 +1104,7 @@ do_layer_and_mask(FILE *fd)
do_layers(fd, &offset);
IFDBG {printf("And...?\n");fflush(stdout);}
if (offset < Size)
{
......@@ -2209,17 +2254,17 @@ throwchunk(size_t n, FILE * fd, gchar *why)
}
#if 0
static guchar *
getchunk(size_t n, FILE * fd, gchar *why)
static gchar *
getstring(size_t n, FILE * fd, gchar *why)
{
guchar *tmpchunk;
gchar *tmpchunk;
tmpchunk = xmalloc(n);
tmpchunk = xmalloc(n+1);
xfread(fd, tmpchunk, n, why);
tmpchunk[n]=0;
return(tmpchunk); /* caller should free memory */
}
#endif
static guchar *
......@@ -2232,7 +2277,6 @@ getpascalstring(FILE *fd, gchar *why)
if (len==0)
{
// xfread(fd, &len, 1, why); /* Throw away a byte? */
return (NULL);
}
......@@ -2336,21 +2380,23 @@ xfread_interlaced(FILE* fd, guchar* buf, long len, gchar *why, gint step)
static void *
xmalloc(size_t n)
{
void *p;
if (n == 0)
{
void *p;
if (n == 0)
{
IFDBG
printf("PSD: WARNING: %s: xmalloc asked for zero-sized chunk\n",
prog_name);
return (NULL);
}
if ((p = g_malloc(n)) != NULL)
return p;
printf("%s: out of memory\n", prog_name);
gimp_quit();
return NULL;
return (NULL);
}
if ((p = g_malloc(n)) != NULL)
return p;
printf("%s: out of memory\n", prog_name);
gimp_quit();
return NULL;
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment