Commit 73057f76 authored by Michael Natterer's avatar Michael Natterer 😴 Committed by Michael Natterer

gimp_display_idlerenderer_callback()). The assertion went off whenever we

2002-05-13  Michael Natterer  <mitch@gimp.org>

	* app/paint-funcs/paint-funcs.c commented out a warning in
	initial_sub_region and a g_error() in combine_sub_region which
	didn't expect to get chunks of pixels with a width of > 128
	passed. I guess it was an assertion to ensure the integrity of
	some higher level code (see gimpdisplay.c:
	gimp_display_idlerenderer_callback()).  The assertion went off
	whenever we wanted to render a preview with a width of > 128,
	which is however handled absolutely correctly by the two
	functions. (fixes #26072)

	* app/core/gimpcontext.c (gimp_context_get_by_type): unref objects
	before returning them. Fixes our biggest memleak (whole images).

	* app/display/gimpdisplay-handlers.c: commented out debugging
	g_print()s which track the image's refcount.
parent d8c4461c
2002-05-13 Michael Natterer <mitch@gimp.org>
* app/paint-funcs/paint-funcs.c commented out a warning in
initial_sub_region and a g_error() in combine_sub_region which
didn't expect to get chunks of pixels with a width of > 128
passed. I guess it was an assertion to ensure the integrity of
some higher level code (see gimpdisplay.c:
gimp_display_idlerenderer_callback()). The assertion went off
whenever we wanted to render a preview with a width of > 128,
which is however handled absolutely correctly by the two
functions. (fixes #26072)
* app/core/gimpcontext.c (gimp_context_get_by_type): unref objects
before returning them. Fixes our biggest memleak (whole images).
* app/display/gimpdisplay-handlers.c: commented out debugging
g_print()s which track the image's refcount.
2002-05-13 Sven Neumann <sven@gimp.org>
* libgimp/gimpmenu.c: use gimp_image_get_name().
......
......@@ -1249,6 +1249,12 @@ gimp_context_get_by_type (GimpContext *context,
gimp_context_prop_names[prop], &object,
NULL);
/* g_object_get() refs the object, this function however is a getter,
* which usually doesn't ref it's return value
*/
if (object)
g_object_unref (G_OBJECT (object));
return object;
}
......
......@@ -63,8 +63,10 @@ gimp_display_connect (GimpDisplay *gdisp,
gimage->instance_count++; /* this is obsolete */
gimage->disp_count++;
#if 0
g_print ("%s: gimage->ref_count before refing: %d\n",
G_GNUC_FUNCTION, G_OBJECT (gdisp->gimage)->ref_count);
#endif
g_object_ref (G_OBJECT (gimage));
......@@ -109,8 +111,10 @@ gimp_display_disconnect (GimpDisplay *gdisp)
gdisp->gimage->disp_count--;
#if 0
g_print ("%s: gimage->ref_count before unrefing: %d\n",
G_GNUC_FUNCTION, G_OBJECT (gdisp->gimage)->ref_count);
#endif
g_object_unref (G_OBJECT (gdisp->gimage));
gdisp->gimage = NULL;
......
......@@ -4203,8 +4203,10 @@ initial_sub_region (struct initial_regions_struct *st,
affect = st->affect;
type = st->type;
#if 0
if (src->w * (src->bytes + 1) > 512)
g_printerr ("initial_sub_region:: error :: src->w * (src->bytes + 1) > 512\n");
#endif
s = src->data;
d = dest->data;
......@@ -4370,8 +4372,10 @@ combine_sub_region (struct combine_regions_struct *st,
d = dest->data;
m = (mask) ? mask->data : NULL;
#if 0
if (src1->w > 128)
g_error("combine_sub_region::src1->w = %d\n", src1->w);
g_printerr ("combine_sub_region::src1->w = %d\n", src1->w);
#endif
if (transparency_quickskip_possible || opacity_quickskip_possible)
{
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment