Commit 5bf0e3c3 authored by Michael Natterer's avatar Michael Natterer 😴

app: fix initializing a rectangle select by clicking into a selection

Don't unconditionally call COMMIT in rectangle_response(), because
that now implicitly HALTs the tool. Instead, check if we got here
because of a click, and call our commit() directly.
parent 6992b433
......@@ -568,7 +568,25 @@ gimp_rectangle_select_tool_rectangle_response (GimpToolWidget *widget,
switch (response_id)
gimp_tool_control (tool, GIMP_TOOL_ACTION_COMMIT, tool->display);
gdouble x1, y1, x2, y2;
gimp_tool_rectangle_get_public_rect (GIMP_TOOL_RECTANGLE (widget),
&x1, &y1, &x2, &y2);
if (x1 == x2 && y1 == y2)
/* if there are no extents, we got here because of a
* click, call commit() directly because we might want to
* reconfigure the rectangle and continue, instead of
* HALTing it like calling COMMIT would do
gimp_rectangle_select_tool_commit (rect_tool);
gimp_tool_control (tool, GIMP_TOOL_ACTION_COMMIT, tool->display);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment