Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
GNOME
GIMP
Commits
40390882
Commit
40390882
authored
Jun 24, 2010
by
Michael Natterer
😴
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
app: add comment about why we can't use GimpContainerView API in init()
parent
3c565a17
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
0 deletions
+12
-0
app/widgets/gimpcontainerbox.c
app/widgets/gimpcontainerbox.c
+12
-0
No files found.
app/widgets/gimpcontainerbox.c
View file @
40390882
...
...
@@ -105,6 +105,18 @@ gimp_container_box_constructed (GObject *object)
{
GimpContainerBox
*
box
=
GIMP_CONTAINER_BOX
(
object
);
/* This is evil: the hash table of "insert_data" is created on
* demand when GimpContainerView API is used, using a
* value_free_func that is set in the interface_init functions of
* its implementors. Therefore, no GimpContainerView API must be
* called from any init() function, because the interface_init()
* function of a subclass that sets the right value_free_func might
* not have been called yet, leaving the insert_data hash table
* without memory management.
*
* Call GimpContainerView API from GObject::constructed() instead,
* which runs after everything is set up correctly.
*/
gimp_container_view_set_dnd_widget
(
GIMP_CONTAINER_VIEW
(
box
),
box
->
scrolled_win
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment