Commit 1f3bd288 authored by Michael Natterer's avatar Michael Natterer 😴 Committed by Michael Natterer
Browse files

removed the old hack which sets tool->gdisp. Fixes bug #98056.

2002-11-14  Michael Natterer  <mitch@gimp.org>

	* app/gui/tools-commands.c (tools_select_cmd_callback): removed
	the old hack which sets tool->gdisp. Fixes bug #98056.

	* app/tools/gimpimagemaptool.c (gimp_image_map_tool_initialize):
	set tool->gdisp here because the hack was there for tools which
	implement initialize() and show dialogs when selected from the
	menu. Also fixed wrong paramater to gimp_viewable_dialog_new().
parent fc8d6b59
2002-11-14 Michael Natterer <mitch@gimp.org>
* app/gui/tools-commands.c (tools_select_cmd_callback): removed
the old hack which sets tool->gdisp. Fixes bug #98056.
* app/tools/gimpimagemaptool.c (gimp_image_map_tool_initialize):
set tool->gdisp here because the hack was there for tools which
implement initialize() and show dialogs when selected from the
menu. Also fixed wrong paramater to gimp_viewable_dialog_new().
2002-11-12 Sven Neumann <sven@gimp.org>
 
* app/paint/gimppaintcore.c: check for NULL masks returned from
......
......@@ -107,11 +107,4 @@ tools_select_cmd_callback (GtkWidget *widget,
gdisp = gimp_context_get_display (context);
tool_manager_initialize_active (tool_info->gimp, gdisp);
/* setting active_tool->gdisp here is a HACK to allow the tools'
* dialog windows being hidden if the tool was selected from
* a tear-off-menu and there was no mouse click in the display
* before deleting it
*/
tool_manager_get_active (tool_info->gimp)->gdisp = gdisp;
}
......@@ -107,11 +107,4 @@ tools_select_cmd_callback (GtkWidget *widget,
gdisp = gimp_context_get_display (context);
tool_manager_initialize_active (tool_info->gimp, gdisp);
/* setting active_tool->gdisp here is a HACK to allow the tools'
* dialog windows being hidden if the tool was selected from
* a tear-off-menu and there was no mouse click in the display
* before deleting it
*/
tool_manager_get_active (tool_info->gimp)->gdisp = gdisp;
}
......@@ -186,6 +186,9 @@ gimp_image_map_tool_initialize (GimpTool *tool,
image_map_tool = GIMP_IMAGE_MAP_TOOL (tool);
/* set gdisp so the dialog can be hidden on display destruction */
tool->gdisp = gdisp;
if (! image_map_tool->shell)
{
GimpToolInfo *tool_info;
......@@ -205,7 +208,7 @@ gimp_image_map_tool_initialize (GimpTool *tool,
GIMP_STOCK_RESET,
gimp_image_map_tool_reset_clicked,
image_map_tool, NULL, NULL, TRUE, FALSE,
image_map_tool, NULL, NULL, FALSE, FALSE,
GTK_STOCK_CANCEL,
gimp_image_map_tool_cancel_clicked,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment