ChangeLog 168 KB
Newer Older
1 2 3 4 5
2005-03-30  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpvectortool.c (gimp_vector_tool_status_update):
	set a different help message in polygonal mode. Fixes bug #172051.

6 7
2005-03-30  Sven Neumann  <sven@gimp.org>

Sven Neumann's avatar
Sven Neumann committed
8 9
	* app/widgets/gimpclipboard.c: when GIMP exits and a clipboard
	manager is available, store the clipboard content.
10

11 12 13 14 15
2005-03-28  Sven Neumann  <sven@gimp.org>

	* app/dialogs/resize-dialog.c (resize_dialog_new): handle
	gimp_viewable_get_pixbuf() returning NULL. Fixes bug #171827.

16 17 18 19 20 21 22 23 24 25 26
2005-03-26  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/script-fu-scripts.c (script_fu_find_scripts):
	removed menu branch registering here (this function is called on
	each refresh).

	* plug-ins/script-fu/script-fu.c (script_fu_extension_init):
	renamed from script_fu_auxillary_init(), this function is only
	called once when the extension starts up. Register the menu
	branches here.

27 28 29 30 31
2005-03-26  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_colorblind.c (lut_lookup): actually do a binary
	search, not a linear search starting in the middle.

32 33 34 35 36 37
2005-03-26  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-close.c
	(gimp_display_shell_close_dialog): added an icon to the "Don't Save"
	button.

38 39 40 41 42 43
2005-03-26  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpdnd.c: don't add the same target multiple times.
	This used to happen when  gimp_dnd_foo_source_add() is called
	after calling gimp_dnd_drag_source_set_by_type().

44 45 46 47 48
2005-03-26  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpdrawablecombobox.c
	* libgimp/gimpimagecombobox.c: accept DND of image / drawable IDs.

49 50 51 52 53
2005-03-26  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimptoolbox-image-area.c: added a hint about XDS to
	the tooltip, but only if compiled for X11.

54 55 56 57 58 59
2005-03-26  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_colorblind.c: use the same LUT for all color
	channels. Do a binary search in the LUT for the backward
	transformation.

60 61 62 63 64 65 66
2005-03-26  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_colorblind.c: applied a modified version of
	a patch by Gautier Portet that introduces a LUT for the gamma
	correction (bug #101256). Also moved constants out of the
	CdisplayColorblind struct.

67 68 69 70 71
2005-03-26  Sven Neumann  <sven@gimp.org>

	* modules/cdisplay_lcms.c: disconnect from the config in dispose
	instead of in finalize.

72 73 74 75
2005-03-25  Sven Neumann  <sven@gimp.org>

	* plug-ins/bmp/bmpread.c: better error message (bug #171646).

76 77 78
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpdockable.c (gimp_dockable_add): initialize the
Sven Neumann's avatar
Sven Neumann committed
79
	tab style to a supported one. Fixes bug #171567.
80

81 82 83 84 85
2005-03-25  Sven Neumann  <sven@gimp.org>

	* plug-ins/bmp/bmpread.c: applied patch from David Costanzo that
	initializes unspecified pixels in RLE bitmaps. Fixes bug #171562.

86 87 88 89 90 91 92 93 94 95
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-save-dialog.c
	* app/widgets/gimpfiledialog.[ch]: moved overwrite confirmation
	dialog to app/widgets.

	* app/widgets/gimpdnd-xds.c: set "Untitled.xcf" as default name
	for untitled images; ask for confirmation before overwriting a
	local file.

96 97 98 99 100 101
2005-03-25  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/emboss.c: fix usage of RGBA data,
	change to premultiplied alpha for embossing, hopefully
	fixes bug #72864.

Sven Neumann's avatar
Sven Neumann committed
102 103 104 105 106 107 108 109 110 111
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/core/gimpmarshal.list: added VOID: OBJECT, OBJECT.

	* app/widgets/gimpview.[ch]: pass old and new viewable in the
	"set-viewable" signal.

	* app/widgets/gimptoolbox-image-area.c: don't add the XDS drag source
	more than once.

112 113 114 115 116
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpdnd-xds.c (gimp_dnd_xds_save_image): in case of
	an error, answer with E (error) instead of F (failure).

117 118 119 120 121 122 123 124 125 126 127
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpview.[ch]: virtualized GimpView::set_viewable.

	* app/widgets/gimptoolbox-image-area.c: hook into "set_viewable"
	and add an XDS drag source.

	* app/widgets/gimpdnd-xds.c
	* app/widgets/gimpdnd.c: unset the XdndDirectSave0 property when
	the drag ends, minor cleanups.

128 129
	* app/widgets/gimpimageview.c: removed unused function prototype.

130 131 132 133 134 135 136 137 138 139 140 141
2005-03-25  Sven Neumann  <sven@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/gimpdnd-xds.[ch]: new files.

	* app/widgets/gimpdnd.[ch]
	* app/widgets/widgets-enums.h: added a basic XDS (Direct Save
	Protocol) implementation.

	* app/widgets/gimpimageview.c: allow to save images by dragging
	them from the Images dialog to an XDS capable file manager.

142 143 144 145 146
2005-03-25  Kevin Cozens  <kcozens@cvs.gimp.org>

	* plug-ins/common/displace.c: Fixed off-by-one error in check for
	number of passed parameters.

147 148 149 150 151 152 153 154 155 156 157
2005-03-25  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppropwidgets.[ch]: added
	gimp_prop_file_chooser_button_new(), a convenience constructor for
	GtkFileChooserButton.

	* libgimpwidgets/gimpwidgets.def: updated.

	* app/dialogs/preferences-dialog.c: use the new prop widget on the
	color management page.

158 159 160 161 162 163 164
2005-03-24  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* configure.in
	* plug-ins/common/screenshot.c: allow option of screenshot
	without decorations if libXmu is present (fixes bug #133626),
	clean up code a bit.

165 166 167 168 169 170 171 172 173 174 175 176 177 178 179
2005-03-24  Michael Natterer  <mitch@gimp.org>

	* app/core/core-enums.[ch]
	* app/core/gimpimage-undo-push.[ch]
	* app/core/gimplayermask.[ch]: eek, my fault... removed
	GIMP_UNDO_LAYER_MASK_EDIT stuff again because that just determines
	the active drawable, which must not affect undo.

	* app/pdb/pdb_glue.h
	* app/actions/layers-commands.c (layers_mask_edit_cmd_callback):
	changed accordingly.

	(layers_mask_disable_cmd_callback): reverted last change. the old
	code was correct.

180 181 182 183 184 185 186 187 188 189 190 191 192
2005-03-24  Michael Natterer  <mitch@gimp.org>

	* app/core/core-enums.[ch] (enum GimpUndoType) : reordered values
	so layer and layer mask undos are grouped together.

	* app/core/gimpimage-undo-push.[ch]: same here. Changed the new
	layer mask undos to have 3 simple push functions for the 3
	properties, just as the layer property undos. Also made the code
	look like the layer properties undo stuff.

	* app/core/gimplayermask.c (gimp_layer_mask_set_apply,edit,show):
	changed accordingly.

193 194 195 196 197 198 199
2005-03-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/bmp/bmp.h (Bitmap_Head_Struct)
	* plug-ins/bmp/bmpread.c: use a signed long for width and height
	and check that width is > 0 (negative height is allowed and
	handled by our code). Fixes bug #171453.

200 201 202 203 204
2005-03-24  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage-undo-push.[ch]
	* app/core/gimplayermask.c: fix compile warnings. 

205 206 207
2005-03-24  Sven Neumann  <sven@gimp.org>

	* app/display/gimpstatusbar.c (gimp_statusbar_push_coords) 
Sven Neumann's avatar
Sven Neumann committed
208
	(gimp_statusbar_set_cursor): use RINT() instead of ROUND() to get
209 210
	proper rounding of negative values. Fixes bug #171497.

211 212 213 214 215 216 217 218 219
2005-03-24  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/core-enums.[ch]
	* app/core/gimpimage-undo-push.[ch]
	* app/core/gimplayermask.[ch]: 
	* app/pdb/pdb_glue.h
	* app/actions/layers-commands.c: try again from clean tree;
	hopefully will work this time.  (bug #148852)
	
220 221 222 223 224 225
2005-03-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/*.scm: don't mark menu branches for
	translation; the translatable branch name is registered by the
	Script-Fu extension.

226 227 228 229 230 231 232 233 234
2005-03-24  Michael Natterer  <mitch@gimp.org>

	Added API to explicitly register dynamic menu items hierarchies.
	Fixes bug #170623.

	* app/core/gimp.h: added "GSList *plug_in_menu_branches".

	* app/plug-in/plug-in-types.h
	* app/plug-in/plug-ins.[ch]: added API to register plug-in menu
235
	branches, just as for locale and help domains. Cleaned up handling
236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275
	of locale and help domains.

	(plug_ins_exit): free the registered menu branches.

	* app/actions/plug-in-actions.[ch] (plug_in_actions_add_branch):
	new function to explicitly add a menu branch action.

	(plug_in_actions_setup): add the registered menu branches to each
	new action group.

	(plug_in_actions_build_path): always strip the untranslated menu
	path from underlines before using it as hash table key or action
	name.

	* app/menus/plug-in-menus.c (plug_in_menus_add_proc): changed
	accordingly: strip underlines from untranslated menu paths before
	passing them to plug_in_menus_build_path().

	* app/core/gimp-gui.[ch]: added gimp_menus_create_branch() plus
	vtable entry to access the new stuff from the core. Renamed the
	functions desling with items from gimp_foo_entry() to
	gimp_foo_item().

	* app/gui/gui-vtable.c: implement create_branch() and add the
	branch action to all existing "plug-in" action groups. Note that
	we don't need to create any menus because that happens implicitly
	when adding menu items.

	* tools/pdbgen/pdb/plug_in.pdb (plugin_menu_branch_register): new
	PDB wrapper to access branch registering from plug-ins.

	* app/pdb/internal_procs.c
	* app/pdb/plug_in_cmds.c
	* libgimp/gimpplugin_pdb.[ch]: regenerated.

	* libgimp/gimp.def: changed accordingly.

	* plug-ins/script-fu/script-fu-scripts.c (script_fu_find_scripts):
	register the menu branches for all included scripts.

Sven Neumann's avatar
Sven Neumann committed
276 277 278 279
2005-03-24  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcolormapeditor.c: use a GimpColorHexEntry widget.

280 281 282 283 284 285
2005-03-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/bmp/bmpread.c: applied a patch from David Costanzo that
	fixes handling of odd-length pixel encodings in "absolute mode" of
	RLE4 compressed data (bug #171306).

Sven Neumann's avatar
Sven Neumann committed
286 287 288 289 290 291 292 293
2005-03-24  Sven Neumann  <sven@gimp.org>

	Merged from gimp-2-2 branch:

	* app/widgets/gimphistogrameditor.c: change to the Value channel
	if the current channel becomes invalid due to an image mode change.
	Fixes bug #170116.

294 295 296 297 298 299 300
2005-03-24  Sven Neumann  <sven@gimp.org>

	* app/actions/layers-commands.c
	* app/core/core-enums.[ch]
	* app/core/gimpimage-undo-push.[ch]
	* app/pdb/pdb_glue.h: reverted Bill's changes to fix the build.

301 302 303 304 305 306 307 308 309
2005-03-23  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/core-enums.[ch]
	* app/core/gimpimage-undo-push.[ch]
	* app/pdb/pdb_glue.h
	* app/actions/layers-commands.c: make layer mask property changes
	undoable, should fix bug #148852.  Note that a little shape-layer
	stuff is in core-enums, will be needed shortly.
	
310 311 312 313 314 315
2005-03-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/screenshot.c: seperated platform specific code into
	individual functions; should make it easier to contribute the missing
	platform specific code ...

316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
2005-03-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/alien-glow-logo.scm
	* plug-ins/script-fu/scripts/alien-neon-logo.scm
	* plug-ins/script-fu/scripts/basic1-logo.scm
	* plug-ins/script-fu/scripts/basic2-logo.scm
	* plug-ins/script-fu/scripts/blended-logo.scm
	* plug-ins/script-fu/scripts/bovinated-logo.scm
	* plug-ins/script-fu/scripts/chalk.scm
	* plug-ins/script-fu/scripts/chip-away.scm
	* plug-ins/script-fu/scripts/chrome-logo.scm
	* plug-ins/script-fu/scripts/comic-logo.scm
	* plug-ins/script-fu/scripts/coolmetal-logo.scm
	* plug-ins/script-fu/scripts/frosty-logo.scm
	* plug-ins/script-fu/scripts/glossy.scm
	* plug-ins/script-fu/scripts/gradient-bevel-logo.scm
	* plug-ins/script-fu/scripts/neon-logo.scm
	* plug-ins/script-fu/scripts/starburst-logo.scm
	* plug-ins/script-fu/scripts/starscape-logo.scm
	* plug-ins/script-fu/scripts/t-o-p-logo.scm
	* plug-ins/script-fu/scripts/textured-logo.scm: no need to set the
	text as name of the text layer. The text layer is created with that
	name already.

340 341 342 343 344
2005-03-24  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpmessagebox.h
	* libgimpconfig/gimpconfigwriter.h: added G_GNUC_PRINTF attributes.

345 346 347 348 349
2005-03-23  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/screenshot.c: add ability to define region
	by pointer-dragging.  UI may need tweaking.

350 351 352 353 354
2005-03-23  Sven Neumann  <sven@gimp.org>

	* app/display/gimpcanvas.[ch] (gimp_canvas_draw_text): fixed
	gtk-doc comments; added G_GNUC_PRINTF attribute.

355 356 357 358 359 360 361
2005-03-23  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpselectiondata.c (gimp_selection_data_get_image)
	(gimp_selection_data_get_component)
	(gimp_selection_data_get_item): same fix as below for ID-based DND
	types.

362 363 364 365 366 367 368 369 370 371 372 373
2005-03-23  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpbrushmenu.c
	* libgimp/gimpfontmenu.c
	* libgimp/gimpgradientmenu.c
	* libgimp/gimppalettemenu.c
	* libgimp/gimppatternmenu.c: accept names passed over DND no matter
	whether they are NULL-terminated or not.

	* app/widgets/gimpselectiondata.c: same change here, also
	UTF8-validate the selection data before accepting it.

374 375 376 377 378 379 380 381 382
2005-03-23  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpbrushmenu.c
	* libgimp/gimpfontmenu.c
	* libgimp/gimpgradientmenu.c
	* libgimp/gimppalettemenu.c
	* libgimp/gimppatternmenu.c: accept drops on selection widgets as
	requested in bug #10677.

383 384 385 386 387
2005-03-23  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpmenu.c: added gtk-doc comments explaining what
	functions to use instead of these deprecated ones.

388 389 390 391 392 393 394 395
2005-03-23  Sven Neumann  <sven@gimp.org>

	* app/base/tile-swap.c (tile_swap_init): create the swap directory
	if it doesn't exist. Will still fail if the parent directory is not
	available. Still good enough to close bug #167506.

	* app/app_procs.c: tweaked error message.

396 397 398
2005-03-22  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/colortoalpha.c: unset "Keep transparency", it is
399
	not what the user wants if this plug-in is being used (bug #151910).
400

401 402 403 404 405 406
2005-03-22  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/screenshot.c: removed global variables; added a
	short delay after destroying the dialog so that the root window
	gets redrawn; moved camera icon to the action button.

407 408 409 410 411
2005-03-22  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/screenshot.c: always derive image from root
	window, fixes bug #144788.
	
412 413 414 415 416 417 418
2005-03-22  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpactiongroup.c
	* app/widgets/gimpcolorpanel.c: use gtk_action_set_sensitive()
	and gtk_action_set_visible() instead of setting the respective
	properties.

419 420 421 422 423 424
2005-03-22  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* configure.in: raise required librsvg version to 2.8.0
	* plug-ins/common/svg.c: change deprecated librsvg api,
	fixes bug #147662.
	
425 426 427 428 429 430 431 432 433 434 435
2005-03-21  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/sparkle.c
	* plug-ins/common/spheredesigner.c
	* plug-ins/common/struc.c
	* plug-ins/common/tileit.c
	* plug-ins/common/warp.c
	* plug-ins/common/whirlpinch.c
	* plug-ins/common/wind.c: handle situation where intersection
	of selection and drawable is empty; progress on bug #155733.

436 437 438 439 440 441 442 443
2005-03-21  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/gimptransformtool.c
	* app/tools/gimpfliptool.c
	* app/core/gimpdrawabletransform.c: avoid messages and critical
	error when transforming a drawable that does not intersect
	the selection.  

444 445 446 447 448 449
2005-03-21  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpink.c: changed time-smoother code to use guint32
	time values externally, guint64 internally. Proper fix for bug
	#164272.

450 451 452
2005-03-21  Sven Neumann  <sven@gimp.org>

	* app/actions/dialogs-actions.h: bail out if
Sven Neumann's avatar
typo  
Sven Neumann committed
453
	widgets/gimpactiongroup.h has not been included beforehand.
454

Sven Neumann's avatar
typo  
Sven Neumann committed
455
	* app/actions/actions.c: include widgets/gimpactiongroup.h. Fixes
456 457
	build with amd64/gcc-4.0 (Debian bug report #300227).

458 459 460 461 462
2005-03-21  Sven Neumann  <sven@gimp.org>

	* etc/controllerrc: fixed defaults for mouse wheel controller (bug
	#171083, fix spotted by Michael Schumacher).

463 464 465 466 467 468
2005-03-21  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_constructor): disable search for tree
	views so that treeview typeahead doesn't collide with global
	accelerators. Fixes bug #169339 and would suck less if bug #170435
469
	was fixed.
470

471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
2005-03-21  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-utils.[ch]: changed all transform
	utilities to modify the passed transform matrix instead of
	creating a new one.

	* app/text/gimptextlayer-transform.c
	* app/tools/gimpperspectivetool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimpscaletool.c
	* app/tools/gimpsheartool.c
	* app/vectors/gimpvectors.c
	* tools/pdbgen/pdb/drawable_transform.pdb
	* tools/pdbgen/pdb/transform_tools.pdb: changed accordingly.

	* app/pdb/drawable_transform_cmds.c
	* app/pdb/transform_tools_cmds.c: regenerated.

489 490 491 492 493
2005-03-21  Sven Neumann  <sven@gimp.org>

	* plug-ins/winicon/icosave.c (ico_create_palette): fixed parameter
	check, NULL is valid for an empty palette. Fixes bug #170812.

494 495 496 497 498 499 500 501
2005-03-21  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-convert.c (gimp_image_convert): added missing
	period in newly added message.

	* app/dialogs/convert-dialog.c (convert_dialog_palette_filter): don't
	show empty palettes (bug #170973).

502 503 504 505 506 507
2005-03-21  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpmeasuretool.[ch]: added width and height to the
	info displayed in the statusbar and the info window.
	Fixes bug #165275.

508 509 510 511 512
2005-03-20  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* libgimpwidgets/gimpcolorscales.c (gimp_color_scales_update_scales):
	Block callback when updating hex entry, fixes bug #169882.
	
513 514 515 516 517 518
2005-03-20  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage-convert.c: check for non-empty palette
	before converting to indexed using custom palette, otherwise
	show warning and abort;	fixes bug #170973.

519 520 521 522 523 524
2005-03-20  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage-convert.c: applied patch from Adam
	Moss converning gray->indexed conversion,
	fixes bug #170825.

525 526 527 528 529 530
2005-03-20  Sven Neumann  <sven@gimp.org>

	* app/text/gimptext.[ch]
	* app/text/gimptextlayer-transform.[ch]: some infrastructure for
	text transforms.

Sven Neumann's avatar
Sven Neumann committed
531 532 533 534 535 536 537 538
2005-03-20  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-utils.c (gimp_transform_matrix_perspective):
	cosmetic changes.

	* libgimpmath/gimpmatrix.[ch]
	* libgimpmath/gimpmath.def: added gimp_matrix_is_affine().

539 540 541 542 543 544 545 546 547 548
2005-03-19  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-sample-points.c
	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell.c
	* app/tools/gimpcolortool.c: make sure sample points always have
	coordinates in the range [0..width/height-1], also added lots of
	+0.5 because they live at the pixels' centers, not at their
	borders. Fixed drawing of sample points at the display borders.

549 550 551 552 553 554 555 556 557 558 559 560 561
2005-03-19  Manish Singh  <yosh@gimp.org>

	* app/config/Makefile.am: actually link test program with
	libgimpconfig.

	* app/Makefile.am
	* libgimpwidgets/Makefile.am: reordered library link order to be
	consistent with shared library dependencies.

	* plug-ins/common/mkgen.pl: Cosmetic fix to the generated Makefile.am.

	* plug-ins/common/Makefile.am: regenerated.

Manish Singh's avatar
Manish Singh committed
562 563 564 565
2005-03-19  Manish Singh  <yosh@gimp.org>

	* gimp.spec.in: Remove outdated file.

566 567 568 569 570 571 572 573 574
2005-03-19  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-altivec.[ch]: More accelerated functions
	(screen, grain_merge, grain_extract, divide, dodge) from Frederic
	Leroy.

	* app/composite/gimp-composite-altivec-installer.c
	* app/composite/gimp-composite-altivec-test.c: regenerated.

575 576 577 578 579 580 581 582
2005-03-19  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-altivec.[ch]: More accelerated functions
	(multiply, blend) from Frederic Leroy.

	* app/composite/gimp-composite-altivec-installer.c
	* app/composite/gimp-composite-altivec-test.c: regenerated.

583 584 585 586 587 588
2005-03-18  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/fp.c: use callbacks to handle
	"size-allocate" for preview size changes, fixes 
	bug #160032.
	
589 590 591 592 593 594
2005-03-18  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage-convert.c:  when converting grayscale
	to mono, treat the palette as gray rather than rgb, giving
	more than tenfold speedup.  Fixes bug #170801.

595 596 597 598 599 600 601 602 603 604 605 606 607 608
2005-03-18  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainerview.c: make "preview-size" and
	"preview-border-width" construct properties. Fixes creation
	using g_object_new().

	* app/widgets/gimpcontainerentry.c
	* app/widgets/gimpcontainertreeview.c
	* app/widgets/gimplayertreeview.c (set_preview_size): handle
	unset model and/or view gracefully.

	* app/dialogs/image-new-dialog.c: unset "focus-on-click" on the
	template combo-box.

609 610 611 612 613
2005-03-17  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/fp.c:  major code cleanup, make it
	Repeat and Re-Show properly.  Should fix bug #141032.

614 615 616 617 618 619 620 621 622 623 624 625 626
2005-03-17  Sven Neumann  <sven@gimp.org>

	* app/actions/layers-actions.c
	* app/actions/plug-in-actions.c
	* app/actions/view-actions.c
	* plug-ins/common/compose.c
	* plug-ins/common/dog.c
	* plug-ins/pygimp/plug-ins/py-slice.py
	* plug-ins/script-fu/scripts/i26-gunya2.scm
	* plug-ins/script-fu/scripts/news-text.scm
	* plug-ins/script-fu/scripts/text-circle.scm: applied patch from
	Michael Terry that adds missing mnemonics (bug #106991).

627 628 629 630 631
2005-03-16  Sven Neumann  <sven@gimp.org>

	* app/base/gimphistogram.c: fixed checks for uncalculated histogram.
	Fixes bug #170570.

632 633 634 635 636 637
2005-03-14  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/gimpnewrectselecttool.c
	* app/tools/gimprectangletool.[ch]: improve cursor handling and
	other aspects of ui for rectangle tools.

638 639 640 641
2005-03-14  Shlomi Fish  <shlomif@iglu.org.il>

	* app/paint-funcs/paint-funcs.c
	* app/paint-funcs/paint-funcs-generic.h: fix bug #143315. When the
642 643
	visibility of the Alpha channel is turned off, it should make
	alpha=255.
644

645 646 647 648 649 650 651 652
2005-03-13  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-altivec.[ch]: More accelerated functions
	from Frederic Leroy.

	* app/composite/gimp-composite-altivec-installer.c
	* app/composite/gimp-composite-altivec-test.c: regenerated.

653 654 655 656 657
2005-03-13  Sven Neumann  <sven@gimp.org>

	* app/dialogs/print-size-dialog.c (print_size_dialog_response):
	handle the resolution unit correctly, fixes bug #170200.

658 659 660 661 662 663 664 665 666 667 668 669 670 671
2005-03-13  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/drawable_transform.pdb
	(drawable_transform_scale)
	(drawable_transform_scale_default): applied fix from Theodor de
	Ment which fixes a wrong precondition check which made certain
	scale operations impossible. Fixes bug #170195.

	* tools/pdbgen/pdb/transform_tools.pdb (scale): fixed the same
	copy & paste bug here.

	* app/pdb/drawable_transform_cmds.c
	* app/pdb/transform_tools_cmds.c: regenerated.

672 673 674 675 676 677 678
2005-03-12  Michael Schumacher  <schumaml@cvs.gnome.org>

	* plug-ins/common/winclipboard.c: applied a patch from 
	Sven Neumann that removes the paste functionality from the
	plug-in. Since GTK+ 2.6.x, this isn't needed anymore. 
	Fixes bug #168488.  

679 680 681 682 683 684 685 686
2005-03-12  Sven Neumann  <sven@gimp.org>

	* app/base/hue-saturation.[ch]
	* app/tools/gimphuesaturationtool.[ch]: applied a patch from Joao
	S. O. Bueno Calligaris and modified it a little. This adds a way
	to control the overlap between hue ranges in the Hue Saturation
	tool (bug #166628).

687 688 689 690 691 692 693
2005-03-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/despeckle.c: test intensity against white and
	black level, not only the red channel. Improved border behavior.
	Iterate over the pixels row-by-row, instead of jumping through the
	data column-wise.

694 695 696 697 698 699
2005-03-11  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpstrokedesc.h
	* app/core/gimpstrokedesc.c (gimp_stroke_desc_duplicate):
	New function, will be needed for shape layers.
	
700 701 702 703 704 705 706 707 708
2005-03-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/deinterlace.c
	* plug-ins/common/despeckle.c
	* plug-ins/common/laplace.c
	* plug-ins/common/neon.c
	* plug-ins/common/sobel.c
	* plug-ins/common/dog.c: update progress less frequently.

709 710 711 712 713
2005-03-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/despeckle.c: minor cleanup, inline
	pixel_intensity() and pixel_copy().

714 715 716 717 718
2005-03-10  Manish Singh  <yosh@gimp.org>

	* plug-ins/uri/url-backend-wget.c: force the server-response wget
	option off so it doesn't screw up our parsing.

719
2005-03-10  Bill Skaggs  <weskaggs@primate.ucdavis.edu>
720 721 722 723

	* app/tools/gimprectangletool.c: lots of code for dealing
	with constraints.  Almost functional now ...
	
Sven Neumann's avatar
Sven Neumann committed
724 725 726 727
2005-03-10  Sven Neumann  <sven@gimp.org>

	* app/composite/gimp-composite-altivec.c: delete trailing whitespace.

728 729 730 731 732
2005-03-09  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/gimptexttool.c (gimp_text_tool_create_vectors_warped):
	make created path visible and active.
	
733 734 735 736 737 738
2005-03-09  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/gimpfu.py: initialize button variable before using
	it in PF_BUTTON code. Fixes bug #169793. Thanks to Joao S. O. Bueno
	Calligaris.

739 740 741 742 743 744 745
2005-03-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpsizeentry.c (gimp_size_entry_show_unit_menu):
	added "Since: GIMP 2.4" to the docs.

	* libgimpwidgets/gimpwidgets.def: added the new symbol.

746 747 748 749 750 751 752 753 754 755 756
2005-03-09  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* libgimpwidgets/gimpsizeentry.[ch]: added function
	gimp_size_entry_show_unit_menu() for convenience.

	* app/tools/gimprectangleoptions.[ch]
	* app/tools/gimprectangletool.[ch]:  more work on 
	controls in Tool Options.  Can now resize rectangle 
	by dragging any corner or edge -- move rectangle by
	clicking inside and dragging.

757 758 759 760 761 762 763 764 765 766 767
2005-03-09  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainerview.c
	* app/widgets/gimpimagedock.c
	* app/widgets/gimptoolbox.c
	* app/widgets/gtkwrapbox.c
	* libgimpwidgets/gimpcellrenderercolor.c
	* libgimpwidgets/gimpcellrenderertoggle.c
	* libgimpwidgets/gimpframe.c: use canonical names when registering
	param specs.

768 769 770
2005-03-09  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/vectors/gimpvectors-warp.c
771
	* app/vectors/gimpvectors-warp.h: new files implementing
772 773 774 775 776 777 778 779 780 781 782
	"path along a path" functionality.

	* app/vectors/Makefile.am: new stuff added
	
	* gimp/app/vectors/gimpvectors.[ch]: actually implement
	gimp_vectors_real_stroke_get_length().

	* app/tools/gimptexttool.c
	* app/tools/gimptextoptions.c: first pass at "text
	along a path", using new functions.  See bug #169616.

783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799
2005-03-09  Sven Neumann  <sven@gimp.org>

	* app/core/gimppalette.[ch]: renamed again, to
	gimp_palette_[gs]et_columns this time.

	* app/dialogs/palette-import-dialog.c
	* app/widgets/gimppaletteeditor.c: changed accordingly.

	* tools/pdbgen/pdb/palette.pdb: renamed newly added PDB function.
	Also added a getter for the columns.

	* app/pdb/internal_procs.c
	* app/pdb/palette_cmds.c
	* libgimp/gimppalette_pdb.[ch]: regenerated.

	* libgimp/gimp.def: updated.

800 801 802 803 804 805
2005-03-09  Michael Natterer  <mitch@gimp.org>

	More sample point stuff. Addresses bug #137776.

	* app/core/gimpimage-sample-points.c
	* app/core/gimpimage-undo-push.c: append, not prepend the sample
806
	points to the image's list because their index matters. Update
807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831
	sample points when their index changes.

	* app/display/gimpcanvas.[ch]: added own sytles for the sample
	points.  Added gimp_canvas_draw_text() which uses a PangoLayout
	which is cached in the canvas.

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_sample_point): draw the sample points
	more distinct from guides using the new canvas APIs above.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_[hv]ruler_button_press): factored out all
	code to

	(gimp_display_shell_ruler_burron_press): which takes a boolean
	"horizontal" variable and allows to add sample points with
	<control>+drag.

	* app/tools/gimpcolortool.[ch]: implement adding, moving and
	removing of sample points in the same way as the move tool moves
	guides.

	* app/tools/gimpcolorpickertool.c
	(gimp_color_picker_tool_oper_update): chain up.

832 833 834 835 836
2005-03-08  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/metadata/interface.c: fix spelling error
	noted in bug #169656.
	
837 838 839 840 841 842
2005-03-08  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/gimprectangletool.[ch]
	* app/tools/gimprectangleoptions.[ch]: add size entry in
	options to control dimensions.  Still work in progress.
	
843 844 845 846 847
2005-03-09  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.[ch]: added
	gimp_display_shell_get_unit(), for completeness.

848 849 850
2005-03-08  Sven Neumann  <sven@gimp.org>

	* app/core/gimpgradient.c (gimp_gradient_segment_split_uniform):
851
	fixed brokeness introduced when eliminating gradient->last_visited.
852

853 854 855 856 857
2005-03-08  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/widgets/gimpviewrenderergradient.c: revert previous
	change.  Didn't read the code carefully enough.
	
858 859 860 861 862 863 864
2005-03-08  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/widgets/gimpviewrenderergradient.c: 
	(gimp_view_renderer_gradient_render): Make sure specified
	point lies within specified gradient segment; should
	fix bug #167604.

865 866 867 868 869
2005-03-08  Sven Neumann  <sven@gimp.org>

	* app/file/file-open.c (file_open_layer): open images interactively.
	Fixes bug #168936.

870 871 872 873 874 875 876 877
2005-03-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimppaintoptions-gui.c (fade_options_gui)
	(gradient_options_gui)
	* app/tools/gimpselectionoptions.c (gimp_selection_options_gui):
	call gimp_unit_menu_set_pixel_digits() after connecting up the
	spinbuttons and the unitmenu. Fixes initial display (bug #169066).

878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894
2005-03-08  Sven Neumann  <sven@gimp.org>

	* app/core/gimppalette.[ch]: renamed gimp_palette_[gs]et_n_columns
	to gimp_palette_[gs]et_num_columns().

	* app/dialogs/palette-import-dialog.c
	* app/widgets/gimppaletteeditor.c: changed accordingly.

	* tools/pdbgen/pdb/palette.pdb: added new PDB function to control
	the number of columns used when displaying a palette (bug #169370).

	* app/pdb/internal_procs.c
	* app/pdb/palette_cmds.c
	* libgimp/gimppalette_pdb.[ch]: regenerated.

	* libgimp/gimp.def: updated.

895 896 897 898 899 900
2005-03-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.c (gimp_curves_tool_dialog)
	* app/tools/gimplevelstool.c (gimp_levels_tool_dialog): added
	mnemonics for the Channels menu.

901 902 903 904 905
2005-03-07  Manish Singh  <yosh@gimp.org>

	* plug-ins/metadata/interface.c
	* plug-ins/metadata/xmp-model.c: fix some gssize confusion.

906 907 908 909 910 911 912
2005-03-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpellipseselecttool.c
	* app/tools/gimprectselecttool.[ch]: applied a patch by Nils
	Bjorklund that should fix bug #143887 (selection rectangle "moves"
	when starting at the top-right corner).

913 914 915 916 917
2005-03-07  Kevin Cozens  <kcozens@cvs.gimp.org>

	* plug-ins/script-fu/scripts/perspective-shadow.scm: Reverting previous
	change as I was mixing up two different versions of GIMP at the time.

918 919
2005-03-07  Kevin Cozens  <kcozens@cvs.gimp.org>

920 921 922
	* plug-ins/script-fu/scripts/perspective-shadow.scm: Fixed the
	options for SF-ENUM in the register block which were changed (read
	broken) when the entry was changed from SF-OPTION.
923

924
2005-03-07  Raphaël Quinet  <raphael@gimp.org>
925 926 927 928 929 930 931 932 933 934 935 936 937 938

	* configure.in
	* plug-ins/Makefile.am (SUBDIRS): Enable build of metadata plug-in.

	* plug-ins/metadata/xmp-gen.c 
	* plug-ins/metadata/xmp-gen.h 
	* plug-ins/metadata/xmp-encode.c 
	* plug-ins/metadata/xmp-encode.h: Renamed xmp-gen.[ch] to
	xmp-encode.[ch].

	* plug-ins/metadata/Makefile.am 
	* plug-ins/metadata/metadata.c 
	* plug-ins/metadata/interface.c: Updated accordingly + minor fixes.

939 940 941 942 943
2005-03-07  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcolortool.c: converted tabs to spaces, stylistic
	cleanups.

944 945 946 947 948 949 950
2003-03-06  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-altivec.c: contort it to compile with
	Apple's weirdo gcc.

	* app/composite/gimp-composite-altivec.h: honor USE_ALTIVEC.

Manish Singh's avatar
Manish Singh committed
951 952 953 954
2003-03-06  Manish Singh  <yosh@gimp.org>

	* configure.in: rework AltiVec tests some.

955 956 957 958 959 960
2003-03-06  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-altivec-installer.c
	* app/composite/gimp-composite-altivec-test.c: regenerated so the new
	implementation is actually used.
	
961 962 963 964 965 966 967 968 969 970 971 972 973 974
2003-03-06  Manish Singh  <yosh@gimp.org>

	* configure.in: revised tests for AltiVec. Define ALTIVEC_EXTRA_CFLAGS
	for the extra compiler options needed. Also, support runtime checking
	for AltiVec through the sysctl on Mac OS X, instead of SIGILL assembly
	instruction checking, which needs GNU as.

	* app/base/cpu_accel.c: use the sysctl if available.

	* app/composite/Makefile.am: use ALTIVEC_EXTRA_CFLAGS.

	* app/composite/gimp-composite-altivec.c: conditionally #include
	altivec.h

975 976 977 978 979 980 981 982 983 984 985 986 987 988
2005-03-05  Helvetix Victorinox  <helvetix@gimp.org>

	* app/composite/gimp-composite-altivec.[ch]
	* app/composite/gimp-composite-altivec-installer.c
	* app/composite/gimp-composite-altivec-test.c:
	Added updates from starox-gimp@starox.org
	(Frederic Leroy) to implement Altivec instruction optimisations.

	Regenerated sources.

	* app/composite/gimp-composite-mmx.c: Replaced a pesky movntq
	instruction with a movq.  Movntq is an SSE instruction, not an MMX
	instruction.

989 990 991 992 993
2005-03-05  Kevin Cozens  <kcozens@cvs.gimp.org>

	* plug-ins/script-fu/siod/sliba.c: Oops...one 'case tc_string:' was
	lost while fixing handling of string arrays.

994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009
2005-03-05  Helvetix Victorinox  <helvetix@gimp.org>

	* app/composite/gimp-composite-generic.c
	* app/composite/gimp-composite-mmx.c
	* app/composite/gimp-composite-sse.c
	Incorporated a very clean patch from starox-gimp@starox.org
	(Frederic Leroy) which improves the generic performance of the
	burn compositing function.  Speed is improved at a cost of a 64k
	look-up table which is probably manageable for 8bpp images, but at
	larger bpp images (which currently are not supported by the GIMP)
	this is unlikely to be tolerable.

	The generic C implementation of the burn function uses this
	look-up table, the mmx/sse implementations have been commented
	out.

Sven Neumann's avatar
Sven Neumann committed
1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021
2005-03-05  Sven Neumann  <sven@gimp.org>

	Fix for bug #169274:

	* configure.in: updated definition of localedir.

	* po/Makefile.in.in: updated.

	* po-libgimp/Makefile.in.in
	* po-plug-ins/Makefile.in.in
	* po-script-fu/Makefile.in.in: synchronized with po/Makefile.in.in.

Manish Singh's avatar
Manish Singh committed
1022 1023 1024 1025
2005-03-05  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/*: Update or add missing copyright and GPL comments.

1026 1027 1028 1029 1030
2005-03-05  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/pygimp-drawable.c: default args for layer
	constructor.

Manish Singh's avatar
Manish Singh committed
1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041
2005-03-04  Manish Singh  <yosh@gimp.org>

	* tools/pdbgen/enumcode-py.pl: include Parasite flag values.

	* plug-ins/pygimp/gimpenums.py: regenerated.

	* plug-ins/pygimp/pygimp-drawable.c: minor change for type
	consistency.

	* plug-ins/pygimp/pygimp-image.c: add keyword args, is_dirty getter.

1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
2005-03-04  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/gimpmodule.c: wrap fonts_refresh and fonts_get_list,
	clean up some of the other resource list plugins.

	* plug-ins/pygimp/pygimp-drawable.c: more keyword args and better
	exception messages.

	* plug-ins/pygimp/pygimp-parasite.c: support keyword args for
	parasite constructor.

1053 1054 1055 1056 1057 1058 1059 1060
2005-03-04  Manish Singh  <yosh@gimp.org>

	* tools/pdbgen/pdb/layer.pdb: fix documentation of edit_mask
	accessors.

	* libgimp/gimplayer_pdb.c
	* app/pdb/layer_cmds.c: regenerated.

1061 1062 1063 1064 1065
2005-03-05  Sven Neumann  <sven@gimp.org>

	* plug-ins/metadata/interface.c: specify alternative button order
	for the new dialogs.

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
2005-03-04  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/Makefile.am: no need to export PLUG_IN_INFO symbol.

	* plug-ins/pygimp/pygimp-image.c: more descriptive exception for
	Image constructor.

	* plug-ins/pygimp/pygimp-pdb.c: cosmetic changes.

	* plug-ins/pygimp/pygimp-drawable.c: wrap transform API, add keyword
	arguments to several drawable methods, wrap
	layer_resize_to_image_size.

1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096
2005-03-05  Michael Natterer  <mitch@gimp.org>

	* app/actions/view-actions.c
	* app/actions/view-commands.[ch]
	* app/config/gimprc-blurbs.h
	* app/core/core-enums.[ch]
	* app/core/gimp.c
	* app/core/gimpimage-crop.c
	* app/core/gimpimage-undo-push.[ch]
	* app/core/gimpimage.c
	* app/display/gimpdisplayoptions.[ch]
	* app/display/gimpdisplayshell-appearance.[ch]
	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell-draw.[ch]
	* app/widgets/gimphelp-ids.h
	* menus/image-menu.xml.in: reordered stuff to be in guides, grid,
	sample points order. Some cleanup and indentation.

1097
2005-03-04  Raphaël Quinet  <raphael@gimp.org>
1098

1099 1100 1101
	* plug-ins/metadata/xmpdump.c: test program that tries to extract
	XMP metadata from files (image files, AI files, PDF documents...)

1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
	* menus/image-menu.xml.in: Added placeholder for file properties.

	* plug-ins/metadata/.cvsignore
	* plug-ins/metadata/Makefile.am
	* plug-ins/metadata/README
	* plug-ins/metadata/interface.c
	* plug-ins/metadata/interface.h
	* plug-ins/metadata/metadata.c
	* plug-ins/metadata/xmp-model.c
	* plug-ins/metadata/xmp-model.h
	* plug-ins/metadata/xmp-parse.c
	* plug-ins/metadata/xmp-parse.h
	* plug-ins/metadata/xmp-gen.c
	* plug-ins/metadata/xmp-gen.h: First import of metadata editor.
	Currently, it cannot read metadata (except for XMP), it cannot
	edit metadata and it cannot save metadata (just export).  But this
	might improve later...  The README file contains some info.

1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
2005-03-04  Sven Neumann  <sven@gimp.org>

	* app/dialogs/user-install-dialog.c
	* app/file/gimprecentlist.c
	* app/widgets/gimpwidgets-utils.c
	* modules/controller_linux_input.c
	* modules/controller_midi.c
	* plug-ins/common/compressor.c
	* plug-ins/common/mail.c
	* plug-ins/common/psp.c
	* plug-ins/common/raw.c
	* plug-ins/helpbrowser/dialog.c
	* plug-ins/imagemap/imap_cern.y
	* plug-ins/imagemap/imap_cern_parse.[ch]
	* plug-ins/imagemap/imap_csim.y
	* plug-ins/imagemap/imap_csim_parse.[ch]
	* plug-ins/imagemap/imap_main.c
	* plug-ins/imagemap/imap_ncsa.y
	* plug-ins/imagemap/imap_ncsa_parse.[ch]
	* plug-ins/uri/uri.c
	* plug-ins/xjt/xjt.c: ported the remaining functions to gstdio.

1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167
2005-03-04  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptoolcontrol.[ch]: in the spirit of the fix for bug
	#165618 below, allow tools to specify up to two "object actions"
	(actions which select brushes, patterns, ...).

	* app/tools/gimpblendtool.c
	* app/tools/gimpbucketfilltool.c
	* app/tools/gimpclonetool.c
	* app/tools/gimppainttool.c
	* app/tools/gimptexttool.c: set actions where appropriate.

	* app/actions/actions.c (action_select_object): allow objects to
	be selected by index.

	* app/actions/context-actions.c: added actions which select
	objects by index. Not really used but the same actions can be used
	to generically pass any GimpActionSelectType enum value to the
	action callbacks.

	* app/actions/tools-actions.c
	* app/actions/tools-commands.[ch]: added actions and callbacks
	for the new generic tool objects.

	Also fixed and cleaned up the new generic tool value code.

Manish Singh's avatar
Manish Singh committed
1168 1169 1170 1171
2003-03-04  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/gqbist.c: #include gstdio.h

1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/CEL.c
	* plug-ins/common/gbr.c
	* plug-ins/common/gih.c
	* plug-ins/common/gqbist.c
	* plug-ins/common/pat.c
	* plug-ins/common/pnm.c
	* plug-ins/common/postscript.c
	* plug-ins/common/raw.c
	* plug-ins/common/sample_colorize.c
	* plug-ins/faxg3/faxg3.c
	* plug-ins/imagemap/imap_preferences.c
	* plug-ins/print/print.c: added missing parameter to g_open() calls,
	ported some functions I missed earlier.

1188 1189 1190 1191 1192 1193
2005-03-04  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage.c
	* app/display/gimpdisplayoptions.c: re-order code so 
	sample-point stuff comes directly after guide stuff.
	
1194 1195 1196 1197 1198 1199
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/siod/slib.c (vload) (fopen_c): ported to
	g_stdio. Also disabled code that attempts to load scripts from
	SIOD_LIB.

1200 1201 1202 1203 1204 1205
2005-03-04  Sven Neumann  <sven@gimp.org>

	* libgimpconfig/gimpconfig-path.c (gimp_config_path_expand_only):
	handle g_get_home_dir() returning NULL and enable it for the Win32
	platform as well.

1206 1207 1208 1209 1210 1211 1212 1213 1214
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/FractalExplorer/Dialogs.c
	* plug-ins/Lighting/lighting_ui.c
	* plug-ins/gfig/gfig-dialog.c
	* plug-ins/gflare/gflare.c
	* plug-ins/gimpressionist/utils.c: same fix for path encoding as
	done in Script-Fu (see bug #165002).

1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253
2005-03-04  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/core/gimpimage-sample-points.c
	* app/core/gimpimage-sample-points.h: new files

	* app/actions/view-actions.c
	* app/actions/view-commands.c
	* app/actions/view-commands.h
	* app/config/gimprc-blurbs.h
	* app/core/Makefile.am
	* app/core/core-enums.c
	* app/core/core-enums.h
	* app/core/core-types.h
	* app/core/gimp.c
	* app/core/gimp.h
	* app/core/gimpimage-crop.c
	* app/core/gimpimage-duplicate.c
	* app/core/gimpimage-flip.c
	* app/core/gimpimage-rotate.c
	* app/core/gimpimage-scale.c
	* app/core/gimpimage-undo-push.c
	* app/core/gimpimage-undo-push.h
	* app/core/gimpimage.c
	* app/core/gimpimage.h
	* app/display/gimpdisplayoptions.c
	* app/display/gimpdisplayoptions.h
	* app/display/gimpdisplayshell-appearance.c
	* app/display/gimpdisplayshell-appearance.h
	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell-draw.h
	* app/display/gimpdisplayshell-handlers.c
	* app/display/gimpdisplayshell.c
	* app/display/gimpdisplayshell.h
	* app/widgets/gimphelp-ids.h
	* menus/image-menu.xml.in: add support for a list of "sample
	points" in each image, coded and handled very similarly to
	guides, for use mainly in color correction.  See bug #137776.

1254 1255 1256 1257 1258 1259
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/script-fu-scripts.c (script_fu_find_scripts):
	need to convert script-fu-path to filesystem encoding. Should fix
	bug #165002.

1260 1261 1262 1263
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/*: ported to gstdio, removed unnecessary includes.

Sven Neumann's avatar
Sven Neumann committed
1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290
2005-03-04  Sven Neumann  <sven@gimp.org>

	* plug-ins/FractalExplorer
	* plug-ins/Lighting
	* plug-ins/bmp
	* plug-ins/dbbrowser
	* plug-ins/faxg3
	* plug-ins/fits
	* plug-ins/flame
	* plug-ins/gfig
	* plug-ins/gflare
	* plug-ins/gfli
	* plug-ins/gimpressionist
	* plug-ins/ifscompose
	* plug-ins/jpeg
	* plug-ins/maze
	* plug-ins/pagecurl
	* plug-ins/print
	* plug-ins/rcm
	* plug-ins/script-fu
	* plug-ins/sel2path
	* plug-ins/sgi
	* plug-ins/twain
	* plug-ins/winicon
	* plug-ins/xjt: ported to gstdio, removed unnecessary includes,
	minor fixes to filename handling here and there.

Michael Natterer's avatar
Michael Natterer committed
1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317
2005-03-04  Michael Natterer  <mitch@gimp.org>

	Fixed bug #165618:

	* app/tools/gimptoolcontrol.[ch]: added new functions
	gimp_tool_control_set/get_action_value_1/2/3/4() which allow tools
	to specify their primary, secondary etc. "values" using
	action-identifying strings like "context/context-brush-radius-set".

	* app/tools/gimpblendtool.c
	* app/tools/gimpbucketfilltool.c
	* app/tools/gimpcolortool.c
	* app/tools/gimpinktool.c
	* app/tools/gimppainttool.c: set actions where appropriate. Still
	needs some way to document the mapping in a user-visible way.

	* app/tools/gimpblendtool.c
	* app/tools/gimpbucketfilltool.c: tab removal and minor cleanups.

	* app/actions/actions.[ch]: added utility function
	action_select_property().

	* app/actions/tools-actions.c
	* app/actions/tools-commands.[ch]: added actions and callbacks for
	setting the ink blob size, aspect and angle. Also added actions
	and callbacks for the new generic tool values.

1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
2005-03-03  Helvetix Victorinox  <helvetix@gimp.org>

	* app/composite/make-installer.py:Applied patch from
	starox-gimp@starox.org (Frederic Leroy) which fixed the parser of
	the nm programme output to understand the output on 64bit
	machines.  Fixes bug #168529
	
	* app/composite/ns.py: 
	Applied patch from starox-gimp@starox.org (Frederic Leroy) which
	fixed a bug that would appear when only one compositing function
	was implemented.  Fixes bug #168529

	Regenerated app/composite function tables.

1332 1333 1334 1335 1336
2005-03-03  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/gifload.c (ReadImage): added a sanity check for
	bogus frame dimensions. Fixes bug #169113.

1337 1338 1339 1340 1341
2005-03-03  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/autocrop.c: allocate tile-cache size more
	intelligently.

1342 1343 1344 1345 1346
2005-03-03  Sven Neumann  <sven@gimp.org>

	* libgimpconfig/gimpconfig-params.h: removed linebreak from macro
	definition; gtk-doc doesn't like this.

Sven Neumann's avatar
Sven Neumann committed
1347 1348 1349 1350
2005-03-03  Sven Neumann  <sven@gimp.org>

	* app/base/curves.c: minor code cleanup.

1351 1352 1353 1354 1355 1356 1357 1358 1359 1360
2005-03-03  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/paths.pdb: use boolean values to indicate
	whether a path is linked ("locked").

	* app/pdb/drawable_cmds.c
	* app/pdb/paths_cmds.c
	* libgimp/gimpdrawable_pdb.c
	* libgimp/gimppaths_pdb.[ch]: regenerated.

1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375
2005-03-03  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/paths.pdb: added new PDB function
	gimp_path_import_string() to allow to easily import dynamically
	created SVG.

	* app/pdb/internal_procs.c
	* app/pdb/paths_cmds.c
	* libgimp/gimppaths_pdb.[ch]: regenerated.

	* libgimp/gimp.def: updated.

	* plug-ins/script-fu/siod-wrapper.c (marshall_proc_db_call):
	removed unused variable.

Manish Singh's avatar
Manish Singh committed
1376 1377 1378 1379
2005-03-03  Manish Singh  <yosh@gimp.org>

	* configure.in: Add check for ppc64.

Manish Singh's avatar
Manish Singh committed
1380 1381 1382 1383
2005-03-03  Manish Singh  <yosh@gimp.org>

	* tools/pdbgen/pdb/drawable.pdb: fix a typo in the docs.

1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410
2005-03-03  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/pygimp.h: Make a compatibility wrapper for
	PyBool_FromLong for pre-2.3 versions of python.

	* plug-ins/pygimp/gimpfu.py
	* plug-ins/pygimp/gimpui.py: Update to use some more modern python
	features.

	* plug-ins/pygimp/gimpmodule.c
	* plug-ins/pygimp/pygimp-display.c
	* plug-ins/pygimp/pygimp-drawable.c
	* plug-ins/pygimp/pygimp-image.c
	* plug-ins/pygimp/pygimp-parasite.c
	* plug-ins/pygimp/pygimp-pdb.c
	* plug-ins/pygimp/pygimp-tile.c: Throw exceptions on failures for
	libgimp wrappers (fixes bug #160136), and make the exception strings
	a lot more descriptive to aid debugging. Also return proper Bools when
	appropriate. Some new API wrapped as well. Still a work in progress.

	* plug-ins/pygimp/gimpplugin.py
	* plug-ins/pygimp/gimpshelf.py
	* plug-ins/pygimp/plug-ins/clothify.py
	* plug-ins/pygimp/plug-ins/foggify.py
	* plug-ins/pygimp/plug-ins/sphere.py: Add some whitespace to make
	things more readable.

1411 1412 1413
2005-03-03  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpdrawablecombobox.c
1414
	* libgimp/gimpimagecombobox.c: set a width request on the combo boxes.
1415 1416 1417 1418
	
	* plug-ins/common/bumpmap.c (SCALE_WIDTH): set a minimum width on
	the scales.

1419 1420 1421 1422 1423 1424 1425
2005-03-02  Manish Singh  <yosh@gimp.org>

	* libgimp/gimp.[ch]
	* libgimp/gimpdrawable.[ch]
	* libgimp/gimpimage.[ch]: changed attach_new_parasite variants
	to return success or failure.

Sven Neumann's avatar
Sven Neumann committed
1426 1427 1428 1429 1430 1431 1432
2005-03-02  Sven Neumann  <sven@gimp.org>

	* app/dialogs/resize-dialog.c (resize_dialog_reset)
	* app/dialogs/scale-dialog.c (scale_dialog_reset): don't rely on
	GObject internals about the order in which properties are being
	set. Fixes one aspect of bug #169011.

1433 1434 1435 1436 1437
2005-03-02  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/tools-enums.[ch]: oops, missed in previous 
	commit.
	
1438 1439
2005-03-02  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
	* app/tools/gimprectangletool.c
	* app/tools/gimprectangletool.h
	* app/tools/gimprectangleoptions.c
	* app/tools/gimprectangleoptions.h: new code for base
	class for rectangle tools.

	* app/tools/gimpnewrectselecttool.[ch]: modified to
	derive from GimpRectangleTool.

	* app/tools/Makefile.am: modified accordingly

	* app/tools/gimpselectionoptions.[ch]: remove stuff
	no longer needed by new rect select tool.

	This is work in progress.
	
2005-03-02  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/widgets/gimpgradienteditor.c: allow dnd of colors
1459 1460 1461
	into preview and control areas, as described in
	bug #119470.

1462 1463
2005-03-02  Sven Neumann  <sven@gimp.org>

1464 1465
	* app/text/gimptextlayout.c
	* app/tools/gimptextoptions.[ch]: allow to adjust letter-spacing.
1466

1467 1468 1469 1470 1471 1472 1473
2005-03-01  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/mail.c: use g_spawn_async_with_pipes instead of
	popen. Addresses bug #108659. Also some general cleanup.

	* plug-ins/common/mblur.c: Fix some typos in comments.

1474 1475 1476 1477 1478 1479 1480 1481
2005-03-01  Michael Natterer  <mitch@gimp.org>

	* app/core/core-enums.[ch]: added VISIBLE and LINKED to the
	GimpImageResizeLayers enum.

	* app/core/gimpimage-resize.c (gimp_image_resize_with_layers):
	changed accordingly. Also looks nicer now.

1482 1483 1484 1485 1486 1487
2005-03-01  Sven Neumann  <sven@gimp.org>

	* plug-ins/ifscompose/ifscompose.[ch]
	* plug-ins/ifscompose/ifscompose_utils.c: purely cosmetic coding
	style changes.

1488 1489 1490 1491 1492 1493
2005-03-01  Kevin Cozens  <kcozens@cvs.gimp.org>

	* plug-ins/script-fu/siod-wrapper.c: Fixed marshalling code to
	treat string arrays as arrays instead of lists of strings. Last
	part of the fix for bug #168290.

1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509
2005-03-01  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpenumcombobox.[ch]: removed 
	gimp_enum_combo_box_set_visible().

	* libgimpwidgets/gimpintcombobox.[ch]: added
	gimp_int_combo_box_set_sensitivity() instead.

	* app/tools/gimpcurvestool.c
	* app/tools/gimplevelstool.c
	* app/widgets/gimphistogrameditor.c: changed accordingly.

	* libgimpwidgets/gimpenumstore.h: added padding for future expansion.

	* libgimpwidgets/gimpwidgets.def: updated.

1510 1511 1512 1513 1514
2005-02-28  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable-blend.c: major speedup for dithering code
	thanks to a suggestion from Jay Cox.

Sven Neumann's avatar
Sven Neumann committed
1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527
2005-02-28  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphelp.c (gimp_help_get_locales): use
	g_get_language_names().

	* plug-ins/help/locales.c (locales_parse): simplified;
	g_get_language_names() already takes care of this.

2005-02-27  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpintcombobox.c: allow to change ellipsation
	mode after the combo has been created.

1528 1529 1530 1531 1532
2005-02-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/imagemap/imap_menu.c (menu_build_mru_items): another
	build fix for compilers that don't support C99 extensions.

1533 1534 1535 1536 1537 1538 1539 1540 1541 1542
2005-02-27  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpintcombobox.c: added an "ellipsize" construct
	property and changed the default behaviour back to not doing
	ellipsation on the text.

	* libgimp/gimpimagecombobox.c
	* libgimp/gimpdrawablecombobox.c: set "ellipsize" to middle for
	drawable and image combo boxes.

1543 1544 1545 1546 1547
2005-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable-blend.c: improved readability by
	introducing a macro for the dithering code.

1548 1549 1550 1551 1552
2005-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable-blend.c: fixed rounding errors in the
	non-dithered case and optimized the dithering code.

1553 1554 1555 1556 1557
2005-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable-blend.c: (hopefully) improve the threaded
	performance by using a dedicated RNG per tile.

1558 1559 1560 1561 1562 1563
2005-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-convert-fsdither.h
	* app/core/gimpimage-convertc: save a kilobyte of data by using
	guchar for the range array.

1564 1565 1566
2005-02-27  Daniel Egger  <de@axiros.com>

	* app/base/Makefile.am
Sven Neumann's avatar
Sven Neumann committed
1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578
	* app/composite/Makefile.am
	* app/config/Makefile.am
	* app/core/Makefile.am
	* app/display/Makefile.am
	* app/file/Makefile.am
	* app/paint-funcs/Makefile.am
	* app/pdb/Makefile.am
	* app/plug-in/Makefile.am
	* app/text/Makefile.am
	* app/tools/Makefile.am
	* app/vectors/Makefile.am
	* app/xcf/Makefile.am: Commonized include paths to always look
1579 1580
	in the builddir also to cater for srcdir != builddir builds.

1581 1582 1583
2005-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpgradient.[ch]: removed the "last_visited" field
Sven Neumann's avatar
Sven Neumann committed
1584 1585 1586
	from GimpGradient. Instead added a segment parameter to
	gimp_gradient_get_color_at() that allows the caller to do the same
	optimization.
1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598

	* app/actions/gradient-editor-commands.c
	* app/core/gimpdrawable-blend.c
	* app/core/gimppalette-import.c
	* app/paint/gimppaintoptions.c
	* app/widgets/gimpgradienteditor.c
	* app/widgets/gimpgradientselect.c
	* app/widgets/gimpviewrenderergradient.c: changed accordingly.

	* app/pdb/gradient_cmds.c
	* app/pdb/gradients_cmds.c: regenerated.

1599 1600 1601 1602 1603
2005-02-26  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/png.c: revert change to read images one row at a
	time, it didn't really fix the bug.

Sven Neumann's avatar
Sven Neumann committed
1604 1605 1606 1607
2005-02-26  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable-blend.c: minor code cleanup.

1608 1609 1610 1611 1612
2005-02-26  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-processor.c (do_parallel_regions): obtain a lock
	on the pool mutex while signalling the termination condition.

1613 1614 1615 1616 1617
2005-02-25  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* plug-ins/common/png.c: read non-interlaced files one row
	at a time instead of in 64-row chunks; fixes bug #137327.

1618 1619 1620 1621 1622 1623
2005-02-25  Kevin Cozens  <kcozens@cvs.gimp.org>

	* plug-ins/script-fu/siod/siod.h
	* plug-ins/script-fu/siod/sliba.c: Creation and manipulation of
	string arrays was seriously broken. Fixes bug #168290.

Sven Neumann's avatar
Sven Neumann committed
1624 1625 1626 1627
2005-02-25  Sven Neumann  <sven@gimp.org>

	* app/base/pixel-processor.c: fixed indentation.

1628
2005-02-24  Jay Cox  <jaycox@gimp.org>
Sven Neumann's avatar
Sven Neumann committed
1629 1630

	* app/base/pixel-processor.c: fixed potential race condition on
1631 1632 1633
	processor->threads.  Changed mutex to a GMutex from a GStaticMutex
	because it needs to be initialized anyway.  Placed g_cond_wait
	calls inside while loops to handle g_cond_wait returning prematurely.
1634

1635 1636 1637 1638 1639
2005-02-24  Manish Singh  <yosh@gimp.org>

	* plug-ins/uri/uri-backend-wget.c: Handle large file sizes, and
	update the downloaded size for unknown file sizes.

1640 1641 1642 1643 1644
2005-02-24  Sven Neumann  <sven@gimp.org>

	* plug-ins/uri/uri-backend-wget.c (uri_backend_load_image): pulse
	the progress while downloading an unspecified amount of data.

1645 1646 1647 1648 1649 1650
2005-02-24  Manish Singh  <yosh@gimp.org>

	* plug-ins/uri/uri-backend-wget.c: Handle HTTP 302 Redirect output
	from wget properly. Also give a little more informative display for
	unspecified sizes. Fixes bug #168322.

1651 1652 1653 1654 1655
2005-02-24  Sven Neumann  <sven@gimp.org>

	* app/actions/file-commands.c (file_open_as_layer_cmd_callback):
	preselect the image just as in file_open_from_image_cmd_callback().

1656 1657 1658
2005-02-24  Michael Natterer  <mitch@gimp.org>

	Allow to resize layers with the image. Fixes bug #87789.
Michael Natterer's avatar
Michael Natterer committed
1659
	Based on patch by Akkana Peck.