"Alpha to Logo" filters: common bugs
Submitted by Ulf-D. Ehlert
Link to original bug (#498480)
Description
I noticed several bugs common to most or all Alpha to Logo filters. These bugs are the result of the implementation of the Logo Script-Fus as filters:
-
According to the tooltips, these filters apply some effect to "the selected region (or alpha)". This is wrong, the filter effect will always be applied to the alpha channel. Actually, any selection will be removed by calling "gimp-selection-none". (cf. bug #73891.)
-
The Logo Script-Fus start creating a (new) text layer and then call "apply-*-logo-effect". In this apply logo effect routine, new layers are created, assuming that there is only one layer (the text layer) and thus using "gimp-image-add-layer" with hard-coded layer positions (mostly 1). This assumption is wrong for the filters and may mess up the layers, e.g. when the active layer is not the top layer.
-
The Logo Script-Fus were registered with a font size option, e.g. SF-ADJUSTMENT _"Font size (pixels)" '(100 2 1000 1 10 0 1). For some of the Alpha to Logo filters (e.g. Alien Glow, Neon), this code line is copied and the the font size renamed to a mysterious "effect size", e.g. SF-ADJUSTMENT _"Effect size (pixels)" '(100 2 1000 1 10 0 1), sometimes with "(pixels * n)" with some integer "n" instead of "(pixels)". Those GUI labels are useless/wrong without font and should be renamed, or the options should be replaced by more appropriate ones.
Version: git master