Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gexiv2 gexiv2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gexiv2gexiv2
  • Merge requests
  • !70

Make get_gps_info return data again even if altitude is unset

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Felix Crux requested to merge felixc/gexiv2:issue72-get-gps-info-without-altitude into master Jan 24, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

In version 0.12.1 and earlier, the gexiv2_metadata_get_gps_info function used to return TRUE if any of latitude, longitude, or altitude were available, even if not all three could be retrieved. In 0.12.2, the behaviour changed so that all three had to be present for the function to return TRUE. If even a single one is unset, FALSE is returned.

That change was made in f2d96b4d, but may have been unintentional. Empirically it appears that some tools will only set lat/long when drawing points on a map, without including an altitude.

This patch restores the older functionality such that if any of latitude, longitude, or altitude are available, gexiv2_metadata_get_gps_info and gexiv2_metadata_try_get_info return TRUE and pass back the available info.

Addresses #72

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue72-get-gps-info-without-altitude